January 2022 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Change in ...nfs-ganesha[next]: wip acl memory leak
by bjfhdhhaha (GerritHub) 29 Jan '22

29 Jan '22

bjfhdhhaha has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/532266 ) Change subject: wip acl memory leak ...................................................................... wip acl memory leak Change-Id: Ibad396b715d028511dd1ab4acfc3f4a2b60aef40 Signed-off-by: bjfhdhhaha <1453769042(a)qq.com> --- M src/FSAL/posix_acls.c 1 file changed, 26 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/532266/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/532266 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibad396b715d028511dd1ab4acfc3f4a2b60aef40 Gerrit-Change-Number: 532266 Gerrit-PatchSet: 1 Gerrit-Owner: bjfhdhhaha <1453769042(a)qq.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: wip acl memory leak
by bjfhdhhaha (GerritHub) 28 Jan '22

28 Jan '22

bjfhdhhaha has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/532211 ) Change subject: wip acl memory leak ...................................................................... wip acl memory leak Change-Id: Ia25f2846b8baa3feb5b25fe188722d304ec8e4e0 Signed-off-by: bjfhdhhaha <1453769042(a)qq.com> --- M src/FSAL/posix_acls.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/532211/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/532211 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia25f2846b8baa3feb5b25fe188722d304ec8e4e0 Gerrit-Change-Number: 532211 Gerrit-PatchSet: 1 Gerrit-Owner: bjfhdhhaha <1453769042(a)qq.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: fix ganesh_mgr remove client failed
by jiangfeng-B (GerritHub) 26 Jan '22

26 Jan '22

jiangfeng-B has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/532048 ) Change subject: fix ganesh_mgr remove client failed ...................................................................... fix ganesh_mgr remove client failed Change-Id: Ic2ffab6ae6eb551dc4b60b94ed5514c022347347 Signed-off-by: bjfhdhhaha <1453769042(a)qq.com> --- M src/support/client_mgr.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/532048/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/532048 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic2ffab6ae6eb551dc4b60b94ed5514c022347347 Gerrit-Change-Number: 532048 Gerrit-PatchSet: 1 Gerrit-Owner: jiangfeng-B <1453769042(a)qq.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: selinux: Use interface calls instead of allow rules
by Kaleb KEITHLEY (GerritHub) 25 Jan '22

25 Jan '22

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/532015 ) Change subject: selinux: Use interface calls instead of allow rules ...................................................................... selinux: Use interface calls instead of allow rules Using interfaces calls in optional_policy() block is necessary when a type from a different module is used. This change is needed for the nfs-ganesha policy to work on systems where the glusterd module is not currently installed. cf. https://bugzilla.redhat.com/show_bug.cgi?id=2043360 Change-Id: I9c2aa2e363ca32f8548a7e7338016c33fbe309eb Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/selinux/ganesha.if M src/selinux/ganesha.te 2 files changed, 94 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/532015/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/532015 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9c2aa2e363ca32f8548a7e7338016c33fbe309eb Gerrit-Change-Number: 532015 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: WIP - Synchonizing I/O and file open/close/reopen without holding rwlock
by Frank Filz (GerritHub) 24 Jan '22

24 Jan '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/531877 ) Change subject: WIP - Synchonizing I/O and file open/close/reopen without holding rwlock ...................................................................... WIP - Synchonizing I/O and file open/close/reopen without holding rwlock For async, we will need to protect I/O from open/close/reopen with the operation being completed on a different thread. Because of this, we can't use a pthread_rwlock, so we basically implement our own. This also allows reducing the contentioon for the obj_lock since we actually just lock the fsal_fd we are using. This implementation ALSO acquires temporary share reservations for more operations. The impact of this actually is that instead of share operations blocking on I/O, they may instead fail. Change-Id: Ib36e112c5599f15ba0522750447175c30badc5a2 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/common_utils.h M src/include/fsal_types.h M src/FSAL/CMakeLists.txt M src/MainNFSD/libganesha_nfsd.ver M src/include/fsal_api.h M src/include/FSAL/fsal_commonlib.h M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/FSAL_CEPH/internal.h M src/FSAL/FSAL_VFS/vfs_methods.h M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/commonlib.c 12 files changed, 1,314 insertions(+), 365 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/531877/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/531877 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib36e112c5599f15ba0522750447175c30badc5a2 Gerrit-Change-Number: 531877 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Minor format fix in nfs4_op_read.c
by Frank Filz (GerritHub) 24 Jan '22

24 Jan '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/531876 ) Change subject: Minor format fix in nfs4_op_read.c ...................................................................... Minor format fix in nfs4_op_read.c Change-Id: I2c3936f4ea132bec2e4933bdfd650abfff54c3c0 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_op_read.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/531876/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/531876 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2c3936f4ea132bec2e4933bdfd650abfff54c3c0 Gerrit-Change-Number: 531876 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Announce Push of V4.0.1
by Frank Filz 15 Jan '22

15 Jan '22

Branch next Tag:V4.0.1 Merge Highlights * Fix crash for out-of-bounds access * Do not define nfsv3_optype if NFS3 is not configured * Bugfix: Allow listening on TCP only without IPv6 configured Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 9f60b6972 Frank S. Filz V4.0.1 afd683712 Idan Yadgar Bugfix: Allow listening on TCP only without IPv6 configured 709fcd5ea Idan Yadgar Do not define nfsv3_optype if NFS3 is not configured 8b6923485 liyinshu Fix crash for out-of-bounds access

1 0

Change in ...nfs-ganesha[next]: Fix core for out-of-bounds access
by liyinshu (GerritHub) 11 Jan '22

11 Jan '22

liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/530853 ) Change subject: Fix core for out-of-bounds access ...................................................................... Fix core for out-of-bounds access Change-Id: I2ecc6a4129040f4c80116847aa062bf160776d57 Signed-off-by: liyinshu <liyinshu(a)bytedance.com> --- M src/SAL/recovery/recovery_fs.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/530853/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/530853 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2ecc6a4129040f4c80116847aa062bf160776d57 Gerrit-Change-Number: 530853 Gerrit-PatchSet: 1 Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Change valid attribute check in Proxy_V3 to allow rawdev.
by Bjorn Leffler (GerritHub) 11 Jan '22

11 Jan '22

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/530833 ) Change subject: Change valid attribute check in Proxy_V3 to allow rawdev. ...................................................................... Change valid attribute check in Proxy_V3 to allow rawdev. Mknode sets rawdev. Signed-off-by: Bjorn Leffler <leffler(a)google.com> Change-Id: I7bc103f05e83fe6b3c14843feb160fc853fe967c --- M src/FSAL/FSAL_PROXY_V3/utils.c M src/FSAL/FSAL_PROXY_V3/main.c 2 files changed, 26 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/530833/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/530833 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7bc103f05e83fe6b3c14843feb160fc853fe967c Gerrit-Change-Number: 530833 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <leffler(a)google.com> Gerrit-MessageType: newchange

1 0