January 2024 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Help needed on FD
by Alok Sinha 31 Jan '24

31 Jan '24

FD created at below path does not have correct link in /proc/self/fd. With vfs_readlink_by_handle , I can get a relative path but cannot get the absolute path of the FD. I need a suggestion for one of the below to get around a production bug: - How to get the full path of the FD? - How to get the parent vfs_fsal_obj_handle? - Anyway to bypass this flow by changing any config file? #0 vfs_create_handle (exp_hdl=0x55801aca22c0, hdl_desc=0x7f93889b1600, handle=0x7f93889b13f8, attrs_out=0x7f93889b1430) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/FSAL_VFS/handle.c:2020 #1 0x00007f94a1f0e13b in mdcache_locate_host (fh_desc=0x7f93889b1600, export=0x55801aca1f20, entry=0x7f93889b1578, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:1109 #2 0x00007f94a1f02455 in mdcache_create_handle (exp_hdl=0x55801aca1f20, fh_desc=0x7f93889b1600, handle=0x7f93889b15d8, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1613 #3 0x00007f94a1ec5ead in nfs4_mds_putfh (data=0x7f93201119e0) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:211 #4 0x00007f94a1ec60d3 in nfs4_op_putfh (op=0x7f93201186d0, data=0x7f93201119e0, resp=0x7f932010ab20) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:281 #5 0x00007f94a1ea96ae in process_one_op (data=0x7f93201119e0, status=0x7f93889b1b48) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:920 #6 0x00007f94a1eaa8c5 in nfs4_Compound (arg=0x7f9320138d78, req=0x7f93201385a0, res=0x7f9320106840) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:1329 #7 0x00007f94a1de8567 in nfs_rpc_process_request (reqdata=0x7f93201385a0) ---Type <return> to continue, or q <return> to quit--- at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1484 #8 0x00007f94a1de8854 in nfs_rpc_valid_NFS (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1591 #9 0x00007f94a13b6faf in svc_vc_decode (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:829 #10 0x00007f94a13b3225 in svc_request (xprt=0x7f9320000ce0, xdrs=0x7f9320066260) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:793 #11 0x00007f94a13b6ec0 in svc_vc_recv (xprt=0x7f9320000ce0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:802 #12 0x00007f94a13b31a5 in svc_rqst_xprt_task (wpe=0x7f9320000f00) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:774 #13 0x00007f94a13bcab0 in work_pool_thread (arg=0x7f9218003340) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/work_pool.c:184 #14 0x00007f94a1badea5 in start_thread () from /lib64/libpthread.so.0 #15 0x00007f94a16ce9fd in clone () from /lib64/libc.so.6 -- Alok Sinha www.spillbox.io https://youtu.be/U-YupjLQ9bU

2 2

[XS] Change in ...nfs-ganesha[next]: Fix GPFS FSAL for FSALS when we do NFSv3 create and open global fd, ...
by Michael Diederich (GerritHub) 25 Jan '24

25 Jan '24

Michael Diederich has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1175982?usp=email ) Change subject: Fix GPFS FSAL for FSALS when we do NFSv3 create and open global fd, we must LRU track it~ ...................................................................... Fix GPFS FSAL for FSALS when we do NFSv3 create and open global fd, we must LRU track it~ Change-Id: I9df784cb63c50fcd5e9c268ebd7ba9e81707d1b2 Signed-off-by: Michael Diederich <diederich(a)de.ibm.com> --- M src/FSAL/FSAL_GPFS/file.c M src/FSAL/FSAL_GPFS/fsal_internal.c 2 files changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/1175982/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1175982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9df784cb63c50fcd5e9c268ebd7ba9e81707d1b2 Gerrit-Change-Number: 1175982 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Diederich <diederich(a)de.ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: FSAL_PSEUDO set change, mtime, ctime on create directory
by Jason Woodward (GerritHub) 23 Jan '24

23 Jan '24

Jason Woodward has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1175826?usp=email ) Change subject: FSAL_PSEUDO set change, mtime, ctime on create directory ...................................................................... FSAL_PSEUDO set change, mtime, ctime on create directory FSAL_PSEUDO needs to update mtime, ctime, and change when creating directories (it does for removing). Fixes: #1060 Change-Id: I437a4f47a178ef4dc774e7d7639925caecfdf51f Signed-off-by: Jason Woodward <jawoodwa(a)microsoft.com> --- M src/FSAL/FSAL_PSEUDO/handle.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1175826/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1175826?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I437a4f47a178ef4dc774e7d7639925caecfdf51f Gerrit-Change-Number: 1175826 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Woodward <jawoodwa(a)microsoft.com>

1 0

[XS] Change in ...nfs-ganesha[next]: monitoring: fails to build with gcc-14
by Kaleb KEITHLEY (GerritHub) 22 Jan '24

22 Jan '24

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1175775?usp=email ) Change subject: monitoring: fails to build with gcc-14 ...................................................................... monitoring: fails to build with gcc-14 IIRC gcc-14 has disabled implicit-int decls. Add #include <algorithm> for decl of std::transform(). Change-Id: I5f9ce7f7e3c532d1320f9c9425d2721c25dc0105 Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/monitoring/monitoring.cc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/1175775/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1175775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5f9ce7f7e3c532d1320f9c9425d2721c25dc0105 Gerrit-Change-Number: 1175775 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

1 0

[XS] Change in ...nfs-ganesha[next]: ACL: fix memory leak
by bjfhdhhaha (GerritHub) 19 Jan '24

19 Jan '24

bjfhdhhaha has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174760?usp=email ) Change subject: ACL: fix memory leak ...................................................................... ACL: fix memory leak Change-Id: Id9cb0a1bd67be445f57aa344058ec7f776ab96d0 Signed-off-by: bjfhdhhaha <1453769042(a)qq.com> --- M src/FSAL/posix_acls.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/1174760/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174760?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id9cb0a1bd67be445f57aa344058ec7f776ab96d0 Gerrit-Change-Number: 1174760 Gerrit-PatchSet: 1 Gerrit-Owner: bjfhdhhaha <1453769042(a)qq.com>

1 0

[S] Change in ...nfs-ganesha[next]: Instrumentation changes to debug future lru_try_one crash
by Rojin George (GerritHub) 17 Jan '24

17 Jan '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174727?usp=email ) Change subject: Instrumentation changes to debug future lru_try_one crash ...................................................................... Instrumentation changes to debug future lru_try_one crash If the number of open FDs is above the low watermark, fd_lru starts the cleanup job. During certain scenarios it was found that it is trying to clean a fsal fd which was already freed up. This CR adds some loggers to debug such use after free issues. Change-Id: I28a74e0fa4665e3a252976ffca5b01c14bbdfa10 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL/FSAL_VFS/file.c M src/FSAL/commonlib.c 2 files changed, 31 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/27/1174727/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174727?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I28a74e0fa4665e3a252976ffca5b01c14bbdfa10 Gerrit-Change-Number: 1174727 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: bugfix: https://github.com/nfs-ganesha/nfs-ganesha/issues/1044
by Name of user not set (GerritHub) 17 Jan '24

17 Jan '24

sunpxyz(a)126.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174722?usp=email ) Change subject: bugfix: https://github.com/nfs-ganesha/nfs-ganesha/issues/1044 ...................................................................... bugfix: https://github.com/nfs-ganesha/nfs-ganesha/issues/1044 Change-Id: I8e1785a8c0d869bb1a5872e2d1a0bcc5ed508da1 Change-Id: I4f91ce02f5384264a9cc442d57a4e52ac4857516 Signed-off-by: sunpxyz <sunpxyz(a)126.com> --- M src/FSAL/FSAL_GLUSTER/handle.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/1174722/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4f91ce02f5384264a9cc442d57a4e52ac4857516 Gerrit-Change-Number: 1174722 Gerrit-PatchSet: 1 Gerrit-Owner: sunpxyz(a)126.com

1 0

[S] Change in ...nfs-ganesha[next]: Update courteous server with Open_State_Per_Client
by Rojin George (GerritHub) 16 Jan '24

16 Jan '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174687?usp=email ) Change subject: Update courteous server with Open_State_Per_Client ...................................................................... Update courteous server with Open_State_Per_Client This CR updates courteous server logics by referring the counter used for implementing Open_State_Per_Client. Change-Id: I5ec15c4ae7de87663ffae53b9f6fa1c4bd54da3b Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/SAL/nfs4_clientid.c 1 file changed, 1 insertion(+), 48 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/1174687/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174687?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5ec15c4ae7de87663ffae53b9f6fa1c4bd54da3b Gerrit-Change-Number: 1174687 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Grant Read delegations properly
by Rojin George (GerritHub) 16 Jan '24

16 Jan '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174684?usp=email ) Change subject: Grant Read delegations properly ...................................................................... Grant Read delegations properly Read delegation grants were failing because of counters going negative, as both _state_del_locked and late in nfs4_op_close, were decrementing the counter in CLOSE op's IO path Fixes: #1056 Change-Id: Ib1028f26f4f3ad184fbcbe5b7610d3b0c7990a31 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/Protocols/NFS/nfs4_op_close.c 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/84/1174684/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174684?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib1028f26f4f3ad184fbcbe5b7610d3b0c7990a31 Gerrit-Change-Number: 1174684 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0