November 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Added missing includes and initializations
by Lior Suliman (GerritHub) 25 Nov '24

25 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204598?usp=email to review the following change. Change subject: Added missing includes and initializations ...................................................................... Added missing includes and initializations Also moved variables initialization only to after we know it is valid to access it. Change-Id: Idf1f4237d6bce2707bf0680e8e721bfbeae09d9e Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_main.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/Protocols/NFS/nfs_proto_tools.c M src/log/log_functions.c 4 files changed, 9 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1204598/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204598?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idf1f4237d6bce2707bf0680e8e721bfbeae09d9e Gerrit-Change-Number: 1204598 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: Added a metric for dropped gss requests
by Lior Suliman (GerritHub) 25 Nov '24

25 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204597?usp=email to review the following change. Change subject: Added a metric for dropped gss requests ...................................................................... Added a metric for dropped gss requests Change-Id: I743da70cfae208e2df43115c9a379c83359d72d5 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_metrics.c M src/MainNFSD/nfs_worker_thread.c M src/include/nfs_metrics.h 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1204597/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204597?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I743da70cfae208e2df43115c9a379c83359d72d5 Gerrit-Change-Number: 1204597 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[L] Change in ...nfs-ganesha[next]: Added logs and lttng traces
by Lior Suliman (GerritHub) 25 Nov '24

25 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204596?usp=email to review the following change. Change subject: Added logs and lttng traces ...................................................................... Added logs and lttng traces Change-Id: I4133bf1d76d16bc7db427543a66002bda922c610 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_init.c M src/RPCAL/connection_manager.c M src/SAL/nfs4_lease.c M src/include/connection_manager.h M src/include/xprt_handler.h M src/support/xprt_handler.c 6 files changed, 225 insertions(+), 25 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/1204596/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4133bf1d76d16bc7db427543a66002bda922c610 Gerrit-Change-Number: 1204596 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have eno...
by Lior Suliman (GerritHub) 25 Nov '24

25 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204595?usp=email to review the following change. Change subject: nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry ...................................................................... nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry There were some flows that set it on failure and some that didn't. Better to always check on failure flow and set it. Change-Id: Ifcc9b97490a788a81e5b15dfeebd6040c8e5e776 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1204595/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204595?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifcc9b97490a788a81e5b15dfeebd6040c8e5e776 Gerrit-Change-Number: 1204595 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-CC: shaharhoch(a)google.com Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: do not crash when ref count is greater than 1
by Lior Suliman (GerritHub) 25 Nov '24

25 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204594?usp=email to review the following change. Change subject: do not crash when ref count is greater than 1 ...................................................................... do not crash when ref count is greater than 1 This is a legitimate case if there is more than 1 open state, and can also happen due to some races Change-Id: Ic69daa088f6ef99227e8c80274772269401158f9 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/SAL/nfs4_clientid.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/1204594/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204594?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic69daa088f6ef99227e8c80274772269401158f9 Gerrit-Change-Number: 1204594 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-CC: ofir vainshtein <ofirvins(a)google.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XL] Change in ...nfs-ganesha[next]: Clang format cc files
by Lior Suliman (GerritHub) 25 Nov '24

25 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204559?usp=email to review the following change. Change subject: Clang format cc files ...................................................................... Clang format cc files Change-Id: I91dfe36092a8974fa912cf6ea91f816b0cd7a20b Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/gtest/fsal_api/test_close2_latency.cc M src/gtest/fsal_api/test_close_latency.cc M src/gtest/fsal_api/test_commit2_latency.cc M src/gtest/fsal_api/test_getattrs_latency.cc M src/gtest/fsal_api/test_handle_to_key_latency.cc M src/gtest/fsal_api/test_handle_to_wire_latency.cc M src/gtest/fsal_api/test_link_latency.cc M src/gtest/fsal_api/test_lock_op2_latency.cc M src/gtest/fsal_api/test_lookup_latency.cc M src/gtest/fsal_api/test_mkdir_latency.cc M src/gtest/fsal_api/test_mknode_latency.cc M src/gtest/fsal_api/test_open2_latency.cc M src/gtest/fsal_api/test_read2_latency.cc M src/gtest/fsal_api/test_readdir_correctness.cc M src/gtest/fsal_api/test_readdir_latency.cc M src/gtest/fsal_api/test_readlink_latency.cc M src/gtest/fsal_api/test_release_latency.cc M src/gtest/fsal_api/test_rename_latency.cc M src/gtest/fsal_api/test_reopen2_latency.cc M src/gtest/fsal_api/test_setattr2_latency.cc M src/gtest/fsal_api/test_symlink_latency.cc M src/gtest/fsal_api/test_unlink_latency.cc M src/gtest/fsal_api/test_write2_latency.cc M src/gtest/nfs4/test_nfs4_link_latency.cc M src/gtest/nfs4/test_nfs4_lookup_latency.cc M src/gtest/nfs4/test_nfs4_putfh_latency.cc M src/gtest/nfs4/test_nfs4_rename_latency.cc M src/gtest/test_ci_hash_dist1.cc M src/gtest/test_example.cc M src/gtest/test_rbt.cc 30 files changed, 6,049 insertions(+), 5,729 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/1204559/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204559?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I91dfe36092a8974fa912cf6ea91f816b0cd7a20b Gerrit-Change-Number: 1204559 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: fsal_manager.c: Add support to configure / init static fsals
by Lior Suliman (GerritHub) 25 Nov '24

25 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204557?usp=email to review the following change. Change subject: fsal_manager.c: Add support to configure / init static fsals ...................................................................... fsal_manager.c: Add support to configure / init static fsals Change-Id: If2687b6d51815b096d5fa257a1d7bd6301de18fe Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/FSAL/fsal_manager.c M src/include/fsal_api.h 2 files changed, 13 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/1204557/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204557?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If2687b6d51815b096d5fa257a1d7bd6301de18fe Gerrit-Change-Number: 1204557 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix build break for USE_NFS3=OFF
by Sachin Punadikar (GerritHub) 24 Nov '24

24 Nov '24

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204553?usp=email ) Change subject: Fix build break for USE_NFS3=OFF ...................................................................... Fix build break for USE_NFS3=OFF Change-Id: Ifb6c4ae77516e892f9ccffaa19a60185d6c459cf Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/MainNFSD/nfs_metrics.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/1204553/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204553?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifb6c4ae77516e892f9ccffaa19a60185d6c459cf Gerrit-Change-Number: 1204553 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[S] Change in ...nfs-ganesha[next]: fsal_helper: Change order of mode bits check in fsal_setattr
by Lior Suliman (GerritHub) 24 Nov '24

24 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204539?usp=email to review the following change. Change subject: fsal_helper: Change order of mode bits check in fsal_setattr ...................................................................... fsal_helper: Change order of mode bits check in fsal_setattr Previously, the first check set ATTR_MODE as valid if ATTR_OWNER or ATTR_GROUP was valid. Then, the the next check looked at if ATTR_MODE was valid. But, there could be a case where it is not originally valid and just because valid due to our code. Changing the order fixes this issue. Change-Id: I4586e5014807227f9f1721a81af676216cc6d6ee Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/FSAL/fsal_helper.c 1 file changed, 19 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1204539/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4586e5014807227f9f1721a81af676216cc6d6ee Gerrit-Change-Number: 1204539 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: FSAL/fsal_helper: Don't clear SGID and SUID on chown for directories
by Lior Suliman (GerritHub) 24 Nov '24

24 Nov '24

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204538?usp=email to review the following change. Change subject: FSAL/fsal_helper: Don't clear SGID and SUID on chown for directories ...................................................................... FSAL/fsal_helper: Don't clear SGID and SUID on chown for directories Change-Id: I436ad98f92cefbe616b6e2d0e1242208d1283686 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/FSAL/fsal_helper.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/38/1204538/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204538?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I436ad98f92cefbe616b6e2d0e1242208d1283686 Gerrit-Change-Number: 1204538 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-CC: shaharhoch(a)google.com Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 0