November 2023 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 19 Feb '24

19 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Help needed on FD
by Alok Sinha 31 Jan '24

31 Jan '24

FD created at below path does not have correct link in /proc/self/fd. With vfs_readlink_by_handle , I can get a relative path but cannot get the absolute path of the FD. I need a suggestion for one of the below to get around a production bug: - How to get the full path of the FD? - How to get the parent vfs_fsal_obj_handle? - Anyway to bypass this flow by changing any config file? #0 vfs_create_handle (exp_hdl=0x55801aca22c0, hdl_desc=0x7f93889b1600, handle=0x7f93889b13f8, attrs_out=0x7f93889b1430) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/FSAL_VFS/handle.c:2020 #1 0x00007f94a1f0e13b in mdcache_locate_host (fh_desc=0x7f93889b1600, export=0x55801aca1f20, entry=0x7f93889b1578, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:1109 #2 0x00007f94a1f02455 in mdcache_create_handle (exp_hdl=0x55801aca1f20, fh_desc=0x7f93889b1600, handle=0x7f93889b15d8, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1613 #3 0x00007f94a1ec5ead in nfs4_mds_putfh (data=0x7f93201119e0) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:211 #4 0x00007f94a1ec60d3 in nfs4_op_putfh (op=0x7f93201186d0, data=0x7f93201119e0, resp=0x7f932010ab20) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:281 #5 0x00007f94a1ea96ae in process_one_op (data=0x7f93201119e0, status=0x7f93889b1b48) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:920 #6 0x00007f94a1eaa8c5 in nfs4_Compound (arg=0x7f9320138d78, req=0x7f93201385a0, res=0x7f9320106840) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:1329 #7 0x00007f94a1de8567 in nfs_rpc_process_request (reqdata=0x7f93201385a0) ---Type <return> to continue, or q <return> to quit--- at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1484 #8 0x00007f94a1de8854 in nfs_rpc_valid_NFS (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1591 #9 0x00007f94a13b6faf in svc_vc_decode (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:829 #10 0x00007f94a13b3225 in svc_request (xprt=0x7f9320000ce0, xdrs=0x7f9320066260) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:793 #11 0x00007f94a13b6ec0 in svc_vc_recv (xprt=0x7f9320000ce0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:802 #12 0x00007f94a13b31a5 in svc_rqst_xprt_task (wpe=0x7f9320000f00) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:774 #13 0x00007f94a13bcab0 in work_pool_thread (arg=0x7f9218003340) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/work_pool.c:184 #14 0x00007f94a1badea5 in start_thread () from /lib64/libpthread.so.0 #15 0x00007f94a16ce9fd in clone () from /lib64/libc.so.6 -- Alok Sinha www.spillbox.io https://youtu.be/U-YupjLQ9bU

2 2

Updated invitation: Ganesha community call @ Weekly from 7am to 8am on Tuesday (PST) (devel@lists.nfs-ganesha.org)
by Frank Filz 29 Nov '23

29 Nov '23

This event has been updated Ganesha community call Weekly from 7am to 8am on Tuesday Pacific Time - Los Angeles Join with Google Meet https://meet.google.com/mkh-ctnj-tqz?hs=224 Join by phone (US) +1 401-702-0462 PIN: 495972631 More joining options https://tel.meet/mkh-ctnj-tqz?pin=2844708468265&hs=0 Join using SIP 2844708468265(a)gmeet.redhat.com ID: 2844708468265 Organizer Frank Filz ffilz(a)redhat.com Guests Frank Filz - organizer thomas.vanderputten(a)panzura.com ffilzg(a)gmail.com Daniel Gryniewicz dmanzoni(a)verisign.com martin(a)uni-mainz.de Matt Benjamin Kaleb Keithley leffler(a)google.com sagar.it.iiests(a)gmail.com geva30(a)gmail.com assafy(a)google.com liorsu(a)google.com gauravin(a)google.com yashnarang(a)google.com dipit(a)google.com roopkamal(a)google.com richard.rupp(a)us.ibm.com alok(a)spillbox.io punadikar.sachin(a)gmail.com devel(a)lists.nfs-ganesha.org Wyll Ingersoll hu hansen ffilz(a)ibm.com Marcus Gorzellik Yogendra Charya Sriram Patil Jacobson, Erik blaine.gardner(a)ibm.com ndevos(a)ibm.com View all guest info https://calendar.google.com/calendar/event?action=VIEW&eid=NXZubmZhbGJwcTdi… Reply for devel(a)lists.nfs-ganesha.org and view more details https://calendar.google.com/calendar/event?action=VIEW&eid=NXZubmZhbGJwcTdi… Your attendance is optional. ~~//~~ Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this email because you are an attendee on the event. To stop receiving future updates for this event, decline this event. Forwarding this invitation could allow any recipient to send a response to the organizer, be added to the guest list, invite others regardless of their own invitation status, or modify your RSVP. Learn more https://support.google.com/calendar/answer/37135#forwarding

1 0

Updated invitation: Ganesha community call @ Weekly from 7am to 8am on Tuesday from Tue Nov 21 to Mon Nov 27 (PST) (devel@lists.nfs-ganesha.org)
by Frank Filz 29 Nov '23

29 Nov '23

This event has been updated Changed: time Ganesha community call Weekly from 7am to 8am on Tuesday from Tuesday Nov 21 to Monday Nov 27 Pacific Time - Los Angeles Join with Google Meet https://meet.google.com/mkh-ctnj-tqz?hs=224 Join by phone (US) +1 401-702-0462 PIN: 495972631 More joining options https://tel.meet/mkh-ctnj-tqz?pin=2844708468265&hs=0 Join using SIP 2844708468265(a)gmeet.redhat.com ID: 2844708468265 Organizer Frank Filz ffilz(a)redhat.com Guests Frank Filz - organizer thomas.vanderputten(a)panzura.com ffilzg(a)gmail.com Daniel Gryniewicz dmanzoni(a)verisign.com martin(a)uni-mainz.de Matt Benjamin Kaleb Keithley leffler(a)google.com sagar.it.iiests(a)gmail.com geva30(a)gmail.com assafy(a)google.com liorsu(a)google.com gauravin(a)google.com yashnarang(a)google.com dipit(a)google.com roopkamal(a)google.com richard.rupp(a)us.ibm.com alok(a)spillbox.io punadikar.sachin(a)gmail.com devel(a)lists.nfs-ganesha.org Wyll Ingersoll hu hansen ffilz(a)ibm.com Marcus Gorzellik Yogendra Charya Sriram Patil Jacobson, Erik View all guest info https://calendar.google.com/calendar/event?action=VIEW&eid=NXZubmZhbGJwcTdi… Reply for devel(a)lists.nfs-ganesha.org and view more details https://calendar.google.com/calendar/event?action=VIEW&eid=NXZubmZhbGJwcTdi… Your attendance is optional. ~~//~~ Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this email because you are an attendee on the event. To stop receiving future updates for this event, decline this event. Forwarding this invitation could allow any recipient to send a response to the organizer, be added to the guest list, invite others regardless of their own invitation status, or modify your RSVP. Learn more https://support.google.com/calendar/answer/37135#forwarding

1 0

[M] Change in ...nfs-ganesha[next]: build: use standard (i.e. pep517) build and installer
by Kaleb KEITHLEY (GerritHub) 20 Nov '23

20 Nov '23

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172381?usp=email ) Change subject: build: use standard (i.e. pep517) build and installer ...................................................................... build: use standard (i.e. pep517) build and installer `python setup.py install` (and to a lesser extent `python setup.py build`) is deprecated, and many build systems are emitting warnings about support for `setup.py install` being removed. Note that `python -m installer --prefix ... --destdir ...` doesn't seem to have any way that I can see to install to /usr/libexec/ganesha/ so we have to explicitly mv it from /usr/bin to /usr/libexec/... in the %install stanza of the .spec. To use outside of an rpmbuild you need python3-wheel, python3-build, and python3-installer rpms installed on your system. python3-wheel is available in RHEL and CentOS from the AppStream repo on both C8S and C9S. python3-build is in EPEL9 but not EPEL8. python3-installer is not in either EPEL8 or EPEL9 at the time of this writing. Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> Change-Id: Ida39a3ee5e6b4b0d3255bfef95601890afd80709 --- M src/CMakeLists.txt M src/nfs-ganesha.spec-in.cmake M src/scripts/ganesha-top/CMakeLists.txt M src/scripts/ganeshactl/CMakeLists.txt M src/scripts/gpfs-epoch/CMakeLists.txt 5 files changed, 119 insertions(+), 33 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/1172381/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172381?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ida39a3ee5e6b4b0d3255bfef95601890afd80709 Gerrit-Change-Number: 1172381 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: Fix crash at free_client_id()->PTHREAD_MUTEX_destroy()
by Name of user not set (GerritHub) 20 Nov '23

20 Nov '23

skmprabhu252(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172367?usp=email ) Change subject: Fix crash at free_client_id()->PTHREAD_MUTEX_destroy() ...................................................................... Fix crash at free_client_id()->PTHREAD_MUTEX_destroy() Commit 75cec08b2fd21739be95b821384b5ae9ec9560e1 removed PTHREAD_MUTEX_lock() before reserve_lease_or_expire(), but left out PTHREAD_MUTEX_unlock() on line #1049. This is causing a crash at free_client_id()->PTHREAD_MUTEX_destroy() Change-Id: Ie5f92347b33c831fa03298354340076fb2f1201f Signed-off-by: Prabhu Murugesan <prabhu.murugesan1(a)ibm.com> --- M src/SAL/nfs4_state_id.c 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/67/1172367/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172367?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie5f92347b33c831fa03298354340076fb2f1201f Gerrit-Change-Number: 1172367 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: xprt_handler: Do not associate a session with an under-destruction xprt
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172202?usp=email ) Change subject: xprt_handler: Do not associate a session with an under-destruction xprt ...................................................................... xprt_handler: Do not associate a session with an under-destruction xprt Change-Id: I5a8f2dec802e100025b731afb0a4c52a6a4b34cc Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/xprt_handler.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/1172202/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172202?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5a8f2dec802e100025b731afb0a4c52a6a4b34cc Gerrit-Change-Number: 1172202 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: xprt_handler: Add function to un-reference xprt client-data
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172201?usp=email ) Change subject: xprt_handler: Add function to un-reference xprt client-data ...................................................................... xprt_handler: Add function to un-reference xprt client-data When destroying a xprt, all its outstanding references must be released. Additionally, the references of external objects held by the xprt must also be released. This CL adds a function that performs this processing. Change-Id: I9142e578c2333ea18b23c95d78de6b451bb094bc Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/include/xprt_handler.h M src/support/xprt_handler.c 2 files changed, 123 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/1172201/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172201?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9142e578c2333ea18b23c95d78de6b451bb094bc Gerrit-Change-Number: 1172201 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: xprt_handler: Add function to destroy the session backchannel for a xprt
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172200?usp=email ) Change subject: xprt_handler: Add function to destroy the session backchannel for a xprt ...................................................................... xprt_handler: Add function to destroy the session backchannel for a xprt Given a xprt and a session, this CL adds a function to destroy the session's backchannel if it uses the xprt. When destroying a xprt, this function would be called to release the xprt's reference held by the session backchannels. Change-Id: I5604dde54a92367d0b738b8530787d30120a3aa0 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/xprt_handler.c 1 file changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/1172200/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172200?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5604dde54a92367d0b738b8530787d30120a3aa0 Gerrit-Change-Number: 1172200 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: nfs41_session: Add function to remove a xprt from the session
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172199?usp=email ) Change subject: nfs41_session: Add function to remove a xprt from the session ...................................................................... nfs41_session: Add function to remove a xprt from the session When processing a xprt object that needs to be destroyed, all its sessions must release the xprt's references. This CL adds a function that removes the reference of a given xprt from a given session. Change-Id: I5fd6ac14a2d82a5d42ce1afcc1be308623597291 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/SAL/nfs41_session_id.c M src/include/sal_functions.h 2 files changed, 80 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/1172199/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172199?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5fd6ac14a2d82a5d42ce1afcc1be308623597291 Gerrit-Change-Number: 1172199 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0