May 2023 - Devel - Nfs Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: build: Fix developer warning for LSB module

by Martin Schwenke (GerritHub)

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/554766?usp=email ) Change subject: build: Fix developer warning for LSB module ...................................................................... build: Fix developer warning for LSB module CMake Warning (dev) at /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to `find_package_handle_standard_args` (LSB_RELEASE) does not match the name of the calling package (LSB). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake/modules/FindLSB.cmake:85 (find_package_handle_standard_args) CMakeLists.txt:1632 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. Rename the module to LSBRelease and make that the first argument to find_package_handle_standard_args(). Other options are: * Pass LSB as the first argument. This just seems confusing. * Rename the module to LSB_RELEASE. Given that there are no cmake modules with names containing underscores, this doesn't seem like the right solution. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: If0e3c80378db8aa97e8f0b6f69d91ef0f8201e3f --- M src/CMakeLists.txt R src/cmake/modules/FindLSBRelease.cmake 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/554766/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/554766?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If0e3c80378db8aa97e8f0b6f69d91ef0f8201e3f Gerrit-Change-Number: 554766 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

3 months, 4 weeks

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: build: Fix Python detection

by Martin Schwenke (GerritHub)

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/554765?usp=email ) Change subject: build: Fix Python detection ...................................................................... build: Fix Python detection Commit c43049fc42b0a1d39b48ddbf93af56223ba5f9ee introduced copies of several cmake modules, which are now breaking Python detection. The commit message does not give details of benefits of these versions of the modules. It is unclear if they were different to the upstream cmake modules at the time and this can't be resolved without an archaeological dig. Whatever the case, the modules have almost certainly been improved upstream to work around the reason for their addition here. Just delete the duplicate modules introduced by the above commit. This leaves src/cmake/modules/FindGTest.cmake as the only apparent duplicate module. Note that this change introduces a developer warning: CMake Warning (dev) at /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:438 (message): The package name passed to `find_package_handle_standard_args` (LSB_RELEASE) does not match the name of the calling package (LSB). This can lead to problems in calling code that expects `find_package` result variables (e.g., `_FOUND`) to follow a certain pattern. Call Stack (most recent call first): cmake/modules/FindLSB.cmake:85 (find_package_handle_standard_args) CMakeLists.txt:1632 (find_package) This warning is for project developers. Use -Wno-dev to suppress it. Given that this is only a warning, this can be fixed in a subsequent commit. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I0cb1fb4d3dd9674d52720095961ed6b56dda6c45 --- D src/cmake/modules/CMakeParseArguments.cmake D src/cmake/modules/FindPackageHandleStandardArgs.cmake D src/cmake/modules/FindPackageMessage.cmake D src/cmake/modules/FindPkgConfig.cmake 4 files changed, 0 insertions(+), 898 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/554765/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/554765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0cb1fb4d3dd9674d52720095961ed6b56dda6c45 Gerrit-Change-Number: 554765 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

3 months, 4 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: GPFS: fix 40 byte sized old file handles

by Name of user not set (GerritHub)

Attention is currently required from: Malahal. Hello Malahal, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/554760?usp=email to review the following change. Change subject: GPFS: fix 40 byte sized old file handles ...................................................................... GPFS: fix 40 byte sized old file handles Some versions may have returned 40 byte sized file handles. Make them same as 48 byte sized file handles to avoid multiple entries in the object cache for the same file system object. Change-Id: I242faa62cfc3c5d88db86a1096ef4720ce4c6590 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> (cherry picked from commit 706e5dce49d7bbb07ea005d1b74eada8b0f1a761) --- M src/FSAL/FSAL_GPFS/handle.c 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/554760/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/554760?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I242faa62cfc3c5d88db86a1096ef4720ce4c6590 Gerrit-Change-Number: 554760 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com Gerrit-Reviewer: Malahal <malahal(a)gmail.com> Gerrit-Attention: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

3 months, 4 weeks

1
0
0 / 0

MDCache LRU management queries

by Gaurav Sharma

Hi Ganesha Team, In MDCache we have two arrays named LRU and CHUNK_LRU to store the lru entry in their respective queues. For the CHUNK_LRU, the function lru_bump_chunk() will move the entry to MRU of L1. For LRU there is a function adjust_lru() which does the similar job. Question : The function adjust_lru() is only called if the flag is LRU_REQ_INITIAL and that is happening only during unexport. 1. Can you please suggest how the entries in LRU queue are moving to MRU of the queue? 2. How LRU entries are moved from L2 to L1 queue? from L1 to L2 is done by the background thread. Regards, Gaurav Sharma

4 months

2
1
0 / 0

Announce Push of V5.2

by Frank Filz

Branch next Tag:V5.2 Merge Highlights * Fix btrfs typo in log messages * Fix cmake so USE_FSAL_CEPH_FS_NONBLOCKING_IO will be used * Unlock work_mutex in fsal_complete_io only if we got it * For async I/O the callback must create it's own op_context * monitoring: C++ cleanup to build with userspace-rcu-14.0.0 * NLM: Fix NSM reference count double-decrement * Multi-client same hostname issue - open owner refcount fix Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 9a84f015b Frank S. Filz V5.2 2aa4494cd Deepak Arumugam Sankara Subramanian Multi-client same hostname issue - open owner refcount fix 8f6ee41cd Martin Schwenke NLM: Fix NSM reference count double-decrement 622d7f68b Kaleb S. KEITHLEY monitoring: C++ cleanup to build with userspace-rcu-14.0.0 10389577b Frank S. Filz For async I/O the callback must create it's own op_context 43d984e2c Frank S. Filz Unlock work_mutex in fsal_complete_io only if we got it ed66984ae Frank S. Filz CMake - actually do USE_FSAL_CEPH_FS_NONBLOCKING_IO 5a747e92a Frank S. Filz Change btfs to btrfs in two log messages

4 months, 1 week

1
0
0 / 0

Understanding ganesha's idmapping behavior for specific principals

by Dipit Grover

Hi team, Looking at the Ganesha nfs idmapper code (at https://github.com/nfs-ganesha/nfs-ganesha/blob/next/src/idmapper/idmappe...), I wish to understand the rationale behind resolving principals of the form "nfs/*", "host/*" and "root/*" to the "root" user. I could not find any mention of it in the NFS protocol RFCs. Is there a specific use-case that this code enables? Thanks, Dipit

4 months, 1 week

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Pass failure to add clientid to recovery database back to client

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/553781?usp=email ) Change subject: Pass failure to add clientid to recovery database back to client ...................................................................... Pass failure to add clientid to recovery database back to client Previously we would log an error, but leave the client with no clue that it would not be able to reclaim state in the case of a server failure. The failure will be reported to the client as NFS4ERR_SERVERFAULT on SET_CLIENDID_CONFIRM or CREATE_SESSION. Change-Id: If68312abcd06ff5bcc010ebd84d1421717b839a3 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/nfs4_clientid.c M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_fs.c M src/SAL/recovery/recovery_fs.h M src/SAL/recovery/recovery_rados.h M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c M src/include/sal_data.h M src/include/sal_functions.h 9 files changed, 74 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/553781/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/553781?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If68312abcd06ff5bcc010ebd84d1421717b839a3 Gerrit-Change-Number: 553781 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 months, 2 weeks

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: For async I/O the callback must create it's own op_context

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/553780?usp=email ) Change subject: For async I/O the callback must create it's own op_context ...................................................................... For async I/O the callback must create it's own op_context We can't pass the orginal caller's op_context, it may still need it. Just instantiate a simple op_context for the callback. The callback op_context needs an export reference but we can take it when we create the op_context because until the protocol callback is made, we know the protocol request's op_context with its reference for the export MUST still be valid. Change-Id: I061c7eed8105b3283a243335b5ea63a86225b85b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h 4 files changed, 98 insertions(+), 47 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/553780/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/553780?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I061c7eed8105b3283a243335b5ea63a86225b85b Gerrit-Change-Number: 553780 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 months, 2 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Unlock work_mutex in fsal_complete_io only if we got it

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/553779?usp=email ) Change subject: Unlock work_mutex in fsal_complete_io only if we got it ...................................................................... Unlock work_mutex in fsal_complete_io only if we got it Change-Id: I280f806f0ae394bdc4f3ca1a79a2346fb38db35b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/commonlib.c 1 file changed, 17 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/553779/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/553779?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I280f806f0ae394bdc4f3ca1a79a2346fb38db35b Gerrit-Change-Number: 553779 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 months, 2 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: CMake - actually do USE_FSAL_CEPH_FS_NONBLOCKING_IO

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/553778?usp=email ) Change subject: CMake - actually do USE_FSAL_CEPH_FS_NONBLOCKING_IO ...................................................................... CMake - actually do USE_FSAL_CEPH_FS_NONBLOCKING_IO Change-Id: I24032d23088344f72cb72734d6dd8b4042ef95e9 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/config-h.in.cmake 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/553778/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/553778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I24032d23088344f72cb72734d6dd8b4042ef95e9 Gerrit-Change-Number: 553778 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

4 months, 2 weeks

1
0
0 / 0

2023

2022

2021

2020

2019

2018

Devel May 2023