May 2024 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: 9P: Avoid grace reference counting bug
by Martin Schwenke (GerritHub) 12 Jun '24

12 Jun '24

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195478?usp=email ) Change subject: 9P: Avoid grace reference counting bug ...................................................................... 9P: Avoid grace reference counting bug Prior code in this case increments the no-grace reference count via nfs_get_grace_status(false). An early break from this case also needs to decrement it. This is a regression introduced by commit 7b1ff6e00d095f1fceb0f56243ac0ad365e31d9c. Reported-by: Arnab Tah <atah(a)ddn.com> Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: If7f3a6a663d89886cdab1a28fc8b269760084899 --- M src/Protocols/9P/9p_lock.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/1195478/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195478?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If7f3a6a663d89886cdab1a28fc8b269760084899 Gerrit-Change-Number: 1195478 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net>

2 1

[S] Change in ...nfs-ganesha[next]: Fix crash at release_lock_owner()-> _get_gsh_export_ref()
by Name of user not set (GerritHub) 12 Jun '24

12 Jun '24

skmprabhu252(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176303?usp=email ) Change subject: Fix crash at release_lock_owner()-> _get_gsh_export_ref() ...................................................................... Fix crash at release_lock_owner()-> _get_gsh_export_ref() Fix crash at release_lock_owner()-> _get_gsh_export_ref() And nfs4_op_free_stateid-> dec_state_t_ref() This issue has been introduced by the commits with the IDs 55545864 and 067058ad. please refer https://github.com/nfs-ganesha/nfs-ganesha/issues/1062 Change-Id: Idc1c539961e42a1a35f064a2bc227856a8e05b49 Signed-off-by: Prabhu Murugesan <prabhu.murugesan1(a)ibm.com> --- M src/SAL/nfs4_state.c 1 file changed, 35 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/1176303/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176303?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idc1c539961e42a1a35f064a2bc227856a8e05b49 Gerrit-Change-Number: 1176303 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com

2 2

[S] Change in ...nfs-ganesha[next]: FSAL: Fix all places fd_work is decremented to signal condition varia...
by Frank Filz (GerritHub) 29 May '24

29 May '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195471?usp=email ) Change subject: FSAL: Fix all places fd_work is decremented to signal condition variables ...................................................................... FSAL: Fix all places fd_work is decremented to signal condition variables Use fsal_complete_fd_work() in the two error cases in fsal_start_fd_work. Also, add a new fsal_start_fd_work_no_reclaim that is void and sets is_reclaiming to false and assures the return code from fsal_complete_fd_work is not an error (can not happen). Change-Id: I60c840570002b8f5c72bc6b6120b7b038de4c22f Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/file.c M src/FSAL/FSAL_KVSFS/kvsfs_file.c M src/FSAL/FSAL_LIZARDFS/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_SAUNAFS/handle.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/commonlib.c M src/include/FSAL/fsal_commonlib.h 10 files changed, 21 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/1195471/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195471?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I60c840570002b8f5c72bc6b6120b7b038de4c22f Gerrit-Change-Number: 1195471 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: nfsv4 is mounted by default
by Name of user not set (GerritHub) 28 May '24

28 May '24

zengzheng007(a)163.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195376?usp=email ) Change subject: nfsv4 is mounted by default ...................................................................... nfsv4 is mounted by default Change-Id: Iecea894e22f4c84cadcbce780d4b36957240400a Signed-off-by: izxl007 <zengzheng007(a)163.com> --- M src/include/nfs_exports.h 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/1195376/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195376?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iecea894e22f4c84cadcbce780d4b36957240400a Gerrit-Change-Number: 1195376 Gerrit-PatchSet: 1 Gerrit-Owner: zengzheng007(a)163.com

1 0

[S] Change in ...nfs-ganesha[next]: nfs_worker: Destroy connection when rpcsec_gss_data request is dropped
by Dipit Grover (GerritHub) 27 May '24

27 May '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195344?usp=email ) Change subject: nfs_worker: Destroy connection when rpcsec_gss_data request is dropped ...................................................................... nfs_worker: Destroy connection when rpcsec_gss_data request is dropped In case of `RPCSEC_GSS_DATA` procedure, if Ganesha receives an AUTH_OK response from ntirpc with instructions to discard the request, the actual authentication did not complete, and ntirpc itself also did not send any response to the client. In such a scenario, in order to remain compliant both GSS_API RFC and NFSV4.1 RFC, Ganesha should terminate the RPC connection. This CL addresses it. Change-Id: I1fc81fef67ebf1292f1e537c34a6a2560a72b62b Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_worker_thread.c 1 file changed, 42 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1195344/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195344?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1fc81fef67ebf1292f1e537c34a6a2560a72b62b Gerrit-Change-Number: 1195344 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: Idmapping: Resolve fully qualified user/group principal names
by Dipit Grover (GerritHub) 27 May '24

27 May '24

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195343?usp=email ) Change subject: Idmapping: Resolve fully qualified user/group principal names ...................................................................... Idmapping: Resolve fully qualified user/group principal names When using pw-utils for idmapping, until now Ganesha validated the domain contained in the user/group principal names against the configured domain-name, before resolving them to uid/gid. On successful validation, the domain was stripped off from the names before passing those names to pw-utils functions for idmapping. This has some limitations: 1. The passed names can conflict with local machine users/groups, and that may cause incorrect user/group resolution 2. In a multi-domain environment (AD trusts for example), the actual domain must be passed for the user/group identification. This CL addresses these limitations by passing the fully-qualified names to pw-utils for user/group resolution. The CL also adds a config flag in Directory_Services section of Ganesha config, which controls whether to use fully qualified names for idmapping with pw-utils. The default value of this config flag is set to false, to retain the existing behavior. Change-Id: I021c3bf5c2d4a9de39e6827e49c9b693763a155c Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/doc/man/ganesha-core-config.rst M src/idmapper/idmapper.c M src/include/gsh_config.h M src/support/nfs_read_conf.c 4 files changed, 83 insertions(+), 45 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1195343/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195343?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I021c3bf5c2d4a9de39e6827e49c9b693763a155c Gerrit-Change-Number: 1195343 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[M] Change in ...nfs-ganesha[next]: feat(recovery): reject reclaim in edge conditions
by Zhitao Li (GerritHub) 22 May '24

22 May '24

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195036?usp=email ) Change subject: feat(recovery): reject reclaim in edge conditions ...................................................................... feat(recovery): reject reclaim in edge conditions Don't allow reclaim if the clientid didn't reclaim completely after grace period terminated to reject questionable reclaim in some edge condition according to RFC 8881 Section 8.4.3. Change-Id: I1d935bc34c4f12ffe7e26b5e50883bad6e1122d0 Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/Protocols/NFS/nfs4_op_reclaim_complete.c M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_fs.c M src/SAL/recovery/recovery_fs_ng.c M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c M src/include/sal_data.h M src/include/sal_functions.h 8 files changed, 44 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/1195036/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195036?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1d935bc34c4f12ffe7e26b5e50883bad6e1122d0 Gerrit-Change-Number: 1195036 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com>

1 0

[M] Change in ...nfs-ganesha[next]: WIP CEPH: Enable zero copy also allow run time config of async and ze...
by Frank Filz (GerritHub) 21 May '24

21 May '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195024?usp=email ) Change subject: WIP CEPH: Enable zero copy also allow run time config of async and zero copy ...................................................................... WIP CEPH: Enable zero copy also allow run time config of async and zero copy Change-Id: I7b32a748f2c092f1958dd8f88ceee23abd29153e Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_CEPH/internal.h M src/FSAL/FSAL_CEPH/main.c 3 files changed, 52 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/1195024/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195024?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7b32a748f2c092f1958dd8f88ceee23abd29153e Gerrit-Change-Number: 1195024 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: WIP CEPH: cmake bits for detecting zero copy support and revert 4cbf7...
by Frank Filz (GerritHub) 21 May '24

21 May '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195023?usp=email ) Change subject: WIP CEPH: cmake bits for detecting zero copy support and revert 4cbf7d603 ...................................................................... WIP CEPH: cmake bits for detecting zero copy support and revert 4cbf7d603 Revert commit 4cbf7d603ae67404a1ca270cc244027ac2ef8ea0 "CEPH: Disable ceph nonblocking-io for now - it doesn't work well" Change-Id: I7efbbd8ba38f7a8847b799b3149fc3b6040075f7 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/CMakeLists.txt M src/FSAL/FSAL_CEPH/CMakeLists.txt M src/cmake/modules/FindCEPHFS.cmake M src/include/config-h.in.cmake 4 files changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/1195023/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195023?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7efbbd8ba38f7a8847b799b3149fc3b6040075f7 Gerrit-Change-Number: 1195023 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[M] Change in ...nfs-ganesha[next]: MORE fsal_read2
by Frank Filz (GerritHub) 21 May '24

21 May '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195022?usp=email ) Change subject: MORE fsal_read2 ...................................................................... MORE fsal_read2 Change-Id: I4a10ab2696274bb401014a0a27372e5cf09561a4 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/fsal_helper.c M src/RPCAL/rpc_tools.c M src/include/gsh_rpc.h 3 files changed, 66 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/1195022/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1195022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4a10ab2696274bb401014a0a27372e5cf09561a4 Gerrit-Change-Number: 1195022 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0