Monitoring in Ganesha?
by Bjorn Leffler
Apart from the counters that you can access through dbus, is there any
other monitoring built into Ganesha?
I'm thinking of adding it with this higher level plan:
- Exporting metrics from Ganesha to Prometheus.
- Aggregate data in Prometheus.
- Display monitoring consoles and graphs with Grafana.
- Package up Prometheus, Grafana and the preconfigured rules/dashboards as
a Docker image.
- This makes it straightforward to deploy monitoring alongside a Gansha
binary.
My rough coding plan for the code is to:
- Add a USE_MONITORING directive to the CMakeLists.txt files.
- Add a build dependency to the Prometheus C client
<https://github.com/digitalocean/prometheus-client-c>.
- Create a src/monitoring directory for the new source files and templates.
- Increment counters and timers throughout the code.
- Use histograms to compute latency percentiles, heatmaps, etc.
Is this a good idea? Any objections or suggestions?
Thanks,
Bjorn
1 year, 6 months
Change in ...nfs-ganesha[next]: Remove init.d/nfs-ganesha.gpfs
by Dominique Martinet (GerritHub)
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517876 )
Change subject: Remove init.d/nfs-ganesha.gpfs
......................................................................
Remove init.d/nfs-ganesha.gpfs
GPFS doesn't support any init.d based systems anymore.
Change-Id: I8c83b8dad3c0e36289e8a440711cb60610a94adc
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
D src/scripts/init.d/nfs-ganesha.gpfs
1 file changed, 0 insertions(+), 393 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/517876/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517876
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I8c83b8dad3c0e36289e8a440711cb60610a94adc
Gerrit-Change-Number: 517876
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
Gerrit-MessageType: newchange
2 years
Change in ...nfs-ganesha[next]: vfs_getextattr_value: fix posix2fsal_error parameter
by Dominique Martinet (GerritHub)
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517874 )
Change subject: vfs_getextattr_value: fix posix2fsal_error parameter
......................................................................
vfs_getextattr_value: fix posix2fsal_error parameter
fgetxattr returns -1 on error, we need to look at errno
Change-Id: I381b2759cb1582804a945dc26e10510f16a04bb1
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/FSAL/FSAL_VFS/xattrs.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/517874/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517874
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I381b2759cb1582804a945dc26e10510f16a04bb1
Gerrit-Change-Number: 517874
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
Gerrit-MessageType: newchange
2 years
Change in ...nfs-ganesha[next]: CMakefiles: cleanup mooshika-related conf
by Dominique Martinet (GerritHub)
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517873 )
Change subject: CMakefiles: cleanup mooshika-related conf
......................................................................
CMakefiles: cleanup mooshika-related conf
- MOOSHIKA_PREFIX was added twice, remove one
- MOOSHIKA_LIBRARIES can be always used to link with ganesha_nfsd, if
9P_RDMA is not configured then the variable will just be empty
Change-Id: I2331c9cffd265802e986029f9482c19c75abb1a8
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/CMakeLists.txt
M src/MainNFSD/CMakeLists.txt
2 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/517873/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/517873
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2331c9cffd265802e986029f9482c19c75abb1a8
Gerrit-Change-Number: 517873
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
Gerrit-MessageType: newchange
2 years
Announce Push of V4-dev.61
by Frank Filz
Branch next
Tag:V4-dev.61
Merge Highlights
* Fix dbus spec violation in export_show_exports.
* remove unused assignments
* log the permission set fail
* Make parser tokens case sensitive
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
a1127c520 Frank S. Filz V4-dev.61
88ecb55dc Björn Fischer Fix dbus spec violation in export_show_exports.
95687c522 FloridSleeves remove unused assignments
4a518443d FloridSleeves log the permission set fail
4cd8bd97c Malahal Naineni Make parser tokens case sensitive
2 years
Announce Push of V4-dev.60
by Frank Filz
Branch next
Tag:V4-dev.60
Merge Highlights
* fix various build and compile issues
* v4_recovery: off-by-one error, v4_recov_dir is truncated
* ClientID - Add an upper limit on the number of ClientIDs.
* Don't kill mdache entry on error delay
* Stats - Prevent RPC time from going negative.
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
5115fcc50 Frank S. Filz V4-dev.60
1261b7f31 Pradeep Stats - Prevent RPC time from going negative.
1ebec8701 Suhrud Patankar Don't kill mdache entry on error delay
b146e7cca Pradeep ClientID - Add an upper limit on the number of ClientIDs.
43dbe8155 Frank S. Filz Allow building rados_grace with ASAN
dbf74d640 Frank S. Filz Initialize some avl tree keys to 0 to avoid
uninitialized error
5e987a174 Kaleb S. KEITHLEY v4_recovery: off-by-one error, v4_recov_dir is
truncated
83d2f5037 Frank S. Filz multilock: fix compile warning due to ignoring
snprintf return
2 years
FSAL read and ERR_FSAL_DELAY
by Suhrud Patankar
Hello All,
We want to serve read in case of a slow backend and would like the client
to retry the read op.
mdc_read_super_cb() calls mdcache_kill_entry() if FSAL returns eDelay. This
ends up cleaning the state for the file including any byte range locks.
Does this mean eDealy is not a valid error for FSAL read? How do I return
ERR_FSAL_DELAY from FSAL without losing the state?
Thanks in advance for your help!
Thanks & Regards,
Suhrud
2 years