July 2023 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Help needed on FD
by Alok Sinha 31 Jan '24

31 Jan '24

FD created at below path does not have correct link in /proc/self/fd. With vfs_readlink_by_handle , I can get a relative path but cannot get the absolute path of the FD. I need a suggestion for one of the below to get around a production bug: - How to get the full path of the FD? - How to get the parent vfs_fsal_obj_handle? - Anyway to bypass this flow by changing any config file? #0 vfs_create_handle (exp_hdl=0x55801aca22c0, hdl_desc=0x7f93889b1600, handle=0x7f93889b13f8, attrs_out=0x7f93889b1430) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/FSAL_VFS/handle.c:2020 #1 0x00007f94a1f0e13b in mdcache_locate_host (fh_desc=0x7f93889b1600, export=0x55801aca1f20, entry=0x7f93889b1578, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:1109 #2 0x00007f94a1f02455 in mdcache_create_handle (exp_hdl=0x55801aca1f20, fh_desc=0x7f93889b1600, handle=0x7f93889b15d8, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1613 #3 0x00007f94a1ec5ead in nfs4_mds_putfh (data=0x7f93201119e0) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:211 #4 0x00007f94a1ec60d3 in nfs4_op_putfh (op=0x7f93201186d0, data=0x7f93201119e0, resp=0x7f932010ab20) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:281 #5 0x00007f94a1ea96ae in process_one_op (data=0x7f93201119e0, status=0x7f93889b1b48) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:920 #6 0x00007f94a1eaa8c5 in nfs4_Compound (arg=0x7f9320138d78, req=0x7f93201385a0, res=0x7f9320106840) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:1329 #7 0x00007f94a1de8567 in nfs_rpc_process_request (reqdata=0x7f93201385a0) ---Type <return> to continue, or q <return> to quit--- at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1484 #8 0x00007f94a1de8854 in nfs_rpc_valid_NFS (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1591 #9 0x00007f94a13b6faf in svc_vc_decode (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:829 #10 0x00007f94a13b3225 in svc_request (xprt=0x7f9320000ce0, xdrs=0x7f9320066260) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:793 #11 0x00007f94a13b6ec0 in svc_vc_recv (xprt=0x7f9320000ce0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:802 #12 0x00007f94a13b31a5 in svc_rqst_xprt_task (wpe=0x7f9320000f00) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:774 #13 0x00007f94a13bcab0 in work_pool_thread (arg=0x7f9218003340) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/work_pool.c:184 #14 0x00007f94a1badea5 in start_thread () from /lib64/libpthread.so.0 #15 0x00007f94a16ce9fd in clone () from /lib64/libc.so.6 -- Alok Sinha www.spillbox.io https://youtu.be/U-YupjLQ9bU

2 2

[XS] Change in ...nfs-ganesha[next]: Fixed crash during readdir of PSEUDO folder.
by Name of user not set (GerritHub) 31 Jul '23

31 Jul '23

gauravin(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/557078?usp=email ) Change subject: Fixed crash during readdir of PSEUDO folder. ...................................................................... Fixed crash during readdir of PSEUDO folder. In mdcache_new_entry, arrts_out was modified without checking if its passed by user or it NULL which was causing crash. Change-Id: I2af1ccbefb2b19fcca21c20cbbf947d8c9f8c674 Signed-off-by: Gaurav Sharma <gauravin(a)google.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/557078/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/557078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2af1ccbefb2b19fcca21c20cbbf947d8c9f8c674 Gerrit-Change-Number: 557078 Gerrit-PatchSet: 1 Gerrit-Owner: gauravin(a)google.com Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: Fixing data integrity issue found during performance test.
by Name of user not set (GerritHub) 31 Jul '23

31 Jul '23

gauravin(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/557077?usp=email ) Change subject: Fixing data integrity issue found during performance test. ...................................................................... Fixing data integrity issue found during performance test. When two threads want to create same entry, one thread succeed in creating entry. The other thread after taking lock, finds entry but miss to reset the status and return NFS4ERR_NOENT. Change-Id: If6f14f824d10ebc17d79e4bf534b25ce4de424cb Signed-off-by: Gaurav Sharma <gauravin(a)google.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/557077/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/557077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If6f14f824d10ebc17d79e4bf534b25ce4de424cb Gerrit-Change-Number: 557077 Gerrit-PatchSet: 1 Gerrit-Owner: gauravin(a)google.com Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Add config param Cache_FDs and use it in the same way as in ibm2.5 code
by Frank Filz (GerritHub) 26 Jul '23

26 Jul '23

Attention is currently required from: Madhu Thorat. Hello Madhu Thorat, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556955?usp=email to review the following change. Change subject: Add config param Cache_FDs and use it in the same way as in ibm2.5 code ...................................................................... Add config param Cache_FDs and use it in the same way as in ibm2.5 code Similar to ibm2.5, have a config parameter Cache_FDs such that: If Cache_FDs is false then FDs will remained cached till the LRU reaper thread invokes and tries to close the FDs. If Cache_FDs is true (default) then FDs get cached and LRU reaper thread on invocation will try to close the FDs only when the currentopen >= fds_lowat (FD low watermark). Change-Id: Ica3a5e7ea1a0b81665b8d9ad701dccb7090209a8 Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> (cherry picked from commit 9bf5651b7fc74431d6b6604e804f879e5dc39be9) Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_ext.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c M src/FSAL/commonlib.c M src/config_samples/config.txt M src/doc/man/ganesha-cache-config.rst M src/include/fsal.h 7 files changed, 39 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/556955/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ica3a5e7ea1a0b81665b8d9ad701dccb7090209a8 Gerrit-Change-Number: 556955 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Reviewer: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-Attention: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Add config param to disable NLM_SHARE and NLM_UNSHARE
by Frank Filz (GerritHub) 25 Jul '23

25 Jul '23

Attention is currently required from: Malahal. Hello Malahal, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556922?usp=email to review the following change. Change subject: Add config param to disable NLM_SHARE and NLM_UNSHARE ...................................................................... Add config param to disable NLM_SHARE and NLM_UNSHARE Change-Id: I6b218bca9d6f7d941c64a457eb57e39904933a19 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NLM/nlm_Share.c M src/Protocols/NLM/nlm_Unshare.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 6 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/556922/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556922?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6b218bca9d6f7d941c64a457eb57e39904933a19 Gerrit-Change-Number: 556922 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Reviewer: Malahal <malahal(a)gmail.com> Gerrit-Attention: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0

Announce Push of V5.4 - upgrade to this!
by Frank Filz 21 Jul '23

21 Jul '23

Important: This I believe finally solves the issues with the entry cache growing unbounded. Please upgrade to this release and start intensive testing if possible. Branch next Tag:V5.4 Merge Highlights * Improve directory chunk LRU with a low water mark and fix interval bug * Remove all entries from mdcache LRU with elevated refcount * NFSv3 Create opens an fd, need to count those * FSAL_VFS: Don't attempt to get ACLs from symbolic links Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 4f8c484b4 Frank S. Filz V5.4 3a395315f Martin Schwenke FSAL_VFS: Don't attempt to get ACLs from symbolic links d59ff1476 Frank S. Filz FSALs when we do NFSv3 create and open global fd, we must LRU track it 1877b3346 Frank S. Filz MDCACHE: remove all active entries from LRU L1 and L2 c25e00b59 Frank S. Filz MDCACHE: We need to reap chunks and implement a low water mark 29fed5c1d Frank S. Filz MDCACHE: Fix run interval for chunk lru

1 0

[XS] Change in ...nfs-ganesha[next]: FSAL_VFS: Don't attempt to get ACLs from symbolic links
by Martin Schwenke (GerritHub) 21 Jul '23

21 Jul '23

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556818?usp=email ) Change subject: FSAL_VFS: Don't attempt to get ACLs from symbolic links ...................................................................... FSAL_VFS: Don't attempt to get ACLs from symbolic links acl_get_fd() returns NULL, failing with EBADF, if given a file descriptor for a symlink opened with O_NOFOLLOW. Add an early return with success. This turns the function into a no-op for symlinks, so should guarantee now resource leakage. The GlusterFS FSAL handles this slightly differently. It attempts to get the ACLs and converts failure to success on certain errors. However, here in the VFS FSAL, the errno for a failure of this type might vary between filesystems - various manpages provide little guidance - so avoiding the lookup is probably sane. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I69945978f25522b26e312f3577e7a13e50a497f1 --- M src/FSAL/FSAL_VFS/vfs/attrs.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/556818/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556818?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I69945978f25522b26e312f3577e7a13e50a497f1 Gerrit-Change-Number: 556818 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: Ease the lock contention by not rw locking entire tree
by Rojin George (GerritHub) 20 Jul '23

20 Jul '23

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556799?usp=email ) Change subject: Ease the lock contention by not rw locking entire tree ...................................................................... Ease the lock contention by not rw locking entire tree Huge directories, for validation when multiple parallel clients perform operations like md5sum, lsattr etc, we could see lock contention between ReadDir and Lookup operations on the content_lock, especially when backend is slow. As part of this CR, easing the lock contention by not RW locking entire tree. RW lock would be taken back once the chunk is to be updated in the callback post subcall. Change-Id: I800d903152111ba271b09021be9e8b5acc873c04 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/556799/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I800d903152111ba271b09021be9e8b5acc873c04 Gerrit-Change-Number: 556799 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: FSALs when we do NFSv3 create and open global fd, we must LRU track it
by Frank Filz (GerritHub) 18 Jul '23

18 Jul '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556710?usp=email ) Change subject: FSALs when we do NFSv3 create and open global fd, we must LRU track it ...................................................................... FSALs when we do NFSv3 create and open global fd, we must LRU track it Change-Id: Ifdb4656086da7071e4a299e0e0684edcabf6433d Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/commonlib.c M src/MainNFSD/libganesha_nfsd.ver M src/include/FSAL/fsal_commonlib.h 8 files changed, 32 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/556710/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifdb4656086da7071e4a299e0e0684edcabf6433d Gerrit-Change-Number: 556710 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0