December 2023 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Help needed on FD
by Alok Sinha 31 Jan '24

31 Jan '24

FD created at below path does not have correct link in /proc/self/fd. With vfs_readlink_by_handle , I can get a relative path but cannot get the absolute path of the FD. I need a suggestion for one of the below to get around a production bug: - How to get the full path of the FD? - How to get the parent vfs_fsal_obj_handle? - Anyway to bypass this flow by changing any config file? #0 vfs_create_handle (exp_hdl=0x55801aca22c0, hdl_desc=0x7f93889b1600, handle=0x7f93889b13f8, attrs_out=0x7f93889b1430) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/FSAL_VFS/handle.c:2020 #1 0x00007f94a1f0e13b in mdcache_locate_host (fh_desc=0x7f93889b1600, export=0x55801aca1f20, entry=0x7f93889b1578, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:1109 #2 0x00007f94a1f02455 in mdcache_create_handle (exp_hdl=0x55801aca1f20, fh_desc=0x7f93889b1600, handle=0x7f93889b15d8, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1613 #3 0x00007f94a1ec5ead in nfs4_mds_putfh (data=0x7f93201119e0) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:211 #4 0x00007f94a1ec60d3 in nfs4_op_putfh (op=0x7f93201186d0, data=0x7f93201119e0, resp=0x7f932010ab20) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:281 #5 0x00007f94a1ea96ae in process_one_op (data=0x7f93201119e0, status=0x7f93889b1b48) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:920 #6 0x00007f94a1eaa8c5 in nfs4_Compound (arg=0x7f9320138d78, req=0x7f93201385a0, res=0x7f9320106840) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:1329 #7 0x00007f94a1de8567 in nfs_rpc_process_request (reqdata=0x7f93201385a0) ---Type <return> to continue, or q <return> to quit--- at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1484 #8 0x00007f94a1de8854 in nfs_rpc_valid_NFS (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1591 #9 0x00007f94a13b6faf in svc_vc_decode (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:829 #10 0x00007f94a13b3225 in svc_request (xprt=0x7f9320000ce0, xdrs=0x7f9320066260) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:793 #11 0x00007f94a13b6ec0 in svc_vc_recv (xprt=0x7f9320000ce0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:802 #12 0x00007f94a13b31a5 in svc_rqst_xprt_task (wpe=0x7f9320000f00) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:774 #13 0x00007f94a13bcab0 in work_pool_thread (arg=0x7f9218003340) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/work_pool.c:184 #14 0x00007f94a1badea5 in start_thread () from /lib64/libpthread.so.0 #15 0x00007f94a16ce9fd in clone () from /lib64/libc.so.6 -- Alok Sinha www.spillbox.io https://youtu.be/U-YupjLQ9bU

2 2

[M] Change in ...nfs-ganesha[next]: Update state counters to show client dbus
by Rojin George (GerritHub) 26 Dec '23

26 Dec '23

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174062?usp=email ) Change subject: Update state counters to show client dbus ...................................................................... Update state counters to show client dbus This CR adds counters in gsh_clients, upon state_(add/del) and then show them in show_clients dbus Change-Id: Ibabbb6a906ef665c2e0e3a099c14e235ca7c5117 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/SAL/nfs4_state.c M src/SAL/nfs4_state_id.c M src/include/client_mgr.h M src/include/sal_shared.h M src/include/server_stats_private.h M src/support/client_mgr.c 6 files changed, 91 insertions(+), 35 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/62/1174062/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1174062?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibabbb6a906ef665c2e0e3a099c14e235ca7c5117 Gerrit-Change-Number: 1174062 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

Announce Push of V6-dev.2
by Frank Filz 21 Dec '23

21 Dec '23

Branch next Tag:V6-dev.2 Merge Highlights New Features * Courteous Server support in Ganesha Minor Changes and Bug Fixes * LOG: Fix buffer overflow issue * FSAL: in open2 methods, update_share_counters_locked must use *new_obj * FSAL: Fix up how reaper_work is used * Ignore clangd cache directory * Fix monitoring build option * Allow specifying python version * LOG : Parse correct name for COMPONENT_MDCACHE_LRU * Fix compiler warnings for "-Werror" flag * NFSv4 READDIR should pass down the attrs from the request. * Move the log levels and components to a separate headfer file. Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 83712d6dd Frank S. Filz V6-dev.2 1f775b499 Rojin George Courteous Server support in Ganesha 733b7ce8a David Rieber Move the log levels and components to a separate headfer file. dc63fefb4 David Rieber NFSv4 READDIR should pass down the attrs from the request. 4925bb643 Sachin Punadikar Fix compiler warnings for "-Werror" flag 2dfb1df33 Sachin Punadikar LOG : Parse correct name for COMPONENT_MDCACHE_LRU b13fe8943 Daniel Gryniewicz Allow specifying python version 169144a85 Daniel Gryniewicz Fix monitoring build option 46459ec5a Daniel Gryniewicz Ignore clangd cache directory 583a98c5b Frank S. Filz FSAL: Fix up how reaper_work is used d27ed2707 Frank S. Filz FSAL: in open2 methods, update_share_counters_locked must use *new_obj 4595c50cd Frank S. Filz LOG: Fix buffer overflow issue

1 0

[S] Change in ...nfs-ganesha[next]: FSAL: Fix up how reaper_work is used
by Frank Filz (GerritHub) 19 Dec '23

19 Dec '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173851?usp=email ) Change subject: FSAL: Fix up how reaper_work is used ...................................................................... FSAL: Fix up how reaper_work is used While mdcache uses multiple lanes of LRU to track entries and handle reaping of them, and it used to do the global fd management, now that FSAL/commonlib.c does the fd_lru, it is a single lru queue, so it will not do per lane calculations. So the old calculation that calculated a per lane work, is now just reaper_work and that has to be properly set and used. Change-Id: Ife6ce9822edfdecb34d2cfb4b5a264bae95ad4ff Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/commonlib.c M src/include/fsal_types.h 2 files changed, 4 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1173851/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173851?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ife6ce9822edfdecb34d2cfb4b5a264bae95ad4ff Gerrit-Change-Number: 1173851 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: FSAL: in open2 methods, update_share_counters_locked must use *new_obj
by Frank Filz (GerritHub) 18 Dec '23

18 Dec '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173817?usp=email ) Change subject: FSAL: in open2 methods, update_share_counters_locked must use *new_obj ...................................................................... FSAL: in open2 methods, update_share_counters_locked must use *new_obj Otherwise the share counters of the parent directory are being modified. Change-Id: Ie8d4ec997700ddbad6a8cad1586bc066437e7cae Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_VFS/file.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/1173817/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173817?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie8d4ec997700ddbad6a8cad1586bc066437e7cae Gerrit-Change-Number: 1173817 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[S] Change in ...nfs-ganesha[next]: LOG: Fix buffer overflow issue
by Frank Filz (GerritHub) 18 Dec '23

18 Dec '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173816?usp=email ) Change subject: LOG: Fix buffer overflow issue ...................................................................... LOG: Fix buffer overflow issue Change-Id: I38b5bb7dbd41bb5ab4f1e74896ed634e3717f908 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/log/log_functions.c 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/1173816/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173816?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I38b5bb7dbd41bb5ab4f1e74896ed634e3717f908 Gerrit-Change-Number: 1173816 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

1 0

[XS] Change in ...nfs-ganesha[next]: LOG : Parse correct name for COMPONENT_MDCACHE_LRU
by Sachin Punadikar (GerritHub) 15 Dec '23

15 Dec '23

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173683?usp=email ) Change subject: LOG : Parse correct name for COMPONENT_MDCACHE_LRU ...................................................................... LOG : Parse correct name for COMPONENT_MDCACHE_LRU For COMPONENT_MDCACHE_LRU, while parsing, the component name should be MDCACHE_LRU and not MDCACHE. Corrected the name. Change-Id: Ib2cead895e7503399c93eb319e2930e21b3aef24 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/log/log_functions.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/1173683/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173683?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib2cead895e7503399c93eb319e2930e21b3aef24 Gerrit-Change-Number: 1173683 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[M] Change in ...nfs-ganesha[next]: nfs41_session: Replace connections array by a linked-list
by Dipit Grover (GerritHub) 14 Dec '23

14 Dec '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173663?usp=email ) Change subject: nfs41_session: Replace connections array by a linked-list ...................................................................... nfs41_session: Replace connections array by a linked-list In nfs41_Session, the connections array has an upper cap of 16 entries. This can be a problem in scenarios where a client is mounted with nconnect as 16, and undergoes a situation (VM migration, client IP tables update, etc) which leads to disconnection of the existing connections from client's end. Now if the client connects using a fresh set of connections, the server will not add these new connections to the client's existing session, until the server discovers that the older connections are terminated. Since there are certain NFS ops (eg: DESTROY_SESSION in current Ganesha's implementation) that rely on the request being received on the session's connection, those ops will fail under this scenario. Change-Id: I41a9bdbf6db952ca8b36fa2c9f157709ae76ba79 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/Protocols/NFS/nfs4_op_create_session.c M src/SAL/nfs41_session_id.c M src/include/sal_data.h 3 files changed, 54 insertions(+), 38 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1173663/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I41a9bdbf6db952ca8b36fa2c9f157709ae76ba79 Gerrit-Change-Number: 1173663 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: nfs41_session: Update nfs41_Session_Del function to accept session
by Dipit Grover (GerritHub) 14 Dec '23

14 Dec '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173662?usp=email ) Change subject: nfs41_session: Update nfs41_Session_Del function to accept session ...................................................................... nfs41_session: Update nfs41_Session_Del function to accept session Change-Id: Id317463cc537fb58cb2cf26da0802ffccc0b8d62 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/Protocols/NFS/nfs4_op_create_session.c M src/Protocols/NFS/nfs4_op_destroy_session.c M src/SAL/nfs41_session_id.c M src/SAL/nfs4_clientid.c M src/include/sal_functions.h 5 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/62/1173662/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173662?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id317463cc537fb58cb2cf26da0802ffccc0b8d62 Gerrit-Change-Number: 1173662 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0