Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204595?usp=email to review the following change. Change subject: nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry ...................................................................... nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry There were some flows that set it on failure and some that didn't. Better to always check on failure flow and set it. Change-Id: Ifcc9b97490a788a81e5b15dfeebd6040c8e5e776 Signed-off-by: Lior Suliman <liorsu(a)gmail.com&gt; --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1204595/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204595?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifcc9b97490a788a81e5b15dfeebd6040c8e5e776 Gerrit-Change-Number: 1204595 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com&gt; Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com&gt; Gerrit-CC: shaharhoch(a)google.com Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com&gt;