Solomon Boulos has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/502437 )
Change subject: Fix two clang build errors.
......................................................................
Fix two clang build errors.
clang's static analysis found two "bugs".
The first was an unsigned number (delegation count) was
being checked for being negative (the test should have been == 0).
The second was a gsh_refstr check that the byte array "pointer" was
non NULL. Since the byte array is inline though, the pointer is
always non-NULL (dereferencing the gsh_refstr itself, above, may crash
first).
Change-Id: Ie18344a965074f6b696ed95a652984c939c4a659
Signed-off-by: Solomon Boulos <boulos(a)google.com>
---
M src/Protocols/NFS/nfs4_pseudo.c
M src/SAL/state_deleg.c
2 files changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/502437/1
--
To view, visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/502437
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie18344a965074f6b696ed95a652984c939c4a659
Gerrit-Change-Number: 502437
Gerrit-PatchSet: 1
Gerrit-Owner: Solomon Boulos <boulos(a)google.com>
Gerrit-MessageType: newchange