December 2018 - Devel - NFS Ganesha List Archives

Change in ffilz/nfs-ganesha[next]: Read/Write - Don't leak owners / states if read/write isn't done
by Daniel Gryniewicz (GerritHub) 13 Dec '18

13 Dec '18

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/437140 Change subject: Read/Write - Don't leak owners / states if read/write isn't done ...................................................................... Read/Write - Don't leak owners / states if read/write isn't done Change-Id: I881e8e1f4dd371f0349070008caa8d898dea2bad Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/Protocols/NFS/nfs4_op_read.c M src/Protocols/NFS/nfs4_op_write.c 2 files changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/437140/1 -- To view, visit https://review.gerrithub.io/437140 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I881e8e1f4dd371f0349070008caa8d898dea2bad Gerrit-Change-Number: 437140 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>

1 0

Change in ffilz/nfs-ganesha[next]: SAL: Allow READs under write delegation
by Soumya (GerritHub) 11 Dec '18

11 Dec '18

Soumya has uploaded this change for review. ( https://review.gerrithub.io/436785 Change subject: SAL: Allow READs under write delegation ...................................................................... SAL: Allow READs under write delegation If the client opens a file with OPEN4_SHARE_ACCESS_BOTH and been granted write delegation, we should allow it to perform READ operations. Change-Id: I9160e680f63b583729a8334b25988182a4783cc4 Signed-off-by: Soumya Koduri <skoduri(a)redhat.com> --- M src/Protocols/NFS/nfs4_op_open.c M src/Protocols/NFS/nfs4_op_read.c M src/include/sal_data.h 3 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/436785/1 -- To view, visit https://review.gerrithub.io/436785 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I9160e680f63b583729a8334b25988182a4783cc4 Gerrit-Change-Number: 436785 Gerrit-PatchSet: 1 Gerrit-Owner: Soumya <skoduri(a)redhat.com>

1 0

Re: Change in ffilz/nfs-ganesha[next]: Remove unused posix mount details when adding export if duplicate is ...
by Sriram Patil 10 Dec '18

10 Dec '18

Compiler error in FSAL_CLUSTER. /root/rpmbuild/BUILD/nfs-ganesha-2.8-dev.8/FSAL/FSAL_GLUSTER/fsal_up.c: In function 'up_process_event_object': /root/rpmbuild/BUILD/nfs-ganesha-2.8-dev.8/FSAL/FSAL_GLUSTER/fsal_up.c:94:7: error: 'GLFS_EVENT_INODE_INVALIDATE' undeclared (first use in this function) case GLFS_EVENT_INODE_INVALIDATE: ^ /root/rpmbuild/BUILD/nfs-ganesha-2.8-dev.8/FSAL/FSAL_GLUSTER/fsal_up.c:94:7: note: each undeclared identifier is reported only once for each function it appears in - Sriram From: "Gluster Community Jenkins (GerritHub)" <gerrit(a)gerrithub.io> Reply-To: "gerrithub(a)gluster.org" <gerrithub(a)gluster.org>, Sriram Patil <sriramp(a)vmware.com> Date: Monday, December 10, 2018 at 10:09 PM To: Sriram Patil <sriramp(a)vmware.com> Subject: Change in ffilz/nfs-ganesha[next]: Remove unused posix mount details when adding export if duplicate is ... https://ci.centos.org/job/nfs-ganesha_trigger-fsal_gluster/5841//console : FAILED Patch set 1:Verified -1 View Change<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.ger…> To view, visit change 436739<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.ger…>. To unsubscribe, or for help writing mail filters, visit settings<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.ger…>. Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: comment Gerrit-Change-Id: I97d63f5bc21e29bc3ff7f73bf78a7208a3a41f6e Gerrit-Change-Number: 436739 Gerrit-PatchSet: 1 Gerrit-Owner: Sriram Patil <sriramp(a)vmware.com> Gerrit-Reviewer: Gandi Buildbot <ganesha(a)gandi.net> Gerrit-Reviewer: Gluster Community Jenkins <gerrithub(a)gluster.org> Gerrit-Comment-Date: Mon, 10 Dec 2018 16:39:18 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Re: Change in ffilz/nfs-ganesha[next]: Remove unused posix mount details when adding export if duplicate is ...
by Sriram Patil 10 Dec '18

10 Dec '18

Failing because it cannot find rcu library. /root/nfs-ganesha/src/libntirpc/ntirpc/ CMake Error at CMakeLists.txt:1062 (message): userspace-rcu library not found! - Sriram From: "Gluster Community Jenkins (GerritHub)" <gerrit(a)gerrithub.io> Reply-To: "gerrithub(a)gluster.org" <gerrithub(a)gluster.org>, Sriram Patil <sriramp(a)vmware.com> Date: Monday, December 10, 2018 at 10:10 PM To: Sriram Patil <sriramp(a)vmware.com> Subject: Change in ffilz/nfs-ganesha[next]: Remove unused posix mount details when adding export if duplicate is ... https://ci.centos.org//job/nfs_ganesha_cthon04/3739/console : FAILED View Change<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.ger…> To view, visit change 436739<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.ger…>. To unsubscribe, or for help writing mail filters, visit settings<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freview.ger…>. Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: comment Gerrit-Change-Id: I97d63f5bc21e29bc3ff7f73bf78a7208a3a41f6e Gerrit-Change-Number: 436739 Gerrit-PatchSet: 1 Gerrit-Owner: Sriram Patil <sriramp(a)vmware.com> Gerrit-Reviewer: Gandi Buildbot <ganesha(a)gandi.net> Gerrit-Reviewer: Gluster Community Jenkins <gerrithub(a)gluster.org> Gerrit-Comment-Date: Mon, 10 Dec 2018 16:40:21 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in ffilz/nfs-ganesha[next]: Remove unused posix mount details when adding export if duplicate is ...
by Sriram Patil (GerritHub) 10 Dec '18

10 Dec '18

Sriram Patil has uploaded this change for review. ( https://review.gerrithub.io/436739 Change subject: Remove unused posix mount details when adding export if duplicate is found ...................................................................... Remove unused posix mount details when adding export if duplicate is found Ganesha maintains a list of mount points on the host to map the exports to a particular mount point. If the mount point is removed and remounted, the device id (st_dev) is supposed to change. A side effect of this mechanism is that, if a mount is removed (unmounted) from the system, ganesha still holds onto its details. If at a later point another mount is added which gets the same device id (stat.st_dev) as the old mount, ganesha detects the new mount as a duplicate file system. This change makes sure that, if the device id is reused and ganesha has old mount details in memory, we remove the old mount details if it is no longer mounted and exported by ganesha. If the device is reused, the old mount is definitely unmounted, so we just have to check that it is not being exported by ganesha to safely remove it. Change-Id: I97d63f5bc21e29bc3ff7f73bf78a7208a3a41f6e Signed-off-by: Sriram Patil <sriramp(a)vmware.com> --- M src/FSAL/FSAL_VFS/export.c M src/FSAL/commonlib.c 2 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/436739/1 -- To view, visit https://review.gerrithub.io/436739 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I97d63f5bc21e29bc3ff7f73bf78a7208a3a41f6e Gerrit-Change-Number: 436739 Gerrit-PatchSet: 1 Gerrit-Owner: Sriram Patil <sriramp(a)vmware.com>

1 0

Change in ffilz/nfs-ganesha[next]: Added a script to convert knfs exports to ganesha.
by Malahal (GerritHub) 08 Dec '18

08 Dec '18

Malahal has uploaded this change for review. ( https://review.gerrithub.io/436565 Change subject: Added a script to convert knfs exports to ganesha. ...................................................................... Added a script to convert knfs exports to ganesha. Added knfs2ganesha-exports.py script Convert given Linux kernel NFS server exports into Ganesha exports. Typical usage: cat /etc/exports | knfs2ganesha-exports.py > /etc/ganesha/ganesha.conf NOTE: default options with DASH/HYPHEN are not implemented yet! Change-Id: I89d06c70ca3ffd3ba349b77f8e691ee88ac3ee01 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- A src/scripts/ganeshactl/knfs2ganesha-exports.py 1 file changed, 159 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/436565/1 -- To view, visit https://review.gerrithub.io/436565 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I89d06c70ca3ffd3ba349b77f8e691ee88ac3ee01 Gerrit-Change-Number: 436565 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com>

1 0

Announce Push of V2.8-dev.8
by Frank Filz 07 Dec '18

07 Dec '18

Branch next Tag:V2.8-dev.8 NOTE: This merge includes an ntirpc pullup, please update your submodule. Release Highlights * Fixed dereferencing null ctx_export on nfs_read * Fix admin tools to read DisplayExport output * NLM share reservation access check with owner_skip * Handle NLM share FREE_ALL for windows clients * FSAL_UP: add missing locks in async delegation recall * Add checks for client access in NFS user access checks. * FSAL_VFS, FreeBSD: upstream support for d_off * [GPFS] Implement ignore_mode_change config option * Force urcu-bp for now (includes an ntirpc pullup) Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 0dc03f8 Frank S. Filz V2.8-dev.8 66c8153 Jeff Layton Force urcu-bp for now d5c1d3d Malahal Naineni [GPFS] Implement ignore_mode_change config option 074ec86 Jack Halford FSAL_VFS, FreeBSD: upstream support for d_off 14f1eba Gaurav B. Gangalwar Add checks for client access in NFS user access checks. c14363f Fatih Acar FSAL_UP: add missing locks in async delegation recall f83ab05 Suhrud Patankar Handle NLM share FREE_ALL for windows clients 5ca8314 Suhrud Patankar NLM share reservation access check with owner_skip c9311bf Sriram Patil Fix admin tools to read DisplayExport output 3bbd38f Sergey Lysanov Fixed dereferencing null ctx_export on nfs_read

1 0

Change in ffilz/nfs-ganesha[next]: Force urcu-bp for now
by Jeff Layton (GerritHub) 07 Dec '18

07 Dec '18

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/436505 Change subject: Force urcu-bp for now ...................................................................... Force urcu-bp for now When _LGPL_SOURCE is defined the lttng headers will inline some of the RCU functions with the "bulletproof" functions. This means that we can't currently select a urcu flavor at runtime that will be used universally. I'm a little unclear on what happens if you mix different flavored urcu calls, but I doubt that it's anything good. Let's switch back to using urcu-bp universally for now until this has a better solution. It's not ideal for performance, but our use of URCU is pretty minimal for now, and it's better to be safe than fast. Change-Id: I84a62ab70ec9aaf57f6265b0f61fe2134a8c364e Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/CMakeLists.txt M src/FSAL/FSAL_GLUSTER/fsal_up.c M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/FSAL_PROXY/handle.c M src/MainNFSD/9p_dispatcher.c M src/MainNFSD/9p_rdma_dispatcher.c M src/MainNFSD/nfs_admin_thread.c M src/MainNFSD/nfs_init.c M src/SAL/recovery/recovery_rados_cluster.c M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c M src/dbus/dbus_server.c M src/support/delayed_exec.c M src/support/fridgethr.c 14 files changed, 14 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/436505/1 -- To view, visit https://review.gerrithub.io/436505 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I84a62ab70ec9aaf57f6265b0f61fe2134a8c364e Gerrit-Change-Number: 436505 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>

1 0

Access check issue for RO client.
by gaurav gangalwar 07 Dec '18

07 Dec '18

Hi, For client with ReadOnly access and user with ReadWrite access, Ganesha returns READ/MODIFY/APPEND allowed on ACCESS call. Linux kernel NFS returns just READ allowed for same. I think we need to fix Ganesha’s behaviour, we should return access rights based on client access check also. Please check the patch attached to fix the behaviour. Regards, Gaurav

2 3

Change in ffilz/nfs-ganesha[next]: WIP: [GPFS] Implement ignore_mode_change config option
by Malahal (GerritHub) 06 Dec '18

06 Dec '18

Malahal has uploaded this change for review. ( https://review.gerrithub.io/436434 Change subject: WIP: [GPFS] Implement ignore_mode_change config option ...................................................................... WIP: [GPFS] Implement ignore_mode_change config option File system options exist to deny any mode change, and only ACLs are used in such configurations. Any attempt to do mode change will fail leading to application failures as well as NFS client's exclusive file creation failure. Ignore mode change and return success based on an export config setting. This option is specific to GPFS FSAL exports. The default is false and the following ganesha config would enable ignore_mode_change option on GPFS FSAL export "/gpfs/gpfsA/fileset": EXPORT { export_id = 23; path = /gpfs/gpfsA/fileset; FSAL { name = GPFS; ignore_mode_change = true; } CLIENT { clients = *; access_type = RW; } } Change-Id: Id4b00ab051ce1e89db6b4e2caa72ee3434866586 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/fsal_attrs.c M src/FSAL/FSAL_GPFS/gpfs_methods.h 3 files changed, 37 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/436434/1 -- To view, visit https://review.gerrithub.io/436434 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: Id4b00ab051ce1e89db6b4e2caa72ee3434866586 Gerrit-Change-Number: 436434 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com>

1 0