Fwd: Ganesha 2.5, crash /segfault while executing nlm4_Unlock
by Sachin Punadikar
---------- Forwarded message ----------
From: Sachin Punadikar <punadikar.sachin(a)gmail.com>
Date: Tue, Jun 26, 2018 at 3:57 PM
Subject: Ganesha 2.5, crash /segfault while executing nlm4_Unlock
To: nfs-ganesha-devel <nfs-ganesha-devel(a)lists.sourceforge.net>
Hi All,
Recently a crash was reported by customer for Ganesha 2.5.
(gdb) where
#0 0x00007f475872900b in pthread_rwlock_wrlock () from
/lib64/libpthread.so.0
#1 0x000000000041eac9 in fsal_obj_handle_fini (obj=0x7f4378028028) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL/commonlib.c:192
#2 0x000000000053180f in mdcache_lru_clean (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:589
#3 0x0000000000536587 in _mdcache_lru_unref (entry=0x7f4378027ff0,
flags=0, func=0x5a9380 <__func__.23209> "cih_remove_checked", line=406)
at /usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:1921
#4 0x0000000000543e91 in cih_remove_checked (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h:406
#5 0x0000000000544b26 in mdc_clean_entry (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:235
#6 0x000000000053181e in mdcache_lru_clean (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:592
#7 0x0000000000536587 in _mdcache_lru_unref (entry=0x7f4378027ff0,
flags=0, func=0x5a70af <__func__.23112> "mdcache_put", line=190)
at /usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:1921
#8 0x0000000000539666 in mdcache_put (entry=0x7f4378027ff0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h:190
#9 0x000000000053f062 in mdcache_put_ref (obj_hdl=0x7f4378028028) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/FSAL
/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1709
#10 0x000000000049bf0f in nlm4_Unlock (args=0x7f4294165830,
req=0x7f4294165028, res=0x7f43f001e0e0)
at /usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/Prot
ocols/NLM/nlm_Unlock.c:128
#11 0x000000000044c719 in nfs_rpc_execute (reqdata=0x7f4294165000) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/Main
NFSD/nfs_worker_thread.c:1290
#12 0x000000000044cf23 in worker_run (ctx=0x3c200e0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/Main
NFSD/nfs_worker_thread.c:1562
#13 0x000000000050a3e7 in fridgethr_start_routine (arg=0x3c200e0) at
/usr/src/debug/nfs-ganesha-2.5.3-ibm013.00-0.1.1-Source/supp
ort/fridgethr.c:550
#14 0x00007f4758725dc5 in start_thread () from /lib64/libpthread.so.0
#15 0x00007f4757de673d in clone () from /lib64/libc.so.6
A closer look at the backtrace indicates that there was cyclic flow of
execution as below:
nlm4_Unlock -> mdcache_put_ref -> mdcache_put -> _mdcache_lru_unref ->
mdcache_lru_clean -> fsal_obj_handle_fini and then mdc_clean_entry ->
cih_remove_checked -> (purposely coping next flow on below line)
-> _mdcache_lru_unref -> mdcache_lru_clean -> fsal_obj_handle_fini
(currently crashing here)
Do we see any code issue here ? Any hints on how to RCA this issue ?
Thanks in advance.
--
with regards,
Sachin Punadikar
--
with regards,
Sachin Punadikar
6 years, 3 months
Change in ffilz/nfs-ganesha[next]: ganesha-rados-grace: add a new --ns option
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420913
Change subject: ganesha-rados-grace: add a new --ns option
......................................................................
ganesha-rados-grace: add a new --ns option
Add a new --ns option so that we can set the namespace for the grace
oid properly.
Change-Id: I699d9f29b4e28aa240d07a410448cd7aa737b6ef
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/doc/man/ganesha-rados-grace.rst
M src/tools/ganesha-rados-grace.c
2 files changed, 20 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/420913/1
--
To view, visit https://review.gerrithub.io/420913
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I699d9f29b4e28aa240d07a410448cd7aa737b6ef
Gerrit-Change-Number: 420913
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 4 months
Change in ffilz/nfs-ganesha[next]: ganesha-rados-grace: rename --name option to --oid
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420912
Change subject: ganesha-rados-grace: rename --name option to --oid
......................................................................
ganesha-rados-grace: rename --name option to --oid
In a later patch, we're going to be adding a --ns option to allow
the tool to manipulate the object in a particular ns. Rename the
--name option to --oid to make this less confusing.
While we're in there too, change all instances of "hostname" in the
manpage to "nodeid" since that's more correct.
Change-Id: I1fcb52fe0ae7d16f0b40ef917782bef7c24eac3f
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/doc/man/ganesha-rados-grace.rst
M src/tools/ganesha-rados-grace.c
2 files changed, 22 insertions(+), 22 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/420912/1
--
To view, visit https://review.gerrithub.io/420912
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1fcb52fe0ae7d16f0b40ef917782bef7c24eac3f
Gerrit-Change-Number: 420912
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 4 months
Change in ffilz/nfs-ganesha[next]: SAL: add a namespace parameter to RADOS_KV block
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/420911
Change subject: SAL: add a namespace parameter to RADOS_KV block
......................................................................
SAL: add a namespace parameter to RADOS_KV block
It's desirable to be able to further segment a pool into multiple
namespaces and allow ganesha to set its objects within its own ns.
Add an option for that to the RADOS_KV block.
Change-Id: I759f9f248599fceb4755791dd428f0b0e34b4d9f
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/SAL/recovery/recovery_rados.h
M src/SAL/recovery/recovery_rados_cluster.c
M src/SAL/recovery/recovery_rados_kv.c
M src/SAL/recovery/recovery_rados_ng.c
4 files changed, 14 insertions(+), 5 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/420911/1
--
To view, visit https://review.gerrithub.io/420911
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I759f9f248599fceb4755791dd428f0b0e34b4d9f
Gerrit-Change-Number: 420911
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 4 months
Newbie question / help with installation
by Imam Toufique
Hi ,
I am very new to NFS Ganesha, trying to understand how this whole setup works. So, I need setup an NFS server in CentOS 7.5 with a ZFS pool. As I read the documentation, it looks like ZFS FSal have been discontinued from NFS Ganesha source code , it is available via libzfswrap. Documentation suggests that source should be in the contrib directory, but there is no contrib directory when I clone the latest 2.6 repo.
Can you please help understand where do I go about getting libzfswrap? Also, are there rpm packages for CentOS 7 for the latest 2.6 release? If there is a step by step guide on setting up an NFS server using ZFS , that would also be very helpful.
Thanks
6 years, 4 months
Announce Push of V2.7-dev.22
by Frank Filz
Branch next
Tag:V2.7-dev.22
Release Highlights
* Enable readdirplus option for GLUSTER and CEPH
* MDCACHE - Handle ESTALE for all attribute refreshes
* Add fallocate FSAL op and use it for CEPH and GPFS
* exports: add new prepare_unexport operation
* SAL: add a new is_member operation to recovery ops
* FSAL_CEPH: abort the connection before shutdown if server will be
restarting
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
c2bd01f Frank S. Filz V2.7-dev.22
8559102 Jeff Layton FSAL_CEPH: abort the connection before shutdown if
server will be restarting
9fad1ff Jeff Layton SAL: add a new is_member operation to recovery ops
470eade Jeff Layton exports: add new prepare_unexport operation
1586e54 Jeff Layton GPFS: wire up GPFS to new fallocate operation
f2e8b59 Jeff Layton FSAL_CEPH: add an fallocate operation
2751f03 Jeff Layton NFS: rework nfs4_op_allocate/deallocate to dispatch
through fallocate op
5129bfd Jeff Layton FSAL: add a new fallocate fsal operation
3d82f66 Jeff Layton NFS: disallow layout stateids for WRITE op
52b2593 Jeff Layton FSAL_CEPH: enable the readdir_plus boolean
d8f011f Jeff Layton NFS: nfs4_write should be checking BLOCKS for quota
0366d7c Daniel Gryniewicz GLUSTER - Enable new readdir_plus if backend
support exists
9c5c419 Daniel Gryniewicz MDCACHE - Handle ESTALE for all attribute
refreshes
0494e71 Daniel Gryniewicz FSAL_MEM - Fix log level for readdir
8df0b47 Daniel Gryniewicz gtest - convert readdir_correctness to obj_ops
pointer
6 years, 4 months
Change in ffilz/nfs-ganesha[next]: FSAL_MEM - Don't try to merge a handle with itself
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420777
Change subject: FSAL_MEM - Don't try to merge a handle with itself
......................................................................
FSAL_MEM - Don't try to merge a handle with itself
Change-Id: I4efcab726c7d7c1651252febf0da212a63bd204e
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/420777/1
--
To view, visit https://review.gerrithub.io/420777
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4efcab726c7d7c1651252febf0da212a63bd204e
Gerrit-Change-Number: 420777
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 4 months
Change in ffilz/nfs-ganesha[next]: Disallow client to create dirents with an empty name
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/420770
Change subject: Disallow client to create dirents with an empty name
......................................................................
Disallow client to create dirents with an empty name
NFSv4 spec forbids this, and Linux doesn't support it on local
filesystems, and it's caused problems with Gluster (which returns the
parent directory for an empty dirent name), so just protect against it.
Also, NFSv4 spec requires the error to be NFS4ERR_INVAL, not
NFS4ERR_BADNAME, so fix that as well.
Change-Id: Iebcc589ad3f131fd2a4ea500110550741eeb6d07
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/FSAL/fsal_helper.c
2 files changed, 10 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/420770/1
--
To view, visit https://review.gerrithub.io/420770
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iebcc589ad3f131fd2a4ea500110550741eeb6d07
Gerrit-Change-Number: 420770
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 4 months
Change in ffilz/nfs-ganesha[next]: Event log for statistics activity
by GerritHub
From Sachin Punadikar <psachin(a)in.ibm.com>:
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/420760
Change subject: Event log for statistics activity
......................................................................
Event log for statistics activity
Using "ganesha_stats" one can enable and disable statistics counting
for the NFS server and for the FSAL. This activity should be logged
as an event in the Ganesha log file.
Change-Id: I569554b87426bd1d5ecc0fb2583d983b0005b36c
Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com>
---
M src/support/export_mgr.c
1 file changed, 24 insertions(+), 4 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/420760/1
--
To view, visit https://review.gerrithub.io/420760
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I569554b87426bd1d5ecc0fb2583d983b0005b36c
Gerrit-Change-Number: 420760
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com>
6 years, 4 months
Change in ffilz/nfs-ganesha[next]: Display GPFS FSAL response time in milliseconds
by GerritHub
From Sachin Punadikar <psachin(a)in.ibm.com>:
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/420759
Change subject: Display GPFS FSAL response time in milliseconds
......................................................................
Display GPFS FSAL response time in milliseconds
"ganesha_stats" displays GPFS FSAL response time in microseconds.
Make it more readable by converting into milliseconds.
Change-Id: Ie30577cefafa66216a96c059623742e1fab91099
Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com>
---
M src/FSAL/FSAL_GPFS/fsal_stats_gpfs.c
M src/include/server_stats_private.h
M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py
3 files changed, 17 insertions(+), 16 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/420759/1
--
To view, visit https://review.gerrithub.io/420759
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie30577cefafa66216a96c059623742e1fab91099
Gerrit-Change-Number: 420759
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com>
6 years, 4 months
