Change in ...nfs-ganesha[next]: MDCACHE make cih_hash_key and cih_set_latched void
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/463352 )
Change subject: MDCACHE make cih_hash_key and cih_set_latched void
......................................................................
MDCACHE make cih_hash_key and cih_set_latched void
Also fix documentation.
Change-Id: I2f4d28626119a27bb67620d08fc3acf28baca30f
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c
3 files changed, 17 insertions(+), 45 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/463352/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/463352
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2f4d28626119a27bb67620d08fc3acf28baca30f
Gerrit-Change-Number: 463352
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
4 years, 9 months
V2.7.6 with mmleak.so - potential memory leak?
by Rungta, Vandana
Daniel,
I notice a gradual creep up in memory used by ganesha when I set up long running load tests. So, I started my tests with mmleak.so preloaded (https://github.com/malahal/mmleak).
( malahal – Compliments on mmleak. Very nice memory debugging tool).
After about 15 hours of tests I shrank/processed the information dumped by mmleak.
The following is the current counts of the addresses where memory is allocated – without a corresponding free. The first one is reasonable because I have Entries_HWMark = 500000.
All locations from Nfs-ganesha V2.7.6
Count Location. Allocation line
500,000 0x52aad0. /src/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c:1788
1,700,985 0x539186. /src/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h:209
1,700,985 0x53b2b3. /src/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:392
8,992,812 0x541186. /src/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:2214
9,015,224 0x538c82. /src/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h:651
1. Does having 9 million mdcache_dir_entry_t allocated from mdc_readdir_chunk_object (mdcache_helpers.c 2214) and corresponding mdcache_key_dup (mdcache_int.h) seem high?
2. There are 1.7 million entry_export_map (mdcache_helpers.c 392) and cih_hash_key allocations (mdcache_hash.h 209) that as far as I can tell are from mdcache_alloc_entry line 735. Does it seem odd that with 500,000 mdcache entries we have 1.7 million export maps and hash keys?
Thoughts?
Thanks,
Vandana
4 years, 9 months
Change in ...nfs-ganesha[next]: reset should update stats couting start time
by Sachin Punadikar (GerritHub)
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/463272 )
Change subject: reset should update stats couting start time
......................................................................
reset should update stats couting start time
"ganesha_stats reset" operation resets various stats counters. Ganesha
also maintains time since when stats counting is going on / enabled.
Ideally while resetting the counters, stat counting start time should
also set to proper value.
Change-Id: I644757269e21ae539e8e01d9a30ca713131aced2
Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com>
---
M src/support/export_mgr.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/463272/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/463272
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I644757269e21ae539e8e01d9a30ca713131aced2
Gerrit-Change-Number: 463272
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com>
Gerrit-MessageType: newchange
4 years, 9 months
Change in ...nfs-ganesha[next]: Rados revovery - reduce RADOS_KEY_MAX_LEN to 21
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/463105 )
Change subject: Rados revovery - reduce RADOS_KEY_MAX_LEN to 21
......................................................................
Rados revovery - reduce RADOS_KEY_MAX_LEN to 21
Enough to hold decimal form of INT64_MAX plus 1 for NUL.
Change-Id: I8b946dd6d9a97854ebb05db6da96a5be26902167
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/SAL/recovery/recovery_rados.h
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/463105/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/463105
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I8b946dd6d9a97854ebb05db6da96a5be26902167
Gerrit-Change-Number: 463105
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
4 years, 9 months
pNFS details
by Malahal Naineni
Does anyone use pNFS with nfs-ganesha? What layouts we support? Any
pointers for setting up pNFS would be great! Any comparison with pNFS
implementation of linux kernel NFS server?
Regards, Malahal.
4 years, 9 months
Segfault in Ntirpc with V2.7.6
by Rungta, Vandana
Segfault because resarray_val == 0 with status = NFS4ERR_RETRY_UNCACHED_REP
( Not mdcache this time ☺ )
Thanks,
Vandana
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `bin/ganesha.nfsd -f etc/ganesha/ganesha.conf -p var/run/ganesha.pid -F'.
Program terminated with signal 11, Segmentation fault.
#0 0x000000000044b87d in xdr_enum (xdrs=0xaa693f0, ep=0x0) at /src/src/libntirpc/ntirpc/rpc/xdr_inline.h:405
405 /src/src/libntirpc/ntirpc/rpc/xdr_inline.h: No such file or directory.
Missing separate debuginfos, use: debuginfo-install sgw-nfs-ganesha-2.0.108.0-1.x86_64
(gdb) bt
#0 0x000000000044b87d in xdr_enum (xdrs=0xaa693f0, ep=0x0) at /src/src/libntirpc/ntirpc/rpc/xdr_inline.h:405
#1 0x0000000000453b5a in xdr_nfs_opnum4 (xdrs=0xaa693f0, objp=0x0) at /src/src/include/nfsv41.h:8065
#2 0x0000000000454bbb in xdr_nfs_resop4 (xdrs=0xaa693f0, objp=0x0) at /src/src/include/nfsv41.h:8433
#3 0x000000000044c1ba in xdr_array_encode (xdrs=0xaa693f0, cpp=0x17d9d6a0, sizep=0x17d9d698, maxsize=1024, selem=160, xdr_elem=0x454b98 <xdr_nfs_resop4>)
at /src/src/libntirpc/ntirpc/rpc/xdr_inline.h:851
#4 0x000000000044c33b in xdr_array (xdrs=0xaa693f0, cpp=0x17d9d6a0, sizep=0x17d9d698, maxsize=1024, selem=160, xdr_elem=0x454b98 <xdr_nfs_resop4>)
at /src/src/libntirpc/ntirpc/rpc/xdr_inline.h:894
#5 0x0000000000455c1a in xdr_COMPOUND4res (xdrs=0xaa693f0, objp=0x17d9d680) at /src/src/include/nfsv41.h:8779
#6 0x00007fd34e041e78 in svcauth_none_wrap (req=0x78bde5f0, xdrs=0xaa693f0) at /src/src/libntirpc/src/svc_auth_none.c:45
#7 0x00007fd34e04a234 in svc_vc_reply (req=0x78bde5f0) at /src/src/libntirpc/src/svc_vc.c:889
#8 0x00007fd34e041468 in svc_sendreply (req=0x78bde5f0) at /src/src/libntirpc/src/svc.c:501
#9 0x0000000000458016 in nfs_rpc_process_request (reqdata=0x78bde5f0) at /src/src/MainNFSD/nfs_worker_thread.c:1384
#10 0x000000000045859d in nfs_rpc_valid_NFS (req=0x78bde5f0) at /src/src/MainNFSD/nfs_worker_thread.c:1538
#11 0x00007fd34e04a034 in svc_vc_decode (req=0x78bde5f0) at /src/src/libntirpc/src/svc_vc.c:829
#12 0x000000000044b005 in nfs_rpc_decode_request (xprt=0x7aa0ac20, xdrs=0x442a6340) at /src/src/MainNFSD/nfs_rpc_dispatcher_thread.c:1345
#13 0x00007fd34e049f45 in svc_vc_recv (xprt=0x7aa0ac20) at /src/src/libntirpc/src/svc_vc.c:802
#14 0x00007fd34e046689 in svc_rqst_xprt_task (wpe=0x7aa0ae38) at /src/src/libntirpc/src/svc_rqst.c:769
#15 0x00007fd34e046ae6 in svc_rqst_epoll_events (sr_rec=0x1f2e4f0, n_events=1) at /src/src/libntirpc/src/svc_rqst.c:941
#16 0x00007fd34e046d7b in svc_rqst_epoll_loop (sr_rec=0x1f2e4f0) at /src/src/libntirpc/src/svc_rqst.c:1014
#17 0x00007fd34e046e2e in svc_rqst_run_task (wpe=0x1f2e4f0) at /src/src/libntirpc/src/svc_rqst.c:1050
#18 0x00007fd34e04f7f6 in work_pool_thread (arg=0x7af1a1b0) at /src/src/libntirpc/src/work_pool.c:181
#19 0x00007fd34d06dde5 in start_thread () from /lib64/libpthread.so.0
#20 0x00007fd34c974f1d in clone () from /lib64/libc.so.6
(gdb) select-frame 5
(gdb) print objp
$1 = (COMPOUND4res *) 0x17d9d680
(gdb) print *objp
$2 = {status = NFS4ERR_RETRY_UNCACHED_REP, tag = {utf8string_len = 0, utf8string_val = 0x0}, resarray = {resarray_len = 2, resarray_val = 0x0}}
(gdb)
4 years, 9 months
Change in ...nfs-ganesha[next]: Provide stats collection start time and duration
by Sachin Punadikar (GerritHub)
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/462948 )
Change subject: Provide stats collection start time and duration
......................................................................
Provide stats collection start time and duration
"ganesha_stats" command shows various statistics. Recently the utility
enhanced with new options like enable, disable stats counting, reset
stats counter etc. In this context it is good to know since when the
stats counting has been done.
By default the o/p used to show current timestamp. Now enhanced the
code to display the start time of that specific type of stat counting.
Updated "ganesha_stats" utility to display the duration.
Change-Id: Iaeff99d8ac676da5617567f3088897a7af02e972
Signed-off-by: Sachin Punadikar <psachin(a)in.ibm.com>
---
M src/FSAL/FSAL_GPFS/fsal_stats_gpfs.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c
M src/idmapper/idmapper.c
M src/include/server_stats_private.h
M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py
M src/support/export_mgr.c
M src/support/server_stats.c
7 files changed, 138 insertions(+), 136 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/462948/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/462948
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Iaeff99d8ac676da5617567f3088897a7af02e972
Gerrit-Change-Number: 462948
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <psachin(a)in.ibm.com>
Gerrit-MessageType: newchange
4 years, 9 months
Announce Push of V2.9-dev.1
by Frank Filz
Branch next
Tag:V2.9-dev.1
Release Highlights
* Add LizardFS FSAL
* FSAL_RGW: support fast S3 attrs (v1.1.7)
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
63e1140 Frank S. Filz V2.9-dev.1
d197efb Matt Benjamin FSAL_RGW: support fast S3 attrs (v1.1.7)
884ec97 Piotr Sarna Add LizardFS FSAL
7af861d Frank S. Filz V2.8.2
5403af4 Frank S. Filz Bump FSAL_MAJOR_VERSION to 9
1cd4ea3 Suhrud Patankar Use owner_skip for access checks for open reclaims
beba688 Suhrud Patankar Revert "Remove unused openflags"
b5d42db Trishali Nayar Removed a tab from ganesha_mgr script
4 years, 9 months
