August 2019 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: exp dereference error if get_gsh_export() return NULL
by Name of user not set (GerritHub) 06 Aug '19

06 Aug '19

liuwei_coder(a)163.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464356 ) Change subject: exp dereference error if get_gsh_export() return NULL ...................................................................... exp dereference error if get_gsh_export() return NULL Change-Id: Ic79c57654d2a284a1615a82f1b384e2466ac1afe Signed-off-by: sepia-liu <liuwei_coder(a)163.com> --- M src/Protocols/RQUOTA/rquota_common.c 1 file changed, 22 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/464356/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464356 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic79c57654d2a284a1615a82f1b384e2466ac1afe Gerrit-Change-Number: 464356 Gerrit-PatchSet: 1 Gerrit-Owner: liuwei_coder(a)163.com Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Coverity: missing unlock in ceph_fsal_lock_op2
by Zhu Shangzhong (GerritHub) 06 Aug '19

06 Aug '19

Zhu Shangzhong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464297 ) Change subject: Coverity: missing unlock in ceph_fsal_lock_op2 ...................................................................... Coverity: missing unlock in ceph_fsal_lock_op2 Change-Id: Ie3dc3a1572cb0e917a5afb042fe3fdf09b08acac Signed-off-by: Shangzhong Zhu <zhu.shangzhong(a)zte.com.cn> --- M src/FSAL/FSAL_CEPH/handle.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/464297/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464297 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie3dc3a1572cb0e917a5afb042fe3fdf09b08acac Gerrit-Change-Number: 464297 Gerrit-PatchSet: 1 Gerrit-Owner: Zhu Shangzhong <zhu.shangzhong(a)zte.com.cn> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: res maybe double_free, when the first time res has released of the lo...
by Name of user not set (GerritHub) 06 Aug '19

06 Aug '19

liuwei_coder(a)163.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464279 ) Change subject: res maybe double_free, when the first time res has released of the loop,the second getaddrinfo() failed and res not NULL. ...................................................................... res maybe double_free, when the first time res has released of the loop,the second getaddrinfo() failed and res not NULL. Change-Id: Iba40954efd1455e05a01da3d80aa1f48629c81b5 Signed-off-by: sepia-liu <liuwei_coder(a)163.com> --- M src/config_parsing/config_parsing.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/464279/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464279 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iba40954efd1455e05a01da3d80aa1f48629c81b5 Gerrit-Change-Number: 464279 Gerrit-PatchSet: 1 Gerrit-Owner: liuwei_coder(a)163.com Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Coverity: use dirent after free in mdcache_avl_remove
by Zhu Shangzhong (GerritHub) 06 Aug '19

06 Aug '19

Zhu Shangzhong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464277 ) Change subject: Coverity: use dirent after free in mdcache_avl_remove ...................................................................... Coverity: use dirent after free in mdcache_avl_remove Change-Id: Ic9cd9e957e136f0ef50524edcaf679b482d7ca53 Signed-off-by: Shangzhong Zhu <zhu.shangzhong(a)zte.com.cn> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/464277/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464277 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic9cd9e957e136f0ef50524edcaf679b482d7ca53 Gerrit-Change-Number: 464277 Gerrit-PatchSet: 1 Gerrit-Owner: Zhu Shangzhong <zhu.shangzhong(a)zte.com.cn> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Coverity: overrun to index array
by Zhu Shangzhong (GerritHub) 06 Aug '19

06 Aug '19

Zhu Shangzhong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464270 ) Change subject: Coverity: overrun to index array ...................................................................... Coverity: overrun to index array In state_nlm_share, indexing array nlm_share->share_access_counts of size 4 with share_access, the variable share_access may be set as OPEN4_SHARE_ACCESS_ALL(0x00000004). The same as nlm_share->share_deny_counts. Change-Id: Iae1097b71fc5c4bf58601ce9d694ccb1d4e7757e Signed-off-by: Shangzhong Zhu <zhu.shangzhong(a)zte.com.cn> --- M src/SAL/state_share.c 1 file changed, 2 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/464270/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464270 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iae1097b71fc5c4bf58601ce9d694ccb1d4e7757e Gerrit-Change-Number: 464270 Gerrit-PatchSet: 1 Gerrit-Owner: Zhu Shangzhong <zhu.shangzhong(a)zte.com.cn> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Coverity: resource leak in rados_url_setup_watch
by Zhu Shangzhong (GerritHub) 05 Aug '19

05 Aug '19

Zhu Shangzhong has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464255 ) Change subject: Coverity: resource leak in rados_url_setup_watch ...................................................................... Coverity: resource leak in rados_url_setup_watch Parse the URL with rados_url_parse, the memory will be assigned to pool, ns or obj. The resource will be leaked when the rados_url_client_setup return with non-zero. Change-Id: Id12157282ef92ed845f0b7a47b2e1ae2a226570e Signed-off-by: Shangzhong Zhu <zhu.shangzhong(a)zte.com.cn> --- M src/config_parsing/conf_url_rados.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/464255/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464255 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id12157282ef92ed845f0b7a47b2e1ae2a226570e Gerrit-Change-Number: 464255 Gerrit-PatchSet: 1 Gerrit-Owner: Zhu Shangzhong <zhu.shangzhong(a)zte.com.cn> Gerrit-MessageType: newchange

1 0

Re: nfs-ganesha not load private Moudle
by Daniel Gryniewicz 05 Aug '19

05 Aug '19

You will generally get a faster response by posting to the mailing list ( devel(a)lists.nfs-ganesha.org) than by mailing contributors directly. FSALs are loaded by the fsal_manager in fsal_load.c. The library that is loaded is <libdir>/ganesha/lib<fsal>.so where <fsal> is the Name given in the config for that FSAL, transformed to lower case. You will need to make sure there are 3 things done correctly: 1. The name of your fsal library must match the name given in the config 2. Your fsal must be installed in the correct location 3. Your fsal must have MODULE_INIT and MODULE_FINI functions built into it. Without seeing the source, it's a bit hard to debug. Daniel On Fri, Aug 2, 2019 at 7:41 AM kjl8401 <kjl8401(a)126.com> wrote: > dear dang, > hello, i have a question for you about using nfs-ganesha.The private > moudle NCSF do not load while compiled. you are an important contributior > of this project. I think you might meet this problem and hope you can > reply to me. Let me tell you about question. > > the private NCSF moudle looks like load successfully > > /FSAL/FSAL_NCSF/CMakeList.txt > libfsalncsf.so generated successfully > > but execute the command > # ganesha.nfsd -f /etc/ganesha/ganesha.conf -L nfs-ganesha.log -N NIV_DEBUG > > nfs-ganesha.log has not log > i do not konow what causes this problem and how to resolve. > I am looking forward to hearing from you. Thank you very much. > Best, Sincerely, > kjl8401 > > >

3 3

Announce Push of V2.9-dev.3
by Frank Filz 02 Aug '19

02 Aug '19

Branch next Tag:V2.9-dev.3 Release Highlights * Set Runtime, Logs and StateDirectory settings for systemd * Fix refcnt on shared UDP DRC * Remove unused DRC flags * Print error if "getattrs" fails in fsal_common_is_referral * python3: ganesha_stats: Fix "TypeError: '<' not supported between instances of 'str' and 'int'" * Gather generic stats for clients and exports * Use strerror in default case of posix2fsal_error Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: e14ecd1 Frank S. Filz V2.9-dev.3 1383d97 Frank S. Filz Use strerror in default case of posix2fsal_error d0c2913 Sachin Punadikar Gather generic stats for clients and exports 89c44a7 Madhu Thorat python3: ganesha_stats: Fix "TypeError: '<' not supported between instances of 'str' and 'int'" 48955b2 Madhu Thorat Print error if "getattrs" fails in fsal_common_is_referral e9e114e Malahal Naineni Remove unused DRC flags 92f2b7e Malahal Naineni Fix refcnt on shared UDP DRC d4346f8 Malahal Naineni Set Runtime, Logs and StateDirectory settings for systemd

1 0

Nonblocking looks like it's just about there
by Frank Filz 02 Aug '19

02 Aug '19

Daniel, Matt, could you review https://github.com/ffilz/ntirpc/commits/nonblock This needs to be compressed all down to a single patch, and some of the debug stuff removed (or set back to debug level rather than event or error). The top (most recent) two patches are the significant bits to get it working as well as the MORE CODE 11 that deals with partially sent writes. The top patch, at Matt's suggestion, removes the limit on send queues and instead puts a writeq in each duplex record. This simplified blocking additional writes while a blocked write is in progress since the existing queuing code node just queues them up behind the in-progress write whether it's blocked or not. The whole floating sr_rec goes away, the sr_rec per channel is sufficient, instead, each duplex record has both a receive and send event, and the xprt xp_fd is duplicated (dup) if we have blocking I/O (the combination of the duplicated fd and the 2nd event with EPOLLOUT instead of EPOLLIN is sufficient to manage the separate waiting for the tcp window to open again). You might look at the diff between what I did and where Daniel left off (with "Turn on nonblocking") or even the whole diff from next rather than looking at the piecemeal patches. If you don't see any gaping issues, I'll talk with Daniel on Monday about how to render this into a reasonable set of patches for final review and merge. Frank

1 0

Change in ...nfs-ganesha[next]: Remove unused DRC flags
by Malahal (GerritHub) 02 Aug '19

02 Aug '19

Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464031 ) Change subject: Remove unused DRC flags ...................................................................... Remove unused DRC flags Change-Id: I6d70e595d7168cf7cf22b1e73cf7e9ba673fe431 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/RPCAL/nfs_dupreq.c M src/include/nfs_dupreq.h 3 files changed, 9 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/464031/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/464031 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6d70e595d7168cf7cf22b1e73cf7e9ba673fe431 Gerrit-Change-Number: 464031 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0