Change in ...nfs-ganesha[next]: PseudoFS lookup fails with ERR_FSAL_DELAY during export update
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505453 )
Change subject: PseudoFS lookup fails with ERR_FSAL_DELAY during export update
......................................................................
PseudoFS lookup fails with ERR_FSAL_DELAY during export update
FSAL_PSEUDO is very simple and actually has very few errors. The change
to return ERR_FSAL_DELAY instead of ERR_FSAL_NOENT however has broken
export update when a new export is added in the PseudoFS.
This patch simply codes more knowledge of how FSAL_PSEUDO works into
make_pseudofs_node() and ignores any error on lookup because it's either
ERR_FSAL_NOENT straight up or translated to ERR_FSAL_DELAY.
Also simplify non-FSAL_PSEUDO error reporting a bit.
Also add comments to point out how FSAL_PSEUDO will actually behave
in any real scenario. It IS possible for the PseudoFS to be created
as read/write in which case a CLIENT COULD upset our apple cart, so
some "make this code look right" error handling COULD actually be
triggered.
Another fix would be to actually disallow any activity on FSAL_PSEUDO
when an update is in progress and fix is_export_update_in_progress()
to not indicate an update is in progress for the thread actually doing
the update... All that would actually need would be to have a flag in
the op_ctx which denotes the updating thread.
Change-Id: If85c09642cf0776ee86b05dbb0f3aa8dde6533af
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/Protocols/NFS/nfs4_pseudo.c
1 file changed, 35 insertions(+), 18 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/505453/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505453
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: If85c09642cf0776ee86b05dbb0f3aa8dde6533af
Gerrit-Change-Number: 505453
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
3 years, 5 months
Change in ...nfs-ganesha[next]: systemd: bad Wants: and Needs:
by Kaleb KEITHLEY (GerritHub)
Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505340 )
Change subject: systemd: bad Wants: and Needs:
......................................................................
systemd: bad Wants: and Needs:
user zSars reports that second Wants: and Needs: lines override the
first.
Is this a change in behavior, because they've been like this for a
long time.
Change-Id: I3a9b6503f54083a8f9d5c3940830a5a1ed8ebc41
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
---
M src/scripts/systemd/nfs-ganesha.service.debian8
M src/scripts/systemd/nfs-ganesha.service.el7
2 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/505340/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505340
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I3a9b6503f54083a8f9d5c3940830a5a1ed8ebc41
Gerrit-Change-Number: 505340
Gerrit-PatchSet: 1
Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>
Gerrit-MessageType: newchange
3 years, 5 months
Fwd: [PATCH 00/12] Readdir enhancements
by Daniel Gryniewicz
Trond just proposed this for the kernel client. If this gets in, we
should test with it ASAP.
Daniel
-------- Forwarded Message --------
Subject: [PATCH 00/12] Readdir enhancements
Date: Mon, 2 Nov 2020 13:06:46 -0500
From: trondmy(a)kernel.org
To: linux-nfs(a)vger.kernel.org
From: Trond Myklebust <trond.myklebust(a)hammerspace.com>
The following patch series performs a number of cleanups on the readdir
code.
It also adds support for 1MB readdir RPC calls on-the-wire, and modifies
the caching code to ensure that we cache the entire contents of that
1MB call (instead of discarding the data that doesn't fit into a single
page).
Trond Myklebust (12):
NFS: Ensure contents of struct nfs_open_dir_context are consistent
NFS: Clean up readdir struct nfs_cache_array
NFS: Clean up nfs_readdir_page_filler()
NFS: Clean up directory array handling
NFS: Don't discard readdir results
NFS: Remove unnecessary kmap in nfs_readdir_xdr_to_array()
NFS: Replace kmap() with kmap_atomic() in nfs_readdir_search_array()
NFS: Simplify struct nfs_cache_array_entry
NFS: Support larger readdir buffers
NFS: More readdir cleanups
NFS: nfs_do_filldir() does not return a value
NFS: Reduce readdir stack usage
fs/nfs/client.c | 4 +-
fs/nfs/dir.c | 555 ++++++++++++++++++++++++-----------------
fs/nfs/internal.h | 6 -
include/linux/nfs_fs.h | 1 -
4 files changed, 325 insertions(+), 241 deletions(-)
--
2.28.0
3 years, 5 months
