August 2020 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: FSAL_CEPH: fix cannot find entry by ino_release_cb
by sepia-liu (GerritHub) 24 Aug '20

24 Aug '20

sepia-liu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/501180 ) Change subject: FSAL_CEPH: fix cannot find entry by ino_release_cb ...................................................................... FSAL_CEPH: fix cannot find entry by ino_release_cb There is no export_id in the key, the correct hash value cannot be calculated, causing cannot find the entry. Change-Id: Iead1952457ab169b15260aab0c4329dc2644d6df Signed-off-by: sepia-liu <liuwei_coder(a)163.com> --- M src/FSAL/FSAL_CEPH/main.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/501180/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/501180 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iead1952457ab169b15260aab0c4329dc2644d6df Gerrit-Change-Number: 501180 Gerrit-PatchSet: 1 Gerrit-Owner: sepia-liu <liuwei_coder(a)163.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_CEPH: register umask callback
by sepia-liu (GerritHub) 24 Aug '20

24 Aug '20

sepia-liu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/501178 ) Change subject: FSAL_CEPH: register umask callback ...................................................................... FSAL_CEPH: register umask callback Solve the problem of creating file permissions mismatch. libcephfs(ceph nautilus version) will use the default umask_cb function if Ganesha is not registered umask_cb, but Ganesha registered handle is not struct ceph_mount_info, at the point, calling the default umask_cb will cause unexpected umask and permissions. Change-Id: I09d924dc664af4dcc423cbfbfb5b736d36a2ea40 Signed-off-by: sepia-liu <liuwei_coder(a)163.com> --- M src/FSAL/FSAL_CEPH/main.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/501178/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/501178 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I09d924dc664af4dcc423cbfbfb5b736d36a2ea40 Gerrit-Change-Number: 501178 Gerrit-PatchSet: 1 Gerrit-Owner: sepia-liu <liuwei_coder(a)163.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_CEPH: register dentry release callback
by sepia-liu (GerritHub) 24 Aug '20

24 Aug '20

sepia-liu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/501177 ) Change subject: FSAL_CEPH: register dentry release callback ...................................................................... FSAL_CEPH: register dentry release callback When multiple Ganesha cache handle of the same file, one Ganesha deletes the file, the other Ganesha(CephFS Clients) cannot respond to the request to release dentry, which results in cache inconsistency and MDS unable to delete the file. Change-Id: I6eab6d61668e07f8d8f5dd4608fc4ccd30a5f60b Signed-off-by: sepia-liu <liuwei_coder(a)163.com> --- M src/FSAL/FSAL_CEPH/main.c 1 file changed, 13 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/501177/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/501177 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6eab6d61668e07f8d8f5dd4608fc4ccd30a5f60b Gerrit-Change-Number: 501177 Gerrit-PatchSet: 1 Gerrit-Owner: sepia-liu <liuwei_coder(a)163.com> Gerrit-MessageType: newchange

1 0

No community call Tuesday August 25
by Frank Filz 20 Aug '20

20 Aug '20

I will be at the beach. There will be a merge next week if there's anything to merge. Frank

1 0

Announce Push of V4-dev.30
by Frank Filz 13 Aug '20

13 Aug '20

Branch next Tag:V4-dev.30 Merge Highlights * Clean up fsal_pnfs_ds and fsal_ds_handle to resolve refcount issues * From Github issue 625: Minor compilation error - Fix provided in issue * CMake: Remove SLES config samples installation * Print error code for ERR_FSAL_IO in nfs4_Errno_verbose()/nfs3_Errno_verbose() Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 258bc1a Frank S. Filz V4-dev.30 7b95e69 Madhu Thorat Print error code for ERR_FSAL_IO in nfs4_Errno_verbose()/nfs3_Errno_verbose() 0eb5c4a supriti CMake: Remove SLES config samples installation 56250f1 Frank S. Filz From Github issue 625: Minor compilation error - Fix provided in issue ab19124 Frank S. Filz Simplify fsal_ds_handle 02a13c1 Frank S. Filz Cleanup DS export refcounting and pnfs ds refcounting 8f6d790 Frank S. Filz fsal_pnfs_ds: rename symbols to make code easier to read

1 0

Change in ...nfs-ganesha[next]: Print error code for ERR_FSAL_IO in nfs4_Errno_verbose()/nfs3_Errno_v...
by Madhu Thorat (GerritHub) 13 Aug '20

13 Aug '20

Madhu Thorat has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/499493 ) Change subject: Print error code for ERR_FSAL_IO in nfs4_Errno_verbose()/nfs3_Errno_verbose() ...................................................................... Print error code for ERR_FSAL_IO in nfs4_Errno_verbose()/nfs3_Errno_verbose() Currently we log ERR_FSAL_IO in nfs4_Errno_verbose()/ nfs3_Errno_verbose() with LogCrit(..). But different errors like EMFILE, ENFILE etc are mapped to ERR_FSAL_IO. The information about the specific error code is usually saved in status.minor. It will be useful to log the specific error code to know which error was mapped to ERR_FSAL_IO. With this change we print the status.minor value in the same LogCrit() log in nfs4_Errno_verbose()/ nfs3_Errno_verbose(). Also removed nfs4_Errno() and nfs3_Errno() as they provided only status.major value to nfs4_Errno_verbose() and nfs3_Errno_verbose(), but with this patch we need to provide status (both major, minor) to nfs4_Errno_verbose()/ nfs3_Errno_verbose(). So now we use nfs4_Errno_status()/ nfs3_Errno_status() in place of nfs4_Errno()/ nfs3_Errno() in code. Change-Id: I5e7e38f7f266588b07ba677ba8052ea2cc2dc83e Signed-off-by: Madhu Thorat <madhu.punjabi(a)in.ibm.com> --- M src/Protocols/NFS/nfs3_access.c M src/Protocols/NFS/nfs4_op_access.c M src/include/nfs_convert.h M src/include/nfs_creds.h M src/support/nfs_convert.c M src/support/nfs_creds.c 6 files changed, 54 insertions(+), 42 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/499493/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/499493 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5e7e38f7f266588b07ba677ba8052ea2cc2dc83e Gerrit-Change-Number: 499493 Gerrit-PatchSet: 1 Gerrit-Owner: Madhu Thorat <madhu.punjabi(a)in.ibm.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: CMake: Remove SLES config samples installation
by Name of user not set (GerritHub) 12 Aug '20

12 Aug '20

supriti.singh(a)suse.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/499442 ) Change subject: CMake: Remove SLES config samples installation ...................................................................... CMake: Remove SLES config samples installation By default, the respective config samples are installed when nfs-ganesha and FSAL is installed. There seems to be no need to install all config samples. Change-Id: I4be198a466841cbd69898c0d8da8423adfdc9f86 Signed-off-by: supriti <supriti.singh(a)suse.com> --- M src/CMakeLists.txt 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/499442/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/499442 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4be198a466841cbd69898c0d8da8423adfdc9f86 Gerrit-Change-Number: 499442 Gerrit-PatchSet: 1 Gerrit-Owner: supriti.singh(a)suse.com Gerrit-MessageType: newchange

1 0

PNFS DS Only Mode
by Frank Filz 11 Aug '20

11 Aug '20

Since I went through and resolved refcount issues with fsal_pnfs_ds (that were exposed when I looked at all the export refcounting), I notice that there's code for DS only mode, but I'm not sure how it actually works. FSAL_GLUSTER, FSAL_GPFS, and FSAL_LIZARDFS are all set up to associate a fsal_pnfs_ds with an export. FSAL_CEPG seems to be set up to use the DS only mode, which does NOT associate an export with a fsal_pnfs_ds. But then how does, for example FSAL_CEPH's ds_read method supposed to work? It immediately de-references op_ctx->fsal_export which will be NULL if called with a Ceph DS handle. Another issue is the processing for the DS config block makes no check about the FSAL specified, so you could configure: DS { Number = 1; FSAL { Name = GPFS; } } Which probably will go badly in some way. I suspect the config processing should try and determine if the FSAL actually supports DS only mode. Frank

2 2

Change in ...nfs-ganesha[next]: Fix for coverity issue:CID 360547
by Name of user not set (GerritHub) 10 Aug '20

10 Aug '20

yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/499300 ) Change subject: Fix for coverity issue:CID 360547 ...................................................................... Fix for coverity issue:CID 360547 Change-Id: I42b40136f70193348432f7998f0f07cd5d9d38db Signed-off-by: Yogendra Charya <yogendra.charya(a)ibm.com> --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/00/499300/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/499300 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I42b40136f70193348432f7998f0f07cd5d9d38db Gerrit-Change-Number: 499300 Gerrit-PatchSet: 1 Gerrit-Owner: yogendra858(a)yahoo.com Gerrit-MessageType: newchange

1 0

Announce Push of V4-dev.29
by Frank Filz 07 Aug '20

07 Aug '20

Branch next Tag:V4-dev.29 Merge Highlights * Make cmake USE_NFS3=OFF actually disable and compile out ALL NFSv3 code * Add USE_RQUOTA compile option to code and cmake * On add export dbus check file path so parser doesn't abort * Rate limit the invalid channel attributes message * Remove extraneous CR in log message Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: db29013 Frank S. Filz V4-dev.29 70fda21 Philippe DENIEL Remove extraneous CR in log message 45965fd Trishali Nayar Rate limit the invalid channel attributes message 8a48bce Frank S. Filz On add export dbus check file path so parser doesn't abort ffd8c42 Frank S. Filz Add USE_RQUOTA compile option to code and cmake c97915d Frank S. Filz Make cmake USE_NFS3=OFF actually disable and compile out ALL NFSv3 code

1 0