March 2021 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: PRIu64 fixups
by Frank Filz (GerritHub) 10 Mar '21

10 Mar '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/512235 ) Change subject: PRIu64 fixups ...................................................................... PRIu64 fixups Patch originally submitted in https://github.com/nfs-ganesha/nfs-ganesha/issues/345 Change-Id: I143062071fb4343cd250fd27bfe5e5fb854975d9 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GLUSTER/export.c M src/FSAL/FSAL_GPFS/file.c 2 files changed, 11 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/35/512235/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/512235 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I143062071fb4343cd250fd27bfe5e5fb854975d9 Gerrit-Change-Number: 512235 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_CEPH: enable XATTR support
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511990 ) Change subject: FSAL_CEPH: enable XATTR support ...................................................................... FSAL_CEPH: enable XATTR support ...and rework how CEPH_SUPPORTED_ATTRS and CEPH_SETTABLE_ATTRIBUTES are defined to reduce duplication. Change-Id: I2f57810c1884e85a3a3d11fb19d16b1733c69ac0 Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/FSAL/FSAL_CEPH/internal.h M src/FSAL/FSAL_CEPH/main.c 2 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/511990/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511990 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2f57810c1884e85a3a3d11fb19d16b1733c69ac0 Gerrit-Change-Number: 511990 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL_CEPH: plumb in xattr handling
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511989 ) Change subject: FSAL_CEPH: plumb in xattr handling ...................................................................... FSAL_CEPH: plumb in xattr handling Add all of the necessary functions to handle xattrs in FSAL_CEPH. Change-Id: I475092b48102f0ff03e2e3d5117b6573584b492d Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/FSAL/FSAL_CEPH/handle.c 1 file changed, 205 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/89/511989/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511989 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I475092b48102f0ff03e2e3d5117b6573584b492d Gerrit-Change-Number: 511989 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: FSAL: add a new listxattr helper routine
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511988 ) Change subject: FSAL: add a new listxattr helper routine ...................................................................... FSAL: add a new listxattr helper routine Most listxattr() implementations return a buffer with a concatenated set of NULL terminated names. Add a new helper routine for listxattr that does all of the work, given paramters from LISTXATTRS call and a populated buffer and length. Change-Id: Id7529af260d42ff3aa0bcdad0c6afaec410e071d Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/FSAL/fsal_helper.c M src/MainNFSD/libganesha_nfsd.ver M src/include/fsal.h 3 files changed, 142 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/511988/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511988 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id7529af260d42ff3aa0bcdad0c6afaec410e071d Gerrit-Change-Number: 511988 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: NFS: fix up handling of ATTR4_XATTR_SUPPORTED
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511987 ) Change subject: NFS: fix up handling of ATTR4_XATTR_SUPPORTED ...................................................................... NFS: fix up handling of ATTR4_XATTR_SUPPORTED Add a new xattr_supported field in the fsal_staticfsinfo_t, and fix up the encoder to consult it and fill out the field appropriately. Change-Id: I03050d4dffd1537d3580faccbc5015764ed4eddb Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/FSAL/commonlib.c M src/FSAL/fsal_config.c M src/Protocols/NFS/nfs_proto_tools.c M src/include/fsal_types.h 4 files changed, 21 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/511987/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511987 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I03050d4dffd1537d3580faccbc5015764ed4eddb Gerrit-Change-Number: 511987 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: NFS: convert LISTXATTRS
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511986 ) Change subject: NFS: convert LISTXATTRS ...................................................................... NFS: convert LISTXATTRS Convert the LISTXATTRS code to convert with RFC8276. Note that we also change the listxattrs API a bit. The old code had nfs4_op_listxattr allocate a (largeish) array based on an estimate using the maxcount passed in by the client. That covered most reasonable cases, but might not have worked well at the edges, and it was a bit odd in that the FSAL still had to allocate the char arrays for utf8string_val. The new API passes in a pointer to a zeroed out xattrlist4 that the FSAL must fill out itself. The FSAL can then allocate an array that is correctly sized, based on the xattrs it finds and the args from the client. Change-Id: I6b742dc04f6ae9fc434bd1bdcdaff04e8b8109ea Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_xattrs.c M src/FSAL/default_methods.c M src/Protocols/NFS/nfs4_op_xattr.c M src/include/fsal_api.h M src/include/nfsv41.h 8 files changed, 75 insertions(+), 111 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/86/511986/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511986 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6b742dc04f6ae9fc434bd1bdcdaff04e8b8109ea Gerrit-Change-Number: 511986 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: NFS: convert REMOVEXATTR
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511985 ) Change subject: NFS: convert REMOVEXATTR ...................................................................... NFS: convert REMOVEXATTR Convert REMOVEXATTR to comply with RFC8276. Change-Id: If09a6a38ce9bf0724ec21462669993a8e5afea4c Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/Protocols/NFS/nfs4_op_xattr.c M src/include/nfsv41.h 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/511985/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511985 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If09a6a38ce9bf0724ec21462669993a8e5afea4c Gerrit-Change-Number: 511985 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: NFS: convert SETXATTR to RFC 8276
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511984 ) Change subject: NFS: convert SETXATTR to RFC 8276 ...................................................................... NFS: convert SETXATTR to RFC 8276 Convert SETXATTR to comply with RFC 8276, including renaming the appropriate structs and fields to follow suit. Change-Id: I520c5168f0f52950b9f4c9acc5c64c8925341ef1 Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_xattrs.c M src/FSAL/default_methods.c M src/Protocols/NFS/nfs4_op_xattr.c M src/include/fsal_api.h M src/include/nfsv41.h 8 files changed, 34 insertions(+), 29 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/84/511984/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511984 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I520c5168f0f52950b9f4c9acc5c64c8925341ef1 Gerrit-Change-Number: 511984 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: NFS: update GETXATTR to RFC 8276
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511983 ) Change subject: NFS: update GETXATTR to RFC 8276 ...................................................................... NFS: update GETXATTR to RFC 8276 There are some differences between the released spec and what had been merged into ganesha several years ago. Overhaul the GETXATTR code to follow RFC 8276, including renaming variables, structs and fields to better match the spec. Change-Id: I323634cf881e608d39670f8052125b092f3ace11 Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/Protocols/NFS/nfs4_op_xattr.c M src/include/nfsv41.h 2 files changed, 37 insertions(+), 32 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/511983/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511983 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I323634cf881e608d39670f8052125b092f3ace11 Gerrit-Change-Number: 511983 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: NFS: add support for xattr ACCESS bits
by Jeff Layton (GerritHub) 08 Mar '21

08 Mar '21

Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511982 ) Change subject: NFS: add support for xattr ACCESS bits ...................................................................... NFS: add support for xattr ACCESS bits Add support for the new ACCESS4_XA* bits. Follow the Linux convention and assume that if we have read permissions then we can read and list xattrs, and if we have write permissions then we can set them. Change-Id: I47efa0c57b2fb07f863bf6a24175f59b6591250d Signed-off-by: Jeff Layton <jlayton(a)redhat.com> --- M src/Protocols/NFS/nfs4_op_access.c M src/include/nfsv41.h 2 files changed, 21 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/511982/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/511982 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I47efa0c57b2fb07f863bf6a24175f59b6591250d Gerrit-Change-Number: 511982 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com> Gerrit-MessageType: newchange

1 0