June 2021 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Fix nfs3_write in case of len "0" write request
by Name of user not set (GerritHub) 23 Jun '21

23 Jun '21

prabhu.murugeshan(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519425 ) Change subject: Fix nfs3_write in case of len "0" write request ...................................................................... Fix nfs3_write in case of len "0" write request Change-Id: I36e818b5545123e4c6866a76d183fba0c1f667c0 Signed-off-by: Prabhu Murugesan <prabhu.murugeshan(a)ibm.com> --- M src/Protocols/NFS/nfs3_write.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/25/519425/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519425 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I36e818b5545123e4c6866a76d183fba0c1f667c0 Gerrit-Change-Number: 519425 Gerrit-PatchSet: 1 Gerrit-Owner: prabhu.murugeshan(a)ibm.com Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Turn off VFS and GPFS support if prereqs are missing
by Matthew DeVore (GerritHub) 21 Jun '21

21 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519308 ) Change subject: Turn off VFS and GPFS support if prereqs are missing ...................................................................... Turn off VFS and GPFS support if prereqs are missing Both of these modules have two common prerequisites. If either one is turned off, we cannot support VFS or GPFS, so turn them off by default, or make CMake error out. Change-Id: I79f06824c52c25b68621f6767dab72c0341fc47c Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/CMakeLists.txt 1 file changed, 19 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/519308/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519308 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I79f06824c52c25b68621f6767dab72c0341fc47c Gerrit-Change-Number: 519308 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <me(a)matvore.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Move fsal_filesystem struct to fsal_localfs.h
by Matthew DeVore (GerritHub) 21 Jun '21

21 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519307 ) Change subject: Move fsal_filesystem struct to fsal_localfs.h ...................................................................... Move fsal_filesystem struct to fsal_localfs.h This struct is not required in builds that don't support local FS hosting. FSAL_MDCACHE and FSAL_NULL are fine with only having a forward declaration for it. Change-Id: I7d03a6e49c08e48c3638ce9b160d03c700725c0f Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/FSAL/FSAL_GPFS/file.c M src/FSAL/FSAL_GPFS/fsal_attrs.c M src/FSAL/FSAL_GPFS/fsal_create.c M src/FSAL/FSAL_GPFS/fsal_symlinks.c M src/FSAL/FSAL_GPFS/fsal_up.c M src/FSAL/FSAL_VFS/vfs_methods.h M src/include/FSAL/fsal_localfs.h M src/include/fsal_api.h 8 files changed, 45 insertions(+), 37 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/519307/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519307 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7d03a6e49c08e48c3638ce9b160d03c700725c0f Gerrit-Change-Number: 519307 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <me(a)matvore.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: NFSv3 READ - uio_vio buffer MUST be a multiple of 4 bytes
by Frank Filz (GerritHub) 21 Jun '21

21 Jun '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519302 ) Change subject: NFSv3 READ - uio_vio buffer MUST be a multiple of 4 bytes ...................................................................... NFSv3 READ - uio_vio buffer MUST be a multiple of 4 bytes We already calculated it correctly, we just set vio.length wrong. The buffer is already properly allocated with RNDUP(size) in nfs3_read.c. Change-Id: Ie8aafd87c3d0c98f987fc6b68a8aeeda5d3c9173 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/XDR/xdr_nfs23.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/02/519302/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519302 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie8aafd87c3d0c98f987fc6b68a8aeeda5d3c9173 Gerrit-Change-Number: 519302 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: EXPORT: Move default value of export level cache expiry to one place.
by Name of user not set (GerritHub) 21 Jun '21

21 Jun '21

pradeepthomas(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519286 ) Change subject: EXPORT: Move default value of export level cache expiry to one place. ...................................................................... EXPORT: Move default value of export level cache expiry to one place. Signed-off-by: Pradeep <pradeepthomas(a)gmail.com> Change-Id: I65b6bd5685e1066618baab120139ae39c9e64d4e --- M src/include/nfs_exports.h M src/support/exports.c 2 files changed, 8 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/86/519286/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519286 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I65b6bd5685e1066618baab120139ae39c9e64d4e Gerrit-Change-Number: 519286 Gerrit-PatchSet: 1 Gerrit-Owner: pradeepthomas(a)gmail.com Gerrit-MessageType: newchange

1 0

Announce Push of V4-dev.64
by Frank Filz 18 Jun '21

18 Jun '21

Branch next Tag:V4-dev.64 Merge Highlights * A bunch of patches to make Ganesha work on MacOS Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: bb103b421 Frank S. Filz V4-dev.64 fceb08bbc Matthew DeVore Define getuser/getgroup for every OS in one spot fba3204db Matthew DeVore Use the st_[amc]tim field names on all OS targets d5dda25ae Matthew DeVore Define TCP_KEEPIDLE on OS that uses another name c3fd5a3aa Matthew DeVore Remove librt dependency da01f9f23 Matthew DeVore Remove clock_gettime shim for pre-Sierra macOS 6346cd2e5 Matthew DeVore Add liburcu include path to compiler invocations 1ad13df72 Matthew DeVore Sanitize use of _GNU_SOURCE preprocessor define 5a72ceda2 Matthew DeVore Use ntirpc's bswap_## definitions 162652867 Matthew DeVore Pull up ntirpc changes ab8ea6e06 Matthew DeVore Specify correct flags for Apple's /usr/bin/ld

1 0

Change in ...nfs-ganesha[next]: Make local-FS-hosting support optional
by Matthew DeVore (GerritHub) 18 Jun '21

18 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519155 ) Change subject: Make local-FS-hosting support optional ...................................................................... Make local-FS-hosting support optional Change-Id: I0b54dca369f2f9864560b66812687247eb3818e0 Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/CMakeLists.txt M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/fsal_ds.c M src/FSAL/FSAL_GPFS/fsal_lookup.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_VFS/export.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/FSAL_VFS/handle_syscalls.c M src/FSAL/commonlib.c M src/FSAL/fsal_destroyer.c A src/FSAL/localfs.c M src/MainNFSD/CMakeLists.txt M src/MainNFSD/nfs_init.c M src/include/FSAL/fsal_commonlib.h A src/include/FSAL/fsal_localfs.h M src/include/config-h.in.cmake 16 files changed, 1,993 insertions(+), 1,960 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/519155/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519155 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0b54dca369f2f9864560b66812687247eb3818e0 Gerrit-Change-Number: 519155 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <me(a)matvore.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: access_check: make credential setting optional
by Matthew DeVore (GerritHub) 18 Jun '21

18 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519154 ) Change subject: access_check: make credential setting optional ...................................................................... access_check: make credential setting optional This does not work on macOS as-is and is only useful for a subset of Ganesha functionality, so make it excludable in builds. Change-Id: I67cd8f4288ba30cffed799458aee448e4a18af9d Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/CMakeLists.txt M src/FSAL/access_check.c M src/include/FSAL/access_check.h M src/include/config-h.in.cmake 4 files changed, 19 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/54/519154/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519154 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I67cd8f4288ba30cffed799458aee448e4a18af9d Gerrit-Change-Number: 519154 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <me(a)matvore.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fix error stats for NFS v3.
by Gaurav (GerritHub) 18 Jun '21

18 Jun '21

Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519134 ) Change subject: Fix error stats for NFS v3. ...................................................................... Fix error stats for NFS v3. For NFS V3 stats collection, check for rpc result status also to account error stats, since in some cases we could return rc as SUCCESS even if there is failure. Change-Id: I0fadee94fa701a92f6c314a220ceee38b438fed0 Signed-off-by: Gaurav <gaurav.gangalwar(a)gmail.com> --- M src/MainNFSD/nfs_worker_thread.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/519134/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519134 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0fadee94fa701a92f6c314a220ceee38b438fed0 Gerrit-Change-Number: 519134 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Define getuser/getgroup for every OS in one spot
by Matthew DeVore (GerritHub) 16 Jun '21

16 Jun '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519057 ) Change subject: Define getuser/getgroup for every OS in one spot ...................................................................... Define getuser/getgroup for every OS in one spot Only one definition is needed, as all OS's use the same API. This CL effectively adds definitions for macOS. Change-Id: Ia0d93ab67b7f18695a13b66055d827c50acc9b3f Signed-off-by: Matthew DeVore <matvore(a)google.com> --- M src/include/os/subr.h M src/os/freebsd/subr.c M src/os/linux/subr.c 3 files changed, 5 insertions(+), 22 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/519057/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/519057 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia0d93ab67b7f18695a13b66055d827c50acc9b3f Gerrit-Change-Number: 519057 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <matvore(a)comcast.net> Gerrit-MessageType: newchange

1 0