Change in ...nfs-ganesha[next]: FSAL_GLUSTER: fix double free of caller_garray when nfs3_create fails
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/520421 )
Change subject: FSAL_GLUSTER: fix double free of caller_garray when nfs3_create fails
......................................................................
FSAL_GLUSTER: fix double free of caller_garray when nfs3_create fails
The create is performed using tmp_fd until the fsal_obj_handle is
created, at which point, the tmp_fd is copied into globalfd, but if
a subsequent error happened, tmp_fd was closed and then the
fsal_obj_handle was released which closed globalfd. Since the two
shared one caller_garray, double free. The fix is to change my_fd to
refer to globalfd once the copy is accomplished and then ignore tmp_fd.
Change-Id: I4ee6ce428895546e6b683017ee74ac2702c6c681
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/FSAL_GLUSTER/handle.c
1 file changed, 24 insertions(+), 15 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/520421/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/520421
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4ee6ce428895546e6b683017ee74ac2702c6c681
Gerrit-Change-Number: 520421
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
11 months, 3 weeks
Change in ...nfs-ganesha[next]: Fix the NFSv3 -> v4 handle mapping length check.
by Virtually Nick (GerritHub)
Virtually Nick has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/520228 )
Change subject: Fix the NFSv3 -> v4 handle mapping length check.
......................................................................
Fix the NFSv3 -> v4 handle mapping length check.
Signed-off-by: Virtually Nick <nick.e.couchman(a)gmail.com>
Change-Id: I3fd80e0b872f91655ca86dce454f7173d7e45c3f
---
M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping.c
M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping.h
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/520228/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/520228
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I3fd80e0b872f91655ca86dce454f7173d7e45c3f
Gerrit-Change-Number: 520228
Gerrit-PatchSet: 1
Gerrit-Owner: Virtually Nick <nick.e.couchman(a)gmail.com>
Gerrit-MessageType: newchange
11 months, 4 weeks
Announce Push of V4-dev.66
by Frank Filz
Branch next
Tag:V4-dev.66
Merge Highlights
* Fix cmake variable for Proxy v4 FSAL module.
* Add byteswap.h includes in FSAL modules.
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
2ce098982 Frank S. Filz V4-dev.66
7846991e3 Virtually Nick Add byteswap.h includes in FSAL modules.
f24a40ac6 Virtually Nick Fix cmake variable for Proxy v4 FSAL module.
12 months
Best way to count number of clients?
by Bjorn Leffler
For monitoring and load balancing purposes, I'd like to count the number of
connected (NFS) clients to Ganesha.
I tried to do this, but didn't get very far:
For NFSv3, I increment a gauge (counter) on mount and decrement on umount.
For NFSv4, I'm not sure how to do this. I don't understand how connections
are established.
Questions:
What is the most accurate way of counting clients?
Which code accepts and closes TCP sessions for nfsv4?
What happens when an nfsv3 goes away without issuing a umount call?
Thanks,
Bjorn
12 months