November 2022 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Fix ganesha_stats with dbus import
by Name of user not set (GerritHub) 11 Nov '22

11 Nov '22

Attention is currently required from: Malahal. Hello Malahal, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545999 to review the following change. Change subject: Fix ganesha_stats with dbus import ...................................................................... Fix ganesha_stats with dbus import commit bb4ec8dd8 moved the try/except clause and added dbus exception error but didn't import dbus! This caused ganesha_stats to take an exception when ganesha daemon isn't available. Change-Id: I0e49913b40c35a130c07256ce7326c98e4c37560 Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com> (cherry picked from commit fc3a738e21ffb91effaf0aceee9633c69a88500a) --- M src/scripts/ganeshactl/ganesha_stats.py 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/545999/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545999 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0e49913b40c35a130c07256ce7326c98e4c37560 Gerrit-Change-Number: 545999 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu2(a)gmail.com Gerrit-Reviewer: Malahal <malahal(a)gmail.com> Gerrit-Attention: Malahal <malahal(a)gmail.com> Gerrit-MessageType: newchange

1 0

[L] Change in ...nfs-ganesha[next]: FSAL: Remove old fsal_fd management
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545915 ) Change subject: FSAL: Remove old fsal_fd management ...................................................................... FSAL: Remove old fsal_fd management Change-Id: Iaaf4d5b3ea50aca9a67fdb0a10ac7798a9e11b50 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/commonlib.c M src/MainNFSD/libganesha_nfsd.ver M src/include/FSAL/fsal_commonlib.h 3 files changed, 53 insertions(+), 539 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/545915/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545915 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iaaf4d5b3ea50aca9a67fdb0a10ac7798a9e11b50 Gerrit-Change-Number: 545915 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: LRU: export roots aren't in LRU anymore
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545914 ) Change subject: LRU: export roots aren't in LRU anymore ...................................................................... LRU: export roots aren't in LRU anymore A long term reference is held to keep them out of the LRU so no need to adjust them during reaping. Change-Id: I87ab1d66c0bc44a078edbc99e3cae05c44f9f099 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/include/fsal_api.h 2 files changed, 13 insertions(+), 38 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/545914/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545914 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I87ab1d66c0bc44a078edbc99e3cae05c44f9f099 Gerrit-Change-Number: 545914 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: FSAL: Remove seek method
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545913 ) Change subject: FSAL: Remove seek method ...................................................................... FSAL: Remove seek method For some reason this had not been removed earlier. The seek2 method is now the method used. Change-Id: I599ea83eca7705be9d65eb3231d74878d4b5f79e Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/default_methods.c M src/include/fsal_api.h 2 files changed, 13 insertions(+), 25 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/545913/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545913 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I599ea83eca7705be9d65eb3231d74878d4b5f79e Gerrit-Change-Number: 545913 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: 9P: Check file open mode for locks
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545912 ) Change subject: 9P: Check file open mode for locks ...................................................................... 9P: Check file open mode for locks Change-Id: If810a9625e2db9f0e9322c56b227cb247cfb053e Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/9P/9p_lock.c 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/545912/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545912 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If810a9625e2db9f0e9322c56b227cb247cfb053e Gerrit-Change-Number: 545912 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: nfs4_op_write.c - fix annoying typo
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545911 ) Change subject: nfs4_op_write.c - fix annoying typo ...................................................................... nfs4_op_write.c - fix annoying typo Change-Id: I01214673a6687d0471d8601327dfd302493f476d Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_op_write.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/545911/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545911 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I01214673a6687d0471d8601327dfd302493f476d Gerrit-Change-Number: 545911 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[L] Change in ...nfs-ganesha[next]: FSAL_MEM: Comvert to new fsal_fd handling and new async I/O
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545910 ) Change subject: FSAL_MEM: Comvert to new fsal_fd handling and new async I/O ...................................................................... FSAL_MEM: Comvert to new fsal_fd handling and new async I/O Change-Id: I0ba4f5a0d19a3f57110d40edca672ea5240d48e4 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_MEM/mem_handle.c 1 file changed, 238 insertions(+), 106 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/545910/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545910 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0ba4f5a0d19a3f57110d40edca672ea5240d48e4 Gerrit-Change-Number: 545910 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: FSAL_MEM: Remove non-functional lock_op2
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545909 ) Change subject: FSAL_MEM: Remove non-functional lock_op2 ...................................................................... FSAL_MEM: Remove non-functional lock_op2 FSAL_MEM will actually work better without, then state_lock.c manages all the lock stuff in memory, which is exactly what we want. Change-Id: If715bcb3d5f3a85f9fa136e4c55a390ebff228bc Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_MEM/mem_main.c 2 files changed, 14 insertions(+), 79 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/545909/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545909 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If715bcb3d5f3a85f9fa136e4c55a390ebff228bc Gerrit-Change-Number: 545909 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[L] Change in ...nfs-ganesha[next]: MDCACHE: Strip out old fd management
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545908 ) Change subject: MDCACHE: Strip out old fd management ...................................................................... MDCACHE: Strip out old fd management Change-Id: Ie89579857207afbcccea0b02a749d171f95c0e11 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/commonlib.c M src/include/fsal.h M src/include/fsal_types.h M src/include/mdcache.h 8 files changed, 124 insertions(+), 467 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/545908/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545908 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie89579857207afbcccea0b02a749d171f95c0e11 Gerrit-Change-Number: 545908 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: Use long term references at the protocol layer
by Frank Filz (GerritHub) 08 Nov '22

08 Nov '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545907 ) Change subject: Use long term references at the protocol layer ...................................................................... Use long term references at the protocol layer By taking a long term reference any time we will hold a reference for long term such as state (locks etc.) and special export entries, we remove those entries from the LRU which opens up the LRU for more effective reaping. Change-Id: Iee5e2b1504657e5fbc7ca46f5e04e170fb02a64f Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/9P/9p_lcreate.c M src/Protocols/9P/9p_lopen.c M src/Protocols/9P/9p_proto_tools.c M src/Protocols/9P/9p_remove.c M src/Protocols/NFS/nfs4_pseudo.c M src/SAL/nfs4_state.c M src/SAL/nlm_state.c M src/support/exports.c 8 files changed, 71 insertions(+), 33 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/545907/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/545907 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iee5e2b1504657e5fbc7ca46f5e04e170fb02a64f Gerrit-Change-Number: 545907 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0