[S] Change in ...nfs-ganesha[next]: state_del could set state->state_export to NULL Check and prevent for...
by Gaurav (GerritHub)
Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539537 )
Change subject: state_del could set state->state_export to NULL Check and prevent for delete state while accessing it. state_mutex should be destroyed by dec_state_t_ref, so should be valid even after state_del.
......................................................................
state_del could set state->state_export to NULL
Check and prevent for delete state while accessing it.
state_mutex should be destroyed by dec_state_t_ref,
so should be valid even after state_del.
Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar(a)nutanix.com>
Change-Id: I549855f5b281d8b1b9a8d839b0ee7be268a6bc8c
---
M src/SAL/nfs4_state.c
1 file changed, 20 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/539537/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539537
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I549855f5b281d8b1b9a8d839b0ee7be268a6bc8c
Gerrit-Change-Number: 539537
Gerrit-PatchSet: 1
Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com>
Gerrit-MessageType: newchange
2 years, 6 months
[S] Change in ...nfs-ganesha[next]: config: add comment for PrefRead/PrefWrite
by vicente (GerritHub)
vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539461 )
Change subject: config: add comment for PrefRead/PrefWrite
......................................................................
config: add comment for PrefRead/PrefWrite
- To tip users to know that the modern size of
PrefRead/PrefWrite may cause older nfs client
to get some errors.
Change-Id: I6e026fa766c3a91cd1d33af3ac263ce91be2729d
Signed-off-by: Vicente Cheng <freeze.bilsted(a)gmail.com>
---
M src/config_samples/config.txt
1 file changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/539461/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539461
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I6e026fa766c3a91cd1d33af3ac263ce91be2729d
Gerrit-Change-Number: 539461
Gerrit-PatchSet: 1
Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com>
Gerrit-MessageType: newchange
2 years, 6 months
Trying to wrap up Ganresha V4.1 this week
by Frank Filz
I would like to do a final merge for Ganesha V4.1 this week. We have quite a
number of patches ready to merge or real close.
Please peruse this list:
https://review.gerrithub.io/q/status:open+project:%255E.*nfs-ganesha.*+branc
h:next+repo:ffilz/nfs-ganesha
Any patches that have not been updated as of June 2nd or later are not under
consideration.
Any other patches that don't have a +2 vote (and especially those with
unresolved comments or -1 votes) should be addressed so they can be resolved
and be ready for merge by Friday.
Thanks
Frank Filz
2 years, 6 months
[S] Change in ...nfs-ganesha[next]: Add a configuration parameter for NFSv3 proxy to disabled lookup opti...
by Lior Suliman (GerritHub)
Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539341 )
Change subject: Add a configuration parameter for NFSv3 proxy to disabled lookup optimization for CWD and CWD parent
......................................................................
Add a configuration parameter for NFSv3 proxy to disabled lookup optimization for CWD and CWD parent
Change-Id: Idce1631af7c2fd0d6205480fccb778d0cca1bf6c
Signed-off-by: Lior Suliman <liorsu(a)google.com>
---
M src/FSAL/FSAL_PROXY_V3/main.c
M src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h
M src/doc/man/ganesha-proxy-v3-config.rst
3 files changed, 27 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/41/539341/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539341
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Idce1631af7c2fd0d6205480fccb778d0cca1bf6c
Gerrit-Change-Number: 539341
Gerrit-PatchSet: 1
Gerrit-Owner: Lior Suliman <liorsu(a)gmail.com>
Gerrit-MessageType: newchange
2 years, 6 months
[S] Change in ...nfs-ganesha[next]: Add conf param whether to call getattrs after completing read
by Assaf Yaari (GerritHub)
Assaf Yaari has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539321 )
Change subject: Add conf param whether to call getattrs after completing read
......................................................................
Add conf param whether to call getattrs after completing read
The reason for the aditional getattrs is to verify to correctness of the
EOF flag which is important mainly for ESXi clients.
Yet, this extra call adds some latency for the entire NFSv4 READ
handling.
Change-Id: I7405bd8062ef92fc8b6a70c81c481c0d880279fc
Signed-off-by: Assaf Yaari <assafy(a)google.com>
---
M src/Protocols/NFS/nfs4_op_read.c
M src/doc/man/ganesha-core-config.rst
M src/include/gsh_config.h
M src/support/nfs_read_conf.c
4 files changed, 27 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/539321/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539321
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I7405bd8062ef92fc8b6a70c81c481c0d880279fc
Gerrit-Change-Number: 539321
Gerrit-PatchSet: 1
Gerrit-Owner: Assaf Yaari <assafy(a)google.com>
Gerrit-MessageType: newchange
2 years, 6 months
Invalidating Ganesha MDCACHE attr entry from spawned off thread triggered by my FSAL
by David Rieber
I am working on a VFS project, using Ganesha. We have our own FSAL module and export, and we are using Ganesha's MDCACHE. In some scenarios a file is modified remotely, not via the NFS front door. Our server already has support for noticing this. When something like this happens we must invalidate cache entries. The plan to invalidate the kernel attr cache is to do an open(2) syscall immediately followed by close(2) syscall in a background thread. But that's not enough: before we do that we must invalidate Ganesha's MDCACHE.
For invalidating the MDCACHE entry I think I need to use the invalidate "up call" (https://github.com/phdeniel/nfs-ganesha/blob/master/src/include/fsal_up.h) provided via the fsal_up_vector.
1) Am I going in the right direction? Any advice/gotchas to keep an eye on?
2) Maybe the update up call is better.
3) Maybe I should use up_async_invalidate (or up_async_update).
Thanks!
2 years, 6 months