September 2022 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Help needed on FD
by Alok Sinha 31 Jan '24

31 Jan '24

FD created at below path does not have correct link in /proc/self/fd. With vfs_readlink_by_handle , I can get a relative path but cannot get the absolute path of the FD. I need a suggestion for one of the below to get around a production bug: - How to get the full path of the FD? - How to get the parent vfs_fsal_obj_handle? - Anyway to bypass this flow by changing any config file? #0 vfs_create_handle (exp_hdl=0x55801aca22c0, hdl_desc=0x7f93889b1600, handle=0x7f93889b13f8, attrs_out=0x7f93889b1430) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/FSAL_VFS/handle.c:2020 #1 0x00007f94a1f0e13b in mdcache_locate_host (fh_desc=0x7f93889b1600, export=0x55801aca1f20, entry=0x7f93889b1578, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:1109 #2 0x00007f94a1f02455 in mdcache_create_handle (exp_hdl=0x55801aca1f20, fh_desc=0x7f93889b1600, handle=0x7f93889b15d8, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1613 #3 0x00007f94a1ec5ead in nfs4_mds_putfh (data=0x7f93201119e0) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:211 #4 0x00007f94a1ec60d3 in nfs4_op_putfh (op=0x7f93201186d0, data=0x7f93201119e0, resp=0x7f932010ab20) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:281 #5 0x00007f94a1ea96ae in process_one_op (data=0x7f93201119e0, status=0x7f93889b1b48) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:920 #6 0x00007f94a1eaa8c5 in nfs4_Compound (arg=0x7f9320138d78, req=0x7f93201385a0, res=0x7f9320106840) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:1329 #7 0x00007f94a1de8567 in nfs_rpc_process_request (reqdata=0x7f93201385a0) ---Type <return> to continue, or q <return> to quit--- at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1484 #8 0x00007f94a1de8854 in nfs_rpc_valid_NFS (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1591 #9 0x00007f94a13b6faf in svc_vc_decode (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:829 #10 0x00007f94a13b3225 in svc_request (xprt=0x7f9320000ce0, xdrs=0x7f9320066260) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:793 #11 0x00007f94a13b6ec0 in svc_vc_recv (xprt=0x7f9320000ce0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:802 #12 0x00007f94a13b31a5 in svc_rqst_xprt_task (wpe=0x7f9320000f00) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:774 #13 0x00007f94a13bcab0 in work_pool_thread (arg=0x7f9218003340) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/work_pool.c:184 #14 0x00007f94a1badea5 in start_thread () from /lib64/libpthread.so.0 #15 0x00007f94a16ce9fd in clone () from /lib64/libc.so.6 -- Alok Sinha www.spillbox.io https://youtu.be/U-YupjLQ9bU

2 2

[S] Change in ...nfs-ganesha[next]: Replace malloc with gsh_malloc
by Frank Filz (GerritHub) 21 Sep '22

21 Sep '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/543749 ) Change subject: Replace malloc with gsh_malloc ...................................................................... Replace malloc with gsh_malloc Two instances of malloc crept into the code. Replace them with gsh_malloc for consistency. Change-Id: I5a914f49513495062334c66cb8cb5f7be7d45546 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_LIZARDFS/lzfs_internal.c M src/idmapper/idmapper_cache.c 2 files changed, 23 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/543749/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/543749 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5a914f49513495062334c66cb8cb5f7be7d45546 Gerrit-Change-Number: 543749 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: ACLs: Make nfs4_acl_release_entry void
by Frank Filz (GerritHub) 21 Sep '22

21 Sep '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/543748 ) Change subject: ACLs: Make nfs4_acl_release_entry void ...................................................................... ACLs: Make nfs4_acl_release_entry void No one does anything with the return other than print a redundanct log message and two places ignored the return. Change-Id: If017416565e73c34d087a784e74e247fcad76e11 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_GLUSTER/gluster_internal.c M src/FSAL/FSAL_GPFS/fsal_convert.c M src/FSAL/FSAL_LIZARDFS/lzfs_acl.c M src/FSAL/FSAL_VFS/vfs/attrs.c M src/FSAL/commonlib.c M src/include/fsal.h M src/include/nfs4_acls.h M src/support/nfs4_acls.c 8 files changed, 29 insertions(+), 71 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/543748/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/543748 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If017416565e73c34d087a784e74e247fcad76e11 Gerrit-Change-Number: 543748 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Upgrading to Ganesha 4.0.0
by Krishna Harathi 21 Sep '22

21 Sep '22

Frank, We are planning to upgrade from using Ganesha 2.5.4 to 4.0.0 in the coming few weeks. Is there any new release coming up very soon? Any other comment on the latest release is appreciated. Thanks. Regards. Krishna Harathi _____________________________________________________________________________________________________________ [cid:arcserve-email-logo_566d469b-c8dc-46eb-909b-300e3f3e47a1.jpg]<https://arcserve.com/> Krishna Harathi | Senior Manager - Engineering Office: 503.475.5279 | Mobile: 503.475.5279 | krishna.harathi(a)arcserve.com arcserve.com<https://www.arcserve.com/> | Twitter<https://twitter.com/Arcserve> | LinkedIn<https://www.linkedin.com/company/arcserve/> | YouTube<https://www.youtube.com/user/arcserve> _____________________________________________________________________________________________________________ If you are not the intended recipient of this message or received it erroneously, please notify the sender and delete it, together with any attachments, and be advised that any dissemination or copying of this message is prohibited.

2 2

Announce Push of V4.0.9
by Frank Filz 19 Sep '22

19 Sep '22

Branch next Tag:V4.0.9 Merge Highlights * Fix several refcount issues with state * A variety of build issues * VFS: POSIX ACLs (disabled by default) * Fix bug in NFSv4.1 slot cache * RCU: Use after free issue for gsh_refstr reported by address_sanitizer * NSM: Compare bytes for ipv4 similar to ipv6. * FSAL_MDCACHE: avoid redundant QLOCK acquiring * Init NFS3 lookup name before logging Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: f59e00f47 Frank S. Filz V4.0.9 5eada8d4d Dimitri Savineau spec: Enable building RPM with tcmalloc 252165496 Gaurav Gangalwar RCU: Use after free issue for gsh_refstr reported by address_sanitizer 0f7bf98d4 Gaurav Gangalwar NSM: Compare bytes for ipv4 similar to ipv6. a17c38f07 Dimitri Savineau spec: remove duplicate flex in buildrequires 5f06bd1c4 liyinshu Fix crash bcz slot->cached_result is null for replay request 29b552d76 Vicente Cheng FSAL_MDCACHE: avoid redundant QLOCK acquiring 3e10dfd23 liyinshu Fix crash at glist_del state_sharelist 6cfa3699c Jonas Windmüller Init NFS3 lookup name before logging a9218666d Martin Schwenke FSAL_VFS: Implement NFSv4 to POSIX ACL mapping 7f01fb9de Martin Schwenke build: Add ENABLE_VFS_POSIX_ACL d1601caa7 Martin Schwenke FSAL_VFS: Put debug ACL code under a single #if defined() c77638968 Martin Schwenke FSAL_VFS: Fix comment typo 8aafe80ab Martin Schwenke build: Add ENABLE_VFS_ACL 150d1393e Martin Schwenke os: Implement Linux replacements for POSIX ACL FD get/set functions d8b64abad Martin Schwenke build: Add checks for POSIX ACL FD get/set extensions 2e0f94234 Martin Schwenke build: Rework libacl detection d3161c538 Frank S. Filz STATE: Remove extraneous put_ref for lock_list empty 4ae547e94 Frank S. Filz STATE: remove extraneous put_ref from state_nlm_notify ebb82046a Frank S. Filz STATE: When we have a grant cookie we need an obj reference 67e9d2349 Frank S. Filz STATE: Fix blocked lock lock_entry refcount (github issue 824) 3fcf16535 Frank S. Filz Remove state_exp from state_t beb69df05 Ross Burton Install fsalmem as a module 40ddf216e Paulo Neves Correct shebang for install_git_hooks

1 0

No merge today
by Frank Filz 17 Sep '22

17 Sep '22

I ran into a problem, a patch from the huge list is causing pynfs to break. I ran out of time to narrow down which patch it is, so I will continue on Monday and once I've eliminated the bad patch, I will push out V4.0.9. I hope next Friday will be the final merge for V4.1. For that, I think we may have an ntirpc update also? Thanks for your patience Frank

1 0

Let's wrap up Ganesha V4.1
by Frank Filz 15 Sep '22

15 Sep '22

I'd like to wrap up Ganesha V4.1, possibly this week. Everyone please look over the Ganesha patches here: https://review.gerrithub.io/q/status:open+project:%255E.*nfs-ganesha.*+branc h:next+repo:ffilz/nfs-ganesha And let me know if there are any that don't have a +2 that you believe really should go into V4.1 and then we will work on getting those patches reviewed and ready for merge. If that can happen this week, that would be great, otherwise, let's shoot for next week. Then after that, I can fork V4-stable and start merging some of the feature stuff into V5-dev. Thanks Frank Filz

3 4

[S] Change in ...nfs-ganesha[next]: FSAL_VFS: Enable NFSv4 to POSIX ACL mapping
by Martin Schwenke (GerritHub) 15 Sep '22

15 Sep '22

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/543537 ) Change subject: FSAL_VFS: Enable NFSv4 to POSIX ACL mapping ...................................................................... FSAL_VFS: Enable NFSv4 to POSIX ACL mapping ENABLE_VFS_POSIX_ACL is now ON by default, so this will be built when possible. Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: Iffc9d6145435cd09cf096ca0d208fe508ff608b3 --- M src/CMakeLists.txt 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/543537/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/543537 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iffc9d6145435cd09cf096ca0d208fe508ff608b3 Gerrit-Change-Number: 543537 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: FSAL_RGW: make sure the `Dir_Chunk` should be enabled
by vicente (GerritHub) 15 Sep '22

15 Sep '22

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/543495 ) Change subject: FSAL_RGW: make sure the `Dir_Chunk` should be enabled ...................................................................... FSAL_RGW: make sure the `Dir_Chunk` should be enabled - For FSAL_RGW, the `Dir_Chunk` is mandatory. That is because FSAL_RGW needs `Dir_Chunk` to make the readdir cookie works well. Change-Id: Ia8b46c536a8c1e7a0acfdc53ef176309e5a70638 Signed-off-by: Vicente Cheng <vicente.cheng(a)suse.com> --- M src/FSAL/FSAL_RGW/main.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/543495/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/543495 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia8b46c536a8c1e7a0acfdc53ef176309e5a70638 Gerrit-Change-Number: 543495 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com> Gerrit-MessageType: newchange

1 0