Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 )
Change subject: Allow EXPORT pseudo path to be changed during export update
......................................................................
Allow EXPORT pseudo path to be changed during export update
This also fully allows adding or removing NFSv4 support from an export
since we can now handle the PseudoFS swizzing that occurs.
Note that an explicit PseudoFS export may be removed or added, though
you can not change it from export_id 0 because we currently don't allow
changing the export_id.
Note that this patch doesn't handle DBUS add or remove export though
that is an option to improve. I may add them to this patch (it wouldn't
be that hard) but I want to get this reviewed as is right now.
There are implications to a client of changing the PseudoFS. I have
tested moving an export in the PseudoFS with a client mounted. The
client will be able to continue accessing the export, though it may
see an ESTALE error if it navigates out of the export. The current
working directory will go bad and the pwd comment will fail indicating
a disconnected mount. I have also seen referencing .. from the root of
the export wrapping around back to the root (I believe this is how
disconnected mounts are set up).
FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3
handle where the inode isn't cached) which fail during an export update
are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or
NFS3ERR_JUKEBOX to force the client to retry under the completed update.
Change-Id: I507dc17a651936936de82303ff1291677ce136be
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/FSAL_PSEUDO/handle.c
M src/MainNFSD/libganesha_nfsd.ver
M src/Protocols/NFS/nfs4_pseudo.c
M src/include/export_mgr.h
M src/include/nfs_proto_functions.h
M src/support/export_mgr.c
M src/support/exports.c
7 files changed, 560 insertions(+), 203 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be
Gerrit-Change-Number: 490334
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
10 months
Help needed on FD
by Alok Sinha
FD created at below path does not have correct link in /proc/self/fd.
With vfs_readlink_by_handle , I can get a relative path but cannot get the
absolute path of the FD.
I need a suggestion for one of the below to get around a production bug:
- How to get the full path of the FD?
- How to get the parent vfs_fsal_obj_handle?
- Anyway to bypass this flow by changing any config file?
#0 vfs_create_handle (exp_hdl=0x55801aca22c0, hdl_desc=0x7f93889b1600,
handle=0x7f93889b13f8, attrs_out=0x7f93889b1430)
at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/FSAL_VFS/handle.c:2020
#1 0x00007f94a1f0e13b in mdcache_locate_host (fh_desc=0x7f93889b1600,
export=0x55801aca1f20, entry=0x7f93889b1578, attrs_out=0x0)
at
/home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:1109
#2 0x00007f94a1f02455 in mdcache_create_handle (exp_hdl=0x55801aca1f20,
fh_desc=0x7f93889b1600, handle=0x7f93889b15d8, attrs_out=0x0)
at
/home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1613
#3 0x00007f94a1ec5ead in nfs4_mds_putfh (data=0x7f93201119e0)
at
/home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:211
#4 0x00007f94a1ec60d3 in nfs4_op_putfh (op=0x7f93201186d0,
data=0x7f93201119e0, resp=0x7f932010ab20)
at
/home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:281
#5 0x00007f94a1ea96ae in process_one_op (data=0x7f93201119e0,
status=0x7f93889b1b48)
at
/home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:920
#6 0x00007f94a1eaa8c5 in nfs4_Compound (arg=0x7f9320138d78,
req=0x7f93201385a0, res=0x7f9320106840)
at
/home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:1329
#7 0x00007f94a1de8567 in nfs_rpc_process_request (reqdata=0x7f93201385a0)
---Type <return> to continue, or q <return> to quit---
at
/home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1484
#8 0x00007f94a1de8854 in nfs_rpc_valid_NFS (req=0x7f93201385a0)
at
/home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1591
#9 0x00007f94a13b6faf in svc_vc_decode (req=0x7f93201385a0)
at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:829
#10 0x00007f94a13b3225 in svc_request (xprt=0x7f9320000ce0,
xdrs=0x7f9320066260)
at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:793
#11 0x00007f94a13b6ec0 in svc_vc_recv (xprt=0x7f9320000ce0)
at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:802
#12 0x00007f94a13b31a5 in svc_rqst_xprt_task (wpe=0x7f9320000f00)
at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:774
#13 0x00007f94a13bcab0 in work_pool_thread (arg=0x7f9218003340)
at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/work_pool.c:184
#14 0x00007f94a1badea5 in start_thread () from /lib64/libpthread.so.0
#15 0x00007f94a16ce9fd in clone () from /lib64/libc.so.6
--
Alok Sinha
www.spillbox.io
https://youtu.be/U-YupjLQ9bU
10 months, 3 weeks
V5 is open now, but no merge this week - review needed - please step up
by Frank Filz
Now that I have tagged V4.3, I'm prepared to fork V4-stable branch and start
V5-dev patches however, only one patch looks like it's actually ready to go.
A number of patches don't have much in the way of review, others have
unresolved comments.
Please review look over all the patches in the following query and please
check out those that don't have a +1 and those that have unresolved
comments.
I know I actually have to finish some work on HA Proxy, and my other big
patch set (async and LRU) may have some unresolved comments (plus the cephfs
non-blocking I/O in support of ceph async has some work to do - though I
don't plan on delaying the Ganesha patches to wait for the cepfs pull
request to merge).
Thanks
Frank
1 year, 10 months
Announce Push of V4.3
by Frank Filz
Branch next
Tag:V4.3
NOTE: This release includes an ntirpc pullup. Please update your submodule.
Merge Highlights
* Add to set server owner in conf file
* Pullup ntirpc to v4.3
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
5e14815e5 Frank S. Filz V4.3
8fdf6e543 Daniel Gryniewicz Pullup ntirpc to v4.3
88ddb5276 Shahar Hochma Add to set server owner in conf file
1 year, 11 months
[S] Change in ...nfs-ganesha[next]: Add to set server owner in conf file
by Name of user not set (GerritHub)
shaharhoch(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548561 )
Change subject: Add to set server owner in conf file
......................................................................
Add to set server owner in conf file
Change-Id: Ie605b41ad13c54525d8dbe8509aea9985ffb9692
Signed-off-by: Shahar Hochma <shaharhoch(a)gmail.com>
---
M src/Protocols/NFS/nfs4_op_exchange_id.c
M src/doc/man/ganesha-core-config.rst
M src/include/gsh_config.h
M src/support/nfs_read_conf.c
4 files changed, 42 insertions(+), 6 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/548561/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548561
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie605b41ad13c54525d8dbe8509aea9985ffb9692
Gerrit-Change-Number: 548561
Gerrit-PatchSet: 1
Gerrit-Owner: shaharhoch(a)gmail.com
Gerrit-MessageType: newchange
1 year, 11 months
[S] Change in ...nfs-ganesha[next]: Add to set server owner in conf file
by Name of user not set (GerritHub)
shaharhoch(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548551 )
Change subject: Add to set server owner in conf file
......................................................................
Add to set server owner in conf file
Change-Id: I2c6e4f8474dc5858f5c438d226b8c8c93f8a4fab
Signed-off-by: Shahar Hochma <shaharhoch(a)gmail.com>
---
M src/Protocols/NFS/nfs4_op_exchange_id.c
M src/doc/man/ganesha-core-config.rst
M src/include/gsh_config.h
M src/support/nfs_read_conf.c
4 files changed, 37 insertions(+), 6 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/548551/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548551
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2c6e4f8474dc5858f5c438d226b8c8c93f8a4fab
Gerrit-Change-Number: 548551
Gerrit-PatchSet: 1
Gerrit-Owner: shaharhoch(a)gmail.com
Gerrit-MessageType: newchange
1 year, 11 months
[S] Change in ...nfs-ganesha[next]: If lru_chunks_used > lru_chunks_hiwat*4 skip MDCache on readdir.
by Sagar Singh (GerritHub)
Sagar Singh has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548423 )
Change subject: If lru_chunks_used > lru_chunks_hiwat*4 skip MDCache on readdir.
......................................................................
If lru_chunks_used > lru_chunks_hiwat*4 skip MDCache on readdir.
Seen the chunks used go very high in number, during heavy load.
Which increases the mdcache size.
Change-Id: I2485bb64675116b5e10e60d0ecf9211658104939
Signed-off-by: Sagar Singh <sagar.it.iiests(a)gmail.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/548423/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548423
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2485bb64675116b5e10e60d0ecf9211658104939
Gerrit-Change-Number: 548423
Gerrit-PatchSet: 1
Gerrit-Owner: Sagar Singh <sagar.it.iiests(a)gmail.com>
Gerrit-MessageType: newchange
1 year, 11 months
Announce Push of V4.2.3
by Frank Filz
Branch next
Tag:V4.2.3
Merge Highlights
* FSAL filesystem - Fix problems with multiple claims and private_data
* Fix crash for used after free when replay request
* Fix race between nfs_rpc_call and nfs_rpc_call_process(callback).
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
cb2c8e3a2 Frank S. Filz V4.2.3
e564a2404 Sagar Singh Fix race between nfs_rpc_call and
nfs_rpc_call_process(callback).
0000b9865 liyinshu Fix crash for used after free when replay request
d5667c880 Frank S. Filz FSAL filesystem - Fix problems with multiple claims
and private_data
1 year, 11 months
[M] Change in ...nfs-ganesha[next]: WIP - Add support for HA Proxy - NOTE - NEEDS NTIRPC PULLUP
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548334 )
Change subject: WIP - Add support for HA Proxy - NOTE - NEEDS NTIRPC PULLUP
......................................................................
WIP - Add support for HA Proxy - NOTE - NEEDS NTIRPC PULLUP
Change-Id: Ie6dfea600f578f6643ca7c87b8591d53cf30d73e
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/MainNFSD/nfs_init.c
M src/MainNFSD/nfs_worker_thread.c
M src/config_samples/config.txt
M src/doc/man/ganesha-core-config.rst
M src/include/client_mgr.h
M src/include/gsh_config.h
M src/support/client_mgr.c
M src/support/nfs_read_conf.c
8 files changed, 116 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/548334/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/548334
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie6dfea600f578f6643ca7c87b8591d53cf30d73e
Gerrit-Change-Number: 548334
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
Gerrit-MessageType: newchange
1 year, 11 months
