November 2023 - Devel - NFS Ganesha List Archives

[L] Change in ...nfs-ganesha[next]: svc_xprt: Maintain mapping between nfs41_session and connection
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172198?usp=email ) Change subject: svc_xprt: Maintain mapping between nfs41_session and connection ...................................................................... svc_xprt: Maintain mapping between nfs41_session and connection Each client session is associated with one or more connections. These connections at the server are associated with either forechannel or backchannel communication with the client. When a connection is destroyed, we need a way to identify the sessions that are associated with that connection. These sessions then need to be dereferenced, their corresponding backchannel and forechannel need to be destroyed and later updated. Similarly, when a session is destroyed, we need a way to identify the connections (svc-xprt objects) associated with that session. These connections then need to be dereferenced, their session-references need to be released. This commit introduces the above session references onto the connection (svc-xprt object) and vice versa. A new xprt-handler file is added, which exposes the required functions to handle the lifecycle of the updated transport object. Change-Id: Iba121c05ff4b03d735851751b1977876b3280ffd Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/Protocols/NFS/nfs4_op_create_session.c M src/Protocols/NFS/nfs4_op_destroy_session.c M src/SAL/nfs41_session_id.c M src/SAL/nfs4_clientid.c M src/include/sal_data.h M src/include/sal_functions.h A src/include/xprt_handler.h M src/support/CMakeLists.txt A src/support/xprt_handler.c 10 files changed, 304 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/1172198/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172198?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iba121c05ff4b03d735851751b1977876b3280ffd Gerrit-Change-Number: 1172198 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: bind_conn_to_session: Fix backchannel implementation
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172197?usp=email ) Change subject: bind_conn_to_session: Fix backchannel implementation ...................................................................... bind_conn_to_session: Fix backchannel implementation Currently, BIND_CONN_TO_SESSION op does not validate or create backchannel. This commit fixes that. Note that Ganesha only supports SP4_NONE state protection mechanism currently. Therefore, backchannel creation support has been enabled only when SP4_NONE is used. Change-Id: Id60e929d8c36716533a96337c7953bc9fab7e783 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_rpc_callback.c M src/Protocols/NFS/nfs4_op_bind_conn.c 2 files changed, 94 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1172197/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id60e929d8c36716533a96337c7953bc9fab7e783 Gerrit-Change-Number: 1172197 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: nfs41_session: Store security params for backchannel creation
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172196?usp=email ) Change subject: nfs41_session: Store security params for backchannel creation ...................................................................... nfs41_session: Store security params for backchannel creation Currently Ganesha creates backchannel only at the time of session creation. If backchannel is required to be re-created later for a pre-created session, the session needs to store the security params that are required to create the backchannel. Change-Id: I8c2ae810f51a164ad6fa89818ea7d64534735710 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/Protocols/NFS/nfs4_op_create_session.c M src/SAL/nfs41_session_id.c M src/include/sal_data.h 3 files changed, 101 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/1172196/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172196?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8c2ae810f51a164ad6fa89818ea7d64534735710 Gerrit-Change-Number: 1172196 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: nfs_client_id: Store state protection mechanism for the client
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172195?usp=email ) Change subject: nfs_client_id: Store state protection mechanism for the client ...................................................................... nfs_client_id: Store state protection mechanism for the client Currently Ganesha always uses SP4_NONE state protection for the client irrespective of what the client requests. This commit does not change that behavior. It only saves the state protection mechanism as part of the nfs-client structure. The value of the mechanism will be used by the server while processing nfs ops like BIND_CONN_TO_SESSION. Change-Id: I2d1c18595bad954865659f4413ca449addbb70ab Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/Protocols/NFS/nfs4_op_exchange_id.c M src/include/sal_data.h 2 files changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1172195/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172195?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2d1c18595bad954865659f4413ca449addbb70ab Gerrit-Change-Number: 1172195 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in ...nfs-ganesha[next]: fix(nfs4.1 EXCHANGE_ID): decrement ref count of confirmed client_id
by Zhitao Li (GerritHub) 14 Nov '23

14 Nov '23

Zhitao Li has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172192?usp=email ) Change subject: fix(nfs4.1 EXCHANGE_ID): decrement ref count of confirmed client_id ...................................................................... fix(nfs4.1 EXCHANGE_ID): decrement ref count of confirmed client_id Fix issue: https://github.com/nfs-ganesha/nfs-ganesha/issues/1030 Change-Id: Ia2ba4fccf9926e42b7fdbef8cb84e2984ea4c54f Signed-off-by: zhitaoli <zhitao.li(a)iomesh.com> --- M src/Protocols/NFS/nfs4_op_exchange_id.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/92/1172192/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172192?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia2ba4fccf9926e42b7fdbef8cb84e2984ea4c54f Gerrit-Change-Number: 1172192 Gerrit-PatchSet: 1 Gerrit-Owner: Zhitao Li <zhitao.li(a)iomesh.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: nfsv41_callback: Do not create backchannel for an under-destruction xprt
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172166?usp=email ) Change subject: nfsv41_callback: Do not create backchannel for an under-destruction xprt ...................................................................... nfsv41_callback: Do not create backchannel for an under-destruction xprt Change-Id: I46ce8e94649d8fcd03000c058d6c24aafb0b2984 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/1172166/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172166?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I46ce8e94649d8fcd03000c058d6c24aafb0b2984 Gerrit-Change-Number: 1172166 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: xprt_handler: Do not associate a session with an under-destruction xprt
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172165?usp=email ) Change subject: xprt_handler: Do not associate a session with an under-destruction xprt ...................................................................... xprt_handler: Do not associate a session with an under-destruction xprt Change-Id: If2bc27ae3c4934fffd4898bed6c154edbbd188ff Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/xprt_handler.c 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/1172165/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172165?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If2bc27ae3c4934fffd4898bed6c154edbbd188ff Gerrit-Change-Number: 1172165 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: nfs_tcp_dispatch: Register callback to un-reference user-data during ...
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172164?usp=email ) Change subject: nfs_tcp_dispatch: Register callback to un-reference user-data during xprt destroy ...................................................................... nfs_tcp_dispatch: Register callback to un-reference user-data during xprt destroy When destroying a tcp transport (svc-xprt), the references (to and from it) held through the transport's user-data need to be released. Such unreleased references to the transport object would otherwise not allow it to be completely destroyed, resulting in leakage. Additionally, the unreleased references to other data held by this transport object would prevent that data to correctly use the transport due to it being under-destruction. This CL registers a callback function with ntirpc for tcp transport to perform the above un-referencing whenever a tcp transport object is to be destroyed. Change-Id: Ie1ab0415f98030b75feead7ac4b261eb996f43e7 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/MainNFSD/nfs_rpc_dispatcher_thread.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/64/1172164/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie1ab0415f98030b75feead7ac4b261eb996f43e7 Gerrit-Change-Number: 1172164 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: xprt_handler: Add function to un-reference xprt client-data
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172163?usp=email ) Change subject: xprt_handler: Add function to un-reference xprt client-data ...................................................................... xprt_handler: Add function to un-reference xprt client-data When destroying a xprt, all its outstanding references must be released. Additionally, the references of external objects held by the xprt must also be released. This CL adds a function that performs this processing. Change-Id: I0daa268122aa98df860c3736842082476034d313 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/include/xprt_handler.h M src/support/xprt_handler.c 2 files changed, 116 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1172163/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172163?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0daa268122aa98df860c3736842082476034d313 Gerrit-Change-Number: 1172163 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: xprt_handler: Add function to destroy the session backchannel for a xprt
by Dipit Grover (GerritHub) 14 Nov '23

14 Nov '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172162?usp=email ) Change subject: xprt_handler: Add function to destroy the session backchannel for a xprt ...................................................................... xprt_handler: Add function to destroy the session backchannel for a xprt Given a xprt and a session, this CL adds a function to destroy the session's backchannel if it uses the xprt. When destroying a xprt, this function would be called to release the xprt's reference held by the session backchannels. Change-Id: I1788f3e681abd5608a824b17a10c99411b8ddaab Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/support/xprt_handler.c 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/62/1172162/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172162?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1788f3e681abd5608a824b17a10c99411b8ddaab Gerrit-Change-Number: 1172162 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-MessageType: newchange

1 0