April 2023 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: RFC - please comment - enable POSIX ACL on Ceph
by Frank Filz (GerritHub) 06 Apr '23

06 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552330 ) Change subject: RFC - please comment - enable POSIX ACL on Ceph ...................................................................... RFC - please comment - enable POSIX ACL on Ceph Per github issue #797 https://github.com/nfs-ganesha/nfs-ganesha/issues/797 Ceph doesn't automatically enable POSIX ACL. This patch is derived from the proposed fix in the github issue. I'm not sure this is right, but this seems the best way to open discussion. Change-Id: I892c94830d9986318cf905227c750201f5d01dc4 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/main.c 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/552330/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552330 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I892c94830d9986318cf905227c750201f5d01dc4 Gerrit-Change-Number: 552330 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Coverity fix repairs in Protocols/XDR
by Frank Filz (GerritHub) 06 Apr '23

06 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552324 ) Change subject: Coverity fix repairs in Protocols/XDR ...................................................................... Coverity fix repairs in Protocols/XDR Fixes to commit c2d2aafb44be6528bbe0cecc38ed66d15cad15dd Unsigned int can't be less than zero, don't check for it... In xdr_posix_acl, a count of zero is valid, so since it's unsigned also, just check for being too large. Change-Id: Idfd9d544ae7c97653a5f98b5e44322e2775bd416 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs_proto_tools.c M src/Protocols/XDR/xdr_nfsacl.c 2 files changed, 20 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/552324/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552324 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idfd9d544ae7c97653a5f98b5e44322e2775bd416 Gerrit-Change-Number: 552324 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: WIP - Fix race with granting blocked locks
by Frank Filz (GerritHub) 05 Apr '23

05 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552280 ) Change subject: WIP - Fix race with granting blocked locks ...................................................................... WIP - Fix race with granting blocked locks This hopefully fixes a problem where a race in granting blocked locks results in the blocked lock being merged into other locks and removed and making sle_owner NULL so the racing grant ends up dereferencing the NULL owner. Change-Id: I91e4be0e48788ca4c79b33e626c0e9ab3e39ce9e Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/state_lock.c 1 file changed, 36 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/552280/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552280 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I91e4be0e48788ca4c79b33e626c0e9ab3e39ce9e Gerrit-Change-Number: 552280 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: Use global mutex and rwlock attributes to set all the same
by Frank Filz (GerritHub) 04 Apr '23

04 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552224 ) Change subject: Use global mutex and rwlock attributes to set all the same ...................................................................... Use global mutex and rwlock attributes to set all the same For Linux we default to: PTHREAD_MUTEX_ADAPTIVE_NP and PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP Change-Id: I3dfcf29521c0b9e2734b8a59372dbe740786a84d Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_MEM/mem_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/commonlib.c M src/FSAL/fsal_manager.c M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_lib.c M src/MainNFSD/nfs_main.c M src/RPCAL/nfs_dupreq.c M src/hashtable/hashtable.c M src/include/common_utils.h M src/include/gsh_wait_queue.h M src/include/nfs_init.h M src/support/client_mgr.c M src/support/ds.c M src/support/export_mgr.c 17 files changed, 80 insertions(+), 104 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/552224/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552224 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3dfcf29521c0b9e2734b8a59372dbe740786a84d Gerrit-Change-Number: 552224 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Replace some LogCrit followed by exit with LogFatal
by Frank Filz (GerritHub) 04 Apr '23

04 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552223 ) Change subject: Replace some LogCrit followed by exit with LogFatal ...................................................................... Replace some LogCrit followed by exit with LogFatal Change-Id: I8c1b1982fb14334e5c15d949716138724a657fcc Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_db.c M src/MainNFSD/nfs_init.c 2 files changed, 14 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/552223/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552223 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8c1b1982fb14334e5c15d949716138724a657fcc Gerrit-Change-Number: 552223 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[XL] Change in ...nfs-ganesha[next]: pthread resources cleanup (mutex, condition, rwlock etc.)
by Frank Filz (GerritHub) 04 Apr '23

04 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552214 ) Change subject: pthread resources cleanup (mutex, condition, rwlock etc.) ...................................................................... pthread resources cleanup (mutex, condition, rwlock etc.) Sorry this is a big one... Unwinding to separate patches after making incremental changes to make sure all the "i"s are dotted and "t"s crossed would be a pain. Normalize so everything uses PTHREAD_MUTEX type macros. Do not use static INITIALIZER (exception, one use in log.h). Make sure everything is initialized. Note that Linxu seems to be OK with NULL/0 initialization. That might not be true for all platforms. Make sure PTHREAD.*_init is matched with PTHREAD.*_destroy. Note that Linux uses no resources so missing destroy doesn't cause leaks. BSD at least does allocate resources so not destroying all objects will result in memory leaks on at least one platform which is not good for portability. Rename a bunch of pthread objects to make auditing easier. No more everyone uses "mxt" and "cv"... Added some sub-system destroy/shutdown functions to handle cleanup. PROXY_V3 and PROXY_V4 are not complete. They require a bit more complex work that deserves to be in a separate patch. Change-Id: I3437014c3e74b562c906c947b976192d81e7594d Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_CEPH/internal.c M src/FSAL/FSAL_GLUSTER/export.c M src/FSAL/FSAL_GLUSTER/gluster_internal.c M src/FSAL/FSAL_GLUSTER/gluster_internal.h M src/FSAL/FSAL_GLUSTER/handle.c M src/FSAL/FSAL_GLUSTER/main.c M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/handle.c M src/FSAL/FSAL_KVSFS/kvsfs_export.c M src/FSAL/FSAL_KVSFS/kvsfs_handle.c M src/FSAL/FSAL_LIZARDFS/export.c M src/FSAL/FSAL_LIZARDFS/handle.c M src/FSAL/FSAL_LIZARDFS/lzfs_internal.c M src/FSAL/FSAL_MEM/mem_export.c M src/FSAL/FSAL_MEM/mem_handle.c M src/FSAL/FSAL_PROXY_V3/rpc.c M src/FSAL/FSAL_PROXY_V4/export.c M src/FSAL/FSAL_PROXY_V4/handle.c M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping_db.c M src/FSAL/FSAL_PROXY_V4/proxyv4_fsal_methods.h M src/FSAL/FSAL_PSEUDO/handle.c M src/FSAL/FSAL_RGW/main.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/FSAL_VFS/handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/commonlib.c M src/FSAL/default_methods.c M src/FSAL/fsal_destroyer.c M src/FSAL/fsal_helper.c M src/FSAL/fsal_manager.c M src/FSAL/localfs.c M src/FSAL_UP/fsal_up_top.c M src/MainNFSD/9p_dispatcher.c M src/MainNFSD/9p_rdma_callbacks.c M src/MainNFSD/9p_rdma_dispatcher.c M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_admin_thread.c M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_reaper_thread.c M src/MainNFSD/nfs_rpc_callback.c M src/MainNFSD/nfs_rpc_callback_simulator.c M src/Protocols/9P/9p_flush_hook.c M src/Protocols/9P/9p_read.c M src/Protocols/9P/9p_write.c M src/Protocols/NFS/mnt_Export.c M src/Protocols/NFS/nfs4_Compound.c M src/Protocols/NFS/nfs4_op_create_session.c M src/Protocols/NFS/nfs4_op_lookupp.c M src/Protocols/NFS/nfs4_op_sequence.c M src/Protocols/NFS/nfs4_pseudo.c M src/Protocols/NFS/nfs_proto_tools.c M src/Protocols/NLM/nlm_async.c M src/Protocols/NLM/nlm_util.c M src/Protocols/NLM/nsm.c M src/RPCAL/gss_credcache.c M src/RPCAL/nfs_dupreq.c M src/SAL/nfs41_session_id.c M src/SAL/nfs4_clientid.c M src/SAL/nfs4_recovery.c M src/SAL/nfs4_state.c M src/SAL/nlm_state.c M src/SAL/recovery/recovery_rados_ng.c M src/SAL/state_lock.c M src/SAL/state_misc.c M src/SAL/state_share.c M src/config_parsing/conf_url.c M src/dbus/dbus_server.c M src/hashtable/hashtable.c M src/idmapper/idmapper.c M src/idmapper/idmapper_cache.c M src/include/9p.h M src/include/9p_req_queue.h M src/include/client_mgr.h M src/include/common_utils.h M src/include/export_mgr.h M src/include/fridgethr.h M src/include/fsal.h M src/include/fsal_api.h M src/include/fsal_types.h M src/include/fsal_up.h M src/include/gsh_wait_queue.h M src/include/gss_credcache.h M src/include/hashtable.h M src/include/nfs_core.h M src/include/nfs_dupreq.h M src/include/nfs_init.h M src/include/nfs_proto_data.h M src/include/sal_data.h M src/include/uid2grp.h M src/log/log_functions.c M src/support/client_mgr.c M src/support/delayed_exec.c M src/support/ds.c M src/support/export_mgr.c M src/support/exports.c M src/support/fridgethr.c M src/support/netgroup_cache.c M src/support/nfs4_acls.c M src/support/nfs4_fs_locations.c M src/support/server_stats.c M src/support/uid2grp.c M src/support/uid2grp_cache.c 109 files changed, 1,752 insertions(+), 1,036 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/552214/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552214 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3437014c3e74b562c906c947b976192d81e7594d Gerrit-Change-Number: 552214 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: PROXY handle mapping - remove mutexes, not necessary for pool_alloc
by Frank Filz (GerritHub) 04 Apr '23

04 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552213 ) Change subject: PROXY handle mapping - remove mutexes, not necessary for pool_alloc ...................................................................... PROXY handle mapping - remove mutexes, not necessary for pool_alloc Since Ganesha's memory pools have been simplified to basically being just a malloc call (via gsh_malloc), we don't need any serialization. Change-Id: I791fa27642f1b64c390f73f20d28ae31851cf174 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PROXY_V4/handle_mapping/handle_mapping.c 1 file changed, 13 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/552213/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552213 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I791fa27642f1b64c390f73f20d28ae31851cf174 Gerrit-Change-Number: 552213 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: Remove unused fridgethr_defer_block
by Frank Filz (GerritHub) 04 Apr '23

04 Apr '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552212 ) Change subject: Remove unused fridgethr_defer_block ...................................................................... Remove unused fridgethr_defer_block In making sure all mutexs and condition variables are destroyed, discovered unused code, so remove this first... Change-Id: I08269a9ac2527b9abe5f42eff476b9c06ac55f6b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/include/fridgethr.h M src/support/fridgethr.c 2 files changed, 22 insertions(+), 122 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/552212/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/552212 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I08269a9ac2527b9abe5f42eff476b9c06ac55f6b Gerrit-Change-Number: 552212 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0