September 2023 - Devel - Nfs Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: getquota to support 64bit quota using bsize for scaling

by Michael Diederich (GerritHub)

Michael Diederich has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170023?usp=email ) Change subject: getquota to support 64bit quota using bsize for scaling ...................................................................... getquota to support 64bit quota using bsize for scaling Change-Id: Ia7d99aeefee0aab63f9bbdbba3a3ef25d77dde59 Signed-off-by: Michael Diederich <diederich(a)de.ibm.com> --- M src/Protocols/RQUOTA/rquota_getquota.c 1 file changed, 31 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/1170023/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170023?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia7d99aeefee0aab63f9bbdbba3a3ef25d77dde59 Gerrit-Change-Number: 1170023 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Diederich <diederich(a)de.ibm.com> Gerrit-MessageType: newchange

7 months, 2 weeks

1
0
0 / 0

[L] Change in ...nfs-ganesha[next]: Keep expired clients until reaching threshold of expired clients

by Rojin George (GerritHub)

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1169897?usp=email ) Change subject: Keep expired clients until reaching threshold of expired clients ...................................................................... Keep expired clients until reaching threshold of expired clients Change-Id: I4972fba60cc1add02935a47edaaab0bc904d4936 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/MainNFSD/nfs_reaper_thread.c M src/Protocols/NFS/nfs4_op_create_session.c M src/Protocols/NFS/nfs4_op_exchange_id.c M src/Protocols/NFS/nfs4_op_setclientid_confirm.c M src/SAL/nfs4_clientid.c M src/SAL/nfs4_lease.c M src/SAL/nfs4_recovery.c M src/include/gsh_config.h M src/include/sal_data.h M src/include/sal_functions.h M src/support/nfs_read_conf.c 11 files changed, 249 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1169897/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1169897?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4972fba60cc1add02935a47edaaab0bc904d4936 Gerrit-Change-Number: 1169897 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com> Gerrit-MessageType: newchange

7 months, 2 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Incorrect values for ganesha_stats json option

by Name of user not set (GerritHub)

tshete(a)ddn.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1169860?usp=email ) Change subject: Incorrect values for ganesha_stats json option ...................................................................... Incorrect values for ganesha_stats json option Fixes: https://github.com/nfs-ganesha/nfs-ganesha/issues/1003 This commit fixes the second issue mentioned in the bug. Issue: The json option of ganesha_stats utility for iov3, iov4 etc gives incorrect values for write. Due to that we cannot use this option. Without json option the values are correct. Fix: Incorrect element from dbus result was printed. The logic for printing the result was not correct. Now printing the result from correct index. Change-Id: I639a56290649fd57ab2a8b3260798c0e5bde1c61 Signed-off-by: Trupti Shete <tshete(a)ddn.com> --- M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/1169860/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1169860?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I639a56290649fd57ab2a8b3260798c0e5bde1c61 Gerrit-Change-Number: 1169860 Gerrit-PatchSet: 1 Gerrit-Owner: tshete(a)ddn.com Gerrit-MessageType: newchange

7 months, 2 weeks

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Failed to get output of option ganesha_stats json

by Name of user not set (GerritHub)

tshete(a)ddn.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1169859?usp=email ) Change subject: Failed to get output of option ganesha_stats json ...................................................................... Failed to get output of option ganesha_stats json Fixes: https://github.com/nfs-ganesha/nfs-ganesha/issues/1003 This commit fixes the first issue mentioned in the bug. Issue: The json option of ganesha_stats utility fails and gives AssertionError. Due to that we cannot use this option Fix: While converting the data type from dbus to std "int" was not considered. Due to that AssertionError was raised. Now this data type is handled. Change-Id: I35aa6ef23d67e839d4571ba44f7795ec044be3a7 Signed-off-by: Trupti Shete <tshete(a)ddn.com> --- M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/1169859/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1169859?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I35aa6ef23d67e839d4571ba44f7795ec044be3a7 Gerrit-Change-Number: 1169859 Gerrit-PatchSet: 1 Gerrit-Owner: tshete(a)ddn.com Gerrit-MessageType: newchange

7 months, 2 weeks

1
0
0 / 0

Announce Push of V5.5.3

by Frank Filz

Branch next We're getting closer to V5.6, but this isn't quite it yet. Tag:V5.5.3 Merge Highlights * FSAL: in wait_to_start_io only increment wamt_read and want_write once * FSAL: close_fsal_fd should only do fd lru stuff for global fd * Get ref of gsh_export to prevent incorrect release and remove unnecessary dec in lru_reclaim * modify the incorrect value in comments * FSAL: add the get_fsal_obj_handle for FSALs * FSAL_VFS: Don't attempt to get ACLs from FDs opened with O_PATH * Fix accounting of number of operations, per protocol, for server stats. * Decrement fds_num_write_opens, if client don't close the file Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 2a57b6d53 Frank S. Filz V5.5.3 885598ce9 Rojin George Decrement fds_num_write_opens, if client don't close the file 25cc51d00 Bjorn Leffler Fix accounting of number of operations, per protocol, for server stats. a8bbf2486 Martin Schwenke FSAL_VFS: Don't attempt to get ACLs from FDs opened with O_PATH 34470a613 bjfhdhhaha FSAL: add the get_fsal_obj_handle for FSALs 1a0274fb9 bjfhdhhaha modify the incorrect value in comments 73e0d7b36 bjfhdhhaha Get ref of gsh_export to prevent incorrect release and remove unnecessary dec in lru_reclaim 43f6878f1 Frank S. Filz FSAL: close_fsal_fd should only do fd lru stuff for global fd 55aad71f4 Frank S. Filz FSAL: in wait_to_start_io only increment wamt_read and want_write once

7 months, 3 weeks

1
0
0 / 0

Caching in NFS Ganesha

by marcelb＠iternity.com

I hope, that this is the right place for my question. I want to ask if there are any caches by default. In the documentation I found something concerning the MDCache. The most settings there are for the caching of read access and metadata. Unless I am misunderstanding But I want to know, if there is a some cache for write operation. In the end, I would like to know if there is a possibility of data loss due to data cached at the Ganesha layer. As a side note, we are using Ganesha together with GlusterFS Thank you all in advance.

7 months, 3 weeks

4
3
1 / 0

[S] Change in ...nfs-ganesha[next]: FSAL_VFS: Don't attempt to get ACLs from FDs opened with O_PATH

by Martin Schwenke (GerritHub)

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1168852?usp=email ) Change subject: FSAL_VFS: Don't attempt to get ACLs from FDs opened with O_PATH ...................................................................... FSAL_VFS: Don't attempt to get ACLs from FDs opened with O_PATH Fixes: https://github.com/nfs-ganesha/nfs-ganesha/issues/1000 Commit 3a395315f27e19d64eab3e89c464008191ac3e02 improved the situation but didn't catch all of the problems. Linux open(2) documentation for O_PATH says: Obtain a file descriptor that can be used for two purposes: to indicate a location in the filesystem tree and to perform operations that act purely at the file descriptor level. The file itself is not opened, and other file operations (e.g., read(2), write(2), fchmod(2), fchown(2), fgetxattr(2), ioctl(2), mmap(2)) fail with the error EBADF. So, the real problem looks to be FSAL_VFS incorrectly calling libacl's acl_get_fd(3), which then calls fgetxattr(2) on a file descriptor that was opened with O_PATH. FSAL_VFS also opens sockets and device files with O_PATH in find_fd(), so attempting to get ACLs for those will also fail. The fix is to exclude all file types opened with O_PATH from the FSAL_VFS ACL code. This avoids 8 test failures for socket-related tests in pynfs/nfs4.0/testserver.py all: @@ -41,31 +41,23 @@ VF5r st_verify.testWriteOnlyFile : PASS VF5f st_verify.testWriteOnlyFifo : PASS VF5d st_verify.testWriteOnlyDir : PASS -VF7s st_verify.testUnsupportedSocket : FAILURE - nfs4lib.BadCompoundRes: operation OP_GETATTR should - return NFS4_OK, instead got NFS4ERR_IO +VF7s st_verify.testUnsupportedSocket : PASS VF7a st_verify.testUnsupportedLink : PASS VF7r st_verify.testUnsupportedFile : PASS VF7f st_verify.testUnsupportedFifo : PASS VF7d st_verify.testUnsupportedDir : PASS -VF2s st_verify.testTypeSocket : FAILURE - Verifying type of /b'srv/nfs/tree/socket' should - return NFS4_OK, instead got NFS4ERR_IO +VF2s st_verify.testTypeSocket : PASS VF2a st_verify.testTypeLink : PASS VF2r st_verify.testTypeFile : PASS VF2f st_verify.testTypeFifo : PASS VF2d st_verify.testTypeDir : PASS VF4 st_verify.testNoFh : PASS -VF1s st_verify.testMandSocket : FAILURE - nfs4lib.BadCompoundRes: operation OP_GETATTR should - return NFS4_OK, instead got NFS4ERR_IO +VF1s st_verify.testMandSocket : PASS VF1a st_verify.testMandLink : PASS VF1r st_verify.testMandFile : PASS VF1f st_verify.testMandFifo : PASS VF1d st_verify.testMandDir : PASS -VF3s st_verify.testBadSizeSocket : FAILURE - nfs4lib.BadCompoundRes: operation OP_GETATTR should - return NFS4_OK, instead got NFS4ERR_IO +VF3s st_verify.testBadSizeSocket : PASS VF3a st_verify.testBadSizeLink : PASS VF3r st_verify.testBadSizeFile : PASS VF3f st_verify.testBadSizeFifo : PASS @@ -395,9 +387,7 @@ LOCKRNG st_lock.test32bitRange : PASS LINK6 st_link.testZeroLenName : PASS LINKS st_link.testSupported : PASS -LINK1s st_link.testSocket : FAILURE - nfs4lib.BadCompoundRes: operation OP_GETATTR should - return NFS4_OK, instead got NFS4ERR_IO +LINK1s st_link.testSocket : PASS LINK2 st_link.testNoSfh : PASS LINK3 st_link.testNoCfh : PASS LINK7 st_link.testLongName : PASS @@ -440,9 +430,7 @@ GATT1f st_getattr.testMandFifo : PASS GATT1d st_getattr.testMandDir : PASS GATT9 st_getattr.testLotsofGetattrsFile : PASS -GATT7s st_getattr.testLongSocket : FAILURE - Asking for all legal attributes should return NFS4_OK, - instead got NFS4ERR_IO +GATT7s st_getattr.testLongSocket : PASS GATT7a st_getattr.testLongLink : PASS GATT7r st_getattr.testLongFile : PASS GATT7f st_getattr.testLongFifo : PASS @@ -506,9 +494,7 @@ ACL10 st_acl.testLargeACL : PASS ACL0 st_acl.testACLsupport : PASS ACL5 st_acl.testACL : PASS -ACC1s st_access.testReadSocket : FAILURE - OP_ACCESS should return NFS4_OK, instead got - NFS4ERR_IO +ACC1s st_access.testReadSocket : PASS ACC1a st_access.testReadLink : PASS ACC1r st_access.testReadFile : PASS ACC1f st_access.testReadFifo : PASS @@ -519,13 +505,11 @@ ACC4r st_access.testInvalidsFile : PASS ACC4f st_access.testInvalidsFifo : PASS ACC4d st_access.testInvalidsDir : PASS -ACC2s st_access.testAllSocket : FAILURE - OP_ACCESS should return NFS4_OK, instead got - NFS4ERR_IO +ACC2s st_access.testAllSocket : PASS ACC2a st_access.testAllLink : PASS ACC2r st_access.testAllFile : PASS ACC2f st_access.testAllFifo : PASS ACC2d st_access.testAllDir : PASS ************************************************** Command line asked for 591 of 679 tests -Of those: 94 Skipped, 13 Failed, 3 Warned, 481 Passed +Of those: 94 Skipped, 5 Failed, 3 Warned, 489 Passed Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I650eefba72209ef0cbccab3f458f9f635c0dc85f --- M src/FSAL/FSAL_VFS/vfs/attrs.c 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/1168852/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1168852?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I650eefba72209ef0cbccab3f458f9f635c0dc85f Gerrit-Change-Number: 1168852 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

7 months, 4 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: threads: set appropriate thread stack size for fridge and ntirpc workers

by Kaleb KEITHLEY (GerritHub)

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1168839?usp=email ) Change subject: threads: set appropriate thread stack size for fridge and ntirpc workers ...................................................................... threads: set appropriate thread stack size for fridge and ntirpc workers See https://github.com/nfs-ganesha/ntirpc/pull/280 glibc's default thread stack size is 8M. N.B. This can be overridden across the whole process by setting the stack size with ulimit; by default threads will inherit the same size for their thread stack. Empirical testing shows that ganesha works fine with a thread stack size as small as 16K (the glibc minimum). For a margin of safety this will set the size to 32K. The same testing shows that ganesha works fine with ntirpc worker thread stack size of 32K. For a similar safety margin this will set the ntirpc worker thread stack size to 64K. Change-Id: Id6c7c4332f06ff6811f75c24c97f60481fb7c4ac Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/MainNFSD/nfs_init.c M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/include/common_utils.h M src/support/delayed_exec.c M src/support/fridgethr.c M src/tools/multilock/ml_cephfs_client.c M src/tools/multilock/ml_glusterfs_client.c M src/tools/multilock/ml_posix_client.c 8 files changed, 36 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1168839/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1168839?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id6c7c4332f06ff6811f75c24c97f60481fb7c4ac Gerrit-Change-Number: 1168839 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com> Gerrit-MessageType: newchange

7 months, 4 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Decrement fds_num_write_opens, if client don't close the file

by Rojin George (GerritHub)

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1168804?usp=email ) Change subject: Decrement fds_num_write_opens, if client don't close the file ...................................................................... Decrement fds_num_write_opens, if client don't close the file This CR decrements the write open fd count, if the client doesn't close the file. Else this could result in a file never being delegated. Change-Id: Ia2965239328153e80685d66308adce47dd21329c Signed-off-by: Rojin George <rojin.george(a)nutanix.com> Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/SAL/nfs4_state.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/1168804/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1168804?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia2965239328153e80685d66308adce47dd21329c Gerrit-Change-Number: 1168804 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com> Gerrit-MessageType: newchange

8 months

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: modify the incorrect value in comments

by bjfhdhhaha (GerritHub)

bjfhdhhaha has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1168763?usp=email ) Change subject: modify the incorrect value in comments ...................................................................... modify the incorrect value in comments Change-Id: Ida8b1d160380789f5633a2585bf2f0b4b2f561c8 Signed-off-by: bjfhdhhaha <1453769042(a)qq.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_ext.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1168763/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1168763?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ida8b1d160380789f5633a2585bf2f0b4b2f561c8 Gerrit-Change-Number: 1168763 Gerrit-PatchSet: 1 Gerrit-Owner: bjfhdhhaha <1453769042(a)qq.com> Gerrit-MessageType: newchange

8 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel September 2023