October 2024 - Devel - Nfs Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: FSAL_MEM : Fix crash in readdir

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202653?usp=email ) Change subject: FSAL_MEM : Fix crash in readdir ...................................................................... FSAL_MEM : Fix crash in readdir Due to non-allocation of new object handle while collecting attrs, existing FD and related mutex were getting used and destroyed after usage. This was leading to crash due to non-availability of mutex. ''' [psachin@rhs-srv-03 ~]$ grep 0x7f69d02ce228 /var/log/ganesha.log.broken 11/10/2024 08:05:39 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[svc_6] init_fsal_fd :RW LOCK :F_DBG :Init mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/include/fsal_types.h:987 11/10/2024 08:05:44 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[Gen_Fridge] fsal_start_fd_work :RW LOCK :F_DBG :Acquired mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/FSAL/commonlib.c:2890 11/10/2024 08:05:44 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[Gen_Fridge] fsal_complete_fd_work :RW LOCK :F_DBG :Released mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/FSAL/commonlib.c:2967 11/10/2024 08:06:04 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[Gen_Fridge] fsal_start_fd_work :RW LOCK :F_DBG :Acquired mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/FSAL/commonlib.c:2890 11/10/2024 08:06:04 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[Gen_Fridge] fsal_complete_fd_work :RW LOCK :F_DBG :Released mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/FSAL/commonlib.c:2967 11/10/2024 08:06:48 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[svc_6] fsal_start_fd_work :RW LOCK :F_DBG :Acquired mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/FSAL/commonlib.c:2890 11/10/2024 08:06:48 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[svc_6] fsal_complete_fd_work :RW LOCK :F_DBG :Released mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/FSAL/commonlib.c:2967 11/10/2024 08:06:48 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[svc_6] destroy_fsal_fd :RW LOCK :F_DBG :Destroy mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/include/fsal_types.h:1002 11/10/2024 08:07:04 : epoch 67091434 : rhs-srv-03.gdev.lab.eng.rdu2.redhat.com : ganesha.nfsd-714666[Gen_Fridge] fsal_start_fd_work :RW LOCK :CRIT :Error 22, acquiring mutex 0x7f69d02ce228 (&fsal_fd->work_mutex) at /home/psachin/downstream/nfs/nfs-ganesha/src/FSAL/commonlib.c:2890 ''' Change-Id: Id4c676e5b7e3ec4eb9233a4706a4ea0ebfb6f532 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_MEM/mem_handle.c 1 file changed, 34 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/53/1202653/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202653?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id4c676e5b7e3ec4eb9233a4706a4ea0ebfb6f532 Gerrit-Change-Number: 1202653 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

21 hours, 37 minutes

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Avoid deref of uninitialized pointer

by Steve Lord (GerritHub)

Steve Lord has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202650?usp=email ) Change subject: Avoid deref of uninitialized pointer ...................................................................... Avoid deref of uninitialized pointer Fix for Issue #1186 In the NFS V3 case nfs4_clientid was not initialized and the logic in do_lock_op was testing for it being set causing a panic. Change-Id: Icfd95cfbf750affd600ac04ec0faeb3ebfdda2c7 Signed-off-by: Steve Lord <steve.p.lord(a)gmail.com> --- M src/SAL/state_lock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/1202650/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icfd95cfbf750affd600ac04ec0faeb3ebfdda2c7 Gerrit-Change-Number: 1202650 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Lord <steve.p.lord(a)gmail.com>

1 day, 6 hours

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Prevent nfs3 read from generating bad reply

by Steve Lord (GerritHub)

Steve Lord has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202649?usp=email ) Change subject: Prevent nfs3 read from generating bad reply ...................................................................... Prevent nfs3 read from generating bad reply Fixes Issue #1185 When an nfs read reques crosses EOF we need to reset data.data_len to the amount of data provided. This prevents the XDR code from marshalling a reply which confuses the NFS client. Change-Id: I9453d8e11ef1c2cd8744d7dd387c629ac48b4a37 Signed-off-by: Steve Lord <steve.p.lord(a)gmail.com> --- M src/Protocols/NFS/nfs3_read.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/1202649/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202649?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9453d8e11ef1c2cd8744d7dd387c629ac48b4a37 Gerrit-Change-Number: 1202649 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Lord <steve.p.lord(a)gmail.com>

1 day, 6 hours

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Avoid double release of read buffers

by Steve Lord (GerritHub)

Steve Lord has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202648?usp=email ) Change subject: Avoid double release of read buffers ...................................................................... Avoid double release of read buffers Fix for issue #1180 In the zero read response case null out the iov_base which prevents the libntirpc layer from performing a double free. Also null out the release function pointer once we have called it. Change-Id: Icbd787b8f4b7e535b776d8587233b10c073bc8c3 Signed-off-by: Steve Lord <steve.p.lord(a)gmail.com> --- M src/Protocols/NFS/nfs3_read.c M src/Protocols/NFS/nfs4_op_read.c 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/1202648/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202648?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icbd787b8f4b7e535b776d8587233b10c073bc8c3 Gerrit-Change-Number: 1202648 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Lord <steve.p.lord(a)gmail.com>

1 day, 6 hours

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: src/SAL/nfs4_owner.c: Don't access owner if it's NULL.

by Yoni Couriel (GerritHub)

Yoni Couriel has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202552?usp=email ) Change subject: src/SAL/nfs4_owner.c: Don't access owner if it's NULL. ...................................................................... src/SAL/nfs4_owner.c: Don't access owner if it's NULL. Change-Id: Ifb72f18f042fae3053d9bed4588934266ca989e5 Signed-off-by: Yoni Couriel <yonic(a)google.com> --- M src/SAL/nfs4_owner.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/1202552/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202552?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifb72f18f042fae3053d9bed4588934266ca989e5 Gerrit-Change-Number: 1202552 Gerrit-PatchSet: 1 Gerrit-Owner: Yoni Couriel <yonic(a)google.com>

3 days, 15 hours

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: src/MainNFSD/nfs_main.c: Truncate should be after taking the lock.

by Yoni Couriel (GerritHub)

Yoni Couriel has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202551?usp=email ) Change subject: src/MainNFSD/nfs_main.c: Truncate should be after taking the lock. ...................................................................... src/MainNFSD/nfs_main.c: Truncate should be after taking the lock. If another Ganesha is using the PID file, we might truncate it even though we don't have the lock. Change-Id: I6edb89a045aa035c99f3910f22cd25a7a0fe5e34 Signed-off-by: Yoni Couriel <yonic(a)google.com> --- M src/MainNFSD/nfs_main.c 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/51/1202551/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202551?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6edb89a045aa035c99f3910f22cd25a7a0fe5e34 Gerrit-Change-Number: 1202551 Gerrit-PatchSet: 1 Gerrit-Owner: Yoni Couriel <yonic(a)google.com>

3 days, 15 hours

1
0
0 / 0

Updated invitation: Ganesha community call @ Weekly from 7am to 8am on Tuesday (PDT) (devel@lists.nfs-ganesha.org)

by Frank Filz

This event has been updated Ganesha community call Weekly from 7am to 8am on Tuesday Pacific Time - Los Angeles Location IL-TLV-ELCO-43-6-Marshmallow (9) [GVC, Not Wheelchair Accessible] https://www.google.com/maps/search/IL-TLV-ELCO-43-6-Marshmallow+(9)+%5BGV... Join with Google Meet https://meet.google.com/mkh-ctnj-tqz?hs=224 Join by phone (US) +1 401-702-0462 PIN: 495972631 More joining options https://tel.meet/mkh-ctnj-tqz?pin=2844708468265&hs=0 Join using SIP 2844708468265(a)gmeet.redhat.com ID: 2844708468265 Organizer Frank Filz ffilz(a)redhat.com Guests Frank Filz - organizer thomas.vanderputten(a)panzura.com ffilzg(a)gmail.com Daniel Gryniewicz dmanzoni(a)verisign.com martin(a)uni-mainz.de Matt Benjamin Kaleb Keithley leffler(a)google.com sagar.it.iiests(a)gmail.com geva30(a)gmail.com assafy(a)google.com liorsu(a)google.com gauravin(a)google.com yashnarang(a)google.com dipit(a)google.com roopkamal(a)google.com RICHARD RUPP alok(a)spillbox.io punadikar.sachin(a)gmail.com ndevos(a)ibm.com sriram.patil(a)broadcom.com itsmerojin(a)gmail.com drieber(a)google.com Marc Eshel yonic(a)google.com shaharhoch(a)google.com Naresh Chillarege ofirvins(a)google.com mivry(a)google.com devel(a)lists.nfs-ganesha.org Wyll Ingersoll hu hansen ffilz(a)ibm.com Marcus Gorzellik Yogendra Charya Sriram Patil Jacobson, Erik blaine.gardner(a)ibm.com naresh.chillarege(a)ibm.com animesh.javali(a)ibm.com Animesh Javali Avani Rateria Deeraj Patil Rajesh Prasad Suhas Athani Shivam Singh Vidya Thumukunta View all guest info https://calendar.google.com/calendar/event?action=VIEW&eid=NXZubmZhbGJwcT... Reply for devel(a)lists.nfs-ganesha.org and view more details https://calendar.google.com/calendar/event?action=VIEW&eid=NXZubmZhbGJwcT... Your attendance is optional. ~~//~~ Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this email because you are an attendee on the event. To stop receiving future updates for this event, decline this event. Forwarding this invitation could allow any recipient to send a response to the organizer, be added to the guest list, invite others regardless of their own invitation status, or modify your RSVP. Learn more https://support.google.com/calendar/answer/37135#forwarding

1 week

1
0
0 / 0

Updated invitation: Ganesha community call @ Weekly from 7am to 8am on Tuesday from Tue Aug 13 to Mon Oct 14 (PDT) (devel@lists.nfs-ganesha.org)

by Frank Filz

This event has been updated Changed: time Ganesha community call Weekly from 7am to 8am on Tuesday from Tuesday Aug 13 to Monday Oct 14 Pacific Time - Los Angeles Location IL-TLV-ELCO-43-6-Marshmallow (9) [GVC, Not Wheelchair Accessible] https://www.google.com/maps/search/IL-TLV-ELCO-43-6-Marshmallow+(9)+%5BGV... Join with Google Meet https://meet.google.com/mkh-ctnj-tqz?hs=224 Join by phone (US) +1 401-702-0462 PIN: 495972631 More joining options https://tel.meet/mkh-ctnj-tqz?pin=2844708468265&hs=0 Join using SIP 2844708468265(a)gmeet.redhat.com ID: 2844708468265 Organizer Frank Filz ffilz(a)redhat.com Guests Frank Filz - organizer thomas.vanderputten(a)panzura.com ffilzg(a)gmail.com Daniel Gryniewicz dmanzoni(a)verisign.com martin(a)uni-mainz.de Matt Benjamin Kaleb Keithley leffler(a)google.com sagar.it.iiests(a)gmail.com geva30(a)gmail.com assafy(a)google.com liorsu(a)google.com gauravin(a)google.com yashnarang(a)google.com dipit(a)google.com roopkamal(a)google.com RICHARD RUPP alok(a)spillbox.io punadikar.sachin(a)gmail.com ndevos(a)ibm.com sriram.patil(a)broadcom.com itsmerojin(a)gmail.com drieber(a)google.com Marc Eshel yonic(a)google.com shaharhoch(a)google.com Naresh Chillarege ofirvins(a)google.com mivry(a)google.com devel(a)lists.nfs-ganesha.org Wyll Ingersoll hu hansen ffilz(a)ibm.com Marcus Gorzellik Yogendra Charya Sriram Patil Jacobson, Erik blaine.gardner(a)ibm.com naresh.chillarege(a)ibm.com animesh.javali(a)ibm.com View all guest info https://calendar.google.com/calendar/event?action=VIEW&eid=NXZubmZhbGJwcT... Reply for devel(a)lists.nfs-ganesha.org and view more details https://calendar.google.com/calendar/event?action=VIEW&eid=NXZubmZhbGJwcT... Your attendance is optional. ~~//~~ Invitation from Google Calendar: https://calendar.google.com/calendar/ You are receiving this email because you are an attendee on the event. To stop receiving future updates for this event, decline this event. Forwarding this invitation could allow any recipient to send a response to the organizer, be added to the guest list, invite others regardless of their own invitation status, or modify your RSVP. Learn more https://support.google.com/calendar/answer/37135#forwarding

1 week

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Sync lru_run with release_export

by Xueqian Hu (GerritHub)

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202422?usp=email ) Change subject: Sync lru_run with release_export ...................................................................... Sync lru_run with release_export Hit ganesha crash when removing a export & lru_run to clean caches: Thread 17 (Thread 0x7fed38bbe700 (LWP 62657)): ... Thread 1 (Thread 0x7fed437d8700 (LWP 62634)): This could happen when the mdcache caches number is above the high water limit which will trigger the lru_run to clean caches, and at the same time the release export(from dbus) is also in progress. Steps to repro the crash: 1. add sleep in unexport code path like 10 seconds(I added delay at the beginning of state_release_export) 2. use short lru interval: LRU_Run_Interval = 5 3. set lru_state.entries_hiwat to low value like 0 4. from client side, use vi to read a file -> keep delegation -> hold the cache to prevent clean immediately 5. dbus call to remove the export Change-Id: I378138f94bd804c312d68d0fab631d077cf52da5 Signed-off-by: Xueqian Hu <xh140312(a)outlook.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/1202422/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202422?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I378138f94bd804c312d68d0fab631d077cf52da5 Gerrit-Change-Number: 1202422 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 week, 1 day

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: log_functions: When clean up list is cleared we need to set cleanup_l...

by ofir vainshtein (GerritHub)

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202363?usp=email ) Change subject: log_functions: When clean up list is cleared we need to set cleanup_list to null ...................................................................... log_functions: When clean up list is cleared we need to set cleanup_list to null if we do not, it still references an already cleared and freed linked list Change-Id: I54b381ddcdf4a17a7454535753ab7d0b8f60f03b Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/log/log_functions.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/63/1202363/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1202363?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I54b381ddcdf4a17a7454535753ab7d0b8f60f03b Gerrit-Change-Number: 1202363 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 week, 1 day

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel October 2024