November 2024 - Devel - Nfs Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: Handle suid, sgid bits reset during chown operation

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204537?usp=email to review the following change. Change subject: Handle suid, sgid bits reset during chown operation ...................................................................... Handle suid, sgid bits reset during chown operation Change-Id: I7c80f03c77f062ce5d8f4ef89b5e326dd18310df Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/FSAL/fsal_helper.c 1 file changed, 40 insertions(+), 21 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/1204537/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204537?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7c80f03c77f062ce5d8f4ef89b5e326dd18310df Gerrit-Change-Number: 1204537 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-CC: Dipit Grover <dipitgrover(a)gmail.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 month

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: src/SAL/state_lock: Fix a bug of adressing the wrong field

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204536?usp=email to review the following change. Change subject: src/SAL/state_lock: Fix a bug of adressing the wrong field ...................................................................... src/SAL/state_lock: Fix a bug of adressing the wrong field Change-Id: I39910a5709adf9d46d7330e70233bcedd9889d56 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/SAL/state_lock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/1204536/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204536?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I39910a5709adf9d46d7330e70233bcedd9889d56 Gerrit-Change-Number: 1204536 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 month

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Add ProxyProtocol config option

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204534?usp=email to review the following change. Change subject: Add ProxyProtocol config option ...................................................................... Add ProxyProtocol config option The config option can be used in (DEFAULT) EXPORT CLIENT blocks to limit the block only to client who use or do not use PROXY protocol. Allows to set different ACLs based on whether a proxy was used or not by the request. src/support/exports: Add ganesha config to EXPORT (DEFAULT) CLIENT block include/nfs_exports: Add config option to export list client entry client_mgr: Add parameter to client match - client_predicate, which allows defining an additional requirement from the client. support/exports: Filter client_match results to only match clients which match op usage of proxy protocol Change-Id: I03690d4c16ba048f17084d62a37f90a8a2c4ddbd Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/config_samples/config.txt M src/config_samples/export.txt M src/doc/man/ganesha-export-config.rst M src/include/client_mgr.h M src/include/nfs_exports.h M src/support/client_mgr.c M src/support/exports.c 7 files changed, 117 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/1204534/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204534?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I03690d4c16ba048f17084d62a37f90a8a2c4ddbd Gerrit-Change-Number: 1204534 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 month

1
0
0 / 0

Announce Push of V6.3

by Frank Filz

Branch next Tag:V6.3 Note: This release includes an ntirpc pullup, please make sure to update your submodule. Merge Highlights * some minor log fixups * some PROXY_V3 fixes * fridgether.c: After cancel we need to join, before freeing thread resources * src/include/sal_functions.h: Avoid using export reserved keyword so this file can be included in C++. * gsh_types.h: Add missing include * src/idmapper/idmapper.c: Clear negatic cache when idmapping status changes * src/monitoring: Clang-format cc files. * src/monitoring/exposer.cc: Added scraping latencies histogram. * src/test/run_test_mode.sh: Added script to run Ganesha for testing. * fix some spelling mistakes * Add limit check in wait_to_start_io(). If exceeded, wakeup reaper & return BUSY * FSAL_MEM:Don't destroy global FD for valid handle * some Coverity fixes Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: f503dc406 Frank S. Filz V6.3 a511dd4ca Frank S. Filz ntirpc V6.3 pullup b37bc668f Shivam Singh Proposed fix for coverity issues: 502177 & 502095 f69068c3c Sachin Punadikar STATE : Fix double unlock (CID 502067) 485610fa1 Sachin Punadikar FSAL_MEM:Don't destroy global FD for valid handle 5d0de2ccf Rojin George Add limit check in wait_to_start_io(). If exceeded, wakeup reaper & return BUSY 1f528f8e3 izxl007 export_mgr.c: Minor log fixup 70ae04439 izxl007 fix some spelling mistakes 3cc9ece26 Yoni Couriel src/test/run_test_mode.sh: Added script to run Ganesha for testing. 10260ba2e Yoni Couriel src/monitoring/exposer.cc: Added scraping latencies histogram. 3d7583de0 Yoni Couriel src/monitoring: Clang-format cc files. c6a8e9e5b Lior Suliman src/idmapper/idmapper.c: Clear negatic cache when idmapping status changes 3963f930b Ofir Vainshtein gsh_types.h: Add missing include bac9246ef Yoni Couriel src/include/sal_functions.h: Avoid using export reserved keyword so this file can be included in C++. 5abe1bc6a Ofir Vainshtein fridgether.c: After cancel we need to join, before freeing thread resources ca6ee9266 Lior Suliman Update .gitignore 7e8b05beb Lior Suliman Change NFSv3 proxy FSAL to return delay instead of invalid val or server fault to the client 8ff262aea Lior Suliman FSAL_PROXY_V3: Fixed a bug that the FSAL Proxy V3 used the original creds and not the resolved creds e0e7c8a83 Frank S. Filz NFS3: Minor log fixup

1 month

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: nfs4_pseudo.c: Fix the issue where subexport get disconnected from Ps...

by Zheng Zeng (GerritHub)

Zheng Zeng has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204509?usp=email ) Change subject: nfs4_pseudo.c: Fix the issue where subexport get disconnected from Pseudofs ...................................................................... nfs4_pseudo.c: Fix the issue where subexport get disconnected from Pseudofs Assume there are two exports: /exp v3,v4 /exp/subexp v3,v4 Use the dbus command to change the /exp protocols from v3,v4 to v3. As a result, /exp will be unmounted. During the pruning phase, /exp/subexp will be unmounted first. However, it will not be remounted because /exp/subexp does not meet the condition "export->config_gen >= generation". Eventually, /exp/subexp will get disconnected from Pseudofs. This patch removes the condition "export->config_gen >= generation" to remount /exp/subexp, When /exp is to be unmounted. This patch will not cause pseudofs structural errors in other scenarios. Change-Id: I85edfeb199f1f52823d11dc9dd1fb84f35a4860a Signed-off-by: izxl007 <zengzheng007(a)163.com> --- M src/Protocols/NFS/nfs4_pseudo.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/09/1204509/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204509?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I85edfeb199f1f52823d11dc9dd1fb84f35a4860a Gerrit-Change-Number: 1204509 Gerrit-PatchSet: 1 Gerrit-Owner: Zheng Zeng <zengzheng007(a)163.com>

1 month

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Signed-off-by: Shivam Singh <shivam.singh9@ibm.com>

by Shivam Singh (GerritHub)

Shivam Singh has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204468?usp=email ) Change subject: Signed-off-by: Shivam Singh <shivam.singh9(a)ibm.com> ...................................................................... Signed-off-by: Shivam Singh <shivam.singh9(a)ibm.com> Proposed fix for coverity issues: 502177 & 502095 Unsafe access to shared attributes in fridgethr module have been fixed by taking lock on frt_mtx Change-Id: I5a7e8575ae8487c287beb39cd832abe4f3e52347 Signed-off-by: Shivam Singh <shivam.singh9(a)ibm.com> --- M src/support/fridgethr.c 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/1204468/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204468?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5a7e8575ae8487c287beb39cd832abe4f3e52347 Gerrit-Change-Number: 1204468 Gerrit-PatchSet: 1 Gerrit-Owner: Shivam Singh <shivam.singh9(a)ibm.com>

1 month

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: export_mgr.c: Minor log fixup

by Zheng Zeng (GerritHub)

Zheng Zeng has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204430?usp=email ) Change subject: export_mgr.c: Minor log fixup ...................................................................... export_mgr.c: Minor log fixup Change-Id: Iedbefe666ce4681b08f2654bcc789d75ff39eda4 Signed-off-by: izxl007 <zengzheng007(a)163.com> --- M src/support/export_mgr.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/1204430/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iedbefe666ce4681b08f2654bcc789d75ff39eda4 Gerrit-Change-Number: 1204430 Gerrit-PatchSet: 1 Gerrit-Owner: Zheng Zeng <zengzheng007(a)163.com>

1 month

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Default to building with prometheus monitoring enabled

by Yuvi Panda (GerritHub)

Yuvi Panda has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204181?usp=email ) Change subject: Default to building with prometheus monitoring enabled ...................................................................... Default to building with prometheus monitoring enabled In b6c59df5a0b8a3ae5b2a87446f8906cb321ee026, it was stated that the reason for guarding monitoring behind a compile time flag was that it introduced a new dependency. However, since 4f96c6a8e759d2a0e07643144fd003ce5c1e4e4d, there are no external build time dependencies as a new library is used and vendored in. This commit changes the default to include monitoring as no external non-vendored dependencies are needed anymore. Change-Id: I655849d330a31041cb3499de96bc6c3e17b8fbb0 Signed-off-by: YuviPanda <yuvipanda(a)gmail.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/1204181/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I655849d330a31041cb3499de96bc6c3e17b8fbb0 Gerrit-Change-Number: 1204181 Gerrit-PatchSet: 1 Gerrit-Owner: Yuvi Panda <yuvipanda(a)gmail.com>

1 month, 1 week

1
0
0 / 0

Critical error in TIRPC svc_rqst_hook_events

by Olivier Garaud

Hi, I'm giving a try to 6.2 and at startup I can see a critical error on TIRPC side: ganesha.nfsd-35296[main] rpc :TIRPC :CRIT :svc_rqst_hook_events: 0x760215596000 fd 1024 xp_refcnt 1 sr_rec 0x76021519a230 evchan 2 ev_refcnt 3 epoll_fd 40 control fd pair (38:39) direction in hook failed (9) This error is not visible when I'm activating FULL_DEBUG on TIRPC so I guess that's a race. What I've found is rec->xprt.xp_fd == 1024 and it's the value set in svc_raw_ncreate (FD_SETSIZE) when srp == NULL Here is the backtrace when the error occurs: #0 svc_rqst_hook_events (rec=0x7fffd64b4600, sr_rec=0x7fffd64b4230, ev_flags=1) at nfs-ganesha/src/src/libntirpc/src/svc_rqst.c:778 #1 0x00007ffff7f74b3b in svc_rqst_evchan_reg (chan_id=2, xprt=0x7fffd64b4600, flags=4096) at nfs-ganesha/src/src/libntirpc/src/svc_rqst.c:1084 #2 0x00007ffff7f5b481 in clnt_vc_ncreatef (fd=44, raddr=0x7fffffffde70, prog=100000, vers=3, sendsz=9000, recvsz=9000, flags=268435472) at nfs-ganesha/src/src/libntirpc/src/clnt_vc.c:219 #3 0x00007ffff7f69882 in local_rpcb (tag=0x7ffff7f92940 <__func__.10> "rpcb_unset") at nfs-ganesha/src/src/libntirpc/src/rpcb_clnt.c:1312 #4 0x00007ffff7f67903 in rpcb_unset (program=100003, version=3, nconf=0x7fffef8241c0) at nfs-ganesha/src/src/libntirpc/src/rpcb_clnt.c:518 #5 0x00007ffff7c6dc88 in unregister (prog=100003, vers1=3, vers2=4) at nfs-ganesha/src/src/MainNFSD/nfs_rpc_dispatcher_thread.c:192 #6 0x00007ffff7c6dd61 in unregister_rpc () at nfs-ganesha/src/src/MainNFSD/nfs_rpc_dispatcher_thread.c:205 #7 0x00007ffff7c718cf in nfs_Init_svc () at nfs-ganesha/src/src/MainNFSD/nfs_rpc_dispatcher_thread.c:1471 #8 0x00007ffff7c76540 in nfs_Init (p_start_info=0x55555555b020 <my_nfs_start_info>) at nfs-ganesha/src/src/MainNFSD/nfs_init.c:1126 #9 0x00007ffff7c76b0c in nfs_start (p_start_info=0x55555555b020 <my_nfs_start_info>) at nfs-ganesha/src/src/MainNFSD/nfs_init.c:1272 #10 0x0000555555557d54 in main (argc=4, argv=0x7fffffffe358) at nfs-ganesha/src/src/MainNFSD/nfs_main.c:638 This doesn't look like having consequences on the next requests but should I worry ? I'm not familiar enough with ntirpc internals but if you need something to help with investigation let me know what I can do. Thanks, Olivier

1 month, 1 week

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: FSAL_MEM:Don't destroy global FD for valid handle

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204107?usp=email ) Change subject: FSAL_MEM:Don't destroy global FD for valid handle ...................................................................... FSAL_MEM:Don't destroy global FD for valid handle In FSAL_MEM, the object handle remains fixed for its lifetime and can not be recreated later on as there is no persistent storage associated. Due to this limitation, the global FD associated with regular files should not be destroyed until associated object handle is getting deleted. Change-Id: I441f276f62a5b73e82de44aa5090a03385bc7f41 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_MEM/mem_handle.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/1204107/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204107?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I441f276f62a5b73e82de44aa5090a03385bc7f41 Gerrit-Change-Number: 1204107 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 month, 1 week

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel November 2024