7:59 a.m.
On 12/6/18 4:42 AM, gaurav gangalwar wrote:
On Thu, Dec 6, 2018 at 1:41 AM William Allen Simpson
<william.allen.simpson(a)gmail.com <mailto:william.allen.simpson@gmail.com>>
wrote:
In any case, this particular denial of service attack should be easy to fix by
adding SVC_DESTROY to the Ganesha umount code path(s).
Should I do SVC_DESTROY or SVC_RELEASE in unmount?
SVC_DESTROY, as it sets the atomic bit telling other parts of the code to
stop making more references. It then calls SVC_RELEASE code path.
SVC_RELEASE alone sets a different bit after the count goes to zero. In a
perfect world, this bit wouldn't have been needed, but we've had years of
problems with the refs bouncing up again. Maybe we've finally fixed them all,
but that bit doesn't hurt anything.
Also I am not sure if we will hit this issue if client mount and
reboot without unmount.
I will test that, will unmount fix work in that case?
Possibly not, but that should be a different patch. Keep the patch focused,
fixing one problem that we all can then test has been fixed.
Do you have a production environment or customer report where
this occurred?
No its not customer issue,
[...]
I am with Nutanix.
-Gaurav
Knowing that this will be needed in a distribution will help the argument for
backporting to earlier releases.
Thanks.