3:30 a.m.
On Tue, 12 Apr 2022 07:21:29 -0700, "Frank Filz"
<ffilzlnx(a)mindspring.com> wrote:
> I have implemented NFSv4 -> POSIX ACL mapping in FSAL_VFS. I
would like to
> submit a simplified version that doesn't attempt to build on FreeBSD. That
> would vastly simplify the code and reduce the amount of review required. It
> would look something like this:
>
> https://github.com/martin-schwenke/nfs-ganesha/commits/vfs-acls-no-
> freebsd
>
> Some of the "build" commits could be squashed together if desired.
That sounds like a reasonable way to proceed. Please do squash
commits as appropriate.
Thanks for the feedback.
I did some more cleanups and got it down to 9 commits. The commits
should be nice and easy to review the way they are. I'm happy to
accept any other suggestions for more squashing. I come from a Samba
background, where tiny, simple-to-review patches are the norm.
Latest is also at:
https://github.com/martin-schwenke/nfs-ganesha/commits/vfs-acls
One of the commits has a bit of commentary where I've probably got the
cmake-fu wrong. Heh, that probably applies to other commits too... :-)
I suppose we could take a set of fixes for FreeBSD but I'm not
sure
how worthwhile that is if we are not committing to full support. What
might be an option is to push your FreeBSD fixes branch into the
nfs-ganesha Github repo so someone coming along later wanting to make
FreeBSD work again could look to those patches to jump start their
efforts.
I'll keep my branches around and hopefully anyone how comes across this
thread can find them. Happy to push them somewhere else too.
[...]
If there's no visible "champion" for FreeBSD, we should
let it drift
back into bit rot.
Yep, I think this is true. It seems to be a platform that requires
expertise to develop for...
> If people agree then, to simplify the code, I can drop all of
the
> FreeBSD compatibility and only enable the ACL mapping if Linux's
> acl/libacl.h is available.
Yes, please do so.
Done. Pushed to gerrithub.
peace & happiness,
martin