Change in ...nfs-ganesha[next]: FSAL_GLUSTER: add support for security labels
by Name of user not set (GerritHub)
arjsharm(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/441301
Change subject: FSAL_GLUSTER: add support for security labels
......................................................................
FSAL_GLUSTER: add support for security labels
Have FSAL_GLUSTER set and provide security labels using an xattr. Add a
new export option that specifies the name of the xattr in which
the labels should be stored.
Signed-off-by: Arjun Sharma <arjsharm(a)redhat.com>
Change-Id: I7bd39d28cf0cd7b7ad09ae88c3acf8b1575e8cd6
---
M src/FSAL/FSAL_GLUSTER/export.c
M src/FSAL/FSAL_GLUSTER/gluster_internal.c
M src/FSAL/FSAL_GLUSTER/gluster_internal.h
M src/FSAL/FSAL_GLUSTER/handle.c
4 files changed, 101 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/441301/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/441301
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I7bd39d28cf0cd7b7ad09ae88c3acf8b1575e8cd6
Gerrit-Change-Number: 441301
Gerrit-PatchSet: 1
Gerrit-Owner: arjsharm(a)redhat.com
Gerrit-MessageType: newchange
5 years, 10 months
Change in ...nfs-ganesha[next]: Remove -Wabi from maintainer mode
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/441170
Change subject: Remove -Wabi from maintainer mode
......................................................................
Remove -Wabi from maintainer mode
-Wabi on it's own doesn't apparently do anything, as it's comparing the
ABI to the current version. This is now a warning on gcc 8, causing
failures with -Werror and C++ (so with GTest)
Change-Id: Ie0a05f90028eb6c2cbf4665eed792dafbdd6b2fb
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/cmake/maintainer_mode.cmake
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/441170/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/441170
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie0a05f90028eb6c2cbf4665eed792dafbdd6b2fb
Gerrit-Change-Number: 441170
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Announce Push of V2.8-dev.14
by Frank Filz
Branch next
Tag:V2.8-dev.14
Release Highlights
* Fix GTest build
* Fix attribute comparison in NFS4_OP_VERIFY
* Fix READDIR duplicate entries
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
74ab010 Frank S. Filz V2.8-dev.14
5dc6a70 Daniel Gryniewicz Fix READDIR duplicate entries
770d8c7 Daniel Gryniewicz Fix attribute comparison in NFS4_OP_VERIFY
8bcd38e Daniel Gryniewicz Fix GTest build
5 years, 10 months
Change in ...nfs-ganesha[next]: Recall delegation if CB_GETATTR not supported
by Soumya (GerritHub)
Soumya has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440771
Change subject: Recall delegation if CB_GETATTR not supported
......................................................................
Recall delegation if CB_GETATTR not supported
RFC states that if a client is granted write delegation, it should
be enquired for file attributes via CB_GETATTR before sending response
to GETATTR. However server may choose to recall delegation instead.
This patch handles the second case which is to recall delegation
incase CB_GETATTR support is not handled.
Change-Id: I4ece38f0f433e0fc422a96964b678a8c84af64ce
Signed-off-by: Soumya Koduri <skoduri(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_getattr.c
M src/SAL/state_deleg.c
M src/include/sal_functions.h
3 files changed, 46 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/71/440771/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440771
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4ece38f0f433e0fc422a96964b678a8c84af64ce
Gerrit-Change-Number: 440771
Gerrit-PatchSet: 1
Gerrit-Owner: Soumya <skoduri(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Change in ...nfs-ganesha[next]: Recall write delegation only if it conflicts with other clients` access
by Soumya (GerritHub)
Soumya has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440770
Change subject: Recall write delegation only if it conflicts with other clients` access
......................................................................
Recall write delegation only if it conflicts with other clients` access
NFS client should be able to perform some operations like setattr or
reopen with different claim type while still holding write delegation.
Hence the server should check and recall delegations only if there is
conflicting access from other clients.
Added a new field in state_hdl->file structure to store the client
which has been granted write delegation. This is compared with
op_ctx->client to check if its the same client performing operations.
Also included a helper function to verify if the file has been write
delegated and if yes to return the client pointer.
Change-Id: Ifbe10bd3350fb9553a29b3b7ab13c6812c99b1fa
Signed-off-by: Soumya Koduri <skoduri(a)redhat.com>
---
M src/SAL/nfs4_state.c
M src/SAL/state_deleg.c
M src/include/sal_data.h
M src/include/sal_functions.h
4 files changed, 52 insertions(+), 4 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/440770/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440770
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ifbe10bd3350fb9553a29b3b7ab13c6812c99b1fa
Gerrit-Change-Number: 440770
Gerrit-PatchSet: 1
Gerrit-Owner: Soumya <skoduri(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Change in ...nfs-ganesha[next]: SAL: Handle open claim of type OPEN_DELEG_CUR_FH
by Soumya (GerritHub)
Soumya has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440769
Change subject: SAL: Handle open claim of type OPEN_DELEG_CUR_FH
......................................................................
SAL: Handle open claim of type OPEN_DELEG_CUR_FH
As stated in NFSv4.1, handle the OPENs of cliam type
OPEN_DELEG_CUR_FH which is similar to OPEN_DELEGATE_CUR
but identified by current filehandle.
Change-Id: Ice45d60fe504380e411e610a6d87b5361686c0d2
Signed-off-by: Soumya Koduri <skoduri(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_open.c
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/69/440769/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440769
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ice45d60fe504380e411e610a6d87b5361686c0d2
Gerrit-Change-Number: 440769
Gerrit-PatchSet: 1
Gerrit-Owner: Soumya <skoduri(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Change in ...nfs-ganesha[next]: Fix READDIR duplicate entries
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440759
Change subject: Fix READDIR duplicate entries
......................................................................
Fix READDIR duplicate entries
In 654dd706d22663c6ae6029e0c8c5814fe0d6ff6a, it backed up when a chunk
was reloaded, causing duplicate entries. Instead, we just need to NULL
out the chunk pointer.
Change-Id: I8342117bb705aa0985bfd62d5de2dc27388e7612
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
1 file changed, 3 insertions(+), 20 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/440759/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440759
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I8342117bb705aa0985bfd62d5de2dc27388e7612
Gerrit-Change-Number: 440759
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Change in ...nfs-ganesha[next]: Fix attribute comparison in NFS4_OP_VERIFY
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440749
Change subject: Fix attribute comparison in NFS4_OP_VERIFY
......................................................................
Fix attribute comparison in NFS4_OP_VERIFY
Our attribute comparison was broken. It was comparing supported_attrs
correctly, but otherwise it was only ever comparing the first attribute
over and over.
In addition, it was assuming that the client creates the bitmaps and
attributes exactly like Ganesha does. However some clients, for
example VMWare, generate bitmaps that are longer than necessary and
zero-filled. This is correct, and we should handle it.
The new code walks the two bitmaps in parallel, compares set bits, and
then compares the value for attributes with both bits set.
Change-Id: Ia72125b64f949a3f9cc3f4e2269f7e5edb44db4c
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_verify.c
M src/Protocols/NFS/nfs_proto_tools.c
2 files changed, 93 insertions(+), 41 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/440749/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440749
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ia72125b64f949a3f9cc3f4e2269f7e5edb44db4c
Gerrit-Change-Number: 440749
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Change in ...nfs-ganesha[next]: Fix GTest build
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440748
Change subject: Fix GTest build
......................................................................
Fix GTest build
Change-Id: Ia11ae94536603f031a0331d7a9e40c18eb470a9f
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/include/nfs_proto_functions.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/48/440748/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/440748
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ia11ae94536603f031a0331d7a9e40c18eb470a9f
Gerrit-Change-Number: 440748
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Announce Push of V2.8-dev.13
by Frank Filz
Branch next
Tag:V2.8-dev.13
Release Highlights
* nfs4_Compound.c: cleanup use of thisarg and thisres
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
3e8f473 Frank S. Filz V2.8-dev.13
ad618ef Frank S. Filz nfs4_Compound.c: cleanup use of thisarg and thisres
5 years, 10 months