gandi buildbot notifications on success
by Dominique Martinet
Hi,
I'm not sure who's managing the gandi cloud build system so shooting in
the dark :)
I noticed that we also get mails when a patch works - I think it's good
to reduce the mail spam from gerrit as much as possible so on success it
would be good to not notify users (so we don't miss the mail when
there's a failure) - would it be possible to get that to happen?
Technically you need to add a "notify: none" field to the json request
if you're dealing with this low-ish level interface. I have no idea how
buildbot is interfaced with gerrit but in jenkins there's a simple
checkbox to toggle "don't notify on success" or simiar..
Thanks!
--
Dominique Martinet (Asmadeus on the irc channel if this needs discussing)
5 years, 10 months
Change in ...nfs-ganesha[next]: RFC: [do not merge] (lib)ganesha_nfsd as a DSO
by Name of user not set (GerritHub)
kaleb(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/439583
Change subject: RFC: [do not merge] (lib)ganesha_nfsd as a DSO
......................................................................
RFC: [do not merge] (lib)ganesha_nfsd as a DSO
Build ganesha as a DSO, i.e. libganesha_nfsd.so.
Take No. Two, addressing comments from the first go-around.
The ganesha.nfsd daemon consists of just nfs_main:main() and is
linked with the DSO.
Then all the FSALs (except FSAL_PSEUDO and FSAL_MDCACHE*) are linked
with libganesha_nfsd resolution of functions in ganesha.nfsd itself.
This will be required if, e.g., Fedora, decides to require default
linking with '-z defs'. They tried to do it for F29 but retreated
when they found that too many applications broke. In the end this may
all be just an exercise in "truth and beauty."
*FSAL_PSEUDO and FSAL_MDCACHE are special; they are included in the
DSO so do not need to be (and can't be) linked with the DSO.
A few other things that could be done are
1) link libganesha_nfsd.so with a .sym file to explicitly control which
symbols are exposed or visible to the outside world.
2) build with -flto (Link Time Optimization)
Annecdotes claim a 5-10% speed improvement is typical, and some
applications have seen as much as 45-50% boost. Of course we have to
do the experiment to see what we can really achieve.
3) don't link ganesha.nfsd with -bdynamic as it's no longer needed
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
Change-Id: I6736246db31564a0207bc6dc433c896e1f6fdddb
---
M src/FSAL/FSAL_CEPH/CMakeLists.txt
M src/FSAL/FSAL_GLUSTER/CMakeLists.txt
M src/FSAL/FSAL_GPFS/CMakeLists.txt
M src/FSAL/FSAL_MEM/CMakeLists.txt
M src/FSAL/FSAL_PROXY/CMakeLists.txt
M src/FSAL/FSAL_RGW/CMakeLists.txt
M src/FSAL/FSAL_VFS/panfs/CMakeLists.txt
M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt
M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt
M src/MainNFSD/CMakeLists.txt
M src/nfs-ganesha.spec-in.cmake
11 files changed, 516 insertions(+), 26 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/439583/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/439583
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I6736246db31564a0207bc6dc433c896e1f6fdddb
Gerrit-Change-Number: 439583
Gerrit-PatchSet: 1
Gerrit-Owner: kaleb(a)redhat.com
Gerrit-MessageType: newchange
5 years, 10 months
FW: Change in ...nfs-ganesha[next]: Make nfs4 read and write async capable
by Frank Filz
Patrice,
I think Dominique found the issue with my patch set, unfortunately the CEA CI is still running against the previous version. It maybe has sped up some, but it’s still taking quite some time to run through all the patches.
Is there anything more that can be done to speed it up?
Thanks
Frank
From: CEA-HPC (GerritHub) [mailto:gerrit@gerrithub.io]
Sent: Tuesday, January 8, 2019 9:28 AM
To: Frank Filz <ffilzlnx(a)mindspring.com>
Cc: Gluster Community Jenkins <gerrithub(a)gluster.org>; Daniel Gryniewicz <dang(a)redhat.com>; Patrice LUCAS <patrice.lucas(a)cea.fr>; Malahal <malahal(a)gmail.com>
Subject: Change in ...nfs-ganesha[next]: Make nfs4 read and write async capable
Build OK - NFSv4.1 proxy mount failed
mount proxy:
server proxy:
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] main :MAIN :EVENT :ganesha.nfsd Starting: Ganesha Version V2.7-rc4-201-g1ba8bce7b, built at Jan 8 2019 15:16:52 on vm1.pcocc.c-inti.ccc.ocre.cea.fr
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] nfs_set_param_from_conf :NFS STARTUP :EVENT :Configuration file successfully parsed
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] init_server_pkgs :NFS STARTUP :EVENT :Initializing ID Mapper.
[New Thread 0x7ffff4ac0700 (LWP 5271)]
[New Thread 0x7ffff42bf700 (LWP 5272)]
[New Thread 0x7ffff3a7e700 (LWP 5273)]
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] init_server_pkgs :NFS STARTUP :EVENT :ID Mapper successfully initialized.
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] nfs_start_grace :STATE :EVENT :NFS Server skipping GRACE (Graceless is true)
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] lower_my_caps :NFS STARTUP :EVENT :CAP_SYS_RESOURCE was successfully removed for proper quota management in FSAL
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] lower_my_caps :NFS STARTUP :EVENT :currenty set capabilities are: = cap_chown,cap_dac_override,cap_dac_read_search,cap_fowner,cap_fsetid,cap_kill,cap_setgid,cap_setuid,cap_setpcap,cap_linux_immutable,cap_net_bind_service,cap_net_broadcast,cap_net_admin,cap_net_raw,cap_ipc_lock,cap_ipc_owner,cap_sys_module,cap_sys_rawio,cap_sys_chroot,cap_sys_ptrace,cap_sys_pacct,cap_sys_admin,cap_sys_boot,cap_sys_nice,cap_sys_time,cap_sys_tty_config,cap_mknod,cap_lease,cap_audit_write,cap_audit_control,cap_setfcap,cap_mac_override,cap_mac_admin,cap_syslog,35,36+ep
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[pxy_clientid_renewer] pxy_setclientid :FSAL :EVENT :Negotiating a new ClientId with the remote server
08/01/2019 15:16:58 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] gsh_dbus_pkginit :DBUS :CRIT :server bus reg failed (org.ganesha.nfsd, Connection ":1.27" is not allowed to own the service "org.ganesha.nfsd" due to security policies in the configuration file)
[New Thread 0x7ffff0a2f700 (LWP 5274)]
[New Thread 0x7ffff022e700 (LWP 5275)]
[New Thread 0x7fffecaf3700 (LWP 5276)]
[New Thread 0x7fffec9f2700 (LWP 5277)]
[New Thread 0x7fffec8f1700 (LWP 5279)]
[New Thread 0x7fffec7f0700 (LWP 5281)]
[New Thread 0x7fffec6ef700 (LWP 5282)]
[New Thread 0x7fffec5ee700 (LWP 5283)]
[New Thread 0x7fffec4ed700 (LWP 5284)]
[New Thread 0x7fffec2eb700 (LWP 5286)]
[New Thread 0x7fffec3ec700 (LWP 5285)]
[New Thread 0x7fffec1ea700 (LWP 5287)]
[New Thread 0x7fffcffff700 (LWP 5288)]
[New Thread 0x7fffcfdfd700 (LWP 5290)]
[New Thread 0x7fffcfefe700 (LWP 5289)]
08/01/2019 15:16:59 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] nfs_Init_svc :DISP :CRIT :Cannot acquire credentials for principal nfs
08/01/2019 15:16:59 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] nfs_Init_admin_thread :NFS CB :EVENT :Admin thread initialized
08/01/2019 15:16:59 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] nfs_rpc_cb_init_ccache :NFS STARTUP :EVENT :Callback creds directory (/var/run/ganesha) already exists
08/01/2019 15:16:59 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] nfs_rpc_cb_init_ccache :NFS STARTUP :WARN :gssd_refresh_krb5_machine_credential failed (-1765328160:0)
08/01/2019 15:16:59 : epoch 5c34beea : vm1.pcocc.c-inti.ccc.ocre.cea.fr : ganesha.nfsd-5267[main] nfs_Start_threads :THREAD :EVENT :Starting delayed executor.
[New Thread 0x7fffcf8c0700 (LWP 5291)]
[New Thread 0x7fffcf0bf700 (LWP 5292)]
[New Thread 0x7fffce8be700 (LWP 5293)]
[New Thread 0x7fffce0bd700 (LWP 5294)]
[New Thread 0x7fffcd8bc700 (LWP 5295)]
[New Thread 0x7fffcd0bb700 (LWP 5296)]
[New Thread 0x7fffcc8ba700 (LWP 5297)]
[New Thread 0x7fffaffff700 (LWP 5298)]
[New Thread 0x7fffaf7fe700 (LWP 5299)]
[New Thread 0x7fffaeffd700 (LWP 5300)]
[New Thread 0x7fffae7fc700 (LWP 5301)]
[New Thread 0x7fffadffb700 (LWP 5302)]
[New Thread 0x7fffad7fa700 (LWP 5303)]
[New Thread 0x7fffacff9700 (LWP 5304)]
[New Thread 0x7fffac7f8700 (LWP 5305)]
[New Thread 0x7fffabff7700 (LWP 5306)]
[New Thread 0x7fffab7f6700 (LWP 5307)]
[New Thread 0x7fffaaff5700 (LWP 5308)]
[New Thread 0x7fffaa7f4700 (LWP 5309)]
[New Thread 0x7fffa9ff3700 (LWP 5310)]
[New Thread 0x7fffa97f2700 (LWP 5311)]
[New Thread 0x7fffa8ff1700 (LWP 5312)]
[New Thread 0x7fffa87f0700 (LWP 5313)]
[New Thread 0x7fffa7fef700 (LWP 5314)]
[New Thread 0x7fffa77ee700 (LWP 5315)]
[New Thread 0x7fffa6fed700 (LWP 5316)]
[New Thread 0x7fffa67ec700 (LWP 5317)]
[New Thread 0x7fffa5feb700 (LWP 5318)]
[New Thread 0x7fffa57ea700 (LWP 5319)]
[New Thread 0x7fffa4fe9700 (LWP 5320)]
[New Thread 0x7fffa47e8700 (LWP 5321)]
[New Thread 0x7fffa3fe7700 (LWP 5322)]
[New Thread 0x7fffa37e6700 (LWP 5323)]
[New Thread 0x7fffa2fe5700 (LWP 5324)]
[New Thread 0x7fffa27e4700 (LWP 5325)]
[New Thread 0x7fffa1fe3700 (LWP 5326)]
[New Thread 0x7fffa17e2700 (LWP 5327)]
[New Thread 0x7fffa0fe1700 (LWP 5328)]
[New Thread 0x7fffa07e0700 (LWP 5329)]
[New Thread 0x7fff9ffdf700 (LWP 5330)]
[New Thread 0x7fff9f7de700 (LWP 5331)]
[New Thread 0x7fff9efdd700 (LWP 5332)]
[New Thread 0x7fff9e7dc700 (LWP 5333)]
[New Thread 0x7fff9dfdb700 (LWP 5334)]
[New Thread 0x7fff9d7da700 (LWP 5335)]
[New Thread 0x7fff9cfd9700 (LWP 5336)]
[New Thread 0x7fff9c7d8700 (LWP 5337)]
[New Thread 0x7fff9bfd7700 (LWP 5338)]
[New Thread 0x7fff9b7d6700 (LWP 5339)]
[New Thread 0x7fff9afd5700 (LWP 5340)]
[New Thread 0x7fff9a7d4700 (LWP 5341)]
[New Thread 0x7fff99fd3700 (LWP 5342)]
[New Thread 0x7fff997d2700 (LWP 5343)]
[New Thread 0x7fff98fd1700 (LWP 5344)]
[New Thread 0x7fff987d0700 (LWP 5345)]
[New Thread 0x7fff97fcf700 (LWP 5346)]
[New Thread 0x7fff977ce700 (LWP 5347)]
[New Thread 0x7fff96fcd700 (LWP 5348)]
[New Thread 0x7fff967cc700 (LWP 5349)]
[New Thread 0x7fff95fcb700 (LWP 5350)]
[New Thread 0x7fff957ca700 (LWP 5351)]
[New Thread 0x7fff94fc9700 (LWP 5352)]
[New Thread 0x7fff947c8700 (LWP 5353)]
[New Thread 0x7fff93fc7700 (LWP 5354)]
[New Thread 0x7fff937c6700 (LWP 5355)]
[New Thread 0x7fff92fc5700 (LWP 5356)]
[New Thread 0x7fff927c4700 (LWP 5357)]
[New Thread 0x7fff91fc3700 (LWP 5358)]
[New Thread 0x7fff917c2700 (LWP 5359)]
[New Thread 0x7fff90fc1700 (LWP 5360)]
[New Thread 0x7fff907c0700 (LWP 5361)]
[New Thread 0x7fff8ffbf700 (LWP 5362)]
[New Thread 0x7fff8f7be700 (LWP 5363)]
[New Thread 0x7fff8efbd700 (LWP 5364)]
[New Thread 0x7fff8e7bc700 (LWP 5365)]
[New Thread 0x7fff8dfbb700 (LWP 5366)]
[New Thread 0x7fff8d7ba700 (LWP 5367)]
[New Thread 0x7fff8cfb9700 (LWP 5368)]
[New Thread 0x7fff8c7b8700 (LWP 5369)]
[New Thread 0x7fff8bfb7700 (LWP 5370)]
[New Thread 0x7fff8b7b6700 (LWP 5371)]
[New Thread 0x7fff8afb5700 (LWP 5372)]
[New Thread 0x7fff8a7b4700 (LWP 5373)]
[New Thread 0x7fff89fb3700 (LWP 5374)]
[New Thread 0x7fff897b2700 (LWP 5375)]
[New Thread 0x7fff88fb1700 (LWP 5376)]
[New Thread 0x7fff887b0700 (LWP 5377)]
[New Thread 0x7fff87faf700 (LWP 5378)]
[New Thread 0x7fff877ae700 (LWP 5379)]
[New Thread 0x7fff86fad700 (LWP 5380)]
[New Thread 0x7fff867ac700 (LWP 5381)]
[New Thread 0x7fff85fab700 (LWP 5382)]
[New Thread 0x7fff857aa700 (LWP 5383)]
[New Thread 0x7fff84fa9700 (LWP 5384)]
[New Thread 0x7fff847a8700 (LWP 5385)]
[New Thread 0x7fff83fa7700 (LWP 5386)]
[New Thread 0x7fff837a6700 (LWP 5387)]
[New Thread 0x7fff82fa5700 (LWP 5388)]
[New Thread 0x7fff827a4700 (LWP 5389)]
[New Thread 0x7fff81fa3700 (LWP 5390)]
[New Thread 0x7fff817a2700 (LWP 5391)]
[New Thread 0x7fff80fa1700 (LWP 5392)]
[New Thread 0x7fff807a0700 (LWP 5393)]
[New Thread 0x7fff7ff9f700 (LWP 5394)]
[New Thread 0x7fff7f79e700 (LWP 5395)]
[New Thread 0x7fff7ef9d700 (LWP 5396)]
[New Thread 0x7fff7e79c700 (LWP 5397)]
[New Thread 0x7fff7df9b700 (LWP 5398)]
[New Thread 0x7fff7d79a700 (LWP 5399)]
[New Thread 0x7fff7cf99700 (LWP 5400)]
[New Thread 0x7fff7c798700 (LWP 5401)]
[New Thread 0x7fff7bf97700 (LWP 5402)]
[New Thread 0x7fff7b796700 (LWP 5403)]
[New Thread 0x7fff7af95700 (LWP 5404)]
[New Thread 0x7fff7a794700 (LWP 5405)]
[New Thread 0x7fff79f93700 (LWP 5406)]
[New Thread 0x7fff79792700 (LWP 5407)]
[New Thread 0x7fff78f91700 (LWP 5408)]
[New Thread 0x7fff78790700 (LWP 5409)]
[New Thread 0x7fff77f8f700 (LWP 5410)]
[New Thread 0x7fff7778e700 (LWP 5411)]
[New Thread 0x7fff76f8d700 (LWP 5412)]
[New Thread 0x7fff7678c700 (LWP 5413)]
[New Thread 0x7fff75f8b700 (LWP 5414)]
[New Thread 0x7fff7578a700 (LWP 5415)]
[New Thread 0x7fff74f89700 (LWP 5416)]
[New Thread 0x7fff74788700 (LWP 5417)]
[New Thread 0x7fff73f87700 (LWP 5418)]
[New Thread 0x7fff73786700 (LWP 5419)]
[New Thread 0x7fff72f85700 (LWP 5420)]
[New Thread 0x7fff72784700 (LWP 5421)]
[New Thread 0x7fff71f83700 (LWP 5422)]
[New Thread 0x7fff71782700 (LWP 5423)]
[New Thread 0x7fff70f81700 (LWP 5424)]
[New Thread 0x7fff70780700 (LWP 5425)]
[New Thread 0x7fff6ff7f700 (LWP 5426)]
[New Thread 0x7fff6f77e700 (LWP 5427)]
[New Thread 0x7fff6ef7d700 (LWP 5428)]
[New Thread 0x7fff6e77c700 (LWP 5429)]
[New Thread 0x7fff6df7b700 (LWP 5430)]
[New Thread 0x7fff6d77a700 (LWP 5431)]
[New Thread 0x7fff6cf79700 (LWP 5432)]
[New Thread 0x7fff6c778700 (LWP 5433)]
[New Thread 0x7fff6bf77700 (LWP 5434)]
[New Thread 0x7fff6b776700 (LWP 5435)]
[New Thread 0x7fff6af75700 (LWP 5436)]
[New Thread 0x7fff6a774700 (LWP 5437)]
[New Thread 0x7fff69f73700 (LWP 5438)]
[New Thread 0x7fff69772700 (LWP 5439)]
[New Thread 0x7fff68f71700 (LWP 5440)]
[New Thread 0x7fff68770700 (LWP 5441)]
[New Thread 0x7fff67f6f700 (LWP 5442)]
[New Thread 0x7fff6776e700 (LWP 5443)]
[New Thread 0x7fff66f6d700 (LWP 5444)]
[New Thread 0x7fff6676c700 (LWP 5445)]
[New Thread 0x7fff65f6b700 (LWP 5446)]
[New Thread 0x7fff6576a700 (LWP 5447)]
[New Thread 0x7fff64f69700 (LWP 5448)]
[New Thread 0x7fff64768700 (LWP 5449)]
[New Thread 0x7fff63f67700 (LWP 5450)]
[New Thread 0x7fff63766700 (LWP 5451)]
[New Thread 0x7fff62f65700 (LWP 5452)]
[New Thread 0x7fff62764700 (LWP 5453)]
[New Thread 0x7fff61f63700 (LWP 5454)]
[New Thread 0x7fff61762700 (LWP 5455)]
[New Thread 0x7fff60f61700 (LWP 5456)]
[New Thread 0x7fff60760700 (LWP 5457)]
[New Thread 0x7fff5ff5f700 (LWP 5458)]
[New Thread 0x7fff5f75e700 (LWP 5459)]
[New Thread 0x7fff5ef5d700 (LWP 5460)]
[New Thread 0x7fff5e75c700 (LWP 5461)]
[New Thread 0x7fff5df5b700 (LWP 5462)]
[New Thread 0x7fff5d75a700 (LWP 5463)]
[New Thread 0x7fff5cf59700 (LWP 5464)]
[New Thread 0x7fff5c758700 (LWP 5465)]
[New Thread 0x7fff5bf57700 (LWP 5466)]
[New Thread 0x7fff5b756700 (LWP 5467)]
[New Thread 0x7fff5af55700 (LWP 5468)]
[New Thread 0x7fff5a754700 (LWP 5469)]
[New Thread 0x7fff59f53700 (LWP 5470)]
[New Thread 0x7fff59752700 (LWP 5471)]
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffcfefe700 (LWP 5289)]
0x00007ffff7bb67ca in svc_request (xprt=0x7fffe4000bf0, xdrs=0x7fffb40008c0) at /opt/nfs-ganesha/src/libntirpc/src/svc_rqst.c:808
808 XDR_DESTROY(req->rq_xdrs);
#0 0x00007ffff7bb67ca in svc_request (xprt=0x7fffe4000bf0, xdrs=0x7fffb40008c0) at /opt/nfs-ganesha/src/libntirpc/src/svc_rqst.c:808
#1 0x00007ffff7bba1e0 in svc_vc_recv (xprt=0x7fffe4000bf0) at /opt/nfs-ganesha/src/libntirpc/src/svc_vc.c:800
#2 0x00007ffff7bb66ef in svc_rqst_xprt_task (wpe=0x7fffe4000e10) at /opt/nfs-ganesha/src/libntirpc/src/svc_rqst.c:774
#3 0x00007ffff7bb6ff7 in svc_rqst_epoll_loop (wpe=0x82d5b0) at /opt/nfs-ganesha/src/libntirpc/src/svc_rqst.c:1087
#4 0x00007ffff7bbfa74 in work_pool_thread (arg=0x7fffdc000fb0) at /opt/nfs-ganesha/src/libntirpc/src/work_pool.c:184
#5 0x00007ffff6371e25 in start_thread () from /lib64/libpthread.so.0
#6 0x00007ffff5a7634d in clone () from /lib64/libc.so.6
Patch set 14:Verified -1
View Change <https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/431234>
To view, visit change 431234 <https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/431234> . To unsubscribe, or for help writing mail filters, visit settings <https://review.gerrithub.io/settings> .
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ia5b93e9381ba0d67445c378d1745f8317525db85
Gerrit-Change-Number: 431234
Gerrit-PatchSet: 14
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> >
Gerrit-Reviewer: CEA-HPC <gerrithub-hpc(a)cea.fr <mailto:gerrithub-hpc@cea.fr> >
Gerrit-Reviewer: Daniel Gryniewicz <dang(a)redhat.com <mailto:dang@redhat.com> >
Gerrit-Reviewer: Dominique Martinet <asmadeus(a)codewreck.org <mailto:asmadeus@codewreck.org> >
Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> >
Gerrit-Reviewer: Gandi Buildbot <ganesha(a)gandi.net <mailto:ganesha@gandi.net> >
Gerrit-Reviewer: Gluster Community Jenkins <gerrithub(a)gluster.org <mailto:gerrithub@gluster.org> >
Gerrit-Reviewer: Malahal <malahal(a)gmail.com <mailto:malahal@gmail.com> >
Gerrit-Reviewer: Patrice LUCAS <patrice.lucas(a)cea.fr <mailto:patrice.lucas@cea.fr> >
Gerrit-Comment-Date: Tue, 08 Jan 2019 17:28:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
5 years, 10 months
NLM reclaim without Ganesha loosing the locks
by Suhrud Patankar
Hello All,
For one case in our cluster, I need to send sm-notify to the client
even when Ganesha has not restarted, but it is in Grace period.
So the client sends reclaim to a server which has not actually lost the locks.
Can Ganesha handle NLM reclaim locks without actually loosing the locks first?
Thanks & Regards,
Suhrud
5 years, 10 months
Announce Push of V2.8-dev.11
by Frank Filz
Branch next
Tag:V2.8-dev.11
Release Highlights
* Handle race while adding host to IP-name cache
* Drop useless code;
* Don't call nfs_req_creds if we don't have export
* cmake: append correct include dir for RADOS header files
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
246caad Frank S. Filz V2.8-dev.11
869d502 Jeff Layton cmake: append correct include dir for RADOS header files
b781319 Suhrud Patankar Don't call nfs_req_creds if we don't have export
6c3193c Bingyin Zhang Drop useless code;
9a55bb1 Sachin Punadikar Handle race while adding host to IP-name cache
5 years, 10 months
Change in ...nfs-ganesha[next]: cmake: append correct include dir for RADOS header files
by Jeff Layton (GerritHub)
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/439152
Change subject: cmake: append correct include dir for RADOS header files
......................................................................
cmake: append correct include dir for RADOS header files
If the RADOS headers are in a non-default location, then these objects
currently fail to build.
Change-Id: I39d6f9ddd370113fc240db1832fd12abf56843ea
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/support/CMakeLists.txt
M src/tools/CMakeLists.txt
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/439152/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/439152
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I39d6f9ddd370113fc240db1832fd12abf56843ea
Gerrit-Change-Number: 439152
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Change in ...nfs-ganesha[next]: Drop useless code;
by Name of user not set (GerritHub)
zhbingyin(a)sina.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/438950
Change subject: Drop useless code;
......................................................................
Drop useless code;
Change-Id: I41d4e06729fda551099199b526f4687b340c0638
Signed-off-by: Bingyin Zhang <zhbingyin(a)sina.com>
---
M src/FSAL/FSAL_GLUSTER/handle.c
M src/FSAL/FSAL_GPFS/handle.c
M src/support/nfs_filehandle_mgmt.c
3 files changed, 3 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/438950/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/438950
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I41d4e06729fda551099199b526f4687b340c0638
Gerrit-Change-Number: 438950
Gerrit-PatchSet: 1
Gerrit-Owner: zhbingyin(a)sina.com
Gerrit-MessageType: newchange
5 years, 10 months
Netgroup caching - race condition
by Sachin Punadikar
Hello All,
A customer reported that same client (part of netgroup) gets access allowed
for 1 request and access denied for another request. I found that due to
race conditions, only one thread will get success for adding particular
client/hosts to the netgroup cache and others will get error.
Here is the log snippet ...
================
10 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] worker_run :DISP :DEBUG :NFS protocol
request, reqdata=0x7f0a940537c0 xprt=0x7f0c54116450 requests=1
12 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] worker_run :DISP :DEBUG :NFS protocol
request, reqdata=0x7f0a94356d90 xprt=0x7f0c54116450 requests=2
13 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG
:EXPORT_DEFAULTS (options=42102002root_squash , ----, 3--, ---, TCP,
----, Manage_Gids , , anon_uid= -2, anon_gid= -2, sys)
14 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] export_check_access :EXPORT :M_DBG
:EXPORT_DEFAULTS (options=42102002root_squash , ----, 3--, ---, TCP,
----, Manage_Gids , , anon_uid= -2, anon_gid= -2, sys)
15 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG
:default options (options=03303002root_squash , ----, 34-, UDP, TCP,
----, No Manage_Gids, -- Deleg, anon_uid= -2, anon_gid= -2, none, sys)
16 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] export_check_access :EXPORT :M_DBG
:default options (options=03303002root_squash , ----, 34-, UDP, TCP,
----, No Manage_Gids, -- Deleg, anon_uid= -2, anon_gid= -2, none, sys)
17 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG :Final
options (options=42102002root_squash , ----, 3--, ---, TCP, ----,
Manage_Gids , -- Deleg, anon_uid= -2, anon_gid= -2, sys)
18 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] export_check_access :EXPORT :M_DBG :Final
options (options=42102002root_squash , ----, 3--, ---, TCP, ----,
Manage_Gids , -- Deleg, anon_uid= -2, anon_gid= -2, sys)
19 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] nfs_rpc_execute :DISP :DEBUG :Request
from ::ffff:53.55.134.154 for Program 100003, Version 3, Function 1 has
xid=2073167330
20 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] nfs_rpc_execute :DISP :DEBUG :Request
from ::ffff:53.55.134.154 for Program 100003, Version 3, Function 1 has
xid=2056390114
21 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] get_gsh_export :HT CACHE :DEBUG
:export_mgr cache hit slot 1
22 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] get_gsh_export :HT CACHE :DEBUG
:export_mgr cache hit slot 1
23 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] nfs_rpc_execute :EXPORT :M_DBG :EXPORT:
MID DEBUG: Found export entry for path=/net/gpfsm/fs1 as exportid=1
24 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] nfs_rpc_execute :EXPORT :M_DBG :EXPORT:
MID DEBUG: nfs_rpc_execute about to call nfs_export_check_access for client
::ffff:53.55.134.154
25 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] nfs_rpc_execute :EXPORT :M_DBG :EXPORT:
MID DEBUG: Found export entry for path=/net/gpfsm/fs1 as exportid=1
26 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] convert_ipv6_to_ipv4 :EXPORT :M_DBG
:Converting IPv6 encapsulated IPv4 address ::ffff:53.55.134.154 to IPv4
53.55.134.154
27 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] nfs_rpc_execute :EXPORT :M_DBG :EXPORT:
MID DEBUG: nfs_rpc_execute about to call nfs_export_check_access for client
::ffff:53.55.134.154
28 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] export_check_access :EXPORT :M_DBG :Check
for address 53.55.134.154 for export id 1 path /net/gpfsm/fs1
29 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] client_match :EXPORT :M_DBG :Match V4:
0x1486fe0 NETGROUP_CLIENT: sea (options=421021e2root_squash , RWrw, 3--,
---, TCP, ----, Manage_Gids , -- Deleg, anon_uid= -2, anon_gid= -2,
sys)
30 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] convert_ipv6_to_ipv4 :EXPORT :M_DBG
:Converting IPv6 encapsulated IPv4 address ::ffff:53.55.134.154 to IPv4
53.55.134.154
31 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG :Check
for address 53.55.134.154 for export id 1 path /net/gpfsm/fs1
32 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] client_match :EXPORT :M_DBG :Match V4:
0x1486fe0 NETGROUP_CLIENT: sea (options=421021e2root_squash , RWrw, 3--,
---, TCP, ----, Manage_Gids , -- Deleg, anon_uid= -2, anon_gid= -2,
sys)
33 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] nfs_ip_name_add :DISP :DEBUG :Inserting
53.55.134.154->SMTCAC2064.rd.corpintra.net to addr cache
34 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] nfs_ip_name_add :DISP :DEBUG :Inserting
53.55.134.154->SMTCAC2064.rd.corpintra.net to addr cache
35 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] client_match :EXPORT :M_DBG :Match V4:
0x148d320 NETGROUP_CLIENT: ep-gf01 (options=421021e2root_squash , RWrw,
3--, ---, TCP, ----, Manage_Gids , -- Deleg, anon_uid= -2, anon_gid=
-2, sys)
36 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG
:CLIENT (options=421021e2root_squash , RWrw, 3--, ---, TCP,
----, Manage_Gids , -- Deleg, anon_uid= -2, anon_gid= -2, sys)
37 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG
:EXPORT (options=03303002 , , ,
, , -- Deleg, , )
38 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG
:EXPORT_DEFAULTS (options=42102002root_squash , ----, 3--, ---, TCP,
----, Manage_Gids , , anon_uid= -2, anon_gid= -2, sys)
39 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG
:default options (options=03303002root_squash , ----, 34-, UDP, TCP,
----, No Manage_Gids, -- Deleg, anon_uid= -2, anon_gid= -2, none, sys)
40 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] export_check_access :EXPORT :M_DBG :Final
options (options=421021e2root_squash , RWrw, 3--, ---, TCP, ----,
Manage_Gids , -- Deleg, anon_uid= -2, anon_gid= -2, sys)
41 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] nfs_req_creds :EXPORT :M_DBG :EXPORT: MID
DEBUG: AUTH_SYS creds mapped to uid=26112, gid=50161, glen=14 (managed)
42 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] nfs3_getattr :NFS3 :DEBUG :REQUEST
PROCESSING: Calling nfs3_getattr handle: File Handle V3: Len=56
430000013030000a00020028000a0001055aa937f902000002000000000300f008000000000000000001000100fefe040000000000000000
43 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] cih_get_by_key_latch :HT CACHE :DEBUG
:cih cache hit slot 16168
44 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] fsal_get_xstat_by_handle :FSAL :DEBUG
:gpfs_ganesha: GET_XSTAT returned, fd 6 rc 0 fh_size 48
45 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-80] gpfsfsal_xstat_2_fsal_attributes :FSAL
:DEBUG :inode 149946371
...
...
70 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] export_check_access :EXPORT :M_DBG
:EXPORT (options=03303002 , , ,
, , -- Deleg, , )
71 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] export_check_access :EXPORT :M_DBG
:EXPORT_DEFAULTS (options=42102002root_squash , ----, 3--, ---, TCP,
----, Manage_Gids , , anon_uid= -2, anon_gid= -2, sys)
72 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] export_check_access :EXPORT :M_DBG
:default options (options=03303002root_squash , ----, 34-, UDP, TCP,
----, No Manage_Gids, -- Deleg, anon_uid= -2, anon_gid= -2, none, sys)
73 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] export_check_access :EXPORT :M_DBG :Final
options (options=42102002root_squash , ----, 3--, ---, TCP, ----,
Manage_Gids , -- Deleg, anon_uid= -2, anon_gid= -2, sys)
74 2018-12-19 16:09:54 : epoch 00080092 : smtcfc0203 :
gpfs.ganesha.nfsd-408410[work-62] nfs_rpc_execute :DISP :INFO :DISP: INFO:
Client ::ffff:53.55.134.154 is not allowed to access Export_Id 1
/net/gpfsm/fs1, vers=3, proc=1
================
I have uploaded patch to fix this kind of access errors:
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/438804
--
with regards,
Sachin Punadikar
5 years, 10 months
