December 2023 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: bind_conn_to_session: Validate check/add connection to session output
by Dipit Grover (GerritHub) 14 Dec '23

14 Dec '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173661?usp=email ) Change subject: bind_conn_to_session: Validate check/add connection to session output ...................................................................... bind_conn_to_session: Validate check/add connection to session output Currently during bind_conn_to_session op, Ganesha checks if the request's connection is part of the input session. If the check fails, it performs the required addition of the connection to the session. However, if the addition fails, it does not fail the op. This is incorrect, since the client would assume that the bind happened successfully, while the server maintained client's session still has no knowledge of the connection. This would cause failures in ops where Ganesha relies on the session's connection to validate the request. Change-Id: I5c36b5179e6cfda330178919278e597f6aad6b76 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/Protocols/NFS/nfs4_op_bind_conn.c 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/1173661/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173661?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5c36b5179e6cfda330178919278e597f6aad6b76 Gerrit-Change-Number: 1173661 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: gsh_rpc: Add method to display xprt's socket-address
by Dipit Grover (GerritHub) 14 Dec '23

14 Dec '23

Dipit Grover has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173660?usp=email ) Change subject: gsh_rpc: Add method to display xprt's socket-address ...................................................................... gsh_rpc: Add method to display xprt's socket-address Change-Id: I4ca4a8c38f64e99c3a5ef7cc3cb3721e82933e97 Signed-off-by: Dipit Grover <dipit(a)google.com> --- M src/RPCAL/rpc_tools.c M src/include/gsh_rpc.h 2 files changed, 17 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/60/1173660/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173660?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4ca4a8c38f64e99c3a5ef7cc3cb3721e82933e97 Gerrit-Change-Number: 1173660 Gerrit-PatchSet: 1 Gerrit-Owner: Dipit Grover <dipitgrover(a)gmail.com>

1 0

[S] Change in ...nfs-ganesha[next]: FSAL_CEPH : Add debug statements
by Sachin Punadikar (GerritHub) 14 Dec '23

14 Dec '23

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173621?usp=email ) Change subject: FSAL_CEPH : Add debug statements ...................................................................... FSAL_CEPH : Add debug statements Add return code and few debug statements to FSAL CEPH. Change-Id: I191e924c6837c9b8f9933fe12f5e685469d5d81a Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/FSAL/FSAL_CEPH/main.c 1 file changed, 32 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/1173621/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173621?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I191e924c6837c9b8f9933fe12f5e685469d5d81a Gerrit-Change-Number: 1173621 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Allow specifying python version
by Daniel Gryniewicz (GerritHub) 13 Dec '23

13 Dec '23

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173559?usp=email ) Change subject: Allow specifying python version ...................................................................... Allow specifying python version Many distros have multiple versions of python installed, and not all of them are created equal. In F38, for example, the "main" version is 3.11, but the highest version is 3.12. Allow specifying "-DWITH_PYTHON3=3.x" to choose a specific version. Change-Id: Ib434545a3c48769240e034e3965415c4b4fbb0fb Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/CMakeLists.txt 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/1173559/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173559?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib434545a3c48769240e034e3965415c4b4fbb0fb Gerrit-Change-Number: 1173559 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix monitoring build option
by Daniel Gryniewicz (GerritHub) 13 Dec '23

13 Dec '23

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173557?usp=email ) Change subject: Fix monitoring build option ...................................................................... Fix monitoring build option The USE_MONITORING build option wasn't correctly failing cmake if it was set to on but the libraries were not installed. Change-Id: I3fd60aab9f1ca0f69b7e0f33974486079134d985 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/57/1173557/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173557?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3fd60aab9f1ca0f69b7e0f33974486079134d985 Gerrit-Change-Number: 1173557 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Ignore clangd cache directory
by Daniel Gryniewicz (GerritHub) 13 Dec '23

13 Dec '23

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173556?usp=email ) Change subject: Ignore clangd cache directory ...................................................................... Ignore clangd cache directory Change-Id: I89aa3ee3ad0b485f66049a4a7973175147e42841 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M .gitignore 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/1173556/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173556?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I89aa3ee3ad0b485f66049a4a7973175147e42841 Gerrit-Change-Number: 1173556 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Fix compiler warnings for "-Werror" flag
by Sachin Punadikar (GerritHub) 12 Dec '23

12 Dec '23

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173508?usp=email ) Change subject: Fix compiler warnings for "-Werror" flag ...................................................................... Fix compiler warnings for "-Werror" flag While building Ganesha with -Werror flag, few warnings for uninitialized variables are observed. Fixing these warnings/errors. Change-Id: Ice52cb57e2cee996deb0959c0c9fb675cf338888 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/Protocols/NFS/nfs4_op_read.c M src/Protocols/NFS/nfs4_op_write.c M src/Protocols/NFS/nfs_proto_tools.c M src/tools/ganesha-rados-grace.c 4 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/1173508/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173508?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ice52cb57e2cee996deb0959c0c9fb675cf338888 Gerrit-Change-Number: 1173508 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 0

[XS] Change in ...nfs-ganesha[next]: NFSv4 READDIR should pass down the attrs from the request.
by Name of user not set (GerritHub) 12 Dec '23

12 Dec '23

drieber(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173507?usp=email ) Change subject: NFSv4 READDIR should pass down the attrs from the request. ...................................................................... NFSv4 READDIR should pass down the attrs from the request. See https://github.com/nfs-ganesha/nfs-ganesha/issues/1034 Change-Id: Idaa1a3c819a76996fc71e71e7c82e84f84372d2f Signed-off-by: David Rieber <drieber(a)google.com> --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/1173507/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173507?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idaa1a3c819a76996fc71e71e7c82e84f84372d2f Gerrit-Change-Number: 1173507 Gerrit-PatchSet: 1 Gerrit-Owner: drieber(a)google.com

1 0

Announce Push of V6-dev.1
by Frank Filz 09 Dec '23

09 Dec '23

Branch next Tag:V6-dev.1 Opening for new development for V6 Merge Highlights New Features * NFSv4+ Server to have limit for Open files per client * Enable the ability to update customized configuration capabilities in the FSAL layer through signal SIGHUP. Minor Changes and Bug Fixes * FSAL's state_free function called by free_state doesn't actually free * Issues in ganesha_stats json option * Resolving error in ganesha-top utility * Initialize export_opt_lock earlier. * malloc_trim is unsupported on darwin. * Fix use-of-uninitialized value error. * Fix: dec ref_count of confirmed client_id * Fix crash at free_client_id()->PTHREAD_MUTEX_destroy() * build: use standard (i.e. pep517) build and installer Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 14efa5105 Frank S. Filz V6-dev.1 23d4401bd Kaleb S. KEITHLEY build: use standard (i.e. pep517) build and installer 11533a6ca shuhaiwen Enable the ability to update customized configuration capabilities in the FSAL layer through signal SIGHUP. 70c386bb8 Prabhu Murugesan Fix crash at free_client_id()->PTHREAD_MUTEX_destroy() 95456f661 Rojin George NFSv4+ Server to have limit for Open files per client 9b353349f zhitaoli Fix: dec ref_count of confirmed client_id c87fa5f30 David Rieber Fix use-of-uninitialized value error. 848ee3320 David Rieber malloc_trim is unsupported on darwin. 6822ab8c2 David Rieber Initialize export_opt_lock earlier. bb3fe4fbe Trupti Shete Resolving error in ganesha-top utility 247e45d15 Trupti Shete Issue in ganesha_stats json option part_5 ea0ccbb73 Trupti Shete Issue in ganesha_stats json option part_4 d0ace9456 Trupti Shete Issue in ganesha_stats json option part_3 bad643006 Trupti Shete Issue in ganesha_stats json option part_2 7e55566e3 Trupti Shete ganesha_stats json issues part_1 a9a42e780 Frank S. Filz FSAL's state_free function called by free_state doesn't actually free

1 0

[XS] Change in ...nfs-ganesha[next]: Issue in ganesha_stats json option part_5
by Name of user not set (GerritHub) 04 Dec '23

04 Dec '23

tshete(a)ddn.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173083?usp=email ) Change subject: Issue in ganesha_stats json option part_5 ...................................................................... Issue in ganesha_stats json option part_5 Issue: ganesha_stats json inode is not showing stats related to LRU Utilization Data. Fix: Added LRU Utilization Data from dbus output to the json report. Change-Id: I9e69c05c8622e989539a4705c2ed60a6d3905c70 Signed-off-by: Trupti Shete <tshete(a)ddn.com> --- M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/1173083/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9e69c05c8622e989539a4705c2ed60a6d3905c70 Gerrit-Change-Number: 1173083 Gerrit-PatchSet: 1 Gerrit-Owner: tshete(a)ddn.com

1 0