December 2023 - Devel - NFS Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: Issue in ganesha_stats json option part_4
by Name of user not set (GerritHub) 04 Dec '23

04 Dec '23

tshete(a)ddn.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173082?usp=email ) Change subject: Issue in ganesha_stats json option part_4 ...................................................................... Issue in ganesha_stats json option part_4 Issue: ganesha_stats json total not showing export_id Fix: In the report for total stats export_id was not added. Due to that it was not displayed in the output for json total command. Added key 'id' and value for export_id in the total stats. Change-Id: Ie90abf0ed324392b0194176125f1a6f1330ffcf9 Signed-off-by: Trupti Shete <tshete(a)ddn.com> --- M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/1173082/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie90abf0ed324392b0194176125f1a6f1330ffcf9 Gerrit-Change-Number: 1173082 Gerrit-PatchSet: 1 Gerrit-Owner: tshete(a)ddn.com

1 0

[XS] Change in ...nfs-ganesha[next]: Issue in ganesha_stats json option part_3
by Name of user not set (GerritHub) 04 Dec '23

04 Dec '23

tshete(a)ddn.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173081?usp=email ) Change subject: Issue in ganesha_stats json option part_3 ...................................................................... Issue in ganesha_stats json option part_3 Issue: ganesha_stats json iomon is showing the stats twice. The output is having 2 entries for each export_id Fix: While creating the dict for showing json format stats for a export_id were appended twice. This was because the append operation was done in the inner loop. So during read and write ops the whole stats were getting appneded. Moved the append operation outside the inner loop. Change-Id: I8263257012ca981a52ec73d4e22fdcd313cb86fc Signed-off-by: Trupti Shete <tshete(a)ddn.com> --- M src/scripts/ganeshactl/Ganesha/glib_dbus_stats.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/1173081/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8263257012ca981a52ec73d4e22fdcd313cb86fc Gerrit-Change-Number: 1173081 Gerrit-PatchSet: 1 Gerrit-Owner: tshete(a)ddn.com

1 0

[XS] Change in ...nfs-ganesha[next]: Issue in ganesha_stats json option part_2
by Name of user not set (GerritHub) 04 Dec '23

04 Dec '23

tshete(a)ddn.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173080?usp=email ) Change subject: Issue in ganesha_stats json option part_2 ...................................................................... Issue in ganesha_stats json option part_2 Issue: ganesha_stats json fails from disable command Fix: ganesha_stats json with disable command should give message that disable is not supported command with json instead of failure. To resolve this disable command was added to the tuple for not available commands. Change-Id: I604cdc8f23d0866d03ee02b29551f03b4493d9f8 Signed-off-by: Trupti Shete <tshete(a)ddn.com> --- M src/scripts/ganeshactl/ganesha_stats.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/1173080/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I604cdc8f23d0866d03ee02b29551f03b4493d9f8 Gerrit-Change-Number: 1173080 Gerrit-PatchSet: 1 Gerrit-Owner: tshete(a)ddn.com

1 0

[XS] Change in ...nfs-ganesha[next]: ganesha_stats json issues part_1
by Name of user not set (GerritHub) 04 Dec '23

04 Dec '23

tshete(a)ddn.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173079?usp=email ) Change subject: ganesha_stats json issues part_1 ...................................................................... ganesha_stats json issues part_1 Issue: If no command is passed to ganesha_stats json in that case it gives error. Fix: The default command is not set for json option in ganesha_stats due to that it is failing if no command is passed. To resolve this issue DEFAULT_COMMAND is set to global and same is used in case of no json. So in future if there is any change in default command it will be applied in both the cases. Change-Id: Icb8d4f88a57543fc0bed9921d05314be82c34460 Signed-off-by: Trupti Shete <tshete(a)ddn.com> --- M src/scripts/ganeshactl/ganesha_stats.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/1173079/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173079?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icb8d4f88a57543fc0bed9921d05314be82c34460 Gerrit-Change-Number: 1173079 Gerrit-PatchSet: 1 Gerrit-Owner: tshete(a)ddn.com

1 0

[XS] Change in ...nfs-ganesha[next]: malloc_trim is unsupported on darwin.
by Name of user not set (GerritHub) 03 Dec '23

03 Dec '23

drieber(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173039?usp=email ) Change subject: malloc_trim is unsupported on darwin. ...................................................................... malloc_trim is unsupported on darwin. Change-Id: I0bbed7784fea1340536d1a0ec5e0971acdc61824 Signed-off-by: David Rieber <drieber(a)google.com> --- M src/MainNFSD/nfs_init.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1173039/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173039?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0bbed7784fea1340536d1a0ec5e0971acdc61824 Gerrit-Change-Number: 1173039 Gerrit-PatchSet: 1 Gerrit-Owner: drieber(a)google.com

1 0

[S] Change in ...nfs-ganesha[next]: Initialize export_opt_lock earlier.
by Name of user not set (GerritHub) 02 Dec '23

02 Dec '23

drieber(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173038?usp=email ) Change subject: Initialize export_opt_lock earlier. ...................................................................... Initialize export_opt_lock earlier. Change-Id: I62a1a01191ae7d8723af57098198fc4b4479851f Signed-off-by: David Rieber <drieber(a)google.com> --- M src/MainNFSD/nfs_lib.c M src/support/exports.c 2 files changed, 13 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/38/1173038/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173038?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I62a1a01191ae7d8723af57098198fc4b4479851f Gerrit-Change-Number: 1173038 Gerrit-PatchSet: 1 Gerrit-Owner: drieber(a)google.com

1 0

[M] Change in ...nfs-ganesha[next]: Move the log levels and components to a separate headfer file.
by Name of user not set (GerritHub) 02 Dec '23

02 Dec '23

drieber(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173037?usp=email ) Change subject: Move the log levels and components to a separate headfer file. ...................................................................... Move the log levels and components to a separate headfer file. This allows us to plugin our own logging framework and get unified logs for out fsal + ganesha. Change-Id: Ie0b268d2c15296c1f08d0ee8e1ce181ca4d81a93 Signed-off-by: David Rieber <drieber(a)google.com> --- M src/include/log.h A src/include/log_common.h 2 files changed, 97 insertions(+), 63 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/1173037/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1173037?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie0b268d2c15296c1f08d0ee8e1ce181ca4d81a93 Gerrit-Change-Number: 1173037 Gerrit-PatchSet: 1 Gerrit-Owner: drieber(a)google.com

1 0

[XS] Change in ...nfs-ganesha[next]: Resolving error in ganesha-top utility
by Name of user not set (GerritHub) 01 Dec '23

01 Dec '23

tshete(a)ddn.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172976?usp=email ) Change subject: Resolving error in ganesha-top utility ...................................................................... Resolving error in ganesha-top utility Because of merge conflicts ganesha-top utility was failing. It was giving error and below call-trace was observed: File "/usr/lib64/python3.6/site-packages/dbus/proxies.py", line 145, in __call__ **keywords) File "/usr/lib64/python3.6/site-packages/dbus/connection.py", line 651, in call_blocking message, timeout) dbus.exceptions.DBusException: org.ganesha.nfsd.exportstats: ShowCacheInode This issue occured because ShowCacheInode was replaced with ShowMDCache with commit 98771cef895e17ccaf2799dd8c21dec6f45b0af1 but it was not merged in ganesha-top. Updated ganesha-top utility to resolve above issue. Change-Id: Ia60c6c236005ed1897c03c41ea56e9afa43ea5b5 Signed-off-by: Trupti Shete <tshete(a)ddn.com> --- M src/scripts/ganesha-top/ganesha-top.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/1172976/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1172976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia60c6c236005ed1897c03c41ea56e9afa43ea5b5 Gerrit-Change-Number: 1172976 Gerrit-PatchSet: 1 Gerrit-Owner: tshete(a)ddn.com

1 0