September 2024 - Devel - Nfs Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: src: Clang formatting

by Lior Suliman (GerritHub)

Lior Suliman has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201308?usp=email ) Change subject: src: Clang formatting ...................................................................... src: Clang formatting Change-Id: I8c47d71bf6fcaf13296837bc042c179648988dd3 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/RPCAL/connection_manager.c M src/include/fsal_api.h M src/support/exports.c 3 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/08/1201308/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201308?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8c47d71bf6fcaf13296837bc042c179648988dd3 Gerrit-Change-Number: 1201308 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com>

3 days, 6 hours

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have eno...

by Name of user not set (GerritHub)

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201307?usp=email ) Change subject: nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry ...................................................................... nfs4_op_readdir: Always return NFS4ERR_TOOSMALL if we didn't have enough space for a single entry There were some flows that set it on failure and some that didn't. Better to always check on failure flow and set it. Change-Id: Ib2cde47fab7d9055d14495e335018a0e27b2d43f Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/1201307/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ib2cde47fab7d9055d14495e335018a0e27b2d43f Gerrit-Change-Number: 1201307 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

3 days, 6 hours

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: nfs4_op_readdir: Fix xdr memory allocation

by Name of user not set (GerritHub)

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201273?usp=email ) Change subject: nfs4_op_readdir: Fix xdr memory allocation ...................................................................... nfs4_op_readdir: Fix xdr memory allocation The memory allocation calculation for XDR encoding of READDIR response wasn't done well. The math as it was didn't really make sense, but the main problem was that if we reach the maximum size response we went over the allocated buffer size and got an error on encoding which caused us to return SERVER_FAULT. The maximum size possible happened when the dir entries filled the allocated buffer exactly, and reached EOF, since in that case we needed to also add a FALSE bool for the last entry. In this case we went over the allocated buffer and got an error. I fixed the memory allocation calculation, and hopefully made it more clear. I also tested it when returning the max response size and did not get an error. Change-Id: Ifd333efe292116e54b0e8089d2ed43916937d1b4 Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/Protocols/NFS/nfs4_op_readdir.c 1 file changed, 22 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/1201273/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifd333efe292116e54b0e8089d2ed43916937d1b4 Gerrit-Change-Number: 1201273 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

3 days, 20 hours

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: MDCACHE: Fix Coverity CID 502123 - fix lock inversion

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201234?usp=email ) Change subject: MDCACHE: Fix Coverity CID 502123 - fix lock inversion ...................................................................... MDCACHE: Fix Coverity CID 502123 - fix lock inversion Instead of doing the mdcache_dirent_invalidate_all in mdcache_refresh_attrs with the attr_lock held, pass the need for invalidate out to the one caller who needs it, who will take the content_lock and call mdcache_dirent_invalidate_all after dropping the attr_lock. Change-Id: I33d24bf4a69dab0de75f34ddd84dc3fcd80af4c2 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h 2 files changed, 19 insertions(+), 11 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/1201234/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I33d24bf4a69dab0de75f34ddd84dc3fcd80af4c2 Gerrit-Change-Number: 1201234 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

5 days, 19 hours

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix vfs_sub_getattrs if called for referral handling

by Christoph Martin (GerritHub)

Christoph Martin has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201193?usp=email ) Change subject: Fix vfs_sub_getattrs if called for referral handling ...................................................................... Fix vfs_sub_getattrs if called for referral handling Change-Id: I6146df185896a7991e527fa151353f2e9c0e9b54 Signed-off-by: Christoph Martin <martin(a)uni-mainz.de> --- M src/FSAL/FSAL_VFS/vfs/attrs.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/93/1201193/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6146df185896a7991e527fa151353f2e9c0e9b54 Gerrit-Change-Number: 1201193 Gerrit-PatchSet: 1 Gerrit-Owner: Christoph Martin <martin(a)uni-mainz.de>

6 days, 5 hours

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: State FD Limit for NFSv4 LOCK and NLM Lock/Share

by Rojin George (GerritHub)

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201044?usp=email ) Change subject: State FD Limit for NFSv4 LOCK and NLM Lock/Share ...................................................................... State FD Limit for NFSv4 LOCK and NLM Lock/Share Change-Id: Ie5f5e4a6de826e6384ff9569637e2b9318edc4f7 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/SAL/nfs4_state.c M src/SAL/nlm_state.c M src/SAL/state_misc.c M src/include/gsh_config.h M src/include/gsh_status.h M src/support/nfs_read_conf.c 6 files changed, 49 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1201044/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201044?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie5f5e4a6de826e6384ff9569637e2b9318edc4f7 Gerrit-Change-Number: 1201044 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 week

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Config Parser: Optimized the parsing of config file

by Shivam Singh (GerritHub)

Shivam Singh has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201043?usp=email ) Change subject: Config Parser: Optimized the parsing of config file ...................................................................... Config Parser: Optimized the parsing of config file The parser, maintaining a token table in a linkedlist having a lookup time O(n) has been changed to an AVL tree and now having a lookup time of O(logn). Further, keys for avl tree are the hash values of token strings which also saves the time for string comparision during lookup. Used avltree and city hash for implementation and found a remarkable improvement in parsing time. Without Optimization: Config file with 20000 exports taking ~ 1780s With Optimization: Config file with 20000 exports taking ~ 0s Config file with 100000 exports taking ~ 3s Change-Id: I92430eceea544c09cfaea4ed23eb6465148ab790 Signed-off-by: Shivam Singh <shivam.singh9(a)ibm.com> --- M src/config_parsing/analyse.c M src/config_parsing/analyse.h M src/config_parsing/conf_lex.l 3 files changed, 132 insertions(+), 45 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1201043/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201043?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I92430eceea544c09cfaea4ed23eb6465148ab790 Gerrit-Change-Number: 1201043 Gerrit-PatchSet: 1 Gerrit-Owner: Shivam Singh <shivam.singh9(a)ibm.com>

1 week

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: idmapper : Fix coverity issue

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200947?usp=email ) Change subject: idmapper : Fix coverity issue ...................................................................... idmapper : Fix coverity issue Fix coverity issues CID 502063 CID 502122 CID 502116 CID 502159 CID 502176 CID 502230 Change-Id: I639c486effb7eede831eb9189b82e8352b1fdee2 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/idmapper/idmapper.c 1 file changed, 20 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/1200947/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200947?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I639c486effb7eede831eb9189b82e8352b1fdee2 Gerrit-Change-Number: 1200947 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 week, 2 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: config: read various intervals as int

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200914?usp=email ) Change subject: config: read various intervals as int ...................................................................... config: read various intervals as int For reading various time intervals (in seconds) time_t structure is being used. As these are config parameters, reading them as integers would be more appropriate. This will fix coverity issue as well - CID 502057 Change-Id: I63b453f9c2bf818ad236aac6c8c4df985438028b Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/include/gsh_config.h 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/1200914/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1200914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I63b453f9c2bf818ad236aac6c8c4df985438028b Gerrit-Change-Number: 1200914 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 week, 2 days

1
0
0 / 0

blogsandarticlesonline

by 6lz91yf6＠maillazy.com

https://www.blogsandarticlesonline.com/ One day, a monkey drove his car near a lake. Sudden, he saw a tiger under a tree. The tiger saw him, too. The tiger ran very fast at the monkey. The monkey was very afraid and he and his car fell into the lake. The monkey couldn't swim and he shouted. A rabbit came and he jumped into the lake. The abbit swam to the monkey but did not help him. Both of them shouted forhelp. Luckily, a giraffe came along. He was very tall. He helped the rabbit and the monkey.

1 week, 3 days

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel September 2024