[XS] Change in ...nfs-ganesha[next]: Ensure delegation grant for read+write access
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1223914?usp=email )
Change subject: Ensure delegation grant for read+write access
......................................................................
Ensure delegation grant for read+write access
Delegations are denied when clients request both read and write
access (OPEN4_SHARE_ACCESS_READ | OPEN4_SHARE_ACCESS_WRITE).
Added !(args->share_access & OPEN4_SHARE_ACCESS_WRITE) to the first
condition in should_we_grant_deleg() to exclude read+write requests
from the read-only contention check.
Change-Id: Ie4aa157d65551e98a3945a8fb2427059c03476ab
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/SAL/state_deleg.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/1223914/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1223914?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie4aa157d65551e98a3945a8fb2427059c03476ab
Gerrit-Change-Number: 1223914
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
3 weeks, 2 days
Announce Push of V7.3
by Frank Filz
Branch next
Tag:V7.3
Merge Highlights
* Rework of IP address utility functions and replacement of libcidr
* Config Parsing: Allow 3 digit mask for IPv6 Export CIDRs
* Allow updating the UTF8 enforcement on a dynamic configuration change.
* Block signals immediately at the beginning of the main function.
* SAL: Fix crash during shutdown due to invalid svc_rqst_rec in
svc_rqst_expire_insert
* Several other bug fixes (see patch list in git or below in e-mail for full
list)
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
6d6328a10 Frank S. Filz V7.3
ca2722419 Oscar Ou Fix cid_mutex deadlock in reserve_lease_or_expire
8e9c2ec24 Eli Daian Block signals immediately at the beginning of the main
function.
92ed7468e Eli Daian Allow updating the UTF8 enforcement on a dynamic
configuration change.
31f11cb71 Sreedhar Agraharam Fix: Race condition between socket flush and
close
1b34f7727 Sreedhar Agraharam Added export_path label to export specific
metrics
746760024 Shahar Hochma Fix notify_granted_completion for NFSv4.1
9409b9948 Peter Schwenke Fix up the protocol number for SCTP in
FSAL_encode_ipv4_netaddr
ccc2abd1a Peter Schwenke Move IP related functions from rpc_tools. to
ip_utils.c
4265c5c48 Peter Schwenke Remove third party library libcidr
87aa1efcf Peter Schwenke Replace libcidr
ae99a4b1b Peter Schwenke Move 2 comments that were causing bizarre
clang-format behaviour
4621ecbff Peter Schwenke Fix ip_str_to_sockaddr for IPv6
b37df5d64 Peter Schwenke Config Parsing: Allow 3 digit mask for IPv6 Export
CIDRs
becc366e1 Nishant Puri SAL: Fix crash during shutdown due to invalid
svc_rqst_rec in svc_rqst_expire_insert
ddc9d3b42 Prabhu Murugesan Skip delegation lock conflict check when
delegation is disabled
5f4b88b22 Prabhu Murugesan Map ERR_FSAL_NOMEM to NFS4ERR_RESOURCE instead of
NFS4ERR_SERVERFAULT
c66ed599a Prabhu Murugesan Fix ganesha_mgr show idmapper_groups error
4c2971ed1 Prabhu Murugesan Set io_request in NFSv3/v4 read paths
b85fe149b Prabhu Murugesan Update config file with scale specific values
43c4d4b46 Prabhu Murugesan Fix race condition between file creation and
symlink repair in NFSv3
3 weeks, 5 days
[XS] Change in ...nfs-ganesha[next]: Fix WRITE delegation check in nfs4_op_getattr()
by Suhas Athani (GerritHub)
Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1223766?usp=email )
Change subject: Fix WRITE delegation check in nfs4_op_getattr()
......................................................................
Fix WRITE delegation check in nfs4_op_getattr()
Earlier the code compared gsh_client pointers, which failed to
differentiate distinct clients. Updated the check to use clientid
comparison so that CB_GETATTR is correctly triggered when a
different client holds the WRITE delegation.
Change-Id: I6bba2a8016978f0e1f7e3c1a5fe5ea20712737f2
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/Protocols/NFS/nfs4_op_getattr.c
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/1223766/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1223766?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I6bba2a8016978f0e1f7e3c1a5fe5ea20712737f2
Gerrit-Change-Number: 1223766
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>
3 weeks, 6 days