May 2025 - Devel - Nfs Ganesha List Archives

[M] Change in ...nfs-ganesha[next]: WIP fsal: Add delegation-aware FD reuse to fsal_start_io()

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214788?usp=email ) Change subject: WIP fsal: Add delegation-aware FD reuse to fsal_start_io() ...................................................................... WIP fsal: Add delegation-aware FD reuse to fsal_start_io() When a WRITE delegation is granted (DELEG_GRANTED), this change allows fsal_start_io() to reuse the associated file descriptor from the original open state, avoiding unnecessary reopen logic. This is done by resolving the delegated state to its openstate and attempting to start I/O on the related FD. Reference counting for openstate is properly maintained, and logs are added for both successful reuse and fallback paths. A placeholder is included for handling DELEG_RECALL_WIP cases in future updates. Change-Id: Ia52e44d9d9a2ad2f1e33a76cdbce888384eb1a72 Signed-off-by: s-athani <suhas.athani(a)ibm.com> --- M src/FSAL/commonlib.c 1 file changed, 61 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/1214788/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia52e44d9d9a2ad2f1e33a76cdbce888384eb1a72 Gerrit-Change-Number: 1214788 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 week, 4 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix compilation error for USE_MONITORING=OFF

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214775?usp=email ) Change subject: Fix compilation error for USE_MONITORING=OFF ...................................................................... Fix compilation error for USE_MONITORING=OFF Fixing the compilation error in case MONITORING is not enabled. The issue got introduced via commit 0e6d553a0 Change-Id: I5778cc285166673281dc244fffead4059304751c Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/monitoring/include/prometheus_exposer.h 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/1214775/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5778cc285166673281dc244fffead4059304751c Gerrit-Change-Number: 1214775 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 week, 4 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix CTAD maybe unsupported warning

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214732?usp=email to review the following change. Change subject: Fix CTAD maybe unsupported warning ...................................................................... Fix CTAD maybe unsupported warning Change-Id: I461fb1ba2d73c32150963bcd9083b11fb7d3a7e8 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/monitoring/prometheus_exposer.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/1214732/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214732?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I461fb1ba2d73c32150963bcd9083b11fb7d3a7e8 Gerrit-Change-Number: 1214732 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 week, 6 days

1
0
0 / 0

Announce Push of V7-dev.13

by Frank Filz

Branch next Tag:V7-dev.13 Merge Highlights * several Coverity fixes * Added mntpath label for export_id metrics. * SAL: NFS V3 locks not released prior to DBUS reply sent * idmapper: should not set idmapping_enabled to true by default * Config: Add support for Monitoring_Addr * Add missing bcond for UNWIND_ENRICHED_BT * selinux: Error observed during package install in cthon04 job * ganesha_mgr usage message correction * feat(dupreq): don't retire inflight entries Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: b84bcb996 Frank S. Filz V7-dev.13 dc8794271 zhitaoli feat(dupreq): don't retire inflight entries d8b872e2a Bipali Gade ganesha_mgr usage message correction f8e1b7d25 Kaleb S. KEITHLEY selinux: Error observed during package install in cthon04 job ce86a3f9c Kaleb S. KEITHLEY Add missing bcond for UNWIND_ENRICHED_BT 0e6d553a0 Sachin Punadikar Config: Add support for Monitoring_Addr b3441848d Vicente Cheng idmapper: should not set idmapping_enabled to true by default a7ea33434 Peter Schwenke SAL: NFS V3 locks not released prior to DBUS reply sent 64132bbb8 Animesh Javali Fix for coverity:542651 In encode_fs_locations: Added fix to prevent leak of memory or pointers to system resources 2b39895dc s-athani Coverity 502077 Overflowed array index write: In cidr_net_supernet: Write to array at integer-overflowed index. Fix integer underflow risk by validating CIDR prefix length. 9024b1bbe s-athani Coverity 509139 : In layoutcommit: A value assigned to a variable is never used. Stored value is overwritten before it can be used. Fix added. 62a34952f Frank S. Filz Added mntpath label for export_id metrics. f36ea8999 Rajesh Prasad Coverity Issue - 542648 e446486b6 Rajesh Prasad RDMA Transport Enablement for NFS v4.0, v4.1 and v4.2

1 week, 6 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: CID 461869: Fixed Resource leak by freeing of buf

by Name of user not set (GerritHub)

Yogendra.Tangalapally(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214641?usp=email ) Change subject: CID 461869: Fixed Resource leak by freeing of buf ...................................................................... CID 461869: Fixed Resource leak by freeing of buf CID 461869: Resource leak (RESOURCE_LEAK) leaked_storage: Variable buf going out of scope leaks the storage it points to. Change-Id: I384c488daf9742ca5496ef307b2aa439b2c7cbfb Signed-off-by: Yogendra Charya Tangalapally <Yogendra.Tangalapally(a)ibm.com> --- M src/FSAL/FSAL_GPFS/handle.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/41/1214641/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I384c488daf9742ca5496ef307b2aa439b2c7cbfb Gerrit-Change-Number: 1214641 Gerrit-PatchSet: 1 Gerrit-Owner: Yogendra.Tangalapally(a)ibm.com

2 weeks

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: selinux: Error observed during package install in cthon04 job

by Kaleb KEITHLEY (GerritHub)

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214444?usp=email ) Change subject: selinux: Error observed during package install in cthon04 job ...................................................................... selinux: Error observed during package install in cthon04 job https://github.com/nfs-ganesha/nfs-ganesha/issues/1259 In https://bugzilla.redhat.com/show_bug.cgi?id=2356228#c3 zpytela(a)redhat.com says: The type ceph_t is not defined and that's why installing fails. Such failures could be prevented using optional blocks. This change, using optional blocks, seems to work, in that it installs without the previously seen warning, but zptyela [ibid] says: You should rather look for the proper interface from the ceph module. But I can find nothing that looks applicable. Change-Id: Ibfcf71cd2781d7c50ef47e0b9b4cc6a0ce6423b6 Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/selinux/ganesha.te 1 file changed, 11 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1214444/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214444?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibfcf71cd2781d7c50ef47e0b9b4cc6a0ce6423b6 Gerrit-Change-Number: 1214444 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

2 weeks, 3 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Add missing bcond for UNWIND_ENRICHED_BT

by Kaleb KEITHLEY (GerritHub)

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214440?usp=email ) Change subject: Add missing bcond for UNWIND_ENRICHED_BT ...................................................................... Add missing bcond for UNWIND_ENRICHED_BT macro in nfs-ganesha.spec is not expanded Change-Id: If2cabbc9fd0036d7c6882d0b9fb29ca203edf84c Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/CMakeLists.txt 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/1214440/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214440?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: If2cabbc9fd0036d7c6882d0b9fb29ca203edf84c Gerrit-Change-Number: 1214440 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

2 weeks, 4 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: ganesha_mgr usage message correction

by Bipali Gade (GerritHub)

Bipali Gade has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214404?usp=email ) Change subject: ganesha_mgr usage message correction ...................................................................... ganesha_mgr usage message correction Updated the message to show the correct usage Change-Id: Iec48a68bbda59e3a3f44ca5eb3f4c54df5c9c7ea Signed-off-by: Bipali Gade <gbipali(a)gmail.com> --- M src/scripts/ganeshactl/ganesha_mgr.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/1214404/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214404?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iec48a68bbda59e3a3f44ca5eb3f4c54df5c9c7ea Gerrit-Change-Number: 1214404 Gerrit-PatchSet: 1 Gerrit-Owner: Bipali Gade <gbipali(a)gmail.com>

2 weeks, 4 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: CEPH: Fixup zerocopy

by Frank Filz (GerritHub)

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214388?usp=email ) Change subject: CEPH: Fixup zerocopy ...................................................................... CEPH: Fixup zerocopy Change default config to enable async and zerocopy If non-zerocopy read, caller must allocate buffer. Since zerocopy is a global config, just indicate FSAL doesn't support allocating own buffers in this case so fsal_read2 will do the allocation. Actually enable write2 for zerocopy. Change-Id: Ibd8848186e787dd1077f76d97256c9209dd48ec8 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_CEPH/main.c 2 files changed, 58 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/1214388/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214388?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ibd8848186e787dd1077f76d97256c9209dd48ec8 Gerrit-Change-Number: 1214388 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>

2 weeks, 6 days

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel May 2025