May 2025 - Devel - Nfs Ganesha List Archives

by Frank Filz

Branch next Tag:V7-dev.14 Merge Highlights * idmapper/idmapper.c: Encode numeric ids when idmapping is disabled * build/compile/startup fixes for monitoring * CEPH: fix attr cache not work when disable ACL Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 66a850ea7 Frank S. Filz V7-dev.14 2b72daa74 wangshaohui.0512 CEPH: fix attr cache not work when disable ACL 4db9d44de Sachin Punadikar Monitoring: Do not dump core for socket errors 64d5706f0 Sachin Punadikar Fix compilation error for USE_MONITORING=OFF 60578c6a8 Kaleb S. KEITHLEY monitoring: monitoriing is always enabled by default dd5c8ab1e Kaleb S. KEITHLEY config: default to monitoring enabled eb061a3f2 Lior Suliman idmapper/idmapper.c: Encode numeric ids when idmapping is disabled

6 days, 17 hours

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Coverity 502244 Data race condition: In display_log_component: Thread...

by Suhas Athani (GerritHub)

Suhas Athani has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215150?usp=email ) Change subject: Coverity 502244 Data race condition: In display_log_component: Thread shared data is accessed without holding an appropriate lock, possibly causing a race condition. Fix added. ...................................................................... Coverity 502244 Data race condition: In display_log_component: Thread shared data is accessed without holding an appropriate lock, possibly causing a race condition. Fix added. Change-Id: I8a4ae680267b932ee5cd770bd8b4f8641911ed21 Signed-off-by: s-athani <suhas.athani(a)ibm.com> --- M src/log/log_functions.c 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/50/1215150/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215150?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I8a4ae680267b932ee5cd770bd8b4f8641911ed21 Gerrit-Change-Number: 1215150 Gerrit-PatchSet: 1 Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>

1 week

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Monitoring: Do not dump core for socket errors

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215122?usp=email ) Change subject: Monitoring: Do not dump core for socket errors ...................................................................... Monitoring: Do not dump core for socket errors At the start of Ganesha process, it starts listening on monitoring port. As this is very beginning, it do not make any value add if it dumps core (via abort) for any socket related error. Error messages are suficient to describe the problem. Change-Id: Iccd240372e70ffc02454ad16de24034682e2871f Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/monitoring/prometheus_exposer.cc 1 file changed, 12 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/1215122/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215122?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iccd240372e70ffc02454ad16de24034682e2871f Gerrit-Change-Number: 1215122 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 week

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: idmapper/idmapper.c: Encode numeric ids when idmapping is disabled

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215094?usp=email to review the following change. Change subject: idmapper/idmapper.c: Encode numeric ids when idmapping is disabled ...................................................................... idmapper/idmapper.c: Encode numeric ids when idmapping is disabled Change-Id: I4e78f5aa39f39ba576ab9858c91a52568d483dbb Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/idmapper/idmapper.c 1 file changed, 1 insertion(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/94/1215094/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1215094?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4e78f5aa39f39ba576ab9858c91a52568d483dbb Gerrit-Change-Number: 1215094 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 week

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: build: fix the build error with invalid preprocessing token

by vicente (GerritHub)

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214855?usp=email ) Change subject: build: fix the build error with invalid preprocessing token ...................................................................... build: fix the build error with invalid preprocessing token We encounter the following error during build In file included from /nfs-ganesha/src/monitoring/include/prometheus_exposer.h:35, from /nfs-ganesha/src/monitoring/prometheus_exposer.cc:37: /nfs-ganesha/src/libntirpc/src/monitoring/include/monitoring.h:162:22: error: pasting "NOT_USED_" and "*" does not give a valid preprocessing token 162 | #define UNUSED_(arg) NOT_USED_##arg UNUSED_ATTR | ^~~~~~~~~ /nfs-ganesha/src/libntirpc/src/monitoring/include/monitoring.h:161:21: note: in expansion of macro 'UNUSED_' 161 | #define UNUSED(...) UNUSED_(__VA_ARGS__) | ^~~~~~~ /nfs-ganesha/src/monitoring/include/prometheus_exposer.h:105:44: note: in expansion of macro 'UNUSED' 105 | prometheus_exposer__start(const sockaddr_t UNUSED(*addr), | ^~~~~~ The `NOT_USED_##arg` is invalidate with the pointer preprocessing. We should move the pointer out of the macro likes libntirpc does. Change-Id: Ieec01fd4957a2d6a65b02eb9a12c90abd15cb496 Signed-off-by: Vicente Cheng <vicente.cheng(a)suse.com> --- M src/monitoring/include/prometheus_exposer.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/1214855/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214855?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ieec01fd4957a2d6a65b02eb9a12c90abd15cb496 Gerrit-Change-Number: 1214855 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com>

1 week, 3 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Coverity 502087: Fix potential end() iterator increment in compact_fa...

by Name of user not set (GerritHub)

Vidya.Thumukunta(a)ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214839?usp=email ) Change subject: Coverity 502087: Fix potential end() iterator increment in compact_family() ...................................................................... Coverity 502087: Fix potential end() iterator increment in compact_family() Change-Id: I61d6fa5878db830267f9aedd4bb3574f4f36d429 Signed-off-by: VidyaThumukunta <Vidya.Thumukunta(a)ibm.com> --- M src/monitoring/prometheus_exposer.cc 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1214839/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214839?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I61d6fa5878db830267f9aedd4bb3574f4f36d429 Gerrit-Change-Number: 1214839 Gerrit-PatchSet: 1 Gerrit-Owner: Vidya.Thumukunta(a)ibm.com

1 week, 3 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: CEPH: fix attr cache not work when disable ACL

by Shaohui Wang (GerritHub)

Shaohui Wang has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214815?usp=email ) Change subject: CEPH: fix attr cache not work when disable ACL ...................................................................... CEPH: fix attr cache not work when disable ACL In the CephFS FSAL export implementation, the callback function fs_supported_attrs is not properly implemented. By default, the ATTR_ACL flag is always set in the returned attributes. However, when the DISABLE_ACL option is enabled in the export configuration, the ATTR_ACL flag should be explicitly unset in the request_mask. This inconsistency between the attribute handling in request_mask and attrs fs_supported_attrs returned causes the mdcache_is_attrs_valid function to always return false, preventing any cache hits for inode attributes in the metadata cache. Change-Id: I4f9dde91d55fd85f6ca17fd22e896194a09cba81 Signed-off-by: Shaohui Wang <wangshaohui.0512(a)bytedance.com> --- M src/FSAL/FSAL_CEPH/export.c M src/FSAL/FSAL_CEPH/internal.h M src/FSAL/FSAL_CEPH/main.c 3 files changed, 24 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1214815/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214815?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4f9dde91d55fd85f6ca17fd22e896194a09cba81 Gerrit-Change-Number: 1214815 Gerrit-PatchSet: 1 Gerrit-Owner: Shaohui Wang <wangshaohui.0512(a)bytedance.com>

1 week, 4 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: monitoring: monitoriing is always enabled by default

by Kaleb KEITHLEY (GerritHub)

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214801?usp=email ) Change subject: monitoring: monitoriing is always enabled by default ...................................................................... monitoring: monitoriing is always enabled by default eliminate conditionals for monitoring; it's enabled by default Change-Id: Idfee736318845fd7347174199bb17045bae36364 Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 0 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/1214801/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214801?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idfee736318845fd7347174199bb17045bae36364 Gerrit-Change-Number: 1214801 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

1 week, 4 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: config: default to monitoring enabled

by Kaleb KEITHLEY (GerritHub)

Kaleb KEITHLEY has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214799?usp=email ) Change subject: config: default to monitoring enabled ...................................................................... config: default to monitoring enabled monitoring has moved to (lib)ntirpc, where it defaults to enabled If we were using ntirpc only as a submodule, we could probably eliminate this here. But since we package ntirpc separately in Fedora, CentOS, etc., and in ntirpc monitoring is enabled by default, we need to keep it here too, and have it enabled by default. Other users who don't want monitoring can disable it in their ntirpc (submodule or separate package) and disable it here too. Change-Id: I9ad3574d820eaf260d7a1244488e2273165eb94d Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com> --- M src/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/99/1214799/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9ad3574d820eaf260d7a1244488e2273165eb94d Gerrit-Change-Number: 1214799 Gerrit-PatchSet: 1 Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>

1 week, 4 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: [WIP] Patchset for Write delegations.

by Animesh Javali (GerritHub)

Animesh Javali has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214795?usp=email ) Change subject: [WIP] Patchset for Write delegations. ...................................................................... [WIP] Patchset for Write delegations. Changes include: - Resetting field `io_work` in `ceph_close_my_fd()` to prevent the reuse of its stale value in Global file descriptor. (This caused subsequent WRITE & READ to hang after a delegreturn.) - Making `ceph_fsal_lease_op2()` handle FSAL_DELEG_NONE correctly by marking FDs for closure (`close_on_complete`). - Enabling Read and Write file delegations by switching delegation option from `FSAL_OPTION_FILE_READ_DELEG` to `FSAL_OPTION_FILE_DELEGATIONS`. - Settting `client_oc` option to true to enable Object Cacher. - In `nfs4_op_open`, store the associated open state key (`stateid_other`) within the delegation state to open the files using this information later via fsal_start_io. - Disabling non-blocking and zerocopy IO flags. - Extending `state_deleg` struct in `sal_data.h` to include `openstate_key` for linking delegations to their corresponding open states. Change-Id: Icd21eee9d182148e19ab03c7f3b43cfc07d08672 Signed-off-by: Animesh Javali <Animesh.Javali(a)ibm.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_CEPH/main.c M src/Protocols/NFS/nfs4_op_open.c M src/include/config-h.in.cmake M src/include/sal_data.h 5 files changed, 35 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/1214795/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1214795?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icd21eee9d182148e19ab03c7f3b43cfc07d08672 Gerrit-Change-Number: 1214795 Gerrit-PatchSet: 1 Gerrit-Owner: Animesh Javali <Animesh.Javali(a)ibm.com>

1 week, 4 days

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel May 2025