September 2025 - Devel - Nfs Ganesha List Archives

[XS] Change in ...nfs-ganesha[next]: SAL: Fix crash during shutdown due to invalid svc_rqst_rec in svc_rqs...

by Nishant Puri (GerritHub)

Nishant Puri has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222291?usp=email ) Change subject: SAL: Fix crash during shutdown due to invalid svc_rqst_rec in svc_rqst_expire_insert ...................................................................... SAL: Fix crash during shutdown due to invalid svc_rqst_rec in svc_rqst_expire_insert During shutdown, svc_destroy clears cx_rec->ev_p as part of xprt unregister. Later, state_export_unlock_all may still trigger RPC callbacks that dereference the freed ev_p (svc_rqst_expire_insert), leading to crashes. Fix by validating, if admin_shutdown is in progress while granting the lock we will not trigger the callbacks. Change-Id: I80257143de6fd8fbc11b19e7de0a6d7bb76a8773 Signed-off-by: Nishant Puri <npuri(a)redhat.com> --- M src/SAL/state_lock.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/1222291/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I80257143de6fd8fbc11b19e7de0a6d7bb76a8773 Gerrit-Change-Number: 1222291 Gerrit-PatchSet: 1 Gerrit-Owner: Nishant Puri <npuri(a)redhat.com>

1 week, 4 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Clang-formatted the code base

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222268?usp=email to review the following change. Change subject: Clang-formatted the code base ...................................................................... Clang-formatted the code base Change-Id: Ic991c47412d304c730ba539c6528bc6e9ca004b7 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_qos.c M src/Protocols/NFS/nfs4_op_xattr.c M src/RPCAL/connection_manager.c M src/SAL/state_lock.c M src/config_parsing/test_parse.c M src/gtest/fsal_api/test_handle_to_wire_latency.cc M src/gtest/fsal_api/test_lock_op2_latency.cc M src/gtest/fsal_api/test_mkdir_latency.cc M src/gtest/fsal_api/test_readlink_latency.cc M src/gtest/fsal_api/test_reopen2_latency.cc M src/include/sss_nss_idmap.h M src/log/log_functions.c M src/support/exports.c M src/support/nfs_qosmgr.c M src/support/uid2grp.c 15 files changed, 119 insertions(+), 81 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/68/1222268/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222268?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic991c47412d304c730ba539c6528bc6e9ca004b7 Gerrit-Change-Number: 1222268 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 week, 5 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Disable nfs_qos and nfs_qosmgr when the ENABLE_QOS is not enabled

by Lior Suliman (GerritHub)

Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222267?usp=email to review the following change. Change subject: Disable nfs_qos and nfs_qosmgr when the ENABLE_QOS is not enabled ...................................................................... Disable nfs_qos and nfs_qosmgr when the ENABLE_QOS is not enabled Change-Id: I2cff23404143c50da043d9a44f7fa44153951641 Signed-off-by: Lior Suliman <liorsu(a)gmail.com> --- M src/MainNFSD/nfs_qos.c M src/support/nfs_qosmgr.c 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/67/1222267/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222267?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2cff23404143c50da043d9a44f7fa44153951641 Gerrit-Change-Number: 1222267 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com>

1 week, 5 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Fix notify_granted_completion for NFSv4.1

by Name of user not set (GerritHub)

shaharhoch(a)google.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222249?usp=email ) Change subject: Fix notify_granted_completion for NFSv4.1 ...................................................................... Fix notify_granted_completion for NFSv4.1 This fixes an issue introduced in: https://github.com/nfs-ganesha/nfs-ganesha/commit/1cfef0bde73e0dca0a347df... The patch changed it so up channel slot release is only called for NFSv4.1, but it used the clientid under the channel. In NFSv4.1 the clientid is not initialized in the channel. The channel keeps a union between the clientid (for NFSv4.0) and the session (for nfsv4.1). So, in NFSv4.1, the check looked at garbage, which means that in some cases the slot was never released. We change the check to look at the channel type, which is always initialized. Change-Id: I9565b148cfdd6a8d1e663e7d12f0d2705294899b Signed-off-by: Shahar Hochma <shaharhoch(a)google.com> --- M src/Protocols/NFS/nfs4_op_lock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/49/1222249/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222249?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9565b148cfdd6a8d1e663e7d12f0d2705294899b Gerrit-Change-Number: 1222249 Gerrit-PatchSet: 1 Gerrit-Owner: shaharhoch(a)google.com

1 week, 5 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: SAL: Avoid extra logging during grace period

by Sachin Punadikar (GerritHub)

Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222231?usp=email ) Change subject: SAL: Avoid extra logging during grace period ...................................................................... SAL: Avoid extra logging during grace period In grace period, status of client reclaim in the form of count, is getting logged. This logging should be done only when we have active clients in the recovery database. Change-Id: I1fbe93c8415c54b4501e53021f70c9da52a458b3 Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com> --- M src/SAL/nfs4_recovery.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/1222231/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222231?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1fbe93c8415c54b4501e53021f70c9da52a458b3 Gerrit-Change-Number: 1222231 Gerrit-PatchSet: 1 Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>

1 week, 6 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Support QoS DS read/write control

by Xueqian Hu (GerritHub)

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222226?usp=email ) Change subject: Support QoS DS read/write control ...................................................................... Support QoS DS read/write control QoS control on bandwidth/token does not work for DS read/write. This change add an option param to apply the bw/token limitaion on ds read/write. Change-Id: I238c9005fc26d3ca0420865a0ddc8685ffc7ed50 Signed-off-by: xueqian.hu <xh140312(a)outlook.com> --- M src/MainNFSD/nfs_qos.c M src/Protocols/NFS/nfs4_op_read.c M src/Protocols/NFS/nfs4_op_write.c M src/doc/man/ganesha-qos-config.rst M src/include/nfs_qos.h M src/support/exports.c M src/support/nfs_read_conf.c 7 files changed, 120 insertions(+), 5 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1222226/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222226?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I238c9005fc26d3ca0420865a0ddc8685ffc7ed50 Gerrit-Change-Number: 1222226 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 week, 6 days

1
0
0 / 0

[M] Change in ...nfs-ganesha[next]: Fix conditional builds for several things

by Daniel Gryniewicz (GerritHub)

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222224?usp=email ) Change subject: Fix conditional builds for several things ...................................................................... Fix conditional builds for several things - Make MONITORING conditional, and integrate with ntirpc - Pull up ntirpc to correct version - Fix RPM build for conditional monitoring, and rename it's package to match the naming convention for Ganesha - Fix a few CMake errors from deprecation (only showed up in RPM build) - Fix RPM conditional build for QOS and NFSIDMAP and ADMIN_TOOLS Change-Id: I4c75b3f3b5f1fab65150c923edd7f0a36a76f5db Signed-off-by: Daniel Gryniewicz <dang(a)fprintf.net> --- M src/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/MainNFSD/nfs_main.c M src/cmake/modules/FindNTIRPC.cmake M src/libntirpc M src/nfs-ganesha.spec-in.cmake 6 files changed, 67 insertions(+), 19 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/1222224/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4c75b3f3b5f1fab65150c923edd7f0a36a76f5db Gerrit-Change-Number: 1222224 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>

1 week, 6 days

1
0
0 / 0

[XS] Change in ...nfs-ganesha[next]: Ignore .egg-info directories from python scripts

by Daniel Gryniewicz (GerritHub)

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222223?usp=email ) Change subject: Ignore .egg-info directories from python scripts ...................................................................... Ignore .egg-info directories from python scripts Change-Id: Ie37f0dd3834396cf8b2d9b896dc812b5262df7b9 Signed-off-by: Daniel Gryniewicz <dang(a)fprintf.net> --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/1222223/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222223?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie37f0dd3834396cf8b2d9b896dc812b5262df7b9 Gerrit-Change-Number: 1222223 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>

1 week, 6 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Fix unitialized errors

by Daniel Gryniewicz (GerritHub)

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222222?usp=email ) Change subject: Fix unitialized errors ...................................................................... Fix unitialized errors Change-Id: Ia85973d46fd9819fea41312af69572a938c201cb Signed-off-by: Daniel Gryniewicz <dang(a)fprintf.net> --- M src/FSAL/FSAL_GPFS/fsal_ds.c M src/Protocols/NFS/nfs4_op_bind_conn.c M src/Protocols/NFS/nfs4_op_lock.c M src/Protocols/NFS/nfs4_op_savefh.c M src/Protocols/NFS/nfs_proto_tools.c 5 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/22/1222222/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222222?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia85973d46fd9819fea41312af69572a938c201cb Gerrit-Change-Number: 1222222 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>

1 week, 6 days

1
0
0 / 0

[S] Change in ...nfs-ganesha[next]: Fix: Race condition between socket flush and close

by Name of user not set (GerritHub)

sragraha(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222190?usp=email ) Change subject: Fix: Race condition between socket flush and close ...................................................................... Fix: Race condition between socket flush and close Change-Id: I15a913c8f235b55e72fa4b423a80dc0bca93583a Signed-off-by: Sreedhar Agraharam <sragraha(a)redhat.com> --- M src/cmake/modules/FindCEPHFS.cmake M src/monitoring/prometheus_exposer.cc 2 files changed, 14 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/1222190/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1222190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I15a913c8f235b55e72fa4b423a80dc0bca93583a Gerrit-Change-Number: 1222190 Gerrit-PatchSet: 1 Gerrit-Owner: sragraha(a)redhat.com

1 week, 6 days

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

Devel September 2025