[M] Change in ...nfs-ganesha[next]: Modify get_buffer_for_io_response to allocate buffer unless asked not to
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1231461?usp=email )
Change subject: Modify get_buffer_for_io_response to allocate buffer unless asked not to
......................................................................
Modify get_buffer_for_io_response to allocate buffer unless asked not to
Originally get_buffer_for_io_response only allocated a buffer if RDMA was
in use. This results in a confusing API.
The new version allocates a buffer unless asked not to for zero copy
purposes. An RDMA buffer is still allocated if required.
Comments clarify that op_ctx->is_rdma_buff_used can be referenced to
determine if the allocated buffer was an RDMA one or not.
Change-Id: I579d65a7c517892886c8fe31cfb791f4c030171f
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/fsal_helper.c
M src/Protocols/NFS/nfs3_readdir.c
M src/Protocols/NFS/nfs3_readdirplus.c
M src/Protocols/NFS/nfs4_op_read.c
M src/Protocols/NFS/nfs4_op_readdir.c
M src/RPCAL/rpc_tools.c
M src/include/fsal.h
M src/include/gsh_rpc.h
8 files changed, 94 insertions(+), 70 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/61/1231461/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1231461?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I579d65a7c517892886c8fe31cfb791f4c030171f
Gerrit-Change-Number: 1231461
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
1 week, 1 day
dread patch breaking dsread
by Marc Eshel
HI Yanghh,
It looks like your patch has broken dsread.
commit a3fd7cbd98d911aa754442afe06499ea4f1c9e21
Author: Haihua Yang <yanghh(a)gmail.com<mailto:yanghh@gmail.com>>
Date: Tue Aug 26 16:59:17 2025 +0000
Add RDMA support in dsread
Change-Id: I435368449e048fc82cc27079a3e295dd4618f425
Signed-off-by: Haihua Yang <yanghh(a)gmail.com<mailto:yanghh@gmail.com>>
The code in get_buffer_for_io_response() is under #ifdef _USE_NFS_RDMA and returns NULL if it is not set.
The call from op_dsread() is not under _USE_NFS_RDMA.
There is no error checking for returning NULL.
Marc.
1 week, 1 day
[S] Change in ...nfs-ganesha[next]: CONFIG: Allow for static message buffer for config errors
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1231196?usp=email )
Change subject: CONFIG: Allow for static message buffer for config errors
......................................................................
CONFIG: Allow for static message buffer for config errors
There are some situations like DBUS commands that use config parsing
functions. These functions take a complex set of structures that allow
collecting a stream of error messages. For those cases where only a
single error is expected, allow for a static buffer to be passed.
The new init_error_type_static() function initializes a struct
config_error_type with a static buffer instead of a file stream and
a dynamic buffer. The fp is then set to NULL.
The config_proc_error() function will check for a valid buffer and
NULL fp and just print into that buffer. It won't display the
filename and linenumber (so cnode can be NULL) which is appropriate
for a DBUS command.
Change-Id: I0365850ecbfe91b9af7cd028a026bde12f882b56
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/config_parsing/config_parsing.c
M src/include/config_parsing.h
2 files changed, 29 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/96/1231196/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1231196?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I0365850ecbfe91b9af7cd028a026bde12f882b56
Gerrit-Change-Number: 1231196
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
1 week, 5 days
[S] Change in ...nfs-ganesha[next]: NLM: Add config to not unmonitor on clean shutdown
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1231088?usp=email )
Change subject: NLM: Add config to not unmonitor on clean shutdown
......................................................................
NLM: Add config to not unmonitor on clean shutdown
On a clean shutdown, Ganesha unmonitors all NLM clients because a refcount
goes to zero. This can be avoided by terminating Ganesha with SIGKILL, but
it may be desireable to allow a clean shutdown without unmonitoring.
Note that this works with external or internal statd.
With internal statd, the monitored NLM clients are listed in the recovery
database and SM_NOTIFY will be sent on restart.
With external rpc.statd, scripting will be required to cause SM_NOTIFY to
be sent.
Change-Id: Ie87688d574a5b91613544bab090e65b184d1ac67
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/Protocols/NLM/nsm.c
M src/config_samples/config.txt
M src/doc/man/ganesha-core-config.rst
M src/include/gsh_config.h
M src/support/nfs_read_conf.c
5 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/1231088/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1231088?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ie87688d574a5b91613544bab090e65b184d1ac67
Gerrit-Change-Number: 1231088
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
1 week, 6 days
[L] Change in ...nfs-ganesha[next]: [Do not Review]: [DNM]: Test PR: revert test
by Name of user not set (GerritHub)
manim(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1230825?usp=email )
Change subject: [Do not Review]: [DNM]: Test PR: revert test
......................................................................
[Do not Review]: [DNM]: Test PR: revert test
Change-Id: Ib67675218d2431fbcd0e7bf5a119addd976d24cb
Signed-off-by: Manimaran M <manim(a)redhat.com>
---
M src/MainNFSD/libganesha_nfsd.ver
M src/SAL/nfs4_recovery.c
M src/SAL/recovery/recovery_fs.c
M src/SAL/recovery/recovery_fs.h
M src/SAL/recovery/recovery_rados.h
M src/SAL/recovery/recovery_rados_cluster.c
M src/SAL/recovery/recovery_rados_kv.c
M src/SAL/recovery/recovery_rados_ng.c
M src/include/sal_functions.h
9 files changed, 458 insertions(+), 321 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/25/1230825/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1230825?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ib67675218d2431fbcd0e7bf5a119addd976d24cb
Gerrit-Change-Number: 1230825
Gerrit-PatchSet: 1
Gerrit-Owner: manim(a)redhat.com
2 weeks, 2 days
Announce Push of V9.5
by Frank Filz
Branch next
Tag:V9.5
Merge Highlights
* FSAL_CEPH: Avoid OPEN_DOWNGRADE hang by fixing async deleg
* FSAL_CEPH: Allow runtime configuration of Async I/O for write op
* Coverity 638299: Fix for uninitialized scalar variable.
* Deleg option parsing for FSALs that don't support
* Fix squash handling corruption or race conditions
* CEPH: Use root creds for reopen call
* Add Content-Type header to Prometheus metrics response
* Add IP-based client owner separation for NFSv4.1+.
* Allow read locks on exported RO filesystems.
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
144f8b447 Frank S. Filz V9.5
eada9e9a3 Pradeep Allow read locks on exported RO filesystems.
bf49da609 Lior Suliman Add IP-based client owner separation for NFSv4.1+.
3f0ee7321 Sanyam Add Content-Type header to Prometheus metrics response
85a2ce071 Sachin Punadikar CEPH: Use root creds for reopen call
c35c6f9be Sachin Punadikar Fix squash handling corruption or race conditions
0617e7a36 Animesh Javali Deleg option parsing for FSALs that don't support
26749adfc Animesh Javali Coverity 638299: Fix for uninitialized scalar
variable.
e717b4553 Suhas Athani FSAL_CEPH: Allow runtime configuration of Async I/O
for write op
271aa3824 Suhas Athani FSAL_CEPH: Avoid OPEN_DOWNGRADE hang by fixing async
deleg recall handling.
2 weeks, 3 days
[XS] Change in ...nfs-ganesha[next]: CEPH: Use root creds for reopen call
by Sachin Punadikar (GerritHub)
Sachin Punadikar has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1230801?usp=email )
Change subject: CEPH: Use root creds for reopen call
......................................................................
CEPH: Use root creds for reopen call
While reopening a file in CEPH, Ganesha should use root_creds. For a
normal user at NFS Client side, the user creds are not sufficient to
reopen a file (which was already created). So make use of root creds.
This issue is surfaced when git clone is issued at the NFS client side.
Relevant Ganesha logs:
nfs-ganesha-1091175[svc_51] fsal_start_io :FSAL :F_DBG :Use global fd openflags = 2
nfs-ganesha-1091175[svc_51] wait_to_start_io :FSAL :F_DBG :0x7fd3cc042170 try io_work = 1 fd_work = 0
nfs-ganesha-1091175[svc_51] wait_to_start_io :FSAL :F_DBG :Open mode = 0, desired mode = 2
nfs-ganesha-1091175[svc_51] wait_to_start_io :FSAL :F_DBG :0x7fd3cc042170 back off io_work (-1) = 0 fd_work = 1
nfs-ganesha-1091175[svc_51] ceph_reopen_func :FSAL :F_DBG :my_fd->fd = (nil) openflags = 2, posix_flags = 1
nfs-ganesha-1091175[svc_51] ceph_reopen_func :FSAL :F_DBG :open failed with Permission denied
nfs-ganesha-1091175[svc_51] reopen_fsal_fd :FSAL :DEBUG :fsal_reopen_fd returned Permission denied
Change-Id: Ib4841d4075a6b8705abe76dbf424b8363a41dcc0
Signed-off-by: Sachin Punadikar <sachin.punadikar(a)ibm.com>
---
M src/FSAL/FSAL_CEPH/handle.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/01/1230801/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1230801?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ib4841d4075a6b8705abe76dbf424b8363a41dcc0
Gerrit-Change-Number: 1230801
Gerrit-PatchSet: 1
Gerrit-Owner: Sachin Punadikar <sachin.punadikar(a)ibm.com>
2 weeks, 4 days
[L] Change in ...nfs-ganesha[next]: WIP - Support Local NLM
by Frank Filz (GerritHub)
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1230489?usp=email )
Change subject: WIP - Support Local NLM
......................................................................
WIP - Support Local NLM
This patch is a hack to allow Ganesha to accept NFSv3 mounts with locking
from localhost. The hack utilizes Ganesha's rpcbind implementation to
accept rpcbind registration from the kernel lockd, and use that when
Ganesha tries to send NLM callbacks and SM_NOTIFY to the kernel client
(note that it doesn't actually send SM_NOTIFY (since that would go to
itself), instead it directly makes the callback registered by SM_MON.
NOTE: This is very work in progress and has had no testing at all.
Change-Id: I87b3459553bd2c9eee197bcf13a09c49a9f2a8fa
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/CMakeLists.txt
M src/MainNFSD/nfs_rpc_dispatcher_thread.c
M src/Protocols/NLM/nlm_async.c
M src/Protocols/NLM/nsm.c
M src/Protocols/RPCBIND/rpcbind.c
M src/SAL/nfs4_recovery.c
M src/SAL/recovery/recovery_fs.c
M src/include/config-h.in.cmake
M src/include/gsh_recovery.h
M src/include/nfs_proto_data.h
M src/include/nsm.h
11 files changed, 753 insertions(+), 18 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/89/1230489/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1230489?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I87b3459553bd2c9eee197bcf13a09c49a9f2a8fa
Gerrit-Change-Number: 1230489
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
3 weeks
