Suhas Athani has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226434?usp=email )
Change subject: Validate CLAIM_DELEGATE* stateids in open4_claim_deleg()
......................................................................
Validate CLAIM_DELEGATE* stateids in open4_claim_deleg()
- Replace the old “FIXME: vet stateid here” path with a call
to nfs4_Check_Stateid, using STATEID_NO_SPECIAL.
- Reject claims whose stateid is missing or not a delegation
(STATE_TYPE_DELEG) and add a debug log for that case.
- Preserve the full‑debug logging of the matching delegation
and make sure we drop the state reference unconditionally.
This ensures CLAIM_DELEGATE_CUR/CLAIM_DELEG_CUR_FH opens only
succeed when the client presents a live delegation stateid tied
to the correct file, preventing stale or unrelated stateids from
being accepted.
Change-Id: I1f4dc7ddab74a99dedc6dee86c120c1e27af5a73
Signed-off-by: Suhas Athani <Suhas.Athani(a)ibm.com>
---
M src/Protocols/NFS/nfs4_op_open.c
1 file changed, 25 insertions(+), 17 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/1226434/1
--
To view, visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1226434?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I1f4dc7ddab74a99dedc6dee86c120c1e27af5a73
Gerrit-Change-Number: 1226434
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani(a)ibm.com>