[NFS-Ganesha-Devel] Re: Reference leaks in nfs4_op_read.c an nfs4_op_write.c
That would very much break FSAL API for out-of-tree FSALs, and it
should be
only a couple of lines to bodge in a fix. Something like this:
https://review.gerrithub.io/#/c/ffilz/nfs-ganesha/+/437140
Good point, the other fix would actually be to not release the references inside the
callback...
I'll be doing that with the full async anyway because we don't want to do too much
in the callback.
Frank
On 12/12/2018 07:58 PM, Frank Filz wrote:
> I just posted comments in long ago merged patches:
>
> https://review.gerrithub.io/#/c/ffilz/nfs-ganesha/+/401028/
>
> https://review.gerrithub.io/#/c/ffilz/nfs-ganesha/+/401029/
>
> pointing out some places where we leak references.
>
> I wonder if it might be better to back out the async work from 2.7.1
> since it wasn’t completed (and then fix the one reference leak I found
> that is there even before the async work), and then I’ll get these
> properly fixed in 2.8?
>
> Frank
>
>
>
> _______________________________________________
> Devel mailing list -- devel(a)lists.nfs-ganesha.org To unsubscribe send
> an email to devel-leave(a)lists.nfs-ganesha.org
>
_______________________________________________
Devel mailing list -- devel(a)lists.nfs-ganesha.org To unsubscribe send an email to
devel-leave(a)lists.nfs-ganesha.org