Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204539?usp=email to review the following change. Change subject: fsal_helper: Change order of mode bits check in fsal_setattr ...................................................................... fsal_helper: Change order of mode bits check in fsal_setattr Previously, the first check set ATTR_MODE as valid if ATTR_OWNER or ATTR_GROUP was valid. Then, the the next check looked at if ATTR_MODE was valid. But, there could be a case where it is not originally valid and just because valid due to our code. Changing the order fixes this issue. Change-Id: I4586e5014807227f9f1721a81af676216cc6d6ee Signed-off-by: Lior Suliman <liorsu(a)gmail.com&gt; --- M src/FSAL/fsal_helper.c 1 file changed, 19 insertions(+), 18 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1204539/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1204539?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4586e5014807227f9f1721a81af676216cc6d6ee Gerrit-Change-Number: 1204539 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu(a)google.com&gt; Gerrit-Reviewer: Frank Filz <ffilzlnx(a)mindspring.com&gt; Gerrit-Attention: Frank Filz <ffilzlnx(a)mindspring.com&gt;