Change in ffilz/nfs-ganesha[next]: GTest - Add second readdir to readdir_correctness
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/427785
Change subject: GTest - Add second readdir to readdir_correctness
......................................................................
GTest - Add second readdir to readdir_correctness
A second readdir exercises the chunk reloading code more thoroughly.
Change-Id: Ie7b31d1b57be39cbb50771613a3aa9bb032a26d0
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/gtest/fsal_api/test_readdir_correctness.cc
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/85/427785/1
--
To view, visit https://review.gerrithub.io/427785
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7b31d1b57be39cbb50771613a3aa9bb032a26d0
Gerrit-Change-Number: 427785
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 2 months
Change in ffilz/nfs-ganesha[next]: readdir_correctness - Empty cache during run
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/427784
Change subject: readdir_correctness - Empty cache during run
......................................................................
readdir_correctness - Empty cache during run
Even though we drop our refs, the way that the entries are created
causes them all to stay in the cache, even though reachable.
Add a debug function to MDCACHE to allow cleaning up all reapable
entries in the cache, so that readdir will trigger all the "missing
entry" cases.
Change-Id: I99f6bc9d5ae2bcf354d4eb2f6c510f9926d85f97
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
Signed-off-by: Daniel Gryniewicz <dang(a)fprintf.net>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_debug.h
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
M src/gtest/fsal_api/test_readdir_correctness.cc
3 files changed, 32 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/84/427784/1
--
To view, visit https://review.gerrithub.io/427784
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99f6bc9d5ae2bcf354d4eb2f6c510f9926d85f97
Gerrit-Change-Number: 427784
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 2 months
Change in ffilz/nfs-ganesha[next]: MEM - Seek to dir location
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/427783
Change subject: MEM - Seek to dir location
......................................................................
MEM - Seek to dir location
During readdir, rather than starting at the beginning and walking to the
target location, seek to that location instead.
Change-Id: I1bfc78480e0b6649060ed52fa6b3339f88b91c06
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
Signed-off-by: Daniel Gryniewicz <dang(a)fprintf.net>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/427783/1
--
To view, visit https://review.gerrithub.io/427783
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bfc78480e0b6649060ed52fa6b3339f88b91c06
Gerrit-Change-Number: 427783
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 2 months
Change in ffilz/nfs-ganesha[next]: gtest - Add dirent name logging to readdir_correctness
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/427782
Change subject: gtest - Add dirent name logging to readdir_correctness
......................................................................
gtest - Add dirent name logging to readdir_correctness
Change-Id: Ie6357b0311097c592e7d61fa105fed7cce1a80e5
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
Signed-off-by: Daniel Gryniewicz <dang(a)fprintf.net>
---
M src/gtest/fsal_api/test_readdir_correctness.cc
1 file changed, 10 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/427782/1
--
To view, visit https://review.gerrithub.io/427782
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6357b0311097c592e7d61fa105fed7cce1a80e5
Gerrit-Change-Number: 427782
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
6 years, 2 months
Change in ffilz/nfs-ganesha[next]: FSAL_CEPH: use ceph_ll_sync_inode to handle COMMIT call when available
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/427756
Change subject: FSAL_CEPH: use ceph_ll_sync_inode to handle COMMIT call when available
......................................................................
FSAL_CEPH: use ceph_ll_sync_inode to handle COMMIT call when available
We can avoid opening and closing the file altogether to handle fsync if
libcephfs provides ceph_ll_sync_inode.
Change-Id: I7b86bbc93d59891af24bc672911b7979a121849c
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/handle.c
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/427756/1
--
To view, visit https://review.gerrithub.io/427756
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b86bbc93d59891af24bc672911b7979a121849c
Gerrit-Change-Number: 427756
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 2 months
Change in ffilz/nfs-ganesha[next]: fsal proxy: update config sample
by GerritHub
From Dominique Martinet <asmadeus(a)codewreck.org>:
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/427714
Change subject: fsal proxy: update config sample
......................................................................
fsal proxy: update config sample
config_samples/proxy.conf was using an obsolete syntax, let's keep
these up to date
Change-Id: I217abaeab1976cd96e872aae9e6dad7c51291a59
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/config_samples/config.txt
M src/config_samples/proxy.conf
2 files changed, 2 insertions(+), 31 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/427714/1
--
To view, visit https://review.gerrithub.io/427714
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I217abaeab1976cd96e872aae9e6dad7c51291a59
Gerrit-Change-Number: 427714
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
6 years, 2 months
Change in ffilz/nfs-ganesha[next]: fsal proxy: refuse to lookup / cleanly
by GerritHub
From Dominique Martinet <asmadeus(a)codewreck.org>:
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/427713
Change subject: fsal proxy: refuse to lookup / cleanly
......................................................................
fsal proxy: refuse to lookup / cleanly
This is better than a segfault if someone tries to use / in Path; we
apparently cannot get an explicit value for the remote nfs rootfh.
new_directory=false, entry=0x7fffffffd620, state=0x0, reason=MDC_REASON_DEFAULT)
at /src/nfs-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:572
at /src/nfs-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1551
at /src/nfs-ganesha/src/support/export_mgr.c:777
Change-Id: I40ee862c97e327be21a99aeaf8dbebfb15053136
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/FSAL/FSAL_PROXY/handle.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/427713/1
--
To view, visit https://review.gerrithub.io/427713
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40ee862c97e327be21a99aeaf8dbebfb15053136
Gerrit-Change-Number: 427713
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
6 years, 2 months
Change in ffilz/nfs-ganesha[next]: fsal proxy: fix use-after-scope in create session
by GerritHub
From Dominique Martinet <asmadeus(a)codewreck.org>:
Dominique Martinet has uploaded this change for review. ( https://review.gerrithub.io/427712
Change subject: fsal proxy: fix use-after-scope in create session
......................................................................
fsal proxy: fix use-after-scope in create session
csa_sec_parms_val was declared in its own scope but was used much
later, we need to declare it outside of the helper and pass the
address there.
==7480==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7fffea684340 at pc 0x7fffecec1e9c bp 0x7fffea683510 sp 0x7fffea683500
READ of size 4 at 0x7fffea684340 thread T5
#0 0x7fffecec1e9b in xdr_uint32_t /src/nfs-ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:221
#1 0x7fffecec1ef7 in xdr_u_int32_t /src/nfs-ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:236
#2 0x7fffecec9d88 in xdr_callback_sec_parms4 /src/nfs-ganesha/src/include/nfsv41.h:6750
#3 0x7fffecec3c3c in xdr_array_encode /src/nfs-ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:848
#4 0x7fffecec3ef3 in xdr_array /src/nfs-ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:891
#5 0x7fffececaa56 in xdr_CREATE_SESSION4args /src/nfs-ganesha/src/include/nfsv41.h:7049
#6 0x7fffecece544 in xdr_nfs_argop4 /src/nfs-ganesha/src/include/nfsv41.h:8233
#7 0x7fffecec3c3c in xdr_array_encode /src/nfs-ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:848
#8 0x7fffecec3ef3 in xdr_array /src/nfs-ganesha/src/libntirpc/ntirpc/rpc/xdr_inline.h:891
#9 0x7fffececfef4 in xdr_COMPOUND4args /src/nfs-ganesha/src/include/nfsv41.h:8732
#10 0x7fffeced6f8c in pxy_compoundv4_call /src/nfs-ganesha/src/FSAL/FSAL_PROXY/handle.c:764
#11 0x7fffeced834a in pxy_compoundv4_execute /src/nfs-ganesha/src/FSAL/FSAL_PROXY/handle.c:857
#12 0x7fffeceda878 in pxy_setsessionid /src/nfs-ganesha/src/FSAL/FSAL_PROXY/handle.c:966
#13 0x7fffecedc7eb in pxy_clientid_renewer /src/nfs-ganesha/src/FSAL/FSAL_PROXY/handle.c:1147
#14 0x7ffff5572593 in start_thread /usr/src/debug/glibc-2.27-78-g2b47bb9cba/nptl/pthread_create.c:463
#15 0x7ffff4e84e6e in clone (/lib64/libc.so.6+0xf9e6e)
Address 0x7fffea684340 is located in stack of thread T5 at offset 288 in frame
#0 0x7fffeced9cbc in pxy_setsessionid /src/nfs-ganesha/src/FSAL/FSAL_PROXY/handle.c:936
This frame has 7 object(s):
[32, 36) 'seqid'
[96, 100) 'fore_ca_rdma_ird_val_sink'
[160, 164) 'back_ca_rdma_ird_val_sink'
[224, 232) 'cid'
[288, 336) 'csa_sec_parms_val' <== Memory access at offset 288 is inside this variable
[384, 960) 'arg'
[992, 1632) 'res'
Change-Id: I597abb06747898418c907e33b57b1f0ac1f904f7
Signed-off-by: Dominique Martinet <dominique.martinet(a)cea.fr>
---
M src/FSAL/FSAL_PROXY/fsal_nfsv4_macros.h
M src/FSAL/FSAL_PROXY/handle.c
2 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/427712/1
--
To view, visit https://review.gerrithub.io/427712
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I597abb06747898418c907e33b57b1f0ac1f904f7
Gerrit-Change-Number: 427712
Gerrit-PatchSet: 1
Gerrit-Owner: Dominique Martinet <asmadeus(a)codewreck.org>
6 years, 2 months
Re: [Nfs-ganesha-devel] Ganesha 2.6.3 Segfault
by William Allen Simpson
There was a timing problem with my 2.6 code, that I'd fixed last April
and flagged to be backported. This might be another manifestation. I'd
debugged it during transport shutdown. From the #132 commit notes:
The thread scheduler doesn't necessarily do work in the order submitted.
In this case, the scheduler can/will run the per transport cleanup task
before other ready worker tasks, causing timing conflicts with the
service request channel task. Use the channel task to free transports.
Client call timeout is most likely increasing relative to other calls
for the same connection, worst case for rbtree insertion. Profiling
showed that rbtree was not a good choice, and TAILQ improved by 200%.
Moreover, maintaining the potentially large list of timeouts in the
service request was slowing event response. Instead, keep only one
entry per transport, with callback timeouts maintained by transport.
6 years, 2 months
