Change in ffilz/nfs-ganesha[next]: Ceph - fix missing braces around initializer
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/428231
Change subject: Ceph - fix missing braces around initializer
......................................................................
Ceph - fix missing braces around initializer
Change-Id: Id421f2564dc33a63f81897a976539d70aab3c920
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/handle.c
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/428231/1
--
To view, visit https://review.gerrithub.io/428231
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id421f2564dc33a63f81897a976539d70aab3c920
Gerrit-Change-Number: 428231
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 6 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - Keep dir handles open across readdir
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/428230
Change subject: MDCACHE - Keep dir handles open across readdir
......................................................................
MDCACHE - Keep dir handles open across readdir
Technically, there's no correlation between offsets returned by
telldir(3) during one opendir(3) and another opendir(3). However, this
happens to work on most filesystems, but not all. To fix this, open dir
handles when the first dirent is read from the FSAL, and leave them open
until either 1) the readdir completes on that director; or 2) the LRU
demotes the handle and closes it.
Change-Id: I5850dd81523ab741c0dc659d7511c8c358d34740
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_CEPH/handle.c
M src/FSAL/FSAL_CEPH/internal.h
M src/FSAL/FSAL_GLUSTER/handle.c
M src/FSAL/FSAL_GPFS/file.c
M src/FSAL/FSAL_GPFS/gpfs_methods.h
M src/FSAL/FSAL_GPFS/handle.c
M src/FSAL/FSAL_MEM/mem_handle.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/include/fsal.h
10 files changed, 222 insertions(+), 75 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/428230/1
--
To view, visit https://review.gerrithub.io/428230
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5850dd81523ab741c0dc659d7511c8c358d34740
Gerrit-Change-Number: 428230
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 6 months
IO Error on NFS v4.0 but not on v4.1
by Boris Faure
Hi everyone,
I'm running a simple test with ganesha-next (but the issue exists at least
in latest V2.5.5-stable):
$ sudo mount -t nfs -o v4.0,users,nolock,soft,timeo=2,retrans=3 127.0.0.1:/
/mnt/nfs
$ dd if=/dev/zero of=/mnt/nfs/dump/pw.1 bs=1024k count=2048 conv=fdatasync
dd: error writing '/mnt/nfs/dump/pw.1': Input/output error
1616+0 records in
1615+0 records out
1693450240 bytes (1,7 GB, 1,6 GiB) copied, 8,28076 s, 205 MB/s
$ sudo mount -t nfs -o users,nolock,soft,timeo=2,retrans=3 127.0.0.1:/
/mnt/nfs
$ dd if=/dev/zero of=/mnt/nfs/dump/pw.1 bs=1024k count=2048 conv=fdatasync
2048+0 records in
2048+0 records out
2147483648 bytes (2,1 GB, 2,0 GiB) copied, 6,27708 s, 342 MB/s
The second mount is using nfs v4.1.
I don't have anything special in my configuration.
If I do the dd with a blocksize of 512k, it works fine.
If I set rsize/wsize to 524288 as mount options, the dd with bs=1024k still
fails.
The only log line I get is the following:
25/09/2018 13:47:25 : epoch 5baa2036 : caipirinha :
ganesha.nfsd-2381[svc_182] rpc :TIRPC :EVENT :svc_ioq_flushv() writev
failed (104)
Thanks for your help.
Best Regards
--
Boris Faure
Software Engineer
--
<https://www.scality.com/download-idc-marketscape/?utm_source=ScalityEmail...>
5 years, 6 months
Change in ffilz/nfs-ganesha[next]: WIP: Avoid double free of COMPOUNDS with non-cachethis SEQUENCE.
by GerritHub
From Malahal <malahal(a)gmail.com>:
Malahal has uploaded this change for review. ( https://review.gerrithub.io/428128
Change subject: WIP: Avoid double free of COMPOUNDS with non-cachethis SEQUENCE.
......................................................................
WIP: Avoid double free of COMPOUNDS with non-cachethis SEQUENCE.
TODO:
Change-Id: I19fb662a2864bce62e8ae11126a0ff0954e20e6a
Signed-off-by: Malahal Naineni <malahal(a)us.ibm.com>
---
M src/Protocols/NFS/nfs4_Compound.c
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/428128/1
--
To view, visit https://review.gerrithub.io/428128
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19fb662a2864bce62e8ae11126a0ff0954e20e6a
Gerrit-Change-Number: 428128
Gerrit-PatchSet: 1
Gerrit-Owner: Malahal <malahal(a)gmail.com>
5 years, 6 months
Change in ffilz/nfs-ganesha[next]: RFC: [do not merge] (lib)ganesha_nfsd as a DSO
by GerritHub
From <kaleb(a)redhat.com>:
kaleb(a)redhat.com has uploaded this change for review. ( https://review.gerrithub.io/428095
Change subject: RFC: [do not merge] (lib)ganesha_nfsd as a DSO
......................................................................
RFC: [do not merge] (lib)ganesha_nfsd as a DSO
Build ganesha as a DSO, i.e. libganesha_nfsd.so.
The ganesha.nfsd daemon consists of just nfs_main::main() and is
linked with the DSO.
Then all the FSALs (except FSAL_PSEUDO and FSAL_MDCACHE*) are linked
with libganesha_nfsd.so, (and ${SYSTEM_LIBS} and ${LTTNG_LIBS}) for
resolution of various calls including calls back into ganesha.nfsd.
This will be required if, e.g., Fedora, decides to require default
linking with '-z defs'. They tried to do it for F29 but retreated
when they found that too many applications broke. In the end this may
all be just "truth and beauty."
*FSAL_PSEUDO and FSAL_MDCACHE are special; they are included in the
DSO so do not need to be (and can't be) linked with the DSO.
There might be more cmake-ish ways to create the various libs, e.g.
as OBJECTs instead of STATICs but this seems to require substantially
more changes everywhere. There might also be a better way to link with
libganesha_nfsd.so but I don't know cmake well enough to determine what
that might be.
A couple other things that could be done are
1) link libganesha_nfsd.so with a .sym file to explicitly control which
symbols are visible to the FSALs.
2) don't link ganesha.nfsd with -bdynamic as it's no longer needed
Change-Id: I6ddb691845e45094b7c636f3d5530a595c13acb2
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
---
M src/CMakeLists.txt
M src/FSAL/CMakeLists.txt
M src/FSAL/FSAL_CEPH/CMakeLists.txt
M src/FSAL/FSAL_GLUSTER/CMakeLists.txt
M src/FSAL/FSAL_GPFS/CMakeLists.txt
M src/FSAL/FSAL_MEM/CMakeLists.txt
M src/FSAL/FSAL_PROXY/CMakeLists.txt
M src/FSAL/FSAL_PSEUDO/CMakeLists.txt
M src/FSAL/FSAL_RGW/CMakeLists.txt
M src/FSAL/FSAL_VFS/os/CMakeLists.txt
M src/FSAL/FSAL_VFS/panfs/CMakeLists.txt
M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt
M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt
M src/FSAL/Stackable_FSALs/CMakeLists.txt
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/CMakeLists.txt
M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt
M src/MainNFSD/CMakeLists.txt
M src/Protocols/9P/CMakeLists.txt
M src/Protocols/NFS/CMakeLists.txt
M src/Protocols/NLM/CMakeLists.txt
M src/Protocols/RQUOTA/CMakeLists.txt
M src/Protocols/XDR/CMakeLists.txt
M src/RPCAL/CMakeLists.txt
M src/SAL/CMakeLists.txt
M src/avl/CMakeLists.txt
M src/cidr/CMakeLists.txt
M src/config_parsing/CMakeLists.txt
M src/dbus/CMakeLists.txt
M src/gtest/CMakeLists.txt
M src/hashtable/CMakeLists.txt
M src/idmapper/CMakeLists.txt
M src/log/CMakeLists.txt
M src/nfs-ganesha.spec-in.cmake
M src/os/CMakeLists.txt
M src/support/CMakeLists.txt
M src/tracing/CMakeLists.txt
36 files changed, 108 insertions(+), 84 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/95/428095/1
--
To view, visit https://review.gerrithub.io/428095
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ddb691845e45094b7c636f3d5530a595c13acb2
Gerrit-Change-Number: 428095
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <kaleb(a)redhat.com>
5 years, 6 months
Change in ffilz/nfs-ganesha[next]: Test response status before freeing response for TEST_STATEID and XAT...
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/428080
Change subject: Test response status before freeing response for TEST_STATEID and XATTR funcs
......................................................................
Test response status before freeing response for TEST_STATEID and XATTR funcs
Change-Id: I54848bfabd26bd51739ad828dd02d1cf3cba5bec
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/Protocols/NFS/nfs4_op_test_stateid.c
M src/Protocols/NFS/nfs4_op_xattr.c
2 files changed, 11 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/428080/1
--
To view, visit https://review.gerrithub.io/428080
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54848bfabd26bd51739ad828dd02d1cf3cba5bec
Gerrit-Change-Number: 428080
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
5 years, 6 months
Change in ffilz/nfs-ganesha[next]: NFS: clean up and simplify RECLAIM_COMPLETE handling
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/428052
Change subject: NFS: clean up and simplify RECLAIM_COMPLETE handling
......................................................................
NFS: clean up and simplify RECLAIM_COMPLETE handling
We're currently tracking whether a client in the reclaim hash sent a
reclaim complete. We already track whether a client sent a
RECLAIM_COMPELTE though in the in-core clientid structure. That one is
more correct anyway, as the client could re-establish its clientid
during the grace period and attempt to re-perform reclaim.
Drop the flag from the reclaim clid table hash object and the function
that sets it. Move the increment of the reclaim_completes into
nfs4_op_reclaim_complete
Change-Id: I73cf293f9e26475b5a51bf41c9251ad44faf6813
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NFS/nfs4_op_reclaim_complete.c
M src/SAL/nfs4_recovery.c
M src/include/sal_data.h
M src/include/sal_functions.h
4 files changed, 5 insertions(+), 49 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/52/428052/1
--
To view, visit https://review.gerrithub.io/428052
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73cf293f9e26475b5a51bf41c9251ad44faf6813
Gerrit-Change-Number: 428052
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 6 months
Change in ffilz/nfs-ganesha[next]: SAL: convert current_grace to struct timespec
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/428032
Change subject: SAL: convert current_grace to struct timespec
......................................................................
SAL: convert current_grace to struct timespec
This allows us to also switch to using CLOCK_MONOTONIC, which guards
against clock jumps and skew. We really do want to base the grace
period on "absolute" time and not be affected by someone monkeying with
the host's clock.
This means that we need to take the grace_mutex a bit earlier when
attempting to lift the grace period, but that also allows us to
simplify nfs4_lift_grace_locked since we can assume that the mutex
was held over the timeout check.
Change-Id: I837bab37c447a9cb9e114b47cd25de8344c8609c
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/SAL/nfs4_recovery.c
1 file changed, 28 insertions(+), 17 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/428032/1
--
To view, visit https://review.gerrithub.io/428032
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I837bab37c447a9cb9e114b47cd25de8344c8609c
Gerrit-Change-Number: 428032
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 6 months
Change in ffilz/nfs-ganesha[next]: NLM: convert nlm4_Test to sticky grace periods
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/428031
Change subject: NLM: convert nlm4_Test to sticky grace periods
......................................................................
NLM: convert nlm4_Test to sticky grace periods
Change-Id: Iae6a30ea0796c046d55f1778e65b467bfa2da823
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NLM/nlm_Test.c
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/428031/1
--
To view, visit https://review.gerrithub.io/428031
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae6a30ea0796c046d55f1778e65b467bfa2da823
Gerrit-Change-Number: 428031
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 6 months
Change in ffilz/nfs-ganesha[next]: NLM: convert nlm4_Share to sticky grace periods
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/428030
Change subject: NLM: convert nlm4_Share to sticky grace periods
......................................................................
NLM: convert nlm4_Share to sticky grace periods
Change-Id: I742da072b4295bd6871e08759f7a31767878d67c
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/Protocols/NLM/nlm_Share.c
1 file changed, 11 insertions(+), 18 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/428030/1
--
To view, visit https://review.gerrithub.io/428030
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I742da072b4295bd6871e08759f7a31767878d67c
Gerrit-Change-Number: 428030
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 6 months