Change in ffilz/nfs-ganesha[next]: MEM - Merge share reservations
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/414282
Change subject: MEM - Merge share reservations
......................................................................
MEM - Merge share reservations
Change-Id: I33718f3ab5f3c8955f581918a68574e39c5428de
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
1 file changed, 26 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/414282/1
--
To view, visit https://review.gerrithub.io/414282
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I33718f3ab5f3c8955f581918a68574e39c5428de
Gerrit-Change-Number: 414282
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: Organize GTests by API being tested
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/414276
Change subject: Organize GTests by API being tested
......................................................................
Organize GTests by API being tested
We're getting a lot of gtests now, so organize them according to what
API they're testing, to allow for easier dev and testing.
Change-Id: I194172f17d370e228b58255b484d768d27cd2ba1
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/gtest/CMakeLists.txt
A src/gtest/fsal_api/CMakeLists.txt
R src/gtest/fsal_api/test_close2_latency.cc
R src/gtest/fsal_api/test_close_latency.cc
R src/gtest/fsal_api/test_commit2_latency.cc
R src/gtest/fsal_api/test_getattrs_latency.cc
R src/gtest/fsal_api/test_handle_to_key_latency.cc
R src/gtest/fsal_api/test_handle_to_wire_latency.cc
R src/gtest/fsal_api/test_link_latency.cc
R src/gtest/fsal_api/test_lock_op2_latency.cc
R src/gtest/fsal_api/test_lookup_latency.cc
R src/gtest/fsal_api/test_mkdir_latency.cc
R src/gtest/fsal_api/test_mknode_latency.cc
R src/gtest/fsal_api/test_open2_latency.cc
R src/gtest/fsal_api/test_read2_latency.cc
R src/gtest/fsal_api/test_readdir_latency.cc
R src/gtest/fsal_api/test_readlink_latency.cc
R src/gtest/fsal_api/test_release_latency.cc
R src/gtest/fsal_api/test_rename_latency.cc
R src/gtest/fsal_api/test_reopen2_latency.cc
R src/gtest/fsal_api/test_setattr2_latency.cc
R src/gtest/fsal_api/test_symlink_latency.cc
R src/gtest/fsal_api/test_unlink_latency.cc
R src/gtest/fsal_api/test_write2_latency.cc
A src/gtest/nfs4/CMakeLists.txt
R src/gtest/nfs4/test_nfs4_lookup_latency.cc
R src/gtest/nfs4/test_nfs4_putfh_latency.cc
R src/gtest/nfs4/test_nfs4_rename_latency.cc
28 files changed, 476 insertions(+), 474 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/76/414276/1
--
To view, visit https://review.gerrithub.io/414276
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I194172f17d370e228b58255b484d768d27cd2ba1
Gerrit-Change-Number: 414276
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: GTest - Convert tests to GaneshaFSALBaseTest
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/414275
Change subject: GTest - Convert tests to GaneshaFSALBaseTest
......................................................................
GTest - Convert tests to GaneshaFSALBaseTest
The new GaneshaFSALBaseTest contains common code used in FSAL tests to
set up the environment, and create sets of handles. Convert all the
extant tests to use this.
Change-Id: Ieea3575ea567c3be1b83d73e02c995b3aa2d2a29
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/gtest/gtest.hh
M src/gtest/gtest_nfs4.hh
M src/gtest/test_close2_latency.cc
M src/gtest/test_close_latency.cc
M src/gtest/test_commit2_latency.cc
M src/gtest/test_getattrs_latency.cc
M src/gtest/test_handle_to_key_latency.cc
M src/gtest/test_handle_to_wire_latency.cc
M src/gtest/test_link_latency.cc
M src/gtest/test_lock_op2_latency.cc
M src/gtest/test_lookup_latency.cc
M src/gtest/test_mkdir_latency.cc
M src/gtest/test_mknode_latency.cc
M src/gtest/test_open2_latency.cc
M src/gtest/test_read2_latency.cc
M src/gtest/test_readdir_latency.cc
M src/gtest/test_readlink_latency.cc
M src/gtest/test_release_latency.cc
M src/gtest/test_rename_latency.cc
M src/gtest/test_reopen2_latency.cc
M src/gtest/test_setattr2_latency.cc
M src/gtest/test_symlink_latency.cc
M src/gtest/test_unlink_latency.cc
M src/gtest/test_write2_latency.cc
24 files changed, 293 insertions(+), 1,701 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/414275/1
--
To view, visit https://review.gerrithub.io/414275
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieea3575ea567c3be1b83d73e02c995b3aa2d2a29
Gerrit-Change-Number: 414275
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: GTest - normalize file/directory names
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/414274
Change subject: GTest - normalize file/directory names
......................................................................
GTest - normalize file/directory names
Change-Id: I0d7d0c511c3e7f5a2ff3409395c7e418d3e986d9
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/gtest/gtest.hh
M src/gtest/test_lookup_latency.cc
M src/gtest/test_mkdir_latency.cc
M src/gtest/test_mknode_latency.cc
M src/gtest/test_nfs4_lookup_latency.cc
M src/gtest/test_readlink_latency.cc
M src/gtest/test_rename_latency.cc
M src/gtest/test_symlink_latency.cc
8 files changed, 55 insertions(+), 55 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/414274/1
--
To view, visit https://review.gerrithub.io/414274
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d7d0c511c3e7f5a2ff3409395c7e418d3e986d9
Gerrit-Change-Number: 414274
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: FSAL_MEM - Handle links
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/414273
Change subject: FSAL_MEM - Handle links
......................................................................
FSAL_MEM - Handle links
Links cause problems for MEM, because you have multiple references to
the same object. This can result in MDCACHE having multiple entries
pointing to the same sub_handle, causing use-after-free when the two
entries are released. It works like this:
mde_A = lookup(OLDNAME)
mde_A->link(NEWNAME)
fsal_remove(NEWNAME) // At this point, mde_A is unreachable
fsal_remove(OLDNAME) // This creates a new handle, mde_B, pointing to
sub_hdl. Then it unlink()s, then put()s,
causing mde_B's ref to go to zero, calling
sub_hdl->release(), and sub_hdl is freed.
mde_A->put_ref() // sub_hdl was already freed, but this calls
release again
To fix this, implement full refcounting for FSAL_MEM handles, and
increment the ref on lookup(), and dec it on release().
Change-Id: I2cfcc8f125aa8de1b7c6245389c27d20eed210e2
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/FSAL_MEM/mem_handle.c
M src/FSAL/FSAL_MEM/mem_int.h
M src/include/gsh_lttng/fsal_mem.h
3 files changed, 310 insertions(+), 74 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/414273/1
--
To view, visit https://review.gerrithub.io/414273
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cfcc8f125aa8de1b7c6245389c27d20eed210e2
Gerrit-Change-Number: 414273
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: MDCACHE - Update some tracepoints to include sub-handles
by GerritHub
From Daniel Gryniewicz <dang(a)redhat.com>:
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/414272
Change subject: MDCACHE - Update some tracepoints to include sub-handles
......................................................................
MDCACHE - Update some tracepoints to include sub-handles
Change-Id: If734cc3645fa500ecbb3b427da47a4b62617259f
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
M src/include/gsh_lttng/mdcache.h
3 files changed, 50 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/414272/1
--
To view, visit https://review.gerrithub.io/414272
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: If734cc3645fa500ecbb3b427da47a4b62617259f
Gerrit-Change-Number: 414272
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: rados_cluster: add a config param for nodeid
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/414192
Change subject: rados_cluster: add a config param for nodeid
......................................................................
rados_cluster: add a config param for nodeid
...and use that to populate the rados_cluster nodeid if it's provided.
Otherwise, use the hostname.
Change-Id: I2f1ba2f625f8f3e2c5a2c309182e249f7b9bcc51
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/SAL/recovery/recovery_rados.h
M src/SAL/recovery/recovery_rados_cluster.c
M src/SAL/recovery/recovery_rados_kv.c
M src/doc/man/ganesha-core-config.rst
4 files changed, 21 insertions(+), 8 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/92/414192/1
--
To view, visit https://review.gerrithub.io/414192
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f1ba2f625f8f3e2c5a2c309182e249f7b9bcc51
Gerrit-Change-Number: 414192
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: rados_cluster: add a grace_oid config param
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/414191
Change subject: rados_cluster: add a grace_oid config param
......................................................................
rados_cluster: add a grace_oid config param
So we can use a grace database with a different OID name if configured.
Change-Id: I0bdbefd19f60f047f5215f455b11673e0663b38f
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/SAL/recovery/recovery_rados.h
M src/SAL/recovery/recovery_rados_cluster.c
M src/SAL/recovery/recovery_rados_kv.c
M src/doc/man/ganesha-core-config.rst
4 files changed, 18 insertions(+), 11 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/414191/1
--
To view, visit https://review.gerrithub.io/414191
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bdbefd19f60f047f5215f455b11673e0663b38f
Gerrit-Change-Number: 414191
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: rados_cluster: fail recovery backend init if host is not a member
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/414190
Change subject: rados_cluster: fail recovery backend init if host is not a member
......................................................................
rados_cluster: fail recovery backend init if host is not a member
If the grace database does not contain an omap key for this node, then
we can't proceed as a rados_cluster member. Have recovery_init fail in
that case.
Change-Id: If25860456c28ba194a44e31bb56b3a6e7c9a497b
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/SAL/recovery/recovery_rados_cluster.c
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/90/414190/1
--
To view, visit https://review.gerrithub.io/414190
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: If25860456c28ba194a44e31bb56b3a6e7c9a497b
Gerrit-Change-Number: 414190
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 10 months
Change in ffilz/nfs-ganesha[next]: rados_grace: add membership check function
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/414189
Change subject: rados_grace: add membership check function
......................................................................
rados_grace: add membership check function
Add a new rados_grace library function that allows the caller to check
whether a particular set of nodeids is present in the grace db omap.
Change-Id: I9f1d8422dc4c73e9a0f52d271858a6ac0fb93a04
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/doc/man/rados_grace_tool.rst
M src/include/rados_grace.h
M src/support/rados_grace.c
M src/tools/rados_grace_tool.c
4 files changed, 62 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/89/414189/1
--
To view, visit https://review.gerrithub.io/414189
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9f1d8422dc4c73e9a0f52d271858a6ac0fb93a04
Gerrit-Change-Number: 414189
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
5 years, 10 months