Change in ffilz/nfs-ganesha[next]: SAL: make recovery_init operation an int return
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/414188
Change subject: SAL: make recovery_init operation an int return
......................................................................
SAL: make recovery_init operation an int return
If the recovery_init operation fails, then we're likely to end up
crashing later anyway as certain pointers we rely on will end up being
NULL, etc.
Failure to initialize the recovery backend should really be a fatal
startup error that prevents the server from starting. Make recovery_init
an int return operation and have the server die if it fails with an
error.
Change-Id: I3fb8ce57e7715801cc069970c782a26d4a61d894
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/MainNFSD/nfs_lib.c
M src/MainNFSD/nfs_main.c
M src/SAL/nfs4_recovery.c
M src/SAL/recovery/recovery_fs.c
M src/SAL/recovery/recovery_fs_ng.c
M src/SAL/recovery/recovery_rados_cluster.c
M src/SAL/recovery/recovery_rados_kv.c
M src/SAL/recovery/recovery_rados_ng.c
M src/include/sal_functions.h
9 files changed, 37 insertions(+), 21 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/414188/1
--
To view, visit https://review.gerrithub.io/414188
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3fb8ce57e7715801cc069970c782a26d4a61d894
Gerrit-Change-Number: 414188
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 6 months
Change in ffilz/nfs-ganesha[next]: rados_grace: don't create grace db on startup
by GerritHub
From Jeff Layton <jlayton(a)redhat.com>:
Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/414187
Change subject: rados_grace: don't create grace db on startup
......................................................................
rados_grace: don't create grace db on startup
Change-Id: I595714f50dffb4ab00e0f1d7398d7935f96d5d65
Signed-off-by: Jeff Layton <jlayton(a)redhat.com>
---
M src/SAL/recovery/recovery_rados_cluster.c
1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/414187/1
--
To view, visit https://review.gerrithub.io/414187
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I595714f50dffb4ab00e0f1d7398d7935f96d5d65
Gerrit-Change-Number: 414187
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton <jlayton(a)redhat.com>
6 years, 6 months
Change in ffilz/nfs-ganesha[next]: Use euid/egid instead of fsuid/fsgid
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/413866
Change subject: Use euid/egid instead of fsuid/fsgid
......................................................................
Use euid/egid instead of fsuid/fsgid
Doing this, we can then call getuid and getgid for saving the
credentials. This allows the interfaces for
fsal_save_ganesha_credentials to be a bit more generic.
Since we want to set thread specific credentials, we call the system
call directly rather than using setresuid/setresgid which is are glibc
functions that cause the system calls to be made on each thread in the
process.
Change-Id: Iaedfb0b9875ca0610171652bd160d748ed429a73
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/access_check.c
M src/include/os/subr.h
M src/os/freebsd/subr.c
M src/os/linux/subr.c
4 files changed, 49 insertions(+), 26 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/413866/1
--
To view, visit https://review.gerrithub.io/413866
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaedfb0b9875ca0610171652bd160d748ed429a73
Gerrit-Change-Number: 413866
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
6 years, 6 months
Change in ffilz/nfs-ganesha[next]: Minimize time fsal_set_credentials is effective.
by GerritHub
From Frank Filz <ffilzlnx(a)mindspring.com>:
Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/413865
Change subject: Minimize time fsal_set_credentials is effective.
......................................................................
Minimize time fsal_set_credentials is effective.
fsal_set_credentials set's the per-thread credentials. We should
minimize the time they are set, and in particular, should not
do any logging while set since the user the credentials are set
to probably doesn't have permission to log...
Change-Id: I9ff899edcd601c6f3fa77991d66d8fc37a88ecc5
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
---
M src/FSAL/FSAL_GPFS/fsal_internal.c
M src/FSAL/FSAL_GPFS/fsal_rename.c
M src/FSAL/FSAL_GPFS/fsal_unlink.c
M src/FSAL/FSAL_VFS/file.c
M src/FSAL/FSAL_VFS/handle.c
5 files changed, 45 insertions(+), 24 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/65/413865/1
--
To view, visit https://review.gerrithub.io/413865
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ff899edcd601c6f3fa77991d66d8fc37a88ecc5
Gerrit-Change-Number: 413865
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com>
6 years, 6 months