Change in ...nfs-ganesha[next]: MDCACHE - Use atomics for readdir flags
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/446124
Change subject: MDCACHE - Use atomics for readdir flags
......................................................................
MDCACHE - Use atomics for readdir flags
Although the write lock is always held when we return from
mdcache_populate_dir_chunk(), the readdir loop can terminate early, if
the client buffer doesn't have enough space. This could result in
multiple readdirs processing the same chunk under the read lock, which
can deref an entry twice.
Switch to using atomics on this flag field.
Change-Id: Ibd59283b274422ee6f2477066389e6e43746fe6f
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h
2 files changed, 10 insertions(+), 4 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/24/446124/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/446124
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ibd59283b274422ee6f2477066389e6e43746fe6f
Gerrit-Change-Number: 446124
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
Proposed 2.7.2
by Daniel Gryniewicz
6dc61e23d (HEAD -> V2.7-stable, tag: V2.7.2) V2.7.2
9be8b9c2a rpm: BuildRequire libnsl2 on RHEL 8+
14ca4a788 rpm: fix selinux policy compression paths
4cfb44170 rpm: fix selinux macros within mock
bbaa967c3 Bump the lease timer when Clientid is reused after lease expires
3d97cfbc5 MDCACHE - Don't drop the sentinal ref with the lock held
6fe75249b MDCACHE - Ref the first chunk during readdir
a6c51e2a4 Reduce nsm_count before nsm_disconnect as we will not be able
to disconnect nsm client in case of RPC failures.
14ca4fc3b Update the cache slot when a new client is inserted
155406892 Update change time when modifying directory in FSAL mem and pseudo
88d5526a5 MDCACHE: lru_run should wait for server initialization
ff4439725 MDCACHE - Fix dirent chunk linking
0e9d494f5 MDCACHE - Add refcounting for dirent chunks
1afe37ac5 Drop dirent ref when releasing dirent
78c416ee6 SAL: Handle open claim of type OPEN_DELEG_CUR_FH
389f1f09d MDCACHE - Don't return dead entries from hashtable
06052e468 Remove -Wabi from maintainer mode
7667412f4 Fix READDIR duplicate entries
216a21dd7 Fix attribute comparison in NFS4_OP_VERIFY
059099669 Fix GTest build
34d98bce4 nfs4_op_open: NULL pointer bug - replace goto out3 with return
8a2210e49 Don't call nfs_req_creds if we don't have export
b9035bcc5 Handle race while adding host to IP-name cache
284e8cc83 exports: prune off old exports after reloading config
5228692bc exports: copy the config tree generation to the export when
adding or updating
afec3bca5 exports: add generation counter to config_root and helpers to
fetch it
132b6fe2a exports: don't allow dbus remove to leave subexports
disconnected in pseudoroot
f9d6aa62f ganesha_status.py - fix missing parens
748363a6b rpm/selinux: fix %pre install and %postun uninstall of selinux
policy
c87a21d36 Fix to set ATTR_RDATTR_ERR correctly as valid_mask in open2.
42ff7989f CEPH: do a getattr after creating a dir and applying extra
attributes
2a5218603 Read/Write - Don't leak owners/states
3d0b071cf SAL: fix multiple state reference leaks
d7fa8a1e3 Set op_ctx for lock_avail and lock_grant
23dce485c FSAL_VFS, FreeBSD: upstream support for d_off
4051e46da Add checks for client access in NFS user access checks.
370e01a5e FSAL_UP: add missing locks in async delegation recall
193e6b549 Handle NLM share FREE_ALL for windows clients
cc30bbc59 NLM share reservation access check with owner_skip
9266976ce Fixed dereferencing null ctx_export on nfs_read
e890d3d6f fix the bug of import config form rados url
885c54977 Remove idmap entry only if it is present in uid_tree
9d943485e MDCACHE: fix invalid assert in mdcache_avl_lookup_ck()
caf984d69 Restore op_ctx->ctx_export and fsal_export in nfs4_op_readdir
a13c80c12 Fix incorrect parent file handle update on rename.
9234da81c Fix NFSv3 EOF handling.
95c5a9da2 FSAL_GLUSTER/FSAL_GPFS: Do not error out if setattr ATTR_ACL
with empty acl
88422a92d FSAL_GLUSTER: fix memory leak of acl_t
328c2f359 [GPFS] Handle failures with NFS readdir operation
37e82b062 FSAL_GLUSTER: Copy user creds and lease_id after reopening fd
2365a4c8d Acquire state's fdlock in close2
f6d9c7d9c Remove unexported export on DBUS unexport.
c2510e30a Fix xprt initial refs
fdb069403 rpc_callback : check return value for
nfs_rpc_create_chan_v40() properly
b6088632c FSAL_PROXY : module options
eae05ed51 Fix compilation on FreeBSD 12
e23eaf9c9 SAL: Fix dead lock in revoke_owner_delegs()
5 years, 10 months
Re: kerberos
by Frank Filz
I haven't tried anything explicit to exclude or include Kerberos. Others are
more up on the CMake stuff so I've cc:ed the mailing list.
Frank
> -----Original Message-----
> From: Marc Eshel [mailto:eshel@us.ibm.com]
> Sent: Friday, February 22, 2019 11:55 AM
> To: Frank Filz <ffilzlnx(a)mindspring.com>
> Subject: kerberos
>
> Hi Frank,
>
> cn you build Ganesha without kerberos?
>
> Thanks, Marc.
>
> -- found krb5-config here KRB5_C_CONFIG-NOTFOUND
> -- KRB5 was not found. Make sure the entries KRB5_* are set.
> -- Looking for include file gssapi.h
> -- Looking for include file gssapi.h - not found CMake Error at
> CMakeLists.txt:493 (message):
> Cannot find kerberos libraries
5 years, 10 months
Change in ...nfs-ganesha[next]: Drop dirent ref before doing mdcache key delete in avl_dirent_set_del...
by Ashish Sangwan (GerritHub)
Ashish Sangwan has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/446019
Change subject: Drop dirent ref before doing mdcache key delete in avl_dirent_set_deleted
......................................................................
Drop dirent ref before doing mdcache key delete in avl_dirent_set_deleted
Was titting the assert assert(FSAL_IS_SUCCESS(status)); in mdcache_avl_remove
We have taken ref on the dirent which was supposed to be dropped by mdcache_readdir_chunked.
But before that,in between readdir RPCs, an unlink/rename could come in which calls mdcache_dirent_remove.
Currently we are calling mdcache_key_delete in avl_dirent_set_deleted without checking for ref.
Signed-off-by: Ashish Sangwan <ashishsangwan2(a)gmail.com>
Change-Id: If88de31c501396dc513459821af41c3e7ee47438
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c
1 file changed, 21 insertions(+), 12 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/19/446019/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/446019
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: If88de31c501396dc513459821af41c3e7ee47438
Gerrit-Change-Number: 446019
Gerrit-PatchSet: 1
Gerrit-Owner: Ashish Sangwan <ashishsangwan2(a)gmail.com>
Gerrit-MessageType: newchange
5 years, 10 months
Re: DBUS command for get/set log level
by Sriram Patil
Here are the commands used for log level Get and Set
dbus-send --print-reply --system --dest=org.ganesha.nfsd /org/ganesha/nfsd/admin org.freedesktop.DBus.Properties.Get string:org.ganesha.nfsd.log.component string:COMPONENT_FSAL
dbus-send --system --print-reply --dest=org.ganesha.nfsd /org/ganesha/nfsd/admin org.freedesktop.DBus.Properties.Set string:org.ganesha.nfsd.log.component string:COMPONENT_FSAL variant:string:NIV_FULL_DEBUG
Hope this helps.
- Sriram
From: Zhang Fan <fanzi2009(a)hotmail.com>
Date: Friday, February 22, 2019 at 4:32 AM
To: "devel(a)lists.nfs-ganesha.org" <devel(a)lists.nfs-ganesha.org>
Subject: [NFS-Ganesha-Devel] DBUS command for get/set log level
Hi,
I tried to use the command below,but it failed. Is there anyone know the correct format?
dbus-send --print-reply --system --dest=org.ganesha.nfsd /org/ganesha/nfsd/admin org.ganesha.nfsd.log.component.Get string:org.ganesha.nfsd.log.COMPONENT_FSAL
Thanks,
Marvin
5 years, 10 months
Announce Push of V2.8-dev.19
by Frank Filz
Branch next
Tag:V2.8-dev.19
Release Highlights
* Reduce nsm_count before nsm_disconnect as we will not be able to
disconnect nsm
* MDCACHE - Ref the first chunk during readdir
* MDCACHE - Don't drop the sentinal ref with the lock held
* Bump the lease timer when Clientid is reused after lease expires
* Packaging fixes for selinux and build requirements
* Remove chgtime attribute in favor of change attribute
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
cd9ac94 Frank S. Filz V2.8-dev.19
fd92962 Frank S. Filz Remove chgtime attribute in favor of change attribute
5a8f06e Ken Dreyer rpm: BuildRequire libnsl2 on RHEL 8+
325c086 Ken Dreyer rpm: fix selinux policy compression paths
dee984e Ken Dreyer rpm: fix selinux macros within mock
8f67261 Trishali Nayar Bump the lease timer when Clientid is reused after
lease expires
e12c77b Daniel Gryniewicz MDCACHE - Don't drop the sentinal ref with the
lock held
b624a18 Daniel Gryniewicz MDCACHE - Ref the first chunk during readdir
5febada Gaurav B. Gangalwar Reduce nsm_count before nsm_disconnect as we
will not be able to disconnect nsm client in case of RPC failures.
5 years, 10 months
DBUS command for get/set log level
by Zhang Fan
Hi,
I tried to use the command below,but it failed. Is there anyone know the correct format?
dbus-send --print-reply --system --dest=org.ganesha.nfsd /org/ganesha/nfsd/admin org.ganesha.nfsd.log.component.Get string:org.ganesha.nfsd.log.COMPONENT_FSAL
Thanks,
Marvin
5 years, 10 months
Change in ...nfs-ganesha[next]: Modify FSAL_NULL, so the code can be re-used for submodules.
by Bjorn Leffler (GerritHub)
Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445837
Change subject: Modify FSAL_NULL, so the code can be re-used for submodules.
......................................................................
Modify FSAL_NULL, so the code can be re-used for submodules.
This will be used for the upcoming data caching stackable FSALs, that I'm
working on: They will implement read2() and a few other functions, but re-use
most of the other FSAL functions from FSAL_NULL.
Signed-off-by: Bjorn Leffler <leffler(a)google.com>
Change-Id: I2a5c38f131360093b3f0e19a968dc21d8674f2f2
---
M src/CMakeLists.txt
M src/FSAL/Stackable_FSALs/CMakeLists.txt
M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt
M src/FSAL/Stackable_FSALs/FSAL_NULL/handle.c
M src/FSAL/Stackable_FSALs/FSAL_NULL/main.c
A src/FSAL/Stackable_FSALs/FSAL_NULL/nullfs.c
M src/FSAL/Stackable_FSALs/FSAL_NULL/nullfs_methods.h
7 files changed, 172 insertions(+), 81 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/445837/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445837
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2a5c38f131360093b3f0e19a968dc21d8674f2f2
Gerrit-Change-Number: 445837
Gerrit-PatchSet: 1
Gerrit-Owner: Bjorn Leffler <leffler(a)google.com>
Gerrit-MessageType: newchange
5 years, 10 months
Change in ...nfs-ganesha[next]: MDCACHE - Don't drop the sentinal ref with the lock held
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445712
Change subject: MDCACHE - Don't drop the sentinal ref with the lock held
......................................................................
MDCACHE - Don't drop the sentinal ref with the lock held
Dropping the sentinal ref in cih_remove_checked() may cause a cleanup
of the entry, which will recurse into cih_remove_checked() again. This
will abort, because the lock is already held by this thread.
Instead, drop the lock before we actually drop the ref. That way, if
it's the last ref (which is common in error cases), the cleanup will
recurse, and not find it in the hash table.
Change-Id: Iccf982f2b2d85a3617f1604e0636afce9501fdfc
Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/445712/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445712
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Iccf982f2b2d85a3617f1604e0636afce9501fdfc
Gerrit-Change-Number: 445712
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
5 years, 10 months
