February 2019 - Devel - Nfs Ganesha List Archives

Change in ...nfs-ganesha[next]: rpm: BuildRequire libnsl2 on RHEL 8+

by Ken Dreyer (GerritHub)

Ken Dreyer has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445645 Change subject: rpm: BuildRequire libnsl2 on RHEL 8+ ...................................................................... rpm: BuildRequire libnsl2 on RHEL 8+ On RHEL 8 we have a libnsl2-devel package, just like Fedora. Change-Id: I7a94ec40acba5479a92aca2e3674c07fbbf6cd6e Signed-off-by: Ken Dreyer <kdreyer(a)redhat.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/445645/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445645 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7a94ec40acba5479a92aca2e3674c07fbbf6cd6e Gerrit-Change-Number: 445645 Gerrit-PatchSet: 1 Gerrit-Owner: Ken Dreyer <kdreyer(a)redhat.com> Gerrit-MessageType: newchange

5 years, 2 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: rpm: fix selinux policy compression paths

by Ken Dreyer (GerritHub)

Ken Dreyer has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445644 Change subject: rpm: fix selinux policy compression paths ...................................................................... rpm: fix selinux policy compression paths When we compress the ganesha policy file, we are already in the top source directory, so the "selinux" directory is directly in the current working directory. Update the pushd command to reflect this. The policy file we create is "ganesha.pp", not "nfs-ganesha.pp". Update the bzip2 command to reflect this. Change-Id: I2184fcfbcc8c58a0a65123a57b0586b17a0ef5cc Signed-off-by: Ken Dreyer <kdreyer(a)redhat.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/445644/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445644 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2184fcfbcc8c58a0a65123a57b0586b17a0ef5cc Gerrit-Change-Number: 445644 Gerrit-PatchSet: 1 Gerrit-Owner: Ken Dreyer <kdreyer(a)redhat.com> Gerrit-MessageType: newchange

5 years, 2 months

1
0
0 / 0

Change in ...nfs-ganesha[next]: rpm: fix selinux macros within mock

by Ken Dreyer (GerritHub)

Ken Dreyer has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445643 Change subject: rpm: fix selinux macros within mock ...................................................................... rpm: fix selinux macros within mock We build the SELinux policy with /usr/share/selinux/devel/Makefile, so we must BuildRequire the selinux-policy-devel package. Also, we must tell rpmbuild to ignore the selinux_requires macro if it is undefined, because rpmbuild evaluates the spec file very early in the build process, before mock installs the BuildRequires packages. Once mock installs selinux-policy, the macros will be available, but we need to gracefully handle the case where %selinux_requires macro is not yet avaialable. Change-Id: I7ceeef7c0ae5652fa11963a807cded661f174d4f Signed-off-by: Ken Dreyer <kdreyer(a)redhat.com> --- M src/nfs-ganesha.spec-in.cmake 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/445643/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445643 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7ceeef7c0ae5652fa11963a807cded661f174d4f Gerrit-Change-Number: 445643 Gerrit-PatchSet: 1 Gerrit-Owner: Ken Dreyer <kdreyer(a)redhat.com> Gerrit-MessageType: newchange

5 years, 2 months

1
0
0 / 0

What's the correct dbus command for get/set log level

by fanzi2009＠hotmail.com

Hi, I tried to use the command below,but it failed. Is there anyone know the correct format? dbus-send --print-reply --system --dest=org.ganesha.nfsd /org/ganesha/nfsd/admin org.ganesha.nfsd.log.component.Get string:org.ganesha.nfsd.log.COMPONENT_FSAL Thanks, Marvin

5 years, 2 months

2
1
0 / 0

Change in ...nfs-ganesha[next]: MDCACHE - Ref the first chunk during readdir

by Daniel Gryniewicz (GerritHub)

Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445330 Change subject: MDCACHE - Ref the first chunk during readdir ...................................................................... MDCACHE - Ref the first chunk during readdir When doing a readdir, we know that we are going to have to return dirents from the first chunk to the client. Protect this chunk from being freed by taking a ref. To do this, take a ref in mdcache_populate_dir_chunk() and mdcache_avl_lookup_ck() Change-Id: I10d5e76bb1fc9c21b425f201271feab22132a400 Signed-off-by: Daniel Gryniewicz <dang(a)redhat.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/445330/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445330 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I10d5e76bb1fc9c21b425f201271feab22132a400 Gerrit-Change-Number: 445330 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com> Gerrit-MessageType: newchange

5 years, 2 months

1
0
0 / 0

Crash in libntirpc code (Ganesha 2.3 version) - should be applicable to latest code as well

by Sachin Punadikar

Hi All, Customer reported a crash in Ganesha 2.3. Jan 22 20:40:52 xxxxx kernel: ganesha.nfsd[xxxxx]: unhandled signal 11 at 00003ffcf8005200 nip 00003ffcf8005200 lr 00003fff7a265e1c code 30002 Program terminated with signal 11, Segmentation fault. (gdb) where #0 0x00003ffcf8005200 in ?? () #1 0x00003fff7a265e1c in xdr_ioq_uv_release (uv=0x3ffd389df700) at /usr/src/debug/nfs-ganesha-2.3.2-ibm59-0.1.1-Source/libntirpc/src/xdr_ioq.c:206 #2 0x00003fff7a267340 in xdr_ioq_release (ioqh=0x3ffd385f8fc8) at /usr/src/debug/nfs-ganesha-2.3.2-ibm59-0.1.1-Source/libntirpc/src/xdr_ioq.c:720 #3 0x00003fff7a2673dc in xdr_ioq_destroy (xioq=0x3ffd385f8f00, qsize=424) at /usr/src/debug/nfs-ganesha-2.3.2-ibm59-0.1.1-Source/libntirpc/src/xdr_ioq.c:729 #4 0x00003fff7a267470 in xdr_ioq_destroy_internal (xdrs=0x3ffd385f8f00) at /usr/src/debug/nfs-ganesha-2.3.2-ibm59-0.1.1-Source/libntirpc/src/xdr_ioq.c:742 #5 0x00003fff7a268480 in svc_ioq_callback (wpe=0x3ff9880025e0) at /usr/src/debug/nfs-ganesha-2.3.2-ibm59-0.1.1-Source/libntirpc/src/svc_ioq.c:222 #6 0x00003fff7a269400 in work_pool_thread (arg=0x3ffa180008c0) at /usr/src/debug/nfs-ganesha-2.3.2-ibm59-0.1.1-Source/libntirpc/src/work_pool.c:196 #7 0x00003fff7a2dc2bc in .start_thread () from /lib64/libpthread.so.0 #8 0x00003fff7a0fb304 in .__clone () from /lib64/libc.so.6 (gdb) frame 1 #1 0x00003fff7a265e1c in xdr_ioq_uv_release (uv=0x3ffd389df700) at /usr/src/debug/nfs-ganesha-2.3.2-ibm59-0.1.1-Source/libntirpc/src/xdr_ioq.c:206 206 uv->u.uio_release(&uv->u, UIO_FLAG_NONE); When I checked Ganesha 2.3/2.5 code (also the latest community code), I am unable to find code for function uio_release. Am I missing anything here ? Or the code is really missing this function ? -- with regards, Sachin Punadikar

5 years, 2 months

2
2
0 / 0

Change in ...nfs-ganesha[next]: Reduce nsm_count before nsm_disconnect as we will not be able to disc...

by Gaurav (GerritHub)

Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445329 Change subject: Reduce nsm_count before nsm_disconnect as we will not be able to disconnect nsm client in case of RPC failures. ...................................................................... Reduce nsm_count before nsm_disconnect as we will not be able to disconnect nsm client in case of RPC failures. Change-Id: I0cd5f0614e89f447dc7c5ac278cf03224add05e2 Signed-off-by: Gaurav B. Gangalwar <gaurav.gangalwar(a)gmail.com> --- M src/Protocols/NLM/nsm.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/445329/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445329 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I0cd5f0614e89f447dc7c5ac278cf03224add05e2 Gerrit-Change-Number: 445329 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com> Gerrit-MessageType: newchange

5 years, 2 months

1
0
0 / 0

nsm_monitor/unmonitor using destroyed svc xprt without ref if statd restart.

by gaurav gangalwar

Using Ganesha 2.7.1 I did this sequence with NFS V3. 1>nlm lock from client 2>Restart statd 3>nlm unlock from client svc xprt got created for nsm_connect during nlm lock gets destroyed if statd restart, this happens through svc_rqst_epoll_event. But we have global nsm_clnt which will still point to destroyed svc xprt. We have checks on svc xprt flags if it already got destroyed, but this will not work if that memory get reallocated and we could end up doing memory corruption. Here are log snippets. *xprt destroyed through epoll*: 13/02/2019 03:25:58 : epoch 5c63d058 : centos7 : ganesha.nfsd-33933[svc_13] rpc :TIRPC :F_DBG :svc_vc_wait: 0x7f5d783f0400 fd 34 recv closed (will set dead) 13/02/2019 03:25:58 : epoch 5c63d058 : centos7 : ganesha.nfsd-33933[svc_21] rpc :TIRPC :F_DBG :svc_vc_destroy_task() 0x7f5d783f0400 fd 34 xp_refcnt 0 *nsm unmonitor accessing destroyed xprt:* 13/02/2019 03:26:51 : epoch 5c63d058 : centos7 : ganesha.nfsd-33933[svc_21] rpc :TIRPC :F_DBG :WARNING! already destroying!() 0x7f5d783f0400 fd -1 xp_refcnt 0 af 2 port 58327 @svc_ioq_write:233 13/02/2019 03:26:54 : epoch 5c63d058 : centos7 : ganesha.nfsd-33933[svc_12] nsm_unmonitor :NLM :CRIT :Unmonitor ::ffff:10.53.91.67 SM_MON failed: RPC: Timed out I am not sure if this is a right way to use nsm rpc client, as its pointing to svc xprt without taking extra ref. Is this a ref count issue with nsm rpc client, should we take extra ref for it? Or we are should not keep global nsm rpc client, instead do nsm_connect/disconnect for every MON/UNMON call? I tried with extra ref fix, it seems to be working, https://paste.fedoraproject.org/paste/BCCeYi933UMdGht1gvbWow Regards, Gaurav

5 years, 2 months

1
2
0 / 0

Change in ...nfs-ganesha[next]: WIP: NFS4ERR_EXPIRED loop caused when RENEW is after lease interval

by Name of user not set (GerritHub)

ntrishal(a)in.ibm.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445113 Change subject: WIP: NFS4ERR_EXPIRED loop caused when RENEW is after lease interval ...................................................................... WIP: NFS4ERR_EXPIRED loop caused when RENEW is after lease interval If a RENEW request comes after the lease interval time, the cid_last_renew is set to a higher value. Reaper runs every 10 secs. If client sends a SETCLIENTID before these 10 secs, we find the existing record and reuse (as part of Case 2) of nfs4_op_setclientid() function. nfs4_op_setclientid_confirm() relevant path is - First try to look up unconfirmed record. And then make sure we have a reference to the confirmed clientid record if any. (Line 330) This has the old lease renewal time in it. SETCLIENTID CONFIRM returns NFS_OK. OPEN fails in reserve_lease() with NFS4ERR_EXPIRED. Next RENEW comes and again fails with NFS4ERR_EXPIRED. Above sequence keeps repeating. Once the reaper runs, the old entry is removed and SETCLIENT sends back a new ClientID and client comes out of this situation. Reset the cid_last_renew when we confirm the client so that client gets the correct lease interval to renew its lease. And also reaper should not remove this entry as well in its next run. Change-Id: I6b4c5c39aa804b3bad60d584daa1d56dd62c6d8b Signed-off-by: Trishali Nayar <ntrishal(a)in.ibm.com> --- M src/Protocols/NFS/nfs4_op_setclientid_confirm.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/445113/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/445113 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6b4c5c39aa804b3bad60d584daa1d56dd62c6d8b Gerrit-Change-Number: 445113 Gerrit-PatchSet: 1 Gerrit-Owner: ntrishal(a)in.ibm.com Gerrit-MessageType: newchange

5 years, 2 months

1
0
0 / 0

Announce Push of V2.8-dev.18

by Frank Filz

Branch next Tag:V2.8-dev.18 Release Highlights * Improved delegation support with CB_GETATTR and related changes * MDCACHE dirent chunk refcounting and ordering fixes * MDCACHE: lru_run should wait for server initialization * Update change time when modifying directory in FSAL mem and pseudo * Update the cache slot when a new client is inserted * Print correct error message in nlm_send_async() Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 1620397 Frank S. Filz V2.8-dev.18 410075a Trishali Nayar Update the cache slot when a new client is inserted 4319313 Sriram Patil Update change time when modifying directory in FSAL mem and pseudo 4cd85d2 Sachin Punadikar MDCACHE: lru_run should wait for server initialization b8fe636 Daniel Gryniewicz MDCACHE - Fix dirent chunk linking 638c49d Daniel Gryniewicz MDCACHE - Add refcounting for dirent chunks bef57bb Daniel Gryniewicz Print correct error message in nlm_send_async() d129f44 Soumya Koduri Do not refresh attrs if the file is delegated de2141e Soumya Koduri Update attrs received from cb_getattr to mdcache 0ebc2f9 Soumya Koduri CB_GETATTR implementation ffab902 Soumya Koduri Recall delegation if CB_GETATTR not supported 7a52768 Soumya Koduri Recall write delegation only if it conflicts with other clients` access

5 years, 2 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

Devel February 2019